Wednesday, March 11, 2020
21 changes · master
Enhancements to existing features
Customer portal sales orders now show the actual delivery date for completed deliveries, or the scheduled date when delivery is still pending. This gives customers clearer and more accurate delivery information instead of showing when the delivery record was created.
Original PR description
purpose of this commit is to show the correct delivery date to the portal user. task:2180525 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The web framework now supports customizing calculated values in addition to regular actions. This gives developers more flexibility when adapting Odoo behavior, with no direct change expected for everyday users.
Original PR description
Previous implementation of patch (web.utils) only allows patching methods. This commit allows patching getters as well. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update renames an internal invoice field from “type” to “move type” in the Latin American invoicing module. It keeps the module aligned with accounting terminology and helps maintain compatibility with the broader invoicing system, with no expected change to day-to-day user workflows.
Original PR description
Rename field 'type' to 'move_type' in a model account.move Related Task-ID: 2028813
The referral app job dashboard no longer shows the left-side "Responsible" filter column. This keeps the dashboard cleaner and better aligned with how employees typically browse referral jobs.
Original PR description
In the referral app, remove the "Responsible" left column: employees will rarely filter by who is responsible. Task 2207639
Resolved issues and error corrections
This fixes an issue that could interrupt cleanup of Latin American invoice documents when related accounting entries were removed. The change uses the correct purchase document check, making the process more reliable and reducing the risk of errors during record deletion.
Original PR description
The `type` field was renamed `move_type` in d675dbaa4c7174591e0e7c1a3caf3e76877312ce but the forward-port #44415 of #43312 re-added a use of the old `type` name, which breaks if an account.move is unlinked while l10n_latam_invoice_document is unlinked (and there are related moves to update). Instead of renaming the field, use the proper utility method for the category (purchase) provided by account.move, that should be more reliable and make for clear code.
Miscellaneous changes
Allow non-alphabetic unit (like percentage) as data-unit value. task-2194309 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47322 Forward-Port-Of: odoo/odoo#47274
Original PR description
Allow non-alphabetic unit (like percentage) as data-unit value. task-2194309 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47322 Forward-Port-Of: odoo/odoo#47274
The website editor now closes open dropdowns and widgets when a user clicks outside them. This prevents menus from staying open unexpectedly, making editing pages feel cleaner and less confusing.
Original PR description
Description of the issue/feature this PR addresses: Purpose:- - The dropdown doesn't closeup when click outside it. Specification:- - For fulfil this purpose, make dropdown able to close up when click outside of the dropdown menu PR #46298 task-2196789
Avoid traceback when click on edit and nothing is editable on the page. task-2199214 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47276
Original PR description
Avoid traceback when click on edit and nothing is editable on the page. task-2199214 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47276
Color Palette improvement -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45872
Original PR description
Color Palette improvement -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45872
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#46912
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#46912
Commit ca4eaf4 introduced the data-mobile attribute, used to specify options to pass when executing an action, only in mobile (like using a fullscreen modal). However, we forgot to add the 'isMobile' check, so the option was passed in desktop as well. This commit fixes the issue and adds some tests. Task ID: 2155601 Forward-Port-Of: odoo/odoo#47265
Original PR description
Commit ca4eaf4 introduced the data-mobile attribute, used to specify options to pass when executing an action, only in mobile (like using a fullscreen modal). However, we forgot to add the 'isMobile' check, so the option was passed in desktop as well. This commit fixes the issue and adds some tests. Task ID: 2155601 Forward-Port-Of: odoo/odoo#47265
- Set 'Product Unit of Measure' to 5 - Set the UoM rounding to 0.001 - Create an excluded tax of 6 % - Create a product costing 7.0 - Open the POS, add the product with a quantity of 0.535 The tax is 0.22 instead of 0.23. The root cause of the issue is the in JS: ``` round_pr(0.535, Math.pow(10,-5)) * 7 = 3.744999999999999 round_pr(0.535, 0.00001) * 7 = 3.745 ``` The numerical error impacts the tax computation later on. As a workaround, we round by the maximum between the U
Original PR description
- Set 'Product Unit of Measure' to 5 - Set the UoM rounding to 0.001 - Create an excluded tax of 6 % - Create a product costing 7.0 - Open the POS, add the product with a quantity of 0.535 The tax is 0.22 instead of 0.23. The root cause of the issue is the in JS: ``` round_pr(0.535, Math.pow(10,-5)) * 7 = 3.744999999999999 round_pr(0.535, 0.00001) * 7 = 3.745 ``` The numerical error impacts the tax computation later on. As a workaround, we round by the maximum between the UoM rounding and the 'Product Unit of Measure', which is what will be done in the backend anyway. opw-2205092 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47300
Fine tuning of 1e411e3a6d - It moves the attachment in the message when we mark an activity as done. - It adds a test OPW-2196668 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47273 Forward-Port-Of: odoo/odoo#45938
Original PR description
Fine tuning of 1e411e3a6d - It moves the attachment in the message when we mark an activity as done. - It adds a test OPW-2196668 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47273 Forward-Port-Of: odoo/odoo#45938
Description of the issue/feature this PR addresses: Before this commit, Payment URL was not encoded correctly which can compute Payment refernece Wrongly on website Current behavior before PR: Eg, Enter Description which contains Special Characters Go to Payment Page using Computed URL. There will be wrong Payment Reference on Payment page. Desired behavior after PR is merged: With this commit, We encode Payment reference before generating Payment URL. -- I confirm
Original PR description
Description of the issue/feature this PR addresses: Before this commit, Payment URL was not encoded correctly which can compute Payment refernece Wrongly on website Current behavior before PR: Eg, Enter Description which contains Special Characters Go to Payment Page using Computed URL. There will be wrong Payment Reference on Payment page. Desired behavior after PR is merged: With this commit, We encode Payment reference before generating Payment URL. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#46157
Commit [1] does not work as it is supposed to, because there has been a confusion between the "notification request" and the "chat with OdooBot". `_showOdoobotTimeout` is for the chat, and it is unrelated to the notification request. We don't want to initiate multiple chats with OdooBot so that has to be reverted. As for the original goal of the PR about the notification request, it wasn't met either because it is the browser controlling it: - on Firefox there simply isn't a "close"
Original PR description
Commit [1] does not work as it is supposed to, because there has been a confusion between the "notification request" and the "chat with OdooBot". `_showOdoobotTimeout` is for the chat, and it is…
Commit [1] does not work as it is supposed to, because there has been a confusion between the "notification request" and the "chat with OdooBot". `_showOdoobotTimeout` is for the chat, and it is unrelated to the notification request. We don't want to initiate multiple chats with OdooBot so that has to be reverted. As for the original goal of the PR about the notification request, it wasn't met either because it is the browser controlling it: - on Firefox there simply isn't a "close" button, and closing it by any other means (escape key) is considered as a denied. - on Chrome, when closing it for the first time, it will appear again automatically after the next page reload, so no additional code is required. However, if it is closed too many times (around 3) it will become automatically denied too, at the browser level. The only thing to do at that point is to better notify the user that it was blocked, without being intrusive, which is the focus of task-2188584. [1] b7254ecaeee7f8fa564ca2059f119f5d12404af6 opw-2186299 Forward-Port-Of: odoo/odoo#47316
The hover effect on popover is the following: the popup is opened when passing the mouse cursor on the icon and closed once it leave the icon. The issue is if the popup has a button inside, clicking the button freeze the popup. It cannot be closed unless the entire page is refreshed Task : 2199078 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guideli
Original PR description
The hover effect on popover is the following: the popup is opened when passing the mouse cursor on the icon and closed once it leave the icon. The issue is if the popup has a button inside, clicking the button freeze the popup. It cannot be closed unless the entire page is refreshed Task : 2199078 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47371
Description of the issue/feature this PR addresses: CLP (Chilean Peso) does not need decimals Current behavior before PR: CLP $ expression is like 11590.00 Desired behavior after PR is merged: CLP $ 11590 (without cents) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47335
Original PR description
Description of the issue/feature this PR addresses: CLP (Chilean Peso) does not need decimals Current behavior before PR: CLP $ expression is like 11590.00 Desired behavior after PR is merged: CLP $ 11590 (without cents) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47335
Images of the lunch dashboard are not cached by the browser. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47411
Original PR description
Images of the lunch dashboard are not cached by the browser. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47411
…ights A user with no Purchase rights and only Inventory User rights should be able to cancel an SO and access requisition_line_ids field. Description of the issue/feature this PR addresses: opw-2209886 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47378 Forward-Port-Of: odoo/odoo#47364
Original PR description
…ights A user with no Purchase rights and only Inventory User rights should be able to cancel an SO and access requisition_line_ids field. Description of the issue/feature this PR addresses: opw-2209886 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47378 Forward-Port-Of: odoo/odoo#47364
1) create an open shift 2) select a role 3) select an employee Observed behavior: The role field is emptied when setting an employee. Expected behavior: The role should remain set when selecting an employee. Forward-Port-Of: odoo/enterprise#8810
Original PR description
1) create an open shift 2) select a role 3) select an employee Observed behavior: The role field is emptied when setting an employee. Expected behavior: The role should remain set when selecting an employee. Forward-Port-Of: odoo/enterprise#8810
Steps to reproduce: - install accounting - go to accounting > reporting > general ledger - open any fold with multiple lines Previous behavior: lines are ordered by line id Current behavior: lines are ordered in a chronological way, making the account report more readable opw-2197887 Forward-Port-Of: odoo/enterprise#8925
Original PR description
Steps to reproduce: - install accounting - go to accounting > reporting > general ledger - open any fold with multiple lines Previous behavior: lines are ordered by line id Current behavior: lines are ordered in a chronological way, making the account report more readable opw-2197887 Forward-Port-Of: odoo/enterprise#8925