Tuesday, April 7, 2020
24 changes · master
Enhancements to existing features
Mailing reports are easier to search and analyze by campaign, with added reporting fields and a bounce total footer. Several labels were simplified from “mass mailing” wording to clearer “mailing” terminology, making the interface more consistent for users.
Original PR description
Improve the mailing.trace.report search view to help users find their statistics based on specific campaigns, and added some minor changes to mailing views - Rename "mass mail campaign" to "mailing campaign" - Rename "create a mass mailing list" to "create a mailing list" - Add sum footer on bounce - Add mass mail campaign field to reporting search view Task ID 2210331 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The manufacturing work order tablet view no longer shows an unwanted help tooltip when users hover near PDF worksheet instructions. This makes the tablet experience cleaner and less distracting for shop floor users.
Original PR description
For the `mrp.routing.workcenter`, removes the help from the `worksheet` field to set it into the view. This way, the tooltip doesn't appear each time the user cursor is placed in front of the pdf in the workorder tablet view (`mpr_workorder`). task-2225362 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Description of the issue/feature this PR addresses: Lack of some taxes and fiscal positions. Current behavior before PR: The user needs to add ILA taxes manually, and also fiscal position for exempt operations. The percentage amount of 10% for 2nd category tax is obsolete and for year 2020 it has been established to 10.75% These changes will be valid for new databases. Adds exempt fiscal positions needed for some document types. Desired behavior after PR is merged: Adds special tax
Original PR description
Description of the issue/feature this PR addresses: Lack of some taxes and fiscal positions. Current behavior before PR: The user needs to add ILA taxes manually, and also fiscal position for exempt operations. The percentage amount of 10% for 2nd category tax is obsolete and for year 2020 it has been established to 10.75% These changes will be valid for new databases. Adds exempt fiscal positions needed for some document types. Desired behavior after PR is merged: Adds special taxes used in sales and purchase of alcoholic beverages. The ILA taxes will be present in new databases after this fix. the withholding of 2nd category will be 10.75% for new databases -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#48564 Forward-Port-Of: odoo/odoo#48547
Followup of https://github.com/odoo/odoo/commit/58df6c86e06304b2c5f020e0fb93988e9e388fe0. By default, the create, when not specified as `api.model`, supports creation in batch (thus the batching opportunity isn't lost here). BUT, if a create override isn't specified as `api.model` or `api.model_create_multi`, it won't be accessible in rpc calls (because the ORM thinks a record in self is needed). It doesn't look like somebody can create stock move lines from the web client itself, but i
Original PR description
Followup of https://github.com/odoo/odoo/commit/58df6c86e06304b2c5f020e0fb93988e9e388fe0. By default, the create, when not specified as `api.model`, supports creation in batch (thus the batching opportunity isn't lost here). BUT, if a create override isn't specified as `api.model` or `api.model_create_multi`, it won't be accessible in rpc calls (because the ORM thinks a record in self is needed). It doesn't look like somebody can create stock move lines from the web client itself, but it doesn't cost anything to follow the global api (and it's clearer to clearly specify the create as create_multi). -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#48935
Python 3.7 is required for function datetime.datetime.fromisoformat to work. Ref: https://docs.python.org/3.7/library/datetime.html?highlight=fromisoformat#datetime.datetime.fromisoformat This is a temporary revert, to avoid rejecting perfectly valid transactions. Ref: https://github.com/odoo/odoo/pull/48581 opw-2179123 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the C
Original PR description
Python 3.7 is required for function datetime.datetime.fromisoformat to work. Ref: https://docs.python.org/3.7/library/datetime.html?highlight=fromisoformat#datetime.datetime.fromisoformat This is a temporary revert, to avoid rejecting perfectly valid transactions. Ref: https://github.com/odoo/odoo/pull/48581 opw-2179123 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49077
- Create a tax: Fixed price: 0.355 Included in price - Assign the tax to product P - Create a POS order with P and a price 0, pay by bank - Create a POS order with P and a price 10, pay by bank - Close the POS session. The following entry is created: D C Tax Received 0.01 0.00 Product Sales 0.00 9.65 Product Sales 0.36 0.00 Receivable 10.00 0.00 Several issues: - the entry is posted and unbal
Original PR description
- Create a tax: Fixed price: 0.355 Included in price - Assign the tax to product P - Create a POS order with P and a price 0, pay by bank - Create a POS order with P and a price 10, pay by bank -…
- Create a tax:
Fixed price: 0.355
Included in price
- Assign the tax to product P
- Create a POS order with P and a price 0, pay by bank
- Create a POS order with P and a price 10, pay by bank
- Close the POS session.
The following entry is created:
D C
Tax Received 0.01 0.00
Product Sales 0.00 9.65
Product Sales 0.36 0.00
Receivable 10.00 0.00
Several issues:
- the entry is posted and unbalanced: covered in #48484
- rounding of 0.355 was either 0.36 or 0.35: to fix one day... [1]
- the tax received of 0.36 for the POS order of 0 is booked on the debit
rather than on credit, leading to a difference 0.01.
This happens because the taxes amounts for the POS order of 10 are
positive, while they should be negative for a sale as done in [2].
We set the amounts as negative as done for incoming invoices, and adapt
the tax line creation accordingly.
[1] The use case is weird: a fixed price of 0.355 while we only have 2
digits in the currency?
[2] https://github.com/odoo/odoo/blob/e415cffa2ffb3fe4b5f0e32bd96b3433387a95e3/addons/account/models/account_move.py#L461
opw-2168096
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#485031) Add a hidden optional field to the timesheet tree view. 2) Try to display that field by checking the checkbox. => the column appears then directly disappears. Asynchronous calls (here: fetching the server time) should always be in the `willStart` method. Task 2204084 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#48741 Forward-Port-Of: odoo/odoo#48645
Original PR description
1) Add a hidden optional field to the timesheet tree view. 2) Try to display that field by checking the checkbox. => the column appears then directly disappears. Asynchronous calls (here: fetching the server time) should always be in the `willStart` method. Task 2204084 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#48741 Forward-Port-Of: odoo/odoo#48645
While installing a module on an existing database, the modification of groups should reset the `base.user_groups_view` to a dummy view in order to validate user views. The `user_groups_view` is set to its "right" value at the end of the installation. Forward-Port-Of: odoo/odoo#49106
Original PR description
While installing a module on an existing database, the modification of groups should reset the `base.user_groups_view` to a dummy view in order to validate user views. The `user_groups_view` is set to its "right" value at the end of the installation. Forward-Port-Of: odoo/odoo#49106
Before this commit: When a PoS session is closed in anglosaxon accounting with real time stock valuation, the stock moves linked to PoS orders are used to create the stock valuation entry. When an order is composed of only products of type 'service', there are no picking linked to the order, and so the entry is created with all stock moves having no `picking_id`. After this commit: To avoid this problem, we are checking that the PoS order has a picking before looking for stock moves. OP
Original PR description
Before this commit: When a PoS session is closed in anglosaxon accounting with real time stock valuation, the stock moves linked to PoS orders are used to create the stock valuation entry. When an order is composed of only products of type 'service', there are no picking linked to the order, and so the entry is created with all stock moves having no `picking_id`. After this commit: To avoid this problem, we are checking that the PoS order has a picking before looking for stock moves. OPW-2206625 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49082 Forward-Port-Of: odoo/odoo#49057
PURPOSE When you browse a courses page,there is alignment issue in Leaderboard and Latest achievements panel. The purpose of this commit is to displayed both panels (Leaderboard and Latest achievements) properly . SPECIFICATIONS Every time when we were trying to browse a course's page,there is alignment issue in Leaderboard and Latest achievements panels. Now Leaderboard and Latest achievements panel is aligned properly. PR # 48922 Task 2227683 -- I confirm I h
Original PR description
PURPOSE When you browse a courses page,there is alignment issue in Leaderboard and Latest achievements panel. The purpose of this commit is to displayed both panels (Leaderboard and Latest achievements) properly . SPECIFICATIONS Every time when we were trying to browse a course's page,there is alignment issue in Leaderboard and Latest achievements panels. Now Leaderboard and Latest achievements panel is aligned properly. PR # 48922 Task 2227683 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#48922
[Task Id - 2223092](https://www.odoo.com/web#id=2223092&action=333&active_id=2818&model=project.task&view_type=form&cids=1&menu_id=4720) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49127 Forward-Port-Of: odoo/odoo#48697
Original PR description
[Task Id - 2223092](https://www.odoo.com/web#id=2223092&action=333&active_id=2818&model=project.task&view_type=form&cids=1&menu_id=4720) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49127 Forward-Port-Of: odoo/odoo#48697
Avoid casting `None` to integer. opw-2231620 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49122
Original PR description
Avoid casting `None` to integer. opw-2231620 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49122
- Activate Multi UoM - Create a product P with 120 Units in stock - Create a SO for 1 Dozen 120 Dozens are expected in the forecast widget instead of 10 Dozens. This happens because the various product quantities are always expressed in the product UoM: https://github.com/odoo/odoo/blob/c95fad77ea5b4663130e256f76031560171f09e6/addons/stock/models/product.py#L190 We add a conversion when necessary. opw-2224335 Description of the issue/feature this PR addresses: Current beh
Original PR description
- Activate Multi UoM - Create a product P with 120 Units in stock - Create a SO for 1 Dozen 120 Dozens are expected in the forecast widget instead of 10 Dozens. This happens because the various product quantities are always expressed in the product UoM: https://github.com/odoo/odoo/blob/c95fad77ea5b4663130e256f76031560171f09e6/addons/stock/models/product.py#L190 We add a conversion when necessary. opw-2224335 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#48718 Forward-Port-Of: odoo/odoo#48859
As Mitchell Admin: - Install timeoff - General Settings > Multi Company - Create companies A - Switch to company A - Go to timeoff > Managers > All > Allocations > Create a record An AccessError is raised from `_onchange_type` because we try to access `employee_ids[:1].id` and it may gives employee of another company. we have already compute field `employee_id`, it will gives employee of curren company. After this AccessError is solved. task - 2179571 Description of the issue/
Original PR description
As Mitchell Admin: - Install timeoff - General Settings > Multi Company - Create companies A - Switch to company A - Go to timeoff > Managers > All > Allocations > Create a record An AccessError is raised from `_onchange_type` because we try to access `employee_ids[:1].id` and it may gives employee of another company. we have already compute field `employee_id`, it will gives employee of curren company. After this AccessError is solved. task - 2179571 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45381
…can countries. Task : https://www.odoo.com/web#id=1906494&model=project.task&view_type=form&cids=2&menu_id=4720 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49099
Original PR description
…can countries. Task : https://www.odoo.com/web#id=1906494&model=project.task&view_type=form&cids=2&menu_id=4720 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49099
Following #48718 opw-2224335 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49138
Original PR description
Following #48718 opw-2224335 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49138
Forward-Port-Of: odoo/enterprise#9725
Original PR description
Forward-Port-Of: odoo/enterprise#9725
TaskID: 2179571 Forward-Port-Of: odoo/enterprise#9588 Forward-Port-Of: odoo/enterprise#8018
Original PR description
TaskID: 2179571 Forward-Port-Of: odoo/enterprise#9588 Forward-Port-Of: odoo/enterprise#8018
Steps to reproduce the bug: - Create a journal entry E with two lines L1 and L2 - L1 is a debit of 100€ on a payable account - L2 is a credit of 100€ on a bank account - Cancel E - Go to the bank reconciliation report Bug: E appeared in the report in the section Validated Payments not Linked with a Bank Statement Line opw:2228338 Forward-Port-Of: odoo/enterprise#9704
Original PR description
Steps to reproduce the bug: - Create a journal entry E with two lines L1 and L2 - L1 is a debit of 100€ on a payable account - L2 is a credit of 100€ on a bank account - Cancel E - Go to the bank reconciliation report Bug: E appeared in the report in the section Validated Payments not Linked with a Bank Statement Line opw:2228338 Forward-Port-Of: odoo/enterprise#9704
https://www.odoo.com/web#id=2227490&action=333&active_id=1691&model=project.task&view_type=form&cids=&menu_id=4720 Forward-Port-Of: odoo/enterprise#9563
Original PR description
https://www.odoo.com/web#id=2227490&action=333&active_id=1691&model=project.task&view_type=form&cids=&menu_id=4720 Forward-Port-Of: odoo/enterprise#9563
Before this commit: The shared URL for job was a relative URL. After this commit: The shared URL is absolute. Forward-Port-Of: odoo/enterprise#9665 Forward-Port-Of: odoo/enterprise#9626
Original PR description
Before this commit: The shared URL for job was a relative URL. After this commit: The shared URL is absolute. Forward-Port-Of: odoo/enterprise#9665 Forward-Port-Of: odoo/enterprise#9626
Steps to reproduce the bug: - Let's consider two companies C1 and C2 in the same tax system - Let's consider a product P with a purchase tax T1 - Let's consider a fiscal position FP that mappes T1 to T2 - Set FP on the partner linked to C1 - C1 and C2 synchronize invoice/bills - Log in C1 and create a customer invoice I for C1 with P as product - Post I Bug: The vendor bill created with C1 as vendor had no fiscal position (instead of having FP) and the tax T1 was applied on line
Original PR description
Steps to reproduce the bug: - Let's consider two companies C1 and C2 in the same tax system - Let's consider a product P with a purchase tax T1 - Let's consider a fiscal position FP that mappes T1 to T2 - Set FP on the partner linked to C1 - C1 and C2 synchronize invoice/bills - Log in C1 and create a customer invoice I for C1 with P as product - Post I Bug: The vendor bill created with C1 as vendor had no fiscal position (instead of having FP) and the tax T1 was applied on line (instead of T2) This fix restores the behavior as in 12.0 opw:2226561 Forward-Port-Of: odoo/enterprise#9601 Forward-Port-Of: odoo/enterprise#9579
Task Id #2229601 Forward-Port-Of: odoo/enterprise#9602
Original PR description
Task Id #2229601 Forward-Port-Of: odoo/enterprise#9602
- Set up a product to automatically generate deferred revenues - Create an invoice with the product, set a price to zero - Post the invoice An error prevents posting: https://github.com/odoo/enterprise/blob/6dc8589ab5d4acf7d880cef0f2f37a920736dd7e/account_asset/models/account_asset.py#L114 In such a use case, there is no need to create a deferred revenue for a free product. opw-2223939 Forward-Port-Of: odoo/enterprise#9696
Original PR description
- Set up a product to automatically generate deferred revenues - Create an invoice with the product, set a price to zero - Post the invoice An error prevents posting: https://github.com/odoo/enterprise/blob/6dc8589ab5d4acf7d880cef0f2f37a920736dd7e/account_asset/models/account_asset.py#L114 In such a use case, there is no need to create a deferred revenue for a free product. opw-2223939 Forward-Port-Of: odoo/enterprise#9696