Friday, April 17, 2020
4 changes · master
Resolved issues and error corrections
This fix prevents labels used inside Owl component declarations from being included in translation export files. It keeps translation files cleaner by avoiding text that is not actually shown or translated for users at runtime.
Original PR description
Have a static template of the form: ```xml <div t-name="ComponentA"> <ComponentB title="no export" /> </div> ``` To be used by Owl (github.com/odoo/owl) In this context, the title in the attributes…
Have a static template of the form: ```xml <div t-name="ComponentA"> <ComponentB title="no export" /> </div> ``` To be used by Owl (github.com/odoo/owl) In this context, the title in the attributes of ComponentB should not be considered as *the* title attribute of HTML but as a sort of variable declaration Before this commit, the string contained in the value of this title attribute was exported. It was not translated at runtime, but we want to export as less stuff as possible in PO files So, after this commit, none of the attributes held by a Owl directive are exported This commit relies on Owl Syntax, which makes mandatory for a component directive's first letter to be capitalized https://github.com/odoo/owl/blob/master/doc/reference/component.md#composition Also, it relies on the good practice and widespread convention to have every HTML node lower cased https://www.w3schools.com/html/html5_syntax.asp Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Email message attachments now include the right cache information when images are loaded, preventing broken or inefficient attachment URLs. This should make attachment previews in discussions more reliable without changing how users work.
Original PR description
This merges two commits: **[FIX] mail: fetches the attachments checksum for cache control.** This commit makes so that we also fetch the checksum of the attachments of mail.messages to use it for cache control. **[REF] mail: removes signature from route params** This commit removes the unnecessary usage of `signature` instead of `unique` in the route params for `web/image`.
Document image requests now use the intended unique identifier instead of an unnecessary signature value. This helps keep document image links consistent and avoids issues caused by using the wrong parameter.
Original PR description
This commit removes the unnecessary usage of signature instead of unique in the route params for documents/image.
A leftover debugging statement was removed from the Data Cleaning feature. This prevents accidental interruptions during normal use and keeps the feature running smoothly.
Original PR description
TaskID: 2240275