Monday, April 27, 2020
35 changes · master
Enhancements to existing features
The event kanban view is easier to use, especially on mobile, with better spacing between key action links. The Confirmed button now opens the kanban view directly, helping users reach the expected event overview faster.
Original PR description
There were 2 imp. to help clarify kanban view: 1. In kanban view on Mobile, add some space between the two clickable links (expected & confirmed). 2. The "Confirmed" button land on kanban view instead of pivot view. Task ID 2228562 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Partner commission records now provide clearer guidance through a tooltip and keep track of the referrer on customer invoices. This helps teams better understand and audit commission-related partner information.
Original PR description
See https://github.com/odoo/enterprise/pull/10202 + track Referrer on account.move
Odoo Studio now limits file choices to image files when uploading an app icon or changing a background. This makes the upload process clearer and helps users avoid selecting unsupported files such as PDFs or documents.
Original PR description
purpose of this commit is when we try to upload an icon on studio it display all files like image,pdf etc but after this commit we are able to display only image file. task: 2184803
This update adds safeguards to ensure key mobile app connection routes keep working when server changes are made. It also cleans up the mobile web code organization, making future maintenance safer without changing app behavior.
Original PR description
The main purpose of this PR is to add unit tests for the routes used by our mobile applications (Android/iOS) to prevent a change made on the server to break involuntarily those apps. In addition, this PR clean up some parts of the `web_mobile` module. Task ID: 2149384
Unused layout settings related to mass mailing editing were removed from the web enterprise styling. This simplifies maintenance without changing visible functionality for users.
Original PR description
This PR removes few of the scss variables which were specifically added for making mass mailing edition occupy available space within notebook tab, but are not useful anymore. TaskID - 2207637 Closes https://github.com/odoo/enterprise/pull/9446
Resolved issues and error corrections
This fixes visual formatting problems in invoice reports so the totals table displays with the intended compact styling and page-break behavior. It helps keep printed or PDF invoices cleaner and more professional for customers.
Original PR description
Looks like this forward-port went wrong: https://github.com/odoo/odoo/pull/38102 This PR fixes two issues: 1/ class attribute was not taken into account anymore ( table-sm ) 2/ page-break-inside didn't work -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
### Issue - Install eCommerce, Delivery Costs - Create 2 delivery methods: - Country: US States: Empty - Country: US States: Oklahoma - Publish both - In private browser, go to "Shop" - Order anything, select US as country The states list only contains Oklahoma. ### Cause When selecting a country, `get_website_sale_states` is triggered. (website_sale_delivery's one) It will loop on deliveries methods and add the delivery method states to an empty list. Bu
Original PR description
### Issue - Install eCommerce, Delivery Costs - Create 2 delivery methods: - Country: US States: Empty - Country: US States: Oklahoma - Publish both - In private browser, go to "Shop" - Order anything, select US as country The states list only contains Oklahoma. ### Cause When selecting a country, `get_website_sale_states` is triggered. (website_sale_delivery's one) It will loop on deliveries methods and add the delivery method states to an empty list. But when the delivery method conditions are country US & States empty. States = no states So only the states of the delivery method country US, states: Oklahoma are taken in account ### Solution Make all states availables when one of the delivery methods doesn't have states **OPW-2222282** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50124
The newsletter editor now shows the newsletter already selected for a newsletter block instead of defaulting to the first available option. This reduces confusion and helps users confirm they are editing the correct mailing list.
Original PR description
…form Clearly display to the user which newsletter is currently being used by the Newsletter Block. Task ID #2192807 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#49840 Forward-Port-Of: odoo/odoo#49824
Original PR description
Forward-Port-Of: odoo/odoo#49840 Forward-Port-Of: odoo/odoo#49824
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49770
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49770
The rules were not added for transient models of localizations. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50074 Forward-Port-Of: odoo/odoo#45222
Original PR description
The rules were not added for transient models of localizations. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50074 Forward-Port-Of: odoo/odoo#45222
With a second company generate the report under Accounting>Reporting>Journals Audit The name on the report and the currency are the one of the first company. This occur because the information on the template is gathered using a parameter named 'res_company' which is set to the first company and not the actual one (stored in company_id). Changing the parameter instead of altering the template. opw-2242431 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.c
Original PR description
With a second company generate the report under Accounting>Reporting>Journals Audit The name on the report and the currency are the one of the first company. This occur because the information on the template is gathered using a parameter named 'res_company' which is set to the first company and not the actual one (stored in company_id). Changing the parameter instead of altering the template. opw-2242431 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50098
Users (res.users) and Partners (res.partner) are two main models of Odoo. This PR aims at improving the performance of their creation: * Records creation in batch * Code optimizations to reduce number of queries when possible Task Id - 2229358 Forward-Port-Of: odoo/odoo#48912
Original PR description
Users (res.users) and Partners (res.partner) are two main models of Odoo. This PR aims at improving the performance of their creation: * Records creation in batch * Code optimizations to reduce number of queries when possible Task Id - 2229358 Forward-Port-Of: odoo/odoo#48912
The cash rounding profit_account_id directly impact the account on the rounding invoice line. If this is configured with a 'payable' or 'receivable' account such line will be read as term and condition line in '_recompute_payment_terms_lines', messing up the line amounts Adding a domain to avoid the wrong choice opw-2214059 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50010 Forward-Port-Of: odoo/odoo#49984
Original PR description
The cash rounding profit_account_id directly impact the account on the rounding invoice line. If this is configured with a 'payable' or 'receivable' account such line will be read as term and condition line in '_recompute_payment_terms_lines', messing up the line amounts Adding a domain to avoid the wrong choice opw-2214059 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50010 Forward-Port-Of: odoo/odoo#49984
State field is present twice and statusbar widget is not usable. Let us fix it by ensuring field is present once and widget is clickable. Forward-Port-Of: odoo/odoo#50193
Original PR description
State field is present twice and statusbar widget is not usable. Let us fix it by ensuring field is present once and widget is clickable. Forward-Port-Of: odoo/odoo#50193
Prevent unexpected country creation when creating a state. Indeed, there is usually no reason to create a new country. opw-2239697 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49854 Forward-Port-Of: odoo/odoo#49713
Original PR description
Prevent unexpected country creation when creating a state. Indeed, there is usually no reason to create a new country. opw-2239697 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49854 Forward-Port-Of: odoo/odoo#49713
8b921471e4c11575b64d6e5e84508fc625dd2b07 has introduced wrong context key which replaces `res_partner_search_mode` with the depricated `search_default_customer` which was breaking search functality added by 8766f388da9b642ba4433d8d5d670847b472cff8 In this commit we correct context's key. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.od
Original PR description
8b921471e4c11575b64d6e5e84508fc625dd2b07 has introduced wrong context key which replaces `res_partner_search_mode` with the depricated `search_default_customer` which was breaking search functality added by 8766f388da9b642ba4433d8d5d670847b472cff8 In this commit we correct context's key. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50176
The (private) Rule.build method takes a values *dict* parameter. From the start it was called with an invalid argument, but before 0.15 `append_unknown` would lead to just not using the argument at all unless the rule is dynamic (aka has converters)[0]. In 0.15 the code was refactored and the `values` mapping is now used in every case[1], leading to a pretty systematic error when calling `search_pages`, which occurs any time an auto-completed URL field gets used on the website e.g. when
Original PR description
The (private) Rule.build method takes a values *dict* parameter. From the start it was called with an invalid argument, but before 0.15 `append_unknown` would lead to just not using the argument at…
The (private) Rule.build method takes a values *dict* parameter. From
the start it was called with an invalid argument, but before 0.15
`append_unknown` would lead to just not using the argument at all
unless the rule is dynamic (aka has converters)[0].
In 0.15 the code was refactored and the `values` mapping is now used
in every case[1], leading to a pretty systematic error when calling
`search_pages`, which occurs any time an auto-completed URL field gets
used on the website e.g. when converting text to a link using the page
editor or when trying to update menu items.
Fixing this in 13.0 because while the current debian stable ("buster")
still bundles 0.14, the soon-to-be-released Ubuntu LTS (20.04) updates
werkzeug to 0.16. Debian Testing (bullseye) also bundles 0.16 but
isn't expected to get released for another year so it's less of a
concern.
Fixes #47356
Relates to odoo/docker#299
[0]
https://github.com/pallets/werkzeug/blob/c769200d1dcf1e21daaa2781f0c5109586daad42/werkzeug/routing.py#L797-L828
[1] https://github.com/pallets/werkzeug/blob/048cdfd9b969c0c3a133d7ff43b8ad1ad6a673ec/src/werkzeug/routing.py#L1020-L1032
Forward-Port-Of: odoo/odoo#49771
Forward-Port-Of: odoo/odoo#49761- In a res.partner; - Schedule activity; - Choose 'meeting' as activity; - Set a summary : 'test summary'; - Open Calendar; - Chose a date and an hour; - Edit the meeting; - Add a description with a line break; - Save the meeting; - open the res.partner view; Before this commit, the note on the planned activity lack the line break. Now, the note in the planned activity has the same output as the description of the calendar meeting. opw-2236838 Forward-Port-Of: odoo/odoo#5015
Original PR description
- In a res.partner; - Schedule activity; - Choose 'meeting' as activity; - Set a summary : 'test summary'; - Open Calendar; - Chose a date and an hour; - Edit the meeting; - Add a description with a line break; - Save the meeting; - open the res.partner view; Before this commit, the note on the planned activity lack the line break. Now, the note in the planned activity has the same output as the description of the calendar meeting. opw-2236838 Forward-Port-Of: odoo/odoo#50156 Forward-Port-Of: odoo/odoo#50143
Missing `not` in #48912 changes. The multi-company group should be given to users if they have access to multiple companies and do not already have this group. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50224
Original PR description
Missing `not` in #48912 changes. The multi-company group should be given to users if they have access to multiple companies and do not already have this group. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50224
Not so stable apparently... Forward-Port-Of: odoo/odoo#50223 Forward-Port-Of: odoo/odoo#50206
Original PR description
Not so stable apparently... Forward-Port-Of: odoo/odoo#50223 Forward-Port-Of: odoo/odoo#50206
Followup of 73dc42d6d598785e381305c30b6b5149cd4e9309: catchall or bounce alias reset to the same value should not raise an UserError. This happens for example when reinitializing mail module. Also enable batch write again. Forward-Port-Of: odoo/odoo#50237
Original PR description
Followup of 73dc42d6d598785e381305c30b6b5149cd4e9309: catchall or bounce alias reset to the same value should not raise an UserError. This happens for example when reinitializing mail module. Also enable batch write again. Forward-Port-Of: odoo/odoo#50237
When the PostgreSQLHandler is used to store some logs in the ir_logging table of a database, the log record pathname is truncated to keep only the relevant part of the path. In some circumstances, the path is wrongly truncated, leading to totally invalid paths. e.g.: When using an addon-path like `/data/build/enteprise` the removed part correspond to the length of `/data/build/odoo/`. The resulting path is `prise/....`. With this commit, the full path is kept. Forward-Port-Of: odoo/o
Original PR description
When the PostgreSQLHandler is used to store some logs in the ir_logging table of a database, the log record pathname is truncated to keep only the relevant part of the path. In some circumstances, the path is wrongly truncated, leading to totally invalid paths. e.g.: When using an addon-path like `/data/build/enteprise` the removed part correspond to the length of `/data/build/odoo/`. The resulting path is `prise/....`. With this commit, the full path is kept. Forward-Port-Of: odoo/odoo#50148
Commit https://github.com/odoo/odoo/commit/4497077f552309f854b7f0afeb2b9e226ef08a04 was intended to show address type for contacts without company, but we should still keep it invisible for company contacts. Description of the issue/feature this PR addresses: opw-2222381 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50244 Forward-Port-Of: odo
Original PR description
Commit https://github.com/odoo/odoo/commit/4497077f552309f854b7f0afeb2b9e226ef08a04 was intended to show address type for contacts without company, but we should still keep it invisible for company contacts. Description of the issue/feature this PR addresses: opw-2222381 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50244 Forward-Port-Of: odoo/odoo#50113
When an outdated snippet's options are activated we display a warning above it's options that inform the user about the potential malfunctions. task-2189669 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50220 Forward-Port-Of: odoo/odoo#44569
Original PR description
When an outdated snippet's options are activated we display a warning above it's options that inform the user about the potential malfunctions. task-2189669 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50220 Forward-Port-Of: odoo/odoo#44569
Create an invoice, assign a customer and create a single invoice line with product and 0% tax. Go to Accounting>General Ledger and click on "Export Datev (ZIP)". The file EXTF_accounting_entries.csv into the zip package is will report the acccounting lines. The line related to the invoice will have a 0 amount, because the taxes are matched based on their tax_line_ids, which a 0% tax does not trigger since no accounting move are created for 0 tax amounts. Using an amount based check to
Original PR description
Create an invoice, assign a customer and create a single invoice line with product and 0% tax. Go to Accounting>General Ledger and click on "Export Datev (ZIP)". The file EXTF_accounting_entries.csv into the zip package is will report the acccounting lines. The line related to the invoice will have a 0 amount, because the taxes are matched based on their tax_line_ids, which a 0% tax does not trigger since no accounting move are created for 0 tax amounts. Using an amount based check to detect tax lines avoid the issue opw-2230699 Forward-Port-Of: odoo/enterprise#10078
[IMP] website_studio, *: add data-snippet in views * = website_helpdesk_form Adapt the views to the data-snippet changes. Related to: odoo/odoo#44569 task-2189669 Forward-Port-Of: odoo/enterprise#10219 Forward-Port-Of: odoo/enterprise#9577
Original PR description
[IMP] website_studio, *: add data-snippet in views * = website_helpdesk_form Adapt the views to the data-snippet changes. Related to: odoo/odoo#44569 task-2189669 Forward-Port-Of: odoo/enterprise#10219 Forward-Port-Of: odoo/enterprise#9577
I'll squash the commits when it's ready for merging. I've added the new profit & loss report in the `profit_loss_data.xml`. I've removed the old profit and loss report from the file `account_financial_html_report_data.xml` and apparently broke it in the process. I'll fix it and rename it the `balance_sheet.xml` as it only contains that now. I'll also rebase branch and resolve conflicts monday. Forward-Port-Of: odoo/enterprise#10216 Forward-Port-Of: odoo/enterprise#9231
Original PR description
I'll squash the commits when it's ready for merging. I've added the new profit & loss report in the `profit_loss_data.xml`. I've removed the old profit and loss report from the file `account_financial_html_report_data.xml` and apparently broke it in the process. I'll fix it and rename it the `balance_sheet.xml` as it only contains that now. I'll also rebase branch and resolve conflicts monday. Forward-Port-Of: odoo/enterprise#10216 Forward-Port-Of: odoo/enterprise#9231
Make sure no account is set on section and notes when an intercompany invoice is created. opw-2239057 Forward-Port-Of: odoo/enterprise#10211 Forward-Port-Of: odoo/enterprise#10206
Original PR description
Make sure no account is set on section and notes when an intercompany invoice is created. opw-2239057 Forward-Port-Of: odoo/enterprise#10211 Forward-Port-Of: odoo/enterprise#10206
Steps to reproduce the bug: - Let's consider a rental product P tracked by unique serial number - Let's consiser two units of P on hand with SN1 and SN2 as serial number - Create a rental order RO for two units of P and confirm it - In RO pick up SN1 and SN2 - In RO return SN1 Bug: When looking in the Gantt view of P (on the product form > rental), the 2 serial numbers were displayed as returned for RO opw:2237685 Forward-Port-Of: odoo/enterprise#10147
Original PR description
Steps to reproduce the bug: - Let's consider a rental product P tracked by unique serial number - Let's consiser two units of P on hand with SN1 and SN2 as serial number - Create a rental order RO for two units of P and confirm it - In RO pick up SN1 and SN2 - In RO return SN1 Bug: When looking in the Gantt view of P (on the product form > rental), the 2 serial numbers were displayed as returned for RO opw:2237685 Forward-Port-Of: odoo/enterprise#10147
The purpose of this commit is to introduce tests for the routes (url) used by the native mobile applications. The end goal is to prevent modification on the server from inadvertently breaking the native apps. In a nutshell, the routes tested are used to: - check for a compatible server - retrieve the databases' list - authenticate the user - retrieve the user's avatar Task ID: 2149384 Forward-Port-Of: odoo/enterprise#10195
Original PR description
The purpose of this commit is to introduce tests for the routes (url) used by the native mobile applications. The end goal is to prevent modification on the server from inadvertently breaking the native apps. In a nutshell, the routes tested are used to: - check for a compatible server - retrieve the databases' list - authenticate the user - retrieve the user's avatar Task ID: 2149384 Forward-Port-Of: odoo/enterprise#10195
before this commit , The 'create your app' button and lots of contents that overflows the viewport's height are not visible in app creator because of no scrollbar In this commit , we fix this issue by adding a scrollbar in the app creator. task - 2234268 Forward-Port-Of: odoo/enterprise#9804
Original PR description
before this commit , The 'create your app' button and lots of contents that overflows the viewport's height are not visible in app creator because of no scrollbar In this commit , we fix this issue by adding a scrollbar in the app creator. task - 2234268 Forward-Port-Of: odoo/enterprise#9804
When signing a contract linked to a car, set the future driver only if it is different from the current driver. opw-2242350 Forward-Port-Of: odoo/enterprise#10142 Forward-Port-Of: odoo/enterprise#10130
Original PR description
When signing a contract linked to a car, set the future driver only if it is different from the current driver. opw-2242350 Forward-Port-Of: odoo/enterprise#10142 Forward-Port-Of: odoo/enterprise#10130
The rules were not added for transient models of localizations Forward-Port-Of: odoo/enterprise#10159 Forward-Port-Of: odoo/enterprise#8395
Original PR description
The rules were not added for transient models of localizations Forward-Port-Of: odoo/enterprise#10159 Forward-Port-Of: odoo/enterprise#8395
Purpose of this commit is when setting a field as readonly, if field is populated by an onchnage, its would not be saved on write so pass force_save attribute 'ture' on the field when setting is as readonly task-2207826 Forward-Port-Of: odoo/enterprise#9864 Forward-Port-Of: odoo/enterprise#9464
Original PR description
Purpose of this commit is when setting a field as readonly, if field is populated by an onchnage, its would not be saved on write so pass force_save attribute 'ture' on the field when setting is as readonly task-2207826 Forward-Port-Of: odoo/enterprise#9864 Forward-Port-Of: odoo/enterprise#9464