Thursday, April 30, 2020
6 changes · master
Enhancements to existing features
This update cleans up internal handling in financial reporting so reports no longer rely on improper stored values. It supports future platform improvements in Odoo's data layer without changing day-to-day reporting behavior for users.
Original PR description
Task [2204376](https://www.odoo.com/web?#id=2204376&action=333&active_id=967&model=project.task&view_type=form&cids=1&menu_id=4720) Some class properties were used as instance properties when they shouldn't have been. Values that are not fields were used on empty recordsets, and this prevents a refactoring in the ORM.
Miscellaneous changes
The warehouse analysis should only contain data related to stockable products, not consumable products. opw-2153840 Forward-Port-Of: odoo/enterprise#10296 Forward-Port-Of: odoo/enterprise#10239
Original PR description
The warehouse analysis should only contain data related to stockable products, not consumable products. opw-2153840 Forward-Port-Of: odoo/enterprise#10296 Forward-Port-Of: odoo/enterprise#10239
Make `_get_linkedin_accounts` always return an iterable, otherwise the following may crash: https://github.com/odoo/enterprise/blob/c3d1d38a98f7192ce8bdb0ab765a16dc2ec0caeb/social_linkedin/models/social_account.py#L68 opw-2239922 opw-2233279 opw-2244954 Forward-Port-Of: odoo/enterprise#10292 Forward-Port-Of: odoo/enterprise#10282
Original PR description
Make `_get_linkedin_accounts` always return an iterable, otherwise the following may crash: https://github.com/odoo/enterprise/blob/c3d1d38a98f7192ce8bdb0ab765a16dc2ec0caeb/social_linkedin/models/social_account.py#L68 opw-2239922 opw-2233279 opw-2244954 Forward-Port-Of: odoo/enterprise#10292 Forward-Port-Of: odoo/enterprise#10282
Before this commit: 1. The amount on the right for car company, was always set to 0 when we open the link (it's updated when we change the selected car) 2. When we fold an item (on front end), the amount of this item (on the right) was not set to 0 3. If we set a contract template for new signature, but no contract template signature for existing contract, we have an error. 4. If we have no hr responsible on contract, the error message was not clear. 5. When we have no available vehicle
Original PR description
Before this commit: 1. The amount on the right for car company, was always set to 0 when we open the link (it's updated when we change the selected car) 2. When we fold an item (on front end), the…
Before this commit: 1. The amount on the right for car company, was always set to 0 when we open the link (it's updated when we change the selected car) 2. When we fold an item (on front end), the amount of this item (on the right) was not set to 0 3. If we set a contract template for new signature, but no contract template signature for existing contract, we have an error. 4. If we have no hr responsible on contract, the error message was not clear. 5. When we have no available vehicle (empty list), we can have error in python, because we made operation on False. 6. The new vehicle to add in waiting list was never created. 7. vehicle in waitinglist have no future driver and no company. 8. When an employee validate his contract, he arrive on signature page, then he decide to use back button, selected item are always selected but stay folded. 9. Default car on contract has mismatch between partner_id and employee_id After this commit: No more bug from the list above Forward-Port-Of: odoo/enterprise#10121
When running the cron for the timesheet managers' validation email the status of the timesheet_mail_manager_allow from the company (set in the general settings) was not checked. This allowed validation emails to be sent even with the option "Manager Reminder" disabled. opw 2225912 Forward-Port-Of: odoo/enterprise#10273
Original PR description
When running the cron for the timesheet managers' validation email the status of the timesheet_mail_manager_allow from the company (set in the general settings) was not checked. This allowed validation emails to be sent even with the option "Manager Reminder" disabled. opw 2225912 Forward-Port-Of: odoo/enterprise#10273
Is possible to add the filter_partner in some account reports, like in partner ledger: https://github.com/odoo/enterprise/blob/d91cc166b405d10044222b2a0f356da4b456b3cc/account_reports/models/account_partner_ledger.py#L21 Is this is enabled, are added 2 options: - Partner - Category  If in a custom report is necessary to hide the filter for Categ
Original PR description
Is possible to add the filter_partner in some account reports, like in partner ledger:…
Is possible to add the filter_partner in some account reports, like in
partner ledger:
https://github.com/odoo/enterprise/blob/d91cc166b405d10044222b2a0f356da4b456b3cc/account_reports/models/account_partner_ledger.py#L21
Is this is enabled, are added 2 options:
- Partner
- Category

If in a custom report is necessary to hide the filter for Category is not
possible, because not exists the option filter_partner_category = False,
then, could be inherited the method
[_get_options](https://github.com/odoo/enterprise/blob/12.0/account_reports/models/account_report.py#L130)
and remove that option, but if it's removed I get an error on report
generation because get the values with dict['key'] and not with
dict.get('key').

Without this fix, is necessary to overwrite the method
``get_report_informations`` to make this improve and avoid the error
(It's no the correct).
Forward-Port-Of: odoo/enterprise#10136