Wednesday, May 13, 2020
23 changes · master
Enhancements to existing features
This update improves Odoo’s documentation by explaining how to use the new database population capability from the command line and how to implement it for testing. It also fixes several documentation formatting issues, making the guidance clearer and easier to maintain.
Original PR description
* Minor sphinx fixes * Information on new CLI populate feature * Testing / Performance testing -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
Fixed an issue where resizing a column in one embedded list could unintentionally widen columns in another list on the same form. This keeps form layouts more predictable and prevents users from accidentally disrupting nearby tables.
Original PR description
Before this commit, on extending the column of the relational field table inside the group, all the column of the table extend rather than the selected column After this commit, only the selected column will expand rather than all columns expand. task-2189968
Miscellaneous changes
The properties must always be accessed using the company of the journal entry defined by its journal. Task: 2244829 X-original-commit: 43aae420c1bdffa93eb5711160ec1a7fe903b6e9 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#51080 Forward-Port-Of: odoo/odoo#51066
Original PR description
The properties must always be accessed using the company of the journal entry defined by its journal. Task: 2244829 X-original-commit: 43aae420c1bdffa93eb5711160ec1a7fe903b6e9 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#51080 Forward-Port-Of: odoo/odoo#51066
This fixes a case where default company-related selection rules were not applied correctly for company fields. It helps ensure users only see valid company choices consistently across the system.
Original PR description
The supported case of check_company on `res_company` model fields wasn't considered when specifying a default domain on `check_company=True` fields. NB: It is already correctly supported in the `_check_company()` method. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Corrects typos that caused errors when creating lead reveal rules from the website CRM lead feature. This helps ensure new lead generation rules can be saved reliably without interrupting users.
Original PR description
…putation Oversight of efafadc3ee2740407d6d6ff8082ab9e1f7d8e87f This commit fixes typos that raise an error when a crm.reveal.rule is created. Task 2250137 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
When a user creates a new Studio model with a name that already exists, the setup screen now closes and returns them to the previous model. This prevents users from getting stuck and lets them choose a unique name to continue their work.
Original PR description
Purpose: -Purpose of this commit is to close the model configurator on unique name model error and go to the previous model. Task-2250768
1. Install eCommerce 2. Enable Pricelist settings 3. Choose a product P and enable it in the ecommerce view 4. Create 2 pricelists, for P with: - PL1: One with "Benelux" as country group with a price of X - PL2: One with a price of Y 5. Assign PL2 to the portal user (Joel Wilis) through "Website > Customer" 6. Connect as the portal user 7. Go into the ecommerce page of the product P The pricelist PL1 is used instead of PL2, this occur because geoIp localisation take priority
Original PR description
1. Install eCommerce
2. Enable Pricelist settings
3. Choose a product P and enable it in the ecommerce view
4. Create 2 pricelists, for P with:
- PL1: One with "Benelux" as country group with a price of X
- PL2: One with a price of Y
5. Assign PL2 to the portal user (Joel Wilis) through "Website > Customer"
6. Connect as the portal user
7. Go into the ecommerce page of the product P
The pricelist PL1 is used instead of PL2, this occur because
geoIp localisation take priority over customer assigned pricelists.
Fixing filter by allowing pricelist with no country defined to be used
opw-2242152
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#50993PURPOSE: Partner autocomplete suggestion popup cropped from the top in small devices. once you type anything in M2O box, autocomplete popup will display with all maximum possibilities consist of the database records and records got from global search partner API. Currently, we have limit of database record search is 7 and for API generated record is 6. SPEC So with this commit, we have reduced the API record display limit to 3 to achieve this cropped issue. Task:2206844 -- I co
Original PR description
PURPOSE: Partner autocomplete suggestion popup cropped from the top in small devices. once you type anything in M2O box, autocomplete popup will display with all maximum possibilities consist of the database records and records got from global search partner API. Currently, we have limit of database record search is 7 and for API generated record is 6. SPEC So with this commit, we have reduced the API record display limit to 3 to achieve this cropped issue. Task:2206844 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50812
### Issue - Install Survey & Contacts - Have 2 contacts with the same email address - Create a survey, send it to that email address Email sent 2 times ### Cause We do not apply any filter which prevents this. ### Solution Add a filter only if login is not required, the person will fill the form only one time so this is useless to send it 3 times. **OPW-2247693** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-
Original PR description
### Issue - Install Survey & Contacts - Have 2 contacts with the same email address - Create a survey, send it to that email address Email sent 2 times ### Cause We do not apply any filter which prevents this. ### Solution Add a filter only if login is not required, the person will fill the form only one time so this is useless to send it 3 times. **OPW-2247693** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#51022
Forward-Port-Of: odoo/odoo#50421
Original PR description
Forward-Port-Of: odoo/odoo#50421
Before this commit, a traceback occurred when user clicked in the Sales Analysis in the sales team dashboard Taskid: 2246368 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50835
Original PR description
Before this commit, a traceback occurred when user clicked in the Sales Analysis in the sales team dashboard Taskid: 2246368 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#50835
Forward-Port-Of: odoo/odoo#51103 Forward-Port-Of: odoo/odoo#50919
Original PR description
Forward-Port-Of: odoo/odoo#51103 Forward-Port-Of: odoo/odoo#50919
Exceptions were not logged correctly due to a typo in ExceptionLogger. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#51168
Original PR description
Exceptions were not logged correctly due to a typo in ExceptionLogger. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#51168
Task: https://www.odoo.com/web#id=1918677&model=project.task&view_type=form&cids=2&menu_id= Forward-Port-Of: odoo/odoo#50028
Original PR description
Task: https://www.odoo.com/web#id=1918677&model=project.task&view_type=form&cids=2&menu_id= Forward-Port-Of: odoo/odoo#50028
Steps to reproduce: - Let's consider a portal user PU - Create a subscription S for PU - Log with PU and go in your subscription on the portal - Filter by Closed Bug: A 403 error was raised because PU has no right to read sale.subscription.stage Fine tuning of https://github.com/odoo/enterprise/commit/1905321746425641756eca9edca933c6a55a4de3 opw:2248630 Forward-Port-Of: odoo/enterprise#10573
Original PR description
Steps to reproduce: - Let's consider a portal user PU - Create a subscription S for PU - Log with PU and go in your subscription on the portal - Filter by Closed Bug: A 403 error was raised because PU has no right to read sale.subscription.stage Fine tuning of https://github.com/odoo/enterprise/commit/1905321746425641756eca9edca933c6a55a4de3 opw:2248630 Forward-Port-Of: odoo/enterprise#10573
Somehow PR odoo/enterprise#10422 was not correctly forward ported. This commit fixes the commit by correctly calling process_event on a marketing_trace, not a mailing_trace. Forward-Port-Of: odoo/enterprise#10579
Original PR description
Somehow PR odoo/enterprise#10422 was not correctly forward ported. This commit fixes the commit by correctly calling process_event on a marketing_trace, not a mailing_trace. Forward-Port-Of: odoo/enterprise#10579
Bug introduced in commit 3031f4399f0ead8f496c38ab310a0a4e8eab9842 "tuple(context.get('company_ids'))" was replaced by "self.env.companies.ids" forgetting to cast it as a tuple. Forward-Port-Of: odoo/enterprise#10561
Original PR description
Bug introduced in commit 3031f4399f0ead8f496c38ab310a0a4e8eab9842
"tuple(context.get('company_ids'))" was replaced by "self.env.companies.ids" forgetting to cast it as a tuple.
Forward-Port-Of: odoo/enterprise#10561Before this commit, the account was erased by the predicted account even if the account was set by setting a product. With this commit, an explicit account set on the product configuration can't be overridden by the prediction. Also, this commit removes the prediction of the product because this behavior is no longer expected. issue: https://github.com/odoo/odoo/issues/49444 Forward-Port-Of: odoo/enterprise#10494 Forward-Port-Of: odoo/enterprise#10242
Original PR description
Before this commit, the account was erased by the predicted account even if the account was set by setting a product. With this commit, an explicit account set on the product configuration can't be overridden by the prediction. Also, this commit removes the prediction of the product because this behavior is no longer expected. issue: https://github.com/odoo/odoo/issues/49444 Forward-Port-Of: odoo/enterprise#10494 Forward-Port-Of: odoo/enterprise#10242
Forward-Port-Of: odoo/enterprise#10502 Forward-Port-Of: odoo/enterprise#10493
Original PR description
Forward-Port-Of: odoo/enterprise#10502 Forward-Port-Of: odoo/enterprise#10493
When Python tests are run with the `--no-database-list` command line option the `MobileRoutesTest#test_database_list` test fails because the route tested is explicitly disabled. Also this option is used on all processes on Odoo.sh, preventing any build from succeeding. This commit adds support for the `--no-database-list` command line option when running this test by adapting it to test both scenario. opw-2252357 Forward-Port-Of: odoo/enterprise#10507
Original PR description
When Python tests are run with the `--no-database-list` command line option the `MobileRoutesTest#test_database_list` test fails because the route tested is explicitly disabled. Also this option is used on all processes on Odoo.sh, preventing any build from succeeding. This commit adds support for the `--no-database-list` command line option when running this test by adapting it to test both scenario. opw-2252357 Forward-Port-Of: odoo/enterprise#10507
Task: https://www.odoo.com/web#id=2209339&action=327&model=project.task&view_type=form&cids=&menu_id=4720 Forward-Port-Of: odoo/enterprise#10332
Original PR description
Task: https://www.odoo.com/web#id=2209339&action=327&model=project.task&view_type=form&cids=&menu_id=4720 Forward-Port-Of: odoo/enterprise#10332
The properties must always be accessed using the company of the journal entry defined by its journal. Task: 2244829 X-original-commit: 43aae420c1bdffa93eb5711160ec1a7fe903b6e9 Forward-Port-Of: odoo/enterprise#10524
Original PR description
The properties must always be accessed using the company of the journal entry defined by its journal. Task: 2244829 X-original-commit: 43aae420c1bdffa93eb5711160ec1a7fe903b6e9 Forward-Port-Of: odoo/enterprise#10524
Issue - Install 'approvals' module - Activate debug mode - Alter name of activity type 'Approval' - Go to "Approval" module - Check a confirmed approval on Approvals. In chatter, normally you should see "Approve" and "Refuse" buttons but you'll see "Mark as done" etc. as if it was a normal activity. Causes The check in xml was based on the name of the activity type. Since user can rename it, the comparaison with the name is no longer working. Solution When
Original PR description
Issue - Install 'approvals' module - Activate debug mode - Alter name of activity type 'Approval' - Go to "Approval" module - Check a confirmed approval on Approvals. In chatter, normally you should see "Approve" and "Refuse" buttons but you'll see "Mark as done" etc. as if it was a normal activity. Causes The check in xml was based on the name of the activity type. Since user can rename it, the comparaison with the name is no longer working. Solution When it's an approval activity type, an 'approver_id' field is extended to the record dict. Now, it check if field 'approve_id' exist to now if it's an approval. opw-2246667 Forward-Port-Of: odoo/enterprise#10533