Saturday, May 23, 2020
5 changes · master
Miscellaneous changes
Before this commit, block for adding new Shipping address was always visible even if It is disabled/Not needed. With this commit, We respect website configuration (Website --> Configuration --> Shipping Address) to display this block. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#51723
Original PR description
Before this commit, block for adding new Shipping address was always visible even if It is disabled/Not needed. With this commit, We respect website configuration (Website --> Configuration --> Shipping Address) to display this block. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#51723
Bug introduced by [1]. When the header starts being animated, the main padding-top of the page is adapted automatically with JS... but that JS was actually starting a never-ending loop. This is fixed now. [1]: https://github.com/odoo/odoo/commit/3defe35a0e4e2097115633797df6898ac2724c66 Forward-Port-Of: odoo/odoo#51630
Original PR description
Bug introduced by [1]. When the header starts being animated, the main padding-top of the page is adapted automatically with JS... but that JS was actually starting a never-ending loop. This is fixed now. [1]: https://github.com/odoo/odoo/commit/3defe35a0e4e2097115633797df6898ac2724c66 Forward-Port-Of: odoo/odoo#51630
In saas-13.2, the list view was added. Before this commit, the style for the inspector target only the Kanban. After this commit, we allow the style for all views. Steps to reproduce: * Open Documents in "Mobile Mode" * Select the list view * Select a record * The Inspector Button appears but not with the correct style (BUG) Task ID: 2210191 Forward-Port-Of: odoo/enterprise#10287
Original PR description
In saas-13.2, the list view was added. Before this commit, the style for the inspector target only the Kanban. After this commit, we allow the style for all views. Steps to reproduce: * Open Documents in "Mobile Mode" * Select the list view * Select a record * The Inspector Button appears but not with the correct style (BUG) Task ID: 2210191 Forward-Port-Of: odoo/enterprise#10287
Since odoo/odoo@18e5416636b19b0953b1e6e26bfaeab1ebecce4c, the call of updateButtons() has been moved from renderButtons() to the end of start() in "abstract_controller.js". Then odoo/enterprise@cebd6bece5a9d73b8ca1983d60f01f5e07c931e1 was introduced. The problem is that _updateSelectionBox() is called twice in Document: - The first time by updateButtons() in renderButtons() but it's too early as a result a traceback as "widget.el" doesn't exist yet. - The second time by updateButtons()
Original PR description
Since odoo/odoo@18e5416636b19b0953b1e6e26bfaeab1ebecce4c, the call of updateButtons() has been moved from renderButtons() to the end of start() in "abstract_controller.js". Then odoo/enterprise@cebd6bece5a9d73b8ca1983d60f01f5e07c931e1 was introduced. The problem is that _updateSelectionBox() is called twice in Document: - The first time by updateButtons() in renderButtons() but it's too early as a result a traceback as "widget.el" doesn't exist yet. - The second time by updateButtons() in start(). So in this commit, we simply remove the call to updateButtons() because it's already done in start() since the ref mentioned above. Steps to reproduce: * Open Odoo in Mobile * Go to the Documents App * Change to the list view (BUG) Forward-Port-Of: odoo/enterprise#10724
When the user attempts to add a contact to its device's address book, either the app crashes (iOS) or silently ignore the contact's image. This is due to the rename of the partner's field "image" to "image_1920" performed in commit odoo/enterprise@fabd84c1fedde92b23f2cd136cd299e20870dc06 which created an inconsistency between the usage of the native `addContact` method and its implementation in the mobile apps (on both iOS & Android). This commit fixes it by mapping the new field's nam
Original PR description
When the user attempts to add a contact to its device's address book, either the app crashes (iOS) or silently ignore the contact's image. This is due to the rename of the partner's field "image" to "image_1920" performed in commit odoo/enterprise@fabd84c1fedde92b23f2cd136cd299e20870dc06 which created an inconsistency between the usage of the native `addContact` method and its implementation in the mobile apps (on both iOS & Android). This commit fixes it by mapping the new field's name to the old one to keep descending compatibility with version < 13.0. Also, it removes the `title` field's retrieval as it isn't used on the mobile apps. opw-2232760 Forward-Port-Of: odoo/enterprise#10720