Monday, June 22, 2020
10 changes · master
Resolved issues and error corrections
Copying a server action now preserves its configured behavior instead of resetting it to the default. This prevents duplicated automated actions from changing how they run, reducing setup mistakes and unexpected business process changes.
Original PR description
`state` is special-cased in `copy_data` and always reset to its default value if its has one. Therefore rename `state` to `action_type`, and add a related `state` field for backwards compatibility. Task 2079441 Alternative version: #53113 changes the implementation of the `state` special case instead note: probably need to fix a few visible uses of `state` if we go with this one (e.g. the view)
Copying a server action now preserves its configured state when the field is explicitly marked to be copied. This prevents duplicated actions from unexpectedly reverting to a default state, reducing manual reconfiguration and potential setup mistakes.
Original PR description
`state` was special cased in `copy_data` such that it would always be reset to its default value if it had one. While this special case can be useful (maybe) and is certainly ingrained in odoo, having it not be overridable can be problematic. Move the special case to the fields, so it's possible to explicitly mark state fields as copy. Task 2079441 Alternative to #53111
Employee private addresses in demo data are now correctly marked as private, matching real privacy expectations. Related accounting and expense flows were adjusted so authorized billing users can still process payments without crashes when those private addresses are used.
Original PR description
we make the field address _home_id private address instead of regular contact for Mitchell admin and Mark demo.Due to that lots of business flows could crash because it is not visible to the demo data.We fix the flows on which errors could occur. LINKS PR #46628 TaskID: 2170016
This pull request adjusts behavior and tests across accounting, point of sale, sales, and localization areas. The changes appear to improve reliability around payments, bank details, invoices, and related workflows, helping reduce errors in day-to-day financial operations.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Monetary amounts shown on kanban cards now display a normal space between the value and currency symbol instead of showing raw HTML text. This makes prices and totals easier to read and avoids confusing visual glitches for users.
Original PR description
When a monetary field is present in a kanban view (without monetary widget specified), and its currency field is also defined (invisible or not, we just need the field information to be present), the field value is displayed with the currency symbol, but with a raw "` `" between the monetary value and the symbol. Example below is the inline kanban view of sale order lines, reduced to only the monetary field in the `templates` part.  --> https://2972599-10870-5bd0ea.runbot29.odoo.com/web?debug=1#action=1122&cids=1&id=43&menu_id=816&model=sale.order&view_type=form -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The recruitment app no longer shows the “Applicant created” message twice in the chatter. This reduces confusion for users reviewing applicant activity and keeps communication history cleaner.
Original PR description
Before this commit the message "Applicant created" was displayed twice in the chatter. Task-2278142
Odoo now correctly creates a single reusable identifier when a field from a shared mixin first appears on a real model. This prevents fields added through module inheritance from being missed, improving reliability for configuration, customization, and upgrades.
Original PR description
We want to create a XMLID for every first exhibition of a field in a model. That is, we just want one XMLID by field by model and not one XMLID by field by class. Previous implementation was…
We want to create a XMLID for every first exhibition of a field in a model. That is, we just want one XMLID by field by model and not one XMLID by field by class. Previous implementation was determining the "first field exhibition" by making sure the field was created and used as part of the same module. This assumption is invalid when we consider mixins. A mixin is an abstract model that define fields and methods to be included in other models. As it is abstract, it does not exhibits the field by itself. The field will only be exhibited when included in a concrete model via inheritance. When it is included in another module, the XMLID creation is discarded. Take a module M1 that defines a model A, take another module M2 that defines a mixin X with a field X1. In a third module M3, extend A to inherit from X. While M3.A is the first model module to exhibit the field X1, the XMLID creation was discarded because `"M2" != "M3"`. See https://github.com/odoo/odoo/issues/49354#issuecomment-614093767 Task: 2235368 Closes #49354 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Employee demo records for Marc/Mitchell now use private addresses where appropriate, preventing business flows and tests from failing when private address visibility rules apply. This keeps Belgian salary contract and payroll accounting demo scenarios aligned with expected HR privacy behavior.
Original PR description
In this commit, we make the field address _home_id private address instead of regular contact for Mitchell admin and Mark demo.Due to that lots of business flows could crash because it is not visible to the demo data.We fix the flows on which errors could occur. LINKS PR #8924 TaskID: 2170016
Several Odoo Enterprise workflows now handle multiple selected records correctly instead of only working reliably on one record at a time. This reduces the risk of errors or incorrect results in areas such as assets, payroll, inter-company rules, manufacturing, quality, subscriptions, and local invoicing.
Original PR description
Wrong usage of self in for loops makes some apparently multi-friendly methods not work correctly when called with a recordset of len > 1. This commit replaces those references by the correct unique record reference which should be used at this iteration of the loop, avoiding potential exceptions or wrong behavior in the concerned methods. Enterprise followup of https://github.com/odoo/odoo/pull/53320
The timesheet grid no longer shows blank rows when users apply certain filters, such as filtering to their own projects. This makes the view clearer and prevents confusing empty entries from appearing in day-to-day timesheet review.
Original PR description
Currently, In grid view of timesheet some filters are applied then it returned completely empty lines. In this commit, we hide those empty lines for better user interface. Task-Id: 2245782 PR #10685