Monday, June 29, 2020
18 changes · master
Enhancements to existing features
The resource attendance form now hides start and end date fields by default while keeping them available when needed. This reduces visual clutter for users managing work schedules and helps them focus on the most commonly used attendance details.
Original PR description
This commit sets the fields date_from and date_to as optional hidden on the resource.calendar.attendace. TaskID: 2241686 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Features or functions removed from Odoo
An obsolete internal customization for decimal precision handling was removed because its behavior is already covered elsewhere. This simplifies maintenance without changing how users see or use the system.
Original PR description
Code's been dead since 3407fb70e4a5b16174234d10d97710572b6f808c essentially inlined its behaviour into the base class.
Code cleanup and technical improvements
The timer feature has been converted to a newer interface framework to make future improvements easier and more consistent. This is mainly an internal modernization, with added tests to help ensure the timer continues working as expected.
Original PR description
PURPOSE Prepare future for owl SPEC Convert timer to owl. task - 2274043
Miscellaneous changes
Well odoo/odoo#40872 is definitely the gift that keeps on giving, after causing grief with the logging configuration change turns out inlining the method was *also* a terrible idea because it's overridden in `mail` in order to note merges on the destination partner, which I apparently completely missed back then. Task 2285876 Forward-Port-Of: odoo/odoo#53742
Original PR description
Well odoo/odoo#40872 is definitely the gift that keeps on giving, after causing grief with the logging configuration change turns out inlining the method was *also* a terrible idea because it's overridden in `mail` in order to note merges on the destination partner, which I apparently completely missed back then. Task 2285876 Forward-Port-Of: odoo/odoo#53742
1. Install the demo data 2. Activate GeoIP and set your IP in Belgium [1] 3. As a non-connected user, go to '/partners' => No result found: expected since we want to filter the partners available in the user's country 4. Click on 'All Countries' => All partners are displayed 5. Click on 'Platinum' or search for 'azure' => No result found The last step is not expected, it should filter partners from the 'All Countries' list. It occurs because the 'All Countries' filter
Original PR description
1. Install the demo data 2. Activate GeoIP and set your IP in Belgium [1] 3. As a non-connected user, go to '/partners' => No result found: expected since we want to filter the partners available in…
1. Install the demo data 2. Activate GeoIP and set your IP in Belgium [1] 3. As a non-connected user, go to '/partners' => No result found: expected since we want to filter the partners available in the user's country 4. Click on 'All Countries' => All partners are displayed 5. Click on 'Platinum' or search for 'azure' => No result found The last step is not expected, it should filter partners from the 'All Countries' list. It occurs because the 'All Countries' filter is not kept when chosing a Level or searching. We use `keep_query` for the level filtering and set the `country_all` `input` field for searching. [1] IP can be set manually in https://github.com/odoo/odoo/blob/bbb45e3412a5653d78aacc92903e95d1353ed60a/addons/http_routing/geoipresolver.py#L42 opw-2277343 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53729
Adding 3 missing accounts, 2083, 2090, 7490 standard in BAS 2020 and should be included. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53237
Original PR description
Adding 3 missing accounts, 2083, 2090, 7490 standard in BAS 2020 and should be included. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53237
Install payment Archive the cron Upgrade system --> Issue the cron is now active Note: on testing server we archive cron (we execute an SQL query before upgrade the system) @qdp-odoo @nim-odoo @sla-subteno-it -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53392
Original PR description
Install payment Archive the cron Upgrade system --> Issue the cron is now active Note: on testing server we archive cron (we execute an SQL query before upgrade the system) @qdp-odoo @nim-odoo @sla-subteno-it -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53392
Steps to reproduce: - Create a database with german as main language - Load the en_US language (keep user preference as german) - Activate debug mode > find the email template named "Purchase Order: Send PO" - Edit the mail template > click the "DE" button to show thet translation dialog Previous behavior: the en_US translation is empty, it is confusing because the user assumes that english translation have not been loaded. that translation is actually fine when you switch to english
Original PR description
Steps to reproduce: - Create a database with german as main language - Load the en_US language (keep user preference as german) - Activate debug mode > find the email template named "Purchase Order: Send PO" - Edit the mail template > click the "DE" button to show thet translation dialog Previous behavior: the en_US translation is empty, it is confusing because the user assumes that english translation have not been loaded. that translation is actually fine when you switch to english Current behavior: en_US translations' empty value are assumed to be the same as the source opw-2276673 Forward-Port-Of: odoo/odoo#53748 Forward-Port-Of: odoo/odoo#53399
The string formating was called inside _() which does not work. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53751 Forward-Port-Of: odoo/odoo#53740
Original PR description
The string formating was called inside _() which does not work. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53751 Forward-Port-Of: odoo/odoo#53740
TaskID: 2219194 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53799
Original PR description
TaskID: 2219194 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53799
Fields that are shared between account.payment & account.move models are badly set when creating the records. For example, 'partner_bank_id' in vals will be set on account.payment but not on the account.move. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53640
Original PR description
Fields that are shared between account.payment & account.move models are badly set when creating the records. For example, 'partner_bank_id' in vals will be set on account.payment but not on the account.move. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53640
commit 4f172c34f504591315c59cd551bdc4b62b849cfe rename _compute_available_products in _compute_available_products but forget to also update overwrite created in commit c71e599e8886f1aa54765474113c3316402359ff Forward-Port-Of: odoo/enterprise#11508
Original PR description
commit 4f172c34f504591315c59cd551bdc4b62b849cfe rename _compute_available_products in _compute_available_products but forget to also update overwrite created in commit c71e599e8886f1aa54765474113c3316402359ff Forward-Port-Of: odoo/enterprise#11508
Issue description: On the salary configurator page, the field for the spouse information were required even if the marrital status was single The javascript that set the fields required or not according their visibility status was not searching for the input properly. Solution: Search for the input to show/hide properly UX improvement: Scroll the user to the top of personnal information form and not at the bottom. Forward-Port-Of: odoo/enterprise#11505
Original PR description
Issue description: On the salary configurator page, the field for the spouse information were required even if the marrital status was single The javascript that set the fields required or not according their visibility status was not searching for the input properly. Solution: Search for the input to show/hide properly UX improvement: Scroll the user to the top of personnal information form and not at the bottom. Forward-Port-Of: odoo/enterprise#11505
…helpdesk ticket Steps to reproduce the bug: - Let's consider two employee E1 and E2 - Let's consider a Helpdesk Team HT with Timesheet on ticket and Time reinvoicing - Let's create a ticket T in HT - Record two timesheet lines on T, one for E1 and one for E2 - Try to create a task TSK in T and save Bug: A UserError was raised saying: You can not modify timesheets from different employees Fine tuning of https://github.com/odoo/odoo/commit/419112
Original PR description
…helpdesk ticket
Steps to reproduce the bug:
- Let's consider two employee E1 and E2
- Let's consider a Helpdesk Team HT with Timesheet on ticket and Time reinvoicing
- Let's create a ticket T in HT
- Record two timesheet lines on T, one for E1 and one for E2
- Try to create a task TSK in T and save
Bug:
A UserError was raised saying: You can not modify timesheets from different employees
Fine tuning of https://github.com/odoo/odoo/commit/419112ec634a11bcc7c2c28b81fd27128b6d5d1e
opw:2282197
Forward-Port-Of: odoo/enterprise#11427
Forward-Port-Of: odoo/enterprise#11417This year the SAT added 3 new codes to its product catalog. As you can see in its [catalog](http://omawww.sat.gob.mx/tramitesyservicios/Paginas/documentos/catCFDI.xls)  The official notification of the SAT is in [Anexo20](http://omawww.sat.gob.mx/tramitesyservicios/Paginas/documentos/GuiaAnexo2014102019.pdf) on its pages **103 to 106** and **page 11
Original PR description
This year the SAT added 3 new codes to its product catalog. As you can see in its [catalog](http://omawww.sat.gob.mx/tramitesyservicios/Paginas/documentos/catCFDI.xls)  The official notification of the SAT is in [Anexo20](http://omawww.sat.gob.mx/tramitesyservicios/Paginas/documentos/GuiaAnexo2014102019.pdf) on its pages **103 to 106** and **page 119**   Forward-Port-Of: odoo/enterprise#11464 Forward-Port-Of: odoo/enterprise#11442
TaskID: 2279468 Forward-Port-Of: odoo/enterprise#11304 Forward-Port-Of: odoo/enterprise#11298
Original PR description
TaskID: 2279468 Forward-Port-Of: odoo/enterprise#11304 Forward-Port-Of: odoo/enterprise#11298
- Install Sales (sale_management) and DHL Express Shipping (delivery_dhl) - Go to Sales > Configuration > Shipping Methods - Select a DHL delivery method (e.g. DHL USA) and activate "Dutiable Material" option - Go to Sales and create a quotation - Add a customer whose an addess is in the same country than the company - Add a product with a Weight and a Volume - Click on the "ADD SHIPPING" button - On the wizard, select the modified DHL delivery method and click on "GET RATE" button The f
Original PR description
- Install Sales (sale_management) and DHL Express Shipping (delivery_dhl) - Go to Sales > Configuration > Shipping Methods - Select a DHL delivery method (e.g. DHL USA) and activate "Dutiable…
- Install Sales (sale_management) and DHL Express Shipping (delivery_dhl) - Go to Sales > Configuration > Shipping Methods - Select a DHL delivery method (e.g. DHL USA) and activate "Dutiable Material" option - Go to Sales and create a quotation - Add a customer whose an addess is in the same country than the company - Add a product with a Weight and a Volume - Click on the "ADD SHIPPING" button - On the wizard, select the modified DHL delivery method and click on "GET RATE" button The following error occurs: "AttributeError: 'NoneType' object has no attribute 'QtdShp'" When making a request for a domestic delivery with a shipping method with dutiable option, DHL API returns a response with a success status but with no "success" data. Instead there is a note in the response with error code 410301 and message "Products not available between this origin and destination (network segment)". As Odoo receives a successful response, it tries to read the "success" data and crashes. Also DHL API returns an error if sent dutiable declared amounts do not have at least 2 decimal digits. For this use case, we will catch the AttributeError and if the 410301 error code is in the notes of the response, we will display the DHL error message to customer and a hint explaining that the issue could come from dutiable option. opw-2263982 Forward-Port-Of: odoo/enterprise#11465
State EDI codes should be of two digits. For instance, state Antioquia with code 5 should be sent as 05 for DIAN to process successfully. City EDI codes should be of five digits. For instance, city ABEJORRAL with code 5002 should be sent as 05002 for DIAN to process successfully. Task: https://www.odoo.com/web#id=2284706&action=333&active_id=1691&model=project.task&view_type=form&cids=2&menu_id=4720 Forward-Port-Of: odoo/enterprise#11420
Original PR description
State EDI codes should be of two digits. For instance, state Antioquia with code 5 should be sent as 05 for DIAN to process successfully. City EDI codes should be of five digits. For instance, city ABEJORRAL with code 5002 should be sent as 05002 for DIAN to process successfully. Task: https://www.odoo.com/web#id=2284706&action=333&active_id=1691&model=project.task&view_type=form&cids=2&menu_id=4720 Forward-Port-Of: odoo/enterprise#11420