Tuesday, June 30, 2020
31 changes · master
Enhancements to existing features
Customers who choose delayed payment methods such as SEPA or wire transfer now see a “View quote” button in their confirmation email instead of “Sign & pay.” This avoids confusion by matching the customer’s payment status and guiding them to review their quotation.
Original PR description
PURPOSE
When you buy something on e-commerce with a differed payment (SEPA or wire transfer), you receive an email saying that payment is pending and you can reach your quote by clicking on a link.
But:
> On the email template, label of this button is "sign & pay" (which is unlogical because it's already paid)
SPECIFICATION
Modify
> "Sign & pay" >> "View quote" ( https://cutt.ly/MtiENzQ )
LINKS
PR: #49389
TaskID: 2210990Long modal window titles now wrap onto multiple lines instead of overflowing outside the dialog. This makes pop-up windows easier to read and keeps the interface looking clean, especially when titles contain long words or references.
Original PR description
…by breaking words. Taskid: 2253703 Linked PR (enterprise) : https://github.com/odoo/enterprise/pull/10947 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update makes Odoo more reliable when preparing translated messages, preventing empty or invalid text values from causing unexpected results. It also adds automated checks to catch translation formatting mistakes earlier, improving consistency across many apps without changing business workflows.
Original PR description
Product forms now hide accounting-related sections when inventory valuation is set to manual. This reduces clutter and helps users focus only on settings that apply to their current valuation method.
Original PR description
Hide sections "Account Properties" & "Account Stock Properties" if the inventory valuation (property_valuation) is set to manual. task-2232026
The Timesheets button on an employee record now opens timesheets in a grid view instead of a list. This makes time entry and review more convenient by showing timesheet data in a format better suited for planning and comparison.
Original PR description
Currently in enterprise, the default view when clicking on hr_employee_form_view "Timesheets" button is a list view. This PR changes it to a grid_view. Task ID: 227726
Resolved issues and error corrections
Attachment content previews now handle very long text without spaces more gracefully. This prevents long indexed content from breaking the page layout, improving readability and visual stability for users reviewing attachments.
Original PR description
Long indexed content without space can break the layout. So we forced the word wrap to avoid visual bug. task id : 2238654
Miscellaneous changes
### Issue - Install eCommerce, Stripe - Setup stripe for testing - Order something - Open stripe payment interface (not with odoo) - Go back with the stripe interface button Order Cancelled - Go back with browser back button - Enter your data Can pay but order still cancelled so you paid for nothing ### Cause I fixed a linked error in b8b9a04ff5b5b2ba40b26632 but I didn't mind that we should cancel the stripe payment intent too ### Solution Cance
Original PR description
### Issue - Install eCommerce, Stripe - Setup stripe for testing - Order something - Open stripe payment interface (not with odoo) - Go back with the stripe interface button Order Cancelled - Go back with browser back button - Enter your data Can pay but order still cancelled so you paid for nothing ### Cause I fixed a linked error in b8b9a04ff5b5b2ba40b26632 but I didn't mind that we should cancel the stripe payment intent too ### Solution Cancel the stripe payment intent so that filling the stripe form by following those step will returns an error from stripe **OPW-2282946** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53737
and fallback on `''` to avoid returning `False` when passing a variable instead of a string
This update fixes how several Odoo Enterprise apps prepare text for translation, helping translated messages appear reliably and consistently. It mainly affects accounting, banking integrations, delivery carriers, payroll, referrals, and localization features, with no expected change to day-to-day workflows beyond better language support.
Original PR description
Following https://www.odoo.com/documentation/master/reference/translations.html#explicit-exports Enterprise part of odoo/odoo#53683
This update corrects leftover references to project forecast views that had previously been removed. It helps prevent errors when using project forecasting and related timesheet sales overview features.
Original PR description
After commit https://github.com/odoo/enterprise/commit/01c70b66612590447977177f090bfc20ac1b6123, some references to removed views exists. This commit fixes those missing references.
Issue - Turn on Sales Product Configurator - Create a product template with an attribute and an attribute value defined as "is custom". - Create a new quote, add the template, and configure the product, entering a custom value. - Save. - Duplicate the Quote Custom value missing. Cause Custom value (field product_custom_attribute_value_ids) not duplicated. Solution Add attribute 'copy=True' to field product_custom_attribute_value_ids. opw-2279933 Forward-Port-Of:
Original PR description
Issue - Turn on Sales Product Configurator - Create a product template with an attribute and an attribute value defined as "is custom". - Create a new quote, add the template, and configure the product, entering a custom value. - Save. - Duplicate the Quote Custom value missing. Cause Custom value (field product_custom_attribute_value_ids) not duplicated. Solution Add attribute 'copy=True' to field product_custom_attribute_value_ids. opw-2279933 Forward-Port-Of: odoo/odoo#53813 Forward-Port-Of: odoo/odoo#53755
before this commit, When archiving a task through the action menu, the 'archive' link is not updated to 'unarchive'. it's only appearing if we refresh the page after this commit, When archiving a task through the action menu, the 'archive' link is updated to 'unarchive'. task - 2251739 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at w
Original PR description
before this commit, When archiving a task through the action menu, the 'archive' link is not updated to 'unarchive'. it's only appearing if we refresh the page after this commit, When archiving a task through the action menu, the 'archive' link is updated to 'unarchive'. task - 2251739 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53807 Forward-Port-Of: odoo/odoo#50914
The do-action handler added was calling directly doAction method of action_manager which lead to an issue in enterprise as the override taking care of closing home menu in web_enterprise/do_action was no more called. This commit fixes that by calling the do_action method of abstract_web_client and thus the override to be executed. Originally detected in task-2282273 Forward-Port-Of: odoo/odoo#53821
Original PR description
The do-action handler added was calling directly doAction method of action_manager which lead to an issue in enterprise as the override taking care of closing home menu in web_enterprise/do_action was no more called. This commit fixes that by calling the do_action method of abstract_web_client and thus the override to be executed. Originally detected in task-2282273 Forward-Port-Of: odoo/odoo#53821
- Create a repair order - Choose a customer A - Change the invoicing address to customer B > set default - Create invoice The delivery address set on the repair order is not taken into account on the invoice. The delivery address field on the invoice stays empty despite having a delivery address set up on the repair order. opw-2285659 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53747
Original PR description
- Create a repair order - Choose a customer A - Change the invoicing address to customer B > set default - Create invoice The delivery address set on the repair order is not taken into account on the invoice. The delivery address field on the invoice stays empty despite having a delivery address set up on the repair order. opw-2285659 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53747
Description of the issue/feature this PR addresses: Small fixes and improvements for the hr_expense module. See Task's pad for information about the improvements. Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Task ID: 2229597 Forward-Port-Of: odoo/odoo#53700 Forward-Port-Of: odoo/odoo#50932
Original PR description
Description of the issue/feature this PR addresses: Small fixes and improvements for the hr_expense module. See Task's pad for information about the improvements. Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Task ID: 2229597 Forward-Port-Of: odoo/odoo#53700 Forward-Port-Of: odoo/odoo#50932
Before this commit, when a search_default on a many2one field tried to update its label after a name_get, the value was set on its initial associated query element which could have been erased by a default favorite. Now, a small check ensure that the query element still exists before assigning the fetched label. Forward-Port-Of: odoo/odoo#53829 Forward-Port-Of: odoo/odoo#53662
Original PR description
Before this commit, when a search_default on a many2one field tried to update its label after a name_get, the value was set on its initial associated query element which could have been erased by a default favorite. Now, a small check ensure that the query element still exists before assigning the fetched label. Forward-Port-Of: odoo/odoo#53829 Forward-Port-Of: odoo/odoo#53662
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53561
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53561
Forward-Port-Of: odoo/odoo#53754
Original PR description
Forward-Port-Of: odoo/odoo#53754
- Create a new POS session with User A - Make an order - Logout and connect as User B - Resume the session The session cannot be resumed and the user is redirected to the POS Dashboard. When searching for a session to resume, the search restricts the user to the current user. Therefore, no session is found. If no session is found, we search on sessions corresponding to the given configuration. The configuration is mandatory to avoid being redirected to a random session. opw-22
Original PR description
- Create a new POS session with User A - Make an order - Logout and connect as User B - Resume the session The session cannot be resumed and the user is redirected to the POS Dashboard. When searching for a session to resume, the search restricts the user to the current user. Therefore, no session is found. If no session is found, we search on sessions corresponding to the given configuration. The configuration is mandatory to avoid being redirected to a random session. opw-2274973 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53844 Forward-Port-Of: odoo/odoo#53412
This fix will complete the task 1965890 by allowing the user with access rights to edit fields (reference, account_id, taxes_ids & analytic_account_id) depending the sheet state. Also added Tests to check if access rights on expense lines are working well depending on the expense.sheet.state and the user group. Task ID 2226352 Forward-Port-Of: odoo/odoo#53830 Forward-Port-Of: odoo/odoo#48870
Original PR description
This fix will complete the task 1965890 by allowing the user with access rights to edit fields (reference, account_id, taxes_ids & analytic_account_id) depending the sheet state. Also added Tests to check if access rights on expense lines are working well depending on the expense.sheet.state and the user group. Task ID 2226352 Forward-Port-Of: odoo/odoo#53830 Forward-Port-Of: odoo/odoo#48870
task-2280174 Forward-Port-Of: odoo/odoo#53856
Original PR description
task-2280174 Forward-Port-Of: odoo/odoo#53856
Create some attributes with "create dynamically" set Create a product template using these attributes (=> product variants should not be created) Set this product as manufactured, and create an associated BOM with some components Try to print the BOM User will face a traceback due to the product_id being non existant opw-2283649 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53854
Original PR description
Create some attributes with "create dynamically" set Create a product template using these attributes (=> product variants should not be created) Set this product as manufactured, and create an associated BOM with some components Try to print the BOM User will face a traceback due to the product_id being non existant opw-2283649 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53854
1. Activate DHL Shipping 2. Create user w/o Administration/ Settings 3. Create WH/OUT with DHL carrier 4. Validate User is not allowed to validate the picking because dhl_account_number is restricted to Administrator opw-2285722 Forward-Port-Of: odoo/enterprise#11542
Original PR description
1. Activate DHL Shipping 2. Create user w/o Administration/ Settings 3. Create WH/OUT with DHL carrier 4. Validate User is not allowed to validate the picking because dhl_account_number is restricted to Administrator opw-2285722 Forward-Port-Of: odoo/enterprise#11542
In the next case: 1. Create a customer invoice and validate it. 2. Cancel the invoice. The PAC status is `Cancelled` 3. Update the SAT status to `Cancelled` 4. The Odoo status is open. After of this process, the cron that update the Odoo status search for invoices where the PAC status is `to_cancel`, but like in this invoice is `cancelled`, ignore this invoice and the Odoo status always is `open`. Now search for invoices cancelled or to cancel in the PAC status Forward-Port-Of: odo
Original PR description
In the next case: 1. Create a customer invoice and validate it. 2. Cancel the invoice. The PAC status is `Cancelled` 3. Update the SAT status to `Cancelled` 4. The Odoo status is open. After of this process, the cron that update the Odoo status search for invoices where the PAC status is `to_cancel`, but like in this invoice is `cancelled`, ignore this invoice and the Odoo status always is `open`. Now search for invoices cancelled or to cancel in the PAC status Forward-Port-Of: odoo/enterprise#11509 Forward-Port-Of: odoo/enterprise#10817
The label is making references to wrong field it was referring to l10n_ar_country_code label when need to be references to l10n_ar_afip_verification_type field. This is making that the tooltip is showing the wrong info. ### Before  ### After  Forward-Port-Of: odoo/ente
Original PR description
The label is making references to wrong field it was referring to l10n_ar_country_code label when need to be references to l10n_ar_afip_verification_type field. This is making that the tooltip is showing the wrong info. ### Before  ### After  Forward-Port-Of: odoo/enterprise#11500 Forward-Port-Of: odoo/enterprise#11483
Forward-Port-Of: odoo/enterprise#11484
Original PR description
Forward-Port-Of: odoo/enterprise#11484
'_get_wizard_values_from_batch' can't be used for editable fields on the wizard. The reason is the orm will always call this method when clicking on the button and then, all custom values will be lost. The workaround of this behavior is to use computed editable fields instead. Forward-Port-Of: odoo/enterprise#11407
Original PR description
'_get_wizard_values_from_batch' can't be used for editable fields on the wizard. The reason is the orm will always call this method when clicking on the button and then, all custom values will be lost. The workaround of this behavior is to use computed editable fields instead. Forward-Port-Of: odoo/enterprise#11407
Currently, When we ask a feedback (Survey integration) on an appraisal, then the error is occurred. In this commit, we fix this issue by updating the appraisal_id field. LINKS PR: #11396 Task Id: 2282089 Forward-Port-Of: odoo/enterprise#11396
Original PR description
Currently, When we ask a feedback (Survey integration) on an appraisal, then the error is occurred. In this commit, we fix this issue by updating the appraisal_id field. LINKS PR: #11396 Task Id: 2282089 Forward-Port-Of: odoo/enterprise#11396
When a new car is selected in the salary configurator from the waiting list, the stage_id is set based on external id that may be missing. It crashes the process. Solution: don't raise if the external id is not found Forward-Port-Of: odoo/enterprise#11514
Original PR description
When a new car is selected in the salary configurator from the waiting list, the stage_id is set based on external id that may be missing. It crashes the process. Solution: don't raise if the external id is not found Forward-Port-Of: odoo/enterprise#11514
Improvement over 5aef69512f13143b544390c8b9b618e06c096222 Original Steps to reproduce: - with Studio, create a new app - in Settings (without Studio), create a new field, linked to the Studio model - export this field (a ir.model.data record is created for the field, with the module "__export__") - add this field in a view with Studio - in debug mode, click on "More" in the Studio sidebar for this field (you then open the field form view) - edit the field (its label for
Original PR description
Improvement over 5aef69512f13143b544390c8b9b618e06c096222 Original Steps to reproduce: - with Studio, create a new app - in Settings (without Studio), create a new field, linked to the Studio model - export this field (a ir.model.data record is created for the field, with the module "__export__") - add this field in a view with Studio - in debug mode, click on "More" in the Studio sidebar for this field (you then open the field form view) - edit the field (its label for example) - then export all Studio customizations __export__ is in the manifest thus makes it impossible to import. Since there are several steps in which dependencies list is populated the safest way to avoid the issue is to filter the faulty string just before writing the file opw-2257447 Forward-Port-Of: odoo/enterprise#11437
The current implementation manipulates the domain to hack the dates. On the other hand, it gets rid of the '|' and '&' operations, transforming the whole domain by using only implicit '&', which is obviously wrong. TaskID: 2245782 Forward-Port-Of: odoo/enterprise#11323 Forward-Port-Of: odoo/enterprise#11212
Original PR description
The current implementation manipulates the domain to hack the dates. On the other hand, it gets rid of the '|' and '&' operations, transforming the whole domain by using only implicit '&', which is obviously wrong. TaskID: 2245782 Forward-Port-Of: odoo/enterprise#11323 Forward-Port-Of: odoo/enterprise#11212
Before this commit, users were allowed to insert an empty pivot (with no data), which leads to an error. As it makes no sense to insert an empty pivot, the button 'Insert in spreadsheet' is now disabled when the pivot is empty task-2283110 Forward-Port-Of: odoo/enterprise#11371
Original PR description
Before this commit, users were allowed to insert an empty pivot (with no data), which leads to an error. As it makes no sense to insert an empty pivot, the button 'Insert in spreadsheet' is now disabled when the pivot is empty task-2283110 Forward-Port-Of: odoo/enterprise#11371