Friday, July 3, 2020
24 changes · master
Miscellaneous changes
Ensure deterministic sorting for slides with the same sequence. opw-2283154 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53996
Original PR description
Ensure deterministic sorting for slides with the same sequence. opw-2283154 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53996
…the translation web editor Steps to reproduce: - install website, website_mass_mailing - go to website, edit and add a popup window (you should see warning banner stating that a newsletter popup is present on this window). Save. - go to settings > languages > load a new language (fr_FR for example) and translate the website - go back to the website > select the new language > click the TRANSLATE button Previous behavior: the warning banner is not editable, also click the "Edit popu
Original PR description
…the translation web editor Steps to reproduce: - install website, website_mass_mailing - go to website, edit and add a popup window (you should see warning banner stating that a newsletter popup is present on this window). Save. - go to settings > languages > load a new language (fr_FR for example) and translate the website - go back to the website > select the new language > click the TRANSLATE button Previous behavior: the warning banner is not editable, also click the "Edit popup" button does nothing Current behavior: the banner is editable opw-2280188 Forward-Port-Of: odoo/odoo#53557
Forward-Port-Of: odoo/odoo#53972 Forward-Port-Of: odoo/odoo#53929
Original PR description
Forward-Port-Of: odoo/odoo#53972 Forward-Port-Of: odoo/odoo#53929
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54002 Forward-Port-Of: odoo/odoo#53983
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54002 Forward-Port-Of: odoo/odoo#53983
If `self.country_id` is `res.country()`, `partner_country_code` return `res.country()`. In the next line `partner_country_code == vat_country_code` return `Comparing apples and oranges: res.country() == 'FR'`. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53966
Original PR description
If `self.country_id` is `res.country()`, `partner_country_code` return `res.country()`. In the next line `partner_country_code == vat_country_code` return `Comparing apples and oranges: res.country() == 'FR'`. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53966
…the translation web editor Steps to reproduce: - install website, website_mass_mailing - go to website, edit and add a popup window (you should see warning banner stating that a newsletter popup is present on this window). Save. - go to settings > languages > load a new language (fr_FR for example) and translate the website - go back to the website > select the new language > click the TRANSLATE button Previous behavior: the warning banner is not editable, also click the "Edit popu
Original PR description
…the translation web editor Steps to reproduce: - install website, website_mass_mailing - go to website, edit and add a popup window (you should see warning banner stating that a newsletter popup is present on this window). Save. - go to settings > languages > load a new language (fr_FR for example) and translate the website - go back to the website > select the new language > click the TRANSLATE button Previous behavior: the warning banner is not editable, also click the "Edit popup" button does nothing Current behavior: the banner is editable opw-2280188 Forward-Port-Of: odoo/odoo#53978 Forward-Port-Of: odoo/odoo#53557
Forward-Port-Of: odoo/odoo#53970
Original PR description
Forward-Port-Of: odoo/odoo#53970
Previously, options were not visible in the video tab of media dialog. In this commit, we have changed classes names to fix the broken behavior of options in the video tab of media dialog. task-2154812 Forward-Port-Of: odoo/odoo#52135
Original PR description
Previously, options were not visible in the video tab of media dialog. In this commit, we have changed classes names to fix the broken behavior of options in the video tab of media dialog. task-2154812 Forward-Port-Of: odoo/odoo#52135
### Description of the issue/feature this PR addresses: Following #52517 (in v12) QR-Bill was designed for a prior version of the specs: https://www.paymentstandards.ch/dam/downloads/ig-qr-bill-en.pdf This intend to reproduce more closely the example of the documentation and improve readability on the following aspects: * Fix Reference :warning: this might change as it currently directly uses `l10n_ch_isr_number_spaced` :hourglass_flowing_sand: on https://github.com/odoo/odoo/pull/
Original PR description
### Description of the issue/feature this PR addresses: Following #52517 (in v12) QR-Bill was designed for a prior version of the specs:…
### Description of the issue/feature this PR addresses: Following #52517 (in v12) QR-Bill was designed for a prior version of the specs: https://www.paymentstandards.ch/dam/downloads/ig-qr-bill-en.pdf This intend to reproduce more closely the example of the documentation and improve readability on the following aspects: * Fix Reference :warning: this might change as it currently directly uses `l10n_ch_isr_number_spaced` :hourglass_flowing_sand: on https://github.com/odoo/odoo/pull/52517 for a better fix * Do not display info that are not filled * Use font size as per the specs (max 10pt) * Remove "Support" section (removed in v2.1) * Fix position of amount * Give enough space to avoid line break on the QRR * Rename titles with simplified versions (missing translations) * Regroup lines to improve readability * Print the QR code without surrounding blank spaces to improve accuracy of placement and size * Adds translations and set the report lang based on the customer. :switzerland: (:fr: :de: :it: ) * Adds thousand separators (blank spaces) * Make it possible to generate an QRR without setting an ISR Subscription number, only the QR-IBAN is necessary. * Adds much needed tests :muscle: ### Current behavior before PR:  With annotations:  ### Desired behavior after PR is merged: Here is the output with the content of this PR in 4 langs:     The aim is to look like the same as in Specs:  TODO: - [x] Translations - [x] Terms - [x] document based on customer lang - [x] Receipt amount labels - [x] "Acceptance point" position - [x] QR is blurry? - [x] QR placement - [ ] Change to QR v25 - [x] fix thousand separators EDIT: updated layout of QR code and Receipt -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54031 Forward-Port-Of: odoo/odoo#53084
fine-tuning of bf8a9af1ac549be830bec28c88eb1c565b591941 - Employees > Configuration > Activity Planning > Plans and ensure the activities have different responsible; - Create a new Employee, assign a Manager (a different user then the one connected, you can assign Marc Demo for example); - Click launch plan. Before this commit, the activity type responsible is ignored and the responsible for all activities is the connected user. Now, the responsible for the activities are assig
Original PR description
fine-tuning of bf8a9af1ac549be830bec28c88eb1c565b591941 - Employees > Configuration > Activity Planning > Plans and ensure the activities have different responsible; - Create a new Employee, assign a Manager (a different user then the one connected, you can assign Marc Demo for example); - Click launch plan. Before this commit, the activity type responsible is ignored and the responsible for all activities is the connected user. Now, the responsible for the activities are assigned taking into account the activity type configuration. opw-2265631 Forward-Port-Of: odoo/odoo#54033
Issue - Install English and French languages - Create a customer contact and assign french as his language - Create a product with correct names in both languages. For example 'French product name' and 'English product name' for easy reference. - Create an inventory transfer with the french customer as contact - Add the product that you created - Print > Delivery Slip The report will show in the lines: """ French product name English product name """ Cause Ge
Original PR description
Issue - Install English and French languages - Create a customer contact and assign french as his language - Create a product with correct names in both languages. For example 'French product name' and 'English product name' for easy reference. - Create an inventory transfer with the french customer as contact - Add the product that you created - Print > Delivery Slip The report will show in the lines: """ French product name English product name """ Cause Getting product description without checking partner language. Solution If partner is set, get product description with partner language in context. opw-2280490 Forward-Port-Of: odoo/odoo#54055 Forward-Port-Of: odoo/odoo#53977
We move the IoT Box version file from /home/pi to /var/odoo so its not overriden after an auto-flash of the IoT Box. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54044
Original PR description
We move the IoT Box version file from /home/pi to /var/odoo so its not overriden after an auto-flash of the IoT Box. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54044
Forward-Port-Of: odoo/odoo#54057
Original PR description
Forward-Port-Of: odoo/odoo#54057
The time to display the check in/check out time was hardcoded to HH:mm:ss while other locales may use different formats. Use the appropriate time utils to retrieve the right format that uses the time format from the res.lang record. Fixes odoo/odoo#50527 Forward-Port-Of: odoo/odoo#54018
Original PR description
The time to display the check in/check out time was hardcoded to HH:mm:ss while other locales may use different formats. Use the appropriate time utils to retrieve the right format that uses the time format from the res.lang record. Fixes odoo/odoo#50527 Forward-Port-Of: odoo/odoo#54018
During TempusDominus autobinding to fields matching its default classes (like `.datetimepicker-input` used by our DatePicker widget) and no config was previously provided to the library (like when we disable it on mobile), an unsafe access to the config's `_options` property results into an error as the config is `undefined`. This PR fixes it by first checking for config existence before attempting to access its property. It also extracts the DatePicker widget's input setter to allow
Original PR description
During TempusDominus autobinding to fields matching its default classes (like `.datetimepicker-input` used by our DatePicker widget) and no config was previously provided to the library (like when we disable it on mobile), an unsafe access to the config's `_options` property results into an error as the config is `undefined`. This PR fixes it by first checking for config existence before attempting to access its property. It also extracts the DatePicker widget's input setter to allow overriding it and preventing from calling the `datetimepicker` lib when not initialized (like on mobile). opw-2242880 Forward-Port-Of: odoo/odoo#54039 Forward-Port-Of: odoo/odoo#54005
Manual forwart-port of https://github.com/odoo/odoo/pull/53894 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54069 Forward-Port-Of: odoo/odoo#53895
Original PR description
Manual forwart-port of https://github.com/odoo/odoo/pull/53894 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54069 Forward-Port-Of: odoo/odoo#53895
Before that, since https://github.com/odoo/odoo/commit/71ee252dc43fd0e2b86ba8079c31915544e528eb , negative invoice lines were not supported by thoses taxes. Nor were miscellaneous entries. To make them work, we change the way tags are assigned to cash basis taxes : instead of copying them from the invoice, sign included, we now change their sign when appropriate, so that the resulting cash basis move can be treated like any regular miscellaneous operation by the tax report (so, always applying a
Original PR description
Before that, since https://github.com/odoo/odoo/commit/71ee252dc43fd0e2b86ba8079c31915544e528eb , negative invoice lines were not supported by thoses taxes. Nor were miscellaneous entries. To make…
Before that, since https://github.com/odoo/odoo/commit/71ee252dc43fd0e2b86ba8079c31915544e528eb , negative invoice lines were not supported by thoses taxes. Nor were miscellaneous entries. To make them work, we change the way tags are assigned to cash basis taxes : instead of copying them from the invoice, sign included, we now change their sign when appropriate, so that the resulting cash basis move can be treated like any regular miscellaneous operation by the tax report (so, always applying a factor of 1 to its lines' balance). Doing that also allows us to re-simplify the code used in the tax report and tax audit computation to manage cash basis entries, and makes the cash basis entry more standard. This is also a usability improvement: now the user does not have to search for the original invoice to understand how the CABA entries are going to impact the report: it's always managed like a misc. operation, so he can just trust the signs of the tags. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54045 Forward-Port-Of: odoo/odoo#53503
Before that, since https://github.com/odoo/odoo/commit/71ee252dc43fd0e2b86ba8079c31915544e528eb , negative invoice lines were not supported by thoses taxes. Nor were miscellaneous entries. To make them work, we change the way tags are assigned to cash basis taxes : instead of copying them from the invoice, sign included, we now change their sign when appropriate, so that the resulting cash basis move can be treated like any regular miscellaneous operation by the tax report (so, always applying a
Original PR description
Before that, since https://github.com/odoo/odoo/commit/71ee252dc43fd0e2b86ba8079c31915544e528eb , negative invoice lines were not supported by thoses taxes. Nor were miscellaneous entries. To make…
Before that, since https://github.com/odoo/odoo/commit/71ee252dc43fd0e2b86ba8079c31915544e528eb , negative invoice lines were not supported by thoses taxes. Nor were miscellaneous entries. To make them work, we change the way tags are assigned to cash basis taxes : instead of copying them from the invoice, sign included, we now change their sign when appropriate, so that the resulting cash basis move can be treated like any regular miscellaneous operation by the tax report (so, always applying a factor of 1 to its lines' balance). Doing that also allows us to re-simplify the code used in the tax report and tax audit computation to manage cash basis entries, and makes the cash basis entry more standard. This is also a usability improvement: now the user does not have to search for the original invoice to understand how the CABA entries are going to impact the report: it's always managed like a misc. operation, so he can just trust the signs of the tags. v13 version of https://github.com/odoo/enterprise/pull/11193 Forward-Port-Of: odoo/enterprise#11647 Forward-Port-Of: odoo/enterprise#11372
…' without inherit_id Made to fix PR 53895 in community. Forward-Port-Of: odoo/enterprise#11655 Forward-Port-Of: odoo/enterprise#11606
Original PR description
…' without inherit_id Made to fix PR 53895 in community. Forward-Port-Of: odoo/enterprise#11655 Forward-Port-Of: odoo/enterprise#11606
When the native datetime picker is used (on mobile apps Android / iOS), the JS datetime picker is destroyed, resulting into the wrong format being used when setting the field's value. The reason behind this is that we detroyed the JS datetime picker and then hand over the input handling to the native method... or so we thought! Actually the JS datetime picker is still lurking in the shadows but, as we destroyed it, its default configuration is applied on the value once send from the nat
Original PR description
When the native datetime picker is used (on mobile apps Android / iOS), the JS datetime picker is destroyed, resulting into the wrong format being used when setting the field's value. The reason behind this is that we detroyed the JS datetime picker and then hand over the input handling to the native method... or so we thought! Actually the JS datetime picker is still lurking in the shadows but, as we destroyed it, its default configuration is applied on the value once send from the native datepicker, resulting into the wrong format being applied. This commit fixes it by not initialising the JS datetimepicker at all and properly overriding the `web.datepicker` methods that may call the JS library. opw-2242880 Forward-Port-Of: odoo/enterprise#11641 Forward-Port-Of: odoo/enterprise#11621
In the next case: A company starts operations in 2018, in December makes the close entry, and mark the entry with the option `MARK AS CLOSING ENTRY FOR THE FISCAL YEAR`. Get the trial balance and is ok. In 2019 makes the close entry with the same option. But when in 2019, try to get the ´Trial Balance Report´, ignore the close entry for 2018 moves. That is incorrect because the entry in 2018 must be considered in the new years. OPW #2276153 Forward-Port-Of: odoo/enterprise#11525
Original PR description
In the next case: A company starts operations in 2018, in December makes the close entry, and mark the entry with the option `MARK AS CLOSING ENTRY FOR THE FISCAL YEAR`. Get the trial balance and is ok. In 2019 makes the close entry with the same option. But when in 2019, try to get the ´Trial Balance Report´, ignore the close entry for 2018 moves. That is incorrect because the entry in 2018 must be considered in the new years. OPW #2276153 Forward-Port-Of: odoo/enterprise#11525
Forward-Port-Of: odoo/enterprise#11608
Original PR description
Forward-Port-Of: odoo/enterprise#11608
Issue - Subscriptions - Configuration > Subscription Templates - Edit Monthly's name with a very long one - Any subscription using monthly - Customer preview The name overflows on the right column Cause There is a no-wrap on the parent in order to have label & value on the same line Solution Add wrap on the name OPW-2288823 Forward-Port-Of: odoo/enterprise#11622 Forward-Port-Of: odoo/enterprise#11595
Original PR description
Issue - Subscriptions - Configuration > Subscription Templates - Edit Monthly's name with a very long one - Any subscription using monthly - Customer preview The name overflows on the right column Cause There is a no-wrap on the parent in order to have label & value on the same line Solution Add wrap on the name OPW-2288823 Forward-Port-Of: odoo/enterprise#11622 Forward-Port-Of: odoo/enterprise#11595
Forward-Port-Of: odoo/enterprise#11511
Original PR description
Forward-Port-Of: odoo/enterprise#11511