Wednesday, July 8, 2020
20 changes · master
Enhancements to existing features
The Account Properties section now remains visible consistently, making product category accounting settings easier to review. Only the price difference account is hidden when it is not relevant, reducing confusion while preserving access to important accounting fields.
Original PR description
Purpose ======= https://github.com/odoo/odoo/pull/52351 already improved the display by hiding some account properties if it wasn't really neeeded on manual inventory valuation. Specification ============= Keep the Account Properties section visible in any cases. The price difference account is the only field of the section which is only used in automated valuation. TaskID: 2232026 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The mail module now includes a new asset bundle to support upcoming changes. This helps keep mail-related interface resources organized and ready for future improvements without changing day-to-day user workflows.
Original PR description
Needed to merge introducing new assets in 13.4 See task-2285691 See odoo/odoo#53410
The IoT module now relies on the standard framework-managed service instead of starting it manually during tests. This prevents early startup crashes and makes the IoT testing setup more reliable without changing end-user functionality.
Original PR description
This commit is the counterpart of odoo/odoo#53817. Without this commit, the IOT longpolling service was instantiated too soon, before services were deployed into the env, and it crashed (this service uses the localstorage service in init). Note that we shouldn't manually instantiate services (registering them to the serviceRegistry is the correct way to do).
Resolved issues and error corrections
Timesheet grid values now line up neatly on the right when viewing entries in days. This makes the read-only grid easier to scan and keeps day-based entries visually consistent with hour-based entries.
Original PR description
Currently, in the read-only view of timesheet grid the numbers are not aligned to the right. In this commit, we fix this by align the numbers to the right. LINKS PR: #11225 Task-ID: 2275993
Code cleanup and technical improvements
The graph view has been rebuilt on Odoo's newer interface framework while keeping its business purpose the same. This makes the reporting charts easier to maintain and evolve, with limited expected visible change for users.
Original PR description
Before this commit: the graph view uses the good old renderer. After this commit: the graph view uses a graph renderer modified to work with owl.
Miscellaneous changes
### Issue - Create a content in a course with type "web page" - Access it frontend and add a "text - image" block, edit the image as a video - save - The video is displayed correctly - Go into full-screen The video is not displayed at all. ### Cause The fullscreen widget just append the web content without taking care of video widget ### Solution Manually append the video iframe **OPW-2290233** -- I confirm I have signed the CLA and read the PR guidelines at
Original PR description
### Issue - Create a content in a course with type "web page" - Access it frontend and add a "text - image" block, edit the image as a video - save - The video is displayed correctly - Go into full-screen The video is not displayed at all. ### Cause The fullscreen widget just append the web content without taking care of video widget ### Solution Manually append the video iframe **OPW-2290233** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54135
The timesheet timer now shows the correct visual warning when someone enters an invalid time manually. Additional automated checks help ensure the timer header continues to behave correctly in future updates.
Original PR description
taskId 2277648
opws: 2269230, 2248760 When a database has a lot of projects with many tasks, and needs to send a lot of feedback mails, the cron tries to send mails to all tasks at the same time, thus it times out. This fix will allow to treat projects one at a time so that when the cron times out, it will not restart from the beginning. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the C
Original PR description
opws: 2269230, 2248760 When a database has a lot of projects with many tasks, and needs to send a lot of feedback mails, the cron tries to send mails to all tasks at the same time, thus it times out. This fix will allow to treat projects one at a time so that when the cron times out, it will not restart from the beginning. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53896
1. set a Sales team and add an alias 2. create a contact (customer) with an email and grant them portal access (under the action) 3. Odoo creates a portal user 4. use the email of the contact to send an email to the alias set under the sales team An opportunity is created but the sales person assign to that opportunity is the customer. This will revert user if the user has no access to crm.lead opw-2288442 -- I confirm I have signed the CLA and read the PR guidelines at www.od
Original PR description
1. set a Sales team and add an alias 2. create a contact (customer) with an email and grant them portal access (under the action) 3. Odoo creates a portal user 4. use the email of the contact to send an email to the alias set under the sales team An opportunity is created but the sales person assign to that opportunity is the customer. This will revert user if the user has no access to crm.lead opw-2288442 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54197
Issue - Runbot 13.0 - Website > Contact Form - Double click on send button Link dialog opened, ok - Discard - Double click on send button - Click link button Traceback Cause summernote's getLinkInfo use range.create() which use document's selection. The first time we double click, everything is ok with the selection. When discarding the selection is ok but if you re-open the link dialog, it will do `this.focus($editable);` which breaks the selecti
Original PR description
Issue - Runbot 13.0 - Website > Contact Form - Double click on send button Link dialog opened, ok - Discard - Double click on send button - Click link button Traceback Cause summernote's getLinkInfo use range.create() which use document's selection. The first time we double click, everything is ok with the selection. When discarding the selection is ok but if you re-open the link dialog, it will do `this.focus($editable);` which breaks the selection (type = 'None') So, range.create() is incorrect and expand doesn't work. Solution Since the selection is ok when discarding the dialog, avoid re-focusing the element and keep the actual selection. OPW-2268595 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53792
### Issue - Install eCommerce - Modify a product image with one which has more than 1024px width/height to enable zoom (I used: https://bit.ly/2VETQZS) - Go on the website preview & hover the image Depending on the screen size, a part of the flyout is hidden because of overflow-x if you want to see it, you should scroll right width right arrow key. ### Cause The flyout has 100% width and is put right (position absolute, left: 100%) ### Solution To avoid
Original PR description
### Issue - Install eCommerce - Modify a product image with one which has more than 1024px width/height to enable zoom (I used: https://bit.ly/2VETQZS) - Go on the website preview & hover the image Depending on the screen size, a part of the flyout is hidden because of overflow-x if you want to see it, you should scroll right width right arrow key. ### Cause The flyout has 100% width and is put right (position absolute, left: 100%) ### Solution To avoid this error on all screen size, the solution is to compute the max-width of the flyout depending on the available space on the right. **OPW-2283648** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53989
- Follow button is now correctly aligned in document app chatter overlay - Topbar does not move up anymore on select Send Message or Log note task-2287136 Forward-Port-Of: odoo/odoo#54211
Original PR description
- Follow button is now correctly aligned in document app chatter overlay - Topbar does not move up anymore on select Send Message or Log note task-2287136 Forward-Port-Of: odoo/odoo#54211
task-2171877 task-2282377 task-2282382 Forward-Port-Of: odoo/odoo#53410
Original PR description
task-2171877 task-2282377 task-2282382 Forward-Port-Of: odoo/odoo#53410
* Make Connect button primary if the Reconcile button is not shown primary) * Rollback the change "Create Manually" > "New Invoice" -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54109
Original PR description
* Make Connect button primary if the Reconcile button is not shown primary) * Rollback the change "Create Manually" > "New Invoice" -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54109
### Issue - Duplicate customer DB - MRP, create a bom for product "[Cooltm-Scarf-bicolore (95x100 cms)..." - In components add any product, I used "KES Protective Face Mask - Silk (Pantone 4059C Red)" - Save - Create a MO with the first product and select the BOM you created - Mark as todo & Plan - Stats buttons > Work orders - Select first - Process - Resize the window For some resolution, the quantity field is out of the screen ### Cause The produ
Original PR description
### Issue - Duplicate customer DB - MRP, create a bom for product "[Cooltm-Scarf-bicolore (95x100 cms)..." - In components add any product, I used "KES Protective Face Mask - Silk (Pantone 4059C…
### Issue - Duplicate customer DB - MRP, create a bom for product "[Cooltm-Scarf-bicolore (95x100 cms)..." - In components add any product, I used "KES Protective Face Mask - Silk (Pantone 4059C Red)" - Save - Create a MO with the first product and select the BOM you created - Mark as todo & Plan - Stats buttons > Work orders - Select first - Process - Resize the window For some resolution, the quantity field is out of the screen ### Cause The product has a long name which push the input far away. ### Solution Limit the product name label width and make it pass to the next line if needed #### Before *Large screen size*  *Small screen size*  #### After *Small screen size*  **OPW-2272328** Forward-Port-Of: odoo/enterprise#11462
- When the methods `get_all_taxes_values` and `get_tic_category` raise a `zeep.exceptions.Fault`, the code stores in the result the exception instead of the exception message. Then the calling methods may try to append the exception object into a string which doesn't work. Instead we will now append to the error message string the exceptions `message` member which contains the exception description. The flow that is crashing in here is (`account_taxcloud/models/accoun
Original PR description
- When the methods `get_all_taxes_values` and `get_tic_category`
raise a `zeep.exceptions.Fault`, the code stores in the
result the exception instead of the exception message.
Then the calling methods may try to append the exception object into a string
which doesn't work.
Instead we will now append to the error message string
the exceptions `message` member which contains the exception
description.
The flow that is crashing in here is (`account_taxcloud/models/account_invoice.py`, method `validate_taxes_on_invoice`)
```python
response = request.get_all_taxes_values()
if response.get('error_message'):
raise ValidationError(
_('Unable to retrieve taxes from TaxCloud: ') + '\n' +
response['error_message']
```
Forward-Port-Of: odoo/enterprise#11721Currently, The tour 'sign_widgets_tour' fails randomly when runned multiple times(fail ratio 200:1 build). It shows a traceback with the following message: "Uncaught TypeError: Cannot read property 'resetCanvas' of undefined" The tour is failed because sometimes the dialog is destroyed before the _printImage completes the process to draw the image. in _printImage there is drawTimeout so it executes the process at last and before that the tour clicks on 'Adopt and Sign' so dialog is goin
Original PR description
Currently, The tour 'sign_widgets_tour' fails randomly when runned multiple times(fail ratio 200:1 build). It shows a traceback with the following message: "Uncaught TypeError: Cannot read property 'resetCanvas' of undefined" The tour is failed because sometimes the dialog is destroyed before the _printImage completes the process to draw the image. in _printImage there is drawTimeout so it executes the process at last and before that the tour clicks on 'Adopt and Sign' so dialog is going to destroy and due to that issue is generated. So in this commit, wait for 1 sec before click on 'Adopt and Sign' so the process of _printImage is completed. TaskID: 2245597 Closes: #11541 Forward-Port-Of: odoo/enterprise#11541
This reverts commit df4ea3d2cae7db69cb1f2fb06ee2b5b197bf12c5. And merge a retrocompatible solution for users that already have this view since it is a stable version. Todo: remove view in master Forward-Port-Of: odoo/enterprise#11713
Original PR description
This reverts commit df4ea3d2cae7db69cb1f2fb06ee2b5b197bf12c5. And merge a retrocompatible solution for users that already have this view since it is a stable version. Todo: remove view in master Forward-Port-Of: odoo/enterprise#11713
When an invoice is validated for a partner without `name` set, the Partner Ledger crashes. opw-2291418 Forward-Port-Of: odoo/enterprise#11681 Forward-Port-Of: odoo/enterprise#11673
Original PR description
When an invoice is validated for a partner without `name` set, the Partner Ledger crashes. opw-2291418 Forward-Port-Of: odoo/enterprise#11681 Forward-Port-Of: odoo/enterprise#11673
If the document to sign needs multiple signatures, and only part of them were already made when cancelling it we should crash when computing completion_date. Small fixup of 8454aca947ed67ea18272033a94636c87800b8f7. opw-2271547 Forward-Port-Of: odoo/enterprise#11702
Original PR description
If the document to sign needs multiple signatures, and only part of them were already made when cancelling it we should crash when computing completion_date. Small fixup of 8454aca947ed67ea18272033a94636c87800b8f7. opw-2271547 Forward-Port-Of: odoo/enterprise#11702