Thursday, July 9, 2020
23 changes · master
New functionality added to Odoo
This change adds internal tests that document how Odoo creates records when computed fields are involved. It helps protect future development by making expected database behavior clearer and reducing the risk of performance regressions.
Original PR description
The purpose is to document the behavior of the ORM.
Enhancements to existing features
The point of sale system can now access internal services directly from its main sales model. This supports better device communication, including connections to IoT services used by point of sale hardware.
Original PR description
Add the possibility to call services from posmodel. At the moment, this is needed to call the `iot_longpolling` service from `DeviceProxy`. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
This fix ensures timesheet entries can correctly determine and store their related task. This matters for businesses using helpdesk and project timesheets because reporting and task-based tracking will be more reliable.
Original PR description
Before this commit: In helpdesk_timesheet, we have a compute_task_id with super. But in hr_timesheet, task_id is not a compute field, so this compute has no effect. After this commit: Task_id is changed to compute stored field. taskId 2285926 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Code cleanup and technical improvements
The automatic scrolling behavior used while dragging items has been moved from the website editor into the broader web framework. This makes the same smoother drag experience available for other Odoo apps, such as Sign, while reducing duplicated work for future features.
Original PR description
Prior to this commit, the autoscroll on drag feature was accessible and only used in the web_editor application. After this commit, the autoscroll on drag feature will be available in the web application and has been refactored in order to allow its usage in other application (as for the sign application). task-2280965 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
with this commit ce0700ce401523267b5a8bd5665a368cfea24912 we lose the compatibility with olders version of Odoo So we keep the vesion of IoT box in the same place for olders version of Odoo Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54232
Original PR description
with this commit ce0700ce401523267b5a8bd5665a368cfea24912 we lose the compatibility with olders version of Odoo So we keep the vesion of IoT box in the same place for olders version of Odoo Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54232
The project email alias display has been cleaned up and now shows email addresses as clickable mail links. This makes it easier for users to contact or use project aliases while also correcting small text errors.
Original PR description
Update mail alias layout, makes email address clickable (mailto) and fix a couple of typos. Task ID 2287394 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Developers can now run installation-time tests without reinstalling or updating a module, making test debugging faster. Existing behavior is preserved when modules are explicitly installed or updated, reducing disruption to current workflows.
Original PR description
Debugging/improvement of an at install test may be tedious because of the need to update the module, spending most of the time checking tables and xml file. This commit proposes to allow to execute test without installing or updating a module. The test is still executed during the loading, and the behavior should be close to an execution of tests during an update.
IoT device communication now uses the standard service provided by the platform instead of a manually created connection. This makes connected devices such as payment terminals, scales, printers, and delivery tools easier to maintain and less prone to inconsistencies.
Original PR description
IoTLongpolling was instanciated manually even though it was created as a service. We change the DeviceProxy to call the service deployed by the framework.
This update adjusts internal editor tests after a shared placeholder image was moved, preventing false test failures. It also temporarily removes a styling rule that was causing intermittent automated test instability, helping keep development checks reliable without changing user-facing behavior.
Original PR description
A mockRPC was catching the route to transparent.png file which has been relocated with [1]. This commit solves that unadapted mockRPC and makes it easier to grep. [1]: https://github.com/odoo/odoo/commit/94b59b1972e1a18e18dfcd6c2ded495391380b9a
The salary contract form now shows name guidance as placeholders instead of pre-filled text, so users can enter their details without deleting default wording. It also requires gender selection before submission, helping prevent incomplete contract information.
Original PR description
Purpose & Specifications 1)When user try to fill the contract form, there should be place holder in Name (Lastname Firstname). But it is text so user need to remove "Enter your name" text before add first name and last name. 2)Contract allow to submit form without gender select. it show show warning if not select. LINKS: PR: #11547 Task-id: 2267774
This update fixes how timesheet entries in Helpdesk are linked to tasks. It ensures the task information is properly calculated and saved, improving consistency for teams tracking support work and time spent.
Original PR description
Before this commit: In helpdesk_timesheet, we have a compute_task_id with super. But in hr_timesheet, task_id is not a compute field, so this compute has no effect. After this commit: Task_id is changed to compute stored field. taskId 2285926
Users can now enter a name for personal information records while creating them in HR contract salary. This removes a form limitation that previously blocked saving complete new records without workaround.
Original PR description
…new records Before this commit, the personal info name is always readonly in form view. When the user creates a new record, there is no possibility to add one. taskid: 2283977
Go to invoice list view. Select several invoices, click on 'Send and print', switch template to a different one (possibly a duplicate of the default). Send On each selected record there will be a pair of attachment: - one belonging the the record (ok) - one duplicate from the first record in the selection (not ok) This occur because when switching template the default composition mode for the wizard is 'comment' (single send), which causes the wizard to compute and store the attachmen
Original PR description
Go to invoice list view. Select several invoices, click on 'Send and print', switch template to a different one (possibly a duplicate of the default). Send On each selected record there will be a pair of attachment: - one belonging the the record (ok) - one duplicate from the first record in the selection (not ok) This occur because when switching template the default composition mode for the wizard is 'comment' (single send), which causes the wizard to compute and store the attachment of the first record it found. Later, this get assigned to the list of attachment to send so it duplicated (and sent) in all other records opw-2291274 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54180
Adjacent buttons are not displayed in a single column. When the table overflows, we try to squeeze largest columns to make it fit into its container (in this case, text may be clipped and an ellipsis is displayed). Button columns didn't get away from this. As a consequence, now that a cell may contain several buttons, some of them may be clipped and replaced by the ellipsis, which isn't what we want for buttons. This commit removes the button columns from the list of columns to squee
Original PR description
Adjacent buttons are not displayed in a single column. When the table overflows, we try to squeeze largest columns to make it fit into its container (in this case, text may be clipped and an ellipsis is displayed). Button columns didn't get away from this. As a consequence, now that a cell may contain several buttons, some of them may be clipped and replaced by the ellipsis, which isn't what we want for buttons. This commit removes the button columns from the list of columns to squeeze, so we let the browser reduce them as much as it can, and we keep them as they are. Task 2282470 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54241
Changing the driver on a car shouldn't change the fleet.vehicle.log.services associated. We should keep the driver assigned to the car at the time the service was done. Also fix the display of the licence plate in the kanban view. TaskID: 2289808 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odo
Original PR description
Changing the driver on a car shouldn't change the fleet.vehicle.log.services associated. We should keep the driver assigned to the car at the time the service was done. Also fix the display of the licence plate in the kanban view. TaskID: 2289808 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54259 Forward-Port-Of: odoo/odoo#54052
Some demo messages have a grey background because they have the subtype_id set to NULL. The subtype should be `mail.mt_comment`, like other messages inside the general channel. task-2278438 Forward-Port-Of: odoo/odoo#54191
Original PR description
Some demo messages have a grey background because they have the subtype_id set to NULL. The subtype should be `mail.mt_comment`, like other messages inside the general channel. task-2278438 Forward-Port-Of: odoo/odoo#54191
There are orm models that don't have _rec_name defined. The orm doesn't allow creation of record via name_create if _rec_name is not defined in the model. This commit considers this fact, such that if `data` do not contain an `id` after name_create, it means we cannot proceed on displaying the non-existing record. Note: _rec_name defaults to 'name' if not specified so only few models don't have _rec_name. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/s
Original PR description
There are orm models that don't have _rec_name defined. The orm doesn't allow creation of record via name_create if _rec_name is not defined in the model. This commit considers this fact, such that if `data` do not contain an `id` after name_create, it means we cannot proceed on displaying the non-existing record. Note: _rec_name defaults to 'name' if not specified so only few models don't have _rec_name. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54143
In an app using rating (e.g. eLearning), get 3 ratings: - A 5-star review - A 3-star review - A 0-star review The average is 2.5 stars, while it should be 4 stars. This happens because the 0-star review is taken into account in the average computation, while it shouldn't. Indeed, zero star means no review. We apply the same login than: https://github.com/odoo/odoo/blob/0028a602bea6a48aaa2747127ec075394732b324/addons/rating/models/rating_mixin.py#L205 opw-2290617 Description
Original PR description
In an app using rating (e.g. eLearning), get 3 ratings: - A 5-star review - A 3-star review - A 0-star review The average is 2.5 stars, while it should be 4 stars. This happens because the 0-star review is taken into account in the average computation, while it shouldn't. Indeed, zero star means no review. We apply the same login than: https://github.com/odoo/odoo/blob/0028a602bea6a48aaa2747127ec075394732b324/addons/rating/models/rating_mixin.py#L205 opw-2290617 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54266
- Enroll user A to a course - Add new content to the course - Publish it => an email is sent to the users enrolled - Reply to the email The reply is considered as a review of the course. It is not intended that users reply to such email; they are 'one-way' notifications. A solution is to be able to set the `email_from` field on the mail template. This way, it's possible to set it to a `noreply` value. opw-2290521 Description of the issue/feature this PR addresses: Curre
Original PR description
- Enroll user A to a course - Add new content to the course - Publish it => an email is sent to the users enrolled - Reply to the email The reply is considered as a review of the course. It is not intended that users reply to such email; they are 'one-way' notifications. A solution is to be able to set the `email_from` field on the mail template. This way, it's possible to set it to a `noreply` value. opw-2290521 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54269 Forward-Port-Of: odoo/odoo#54148
When no update was triggered by an IoT device while the poll request was running, the longpolling would consider it an error and wait some time (up to 15s) before sending a new request. If an update happened during this delay, its value was lost and never arrived to the connected DB. Forward-Port-Of: odoo/enterprise#11763 Forward-Port-Of: odoo/enterprise#11719
Original PR description
When no update was triggered by an IoT device while the poll request was running, the longpolling would consider it an error and wait some time (up to 15s) before sending a new request. If an update happened during this delay, its value was lost and never arrived to the connected DB. Forward-Port-Of: odoo/enterprise#11763 Forward-Port-Of: odoo/enterprise#11719
Before this commit, the BOE file from the tax report (mod 349) was empty. Now, the file contains the same information as the report opw-2278582 Forward-Port-Of: odoo/enterprise#11750 Forward-Port-Of: odoo/enterprise#11730
Original PR description
Before this commit, the BOE file from the tax report (mod 349) was empty. Now, the file contains the same information as the report opw-2278582 Forward-Port-Of: odoo/enterprise#11750 Forward-Port-Of: odoo/enterprise#11730
…osing_move` method Fine-tuning of bf64840c726ce9d88aebd7329e1ef2236665422f Before this commit, an error was raised when opening the trail balance. This error occurs because, since version 12.0, the _get_closing_move only accepts dates as input and not string as it was the case in version 11.0. opw-2292676 opw-2292686 opw-2292687 opw-2292701 Forward-Port-Of: odoo/enterprise#11747
Original PR description
…osing_move` method Fine-tuning of bf64840c726ce9d88aebd7329e1ef2236665422f Before this commit, an error was raised when opening the trail balance. This error occurs because, since version 12.0, the _get_closing_move only accepts dates as input and not string as it was the case in version 11.0. opw-2292676 opw-2292686 opw-2292687 opw-2292701 Forward-Port-Of: odoo/enterprise#11747
Problem: When the credential are missing on a company and the fiscal position is taxlcoud. The property raise a traceback Solution: Raise proper error when the credential for taxcloud are missing on the company. Forward-Port-Of: odoo/enterprise#11624
Original PR description
Problem: When the credential are missing on a company and the fiscal position is taxlcoud. The property raise a traceback Solution: Raise proper error when the credential for taxcloud are missing on the company. Forward-Port-Of: odoo/enterprise#11624