Wednesday, July 22, 2020
1 change · master
Resolved issues and error corrections
Fixes a Chrome-specific issue that caused some website editor settings tied to styling variables to appear incorrectly or stop matching selected values. This restores expected editing controls for website snippets and helps users reliably adjust colors, labels, and related design options.
Original PR description
*: website Commit [1] broke the UI for some options related to CSS variables when using Chrome. The commit made sure the string-value CSS variables are printed with quotes, so that the JS representation of the CSS values can distinguish them (strings = strings with surrounding quotes, others like colors, numbers, etc = strings without surrounding quotes). With chrome, the printed surrounding single quotes are read as double quotes for strange reasons though... so the value "a" was not considered equal to the value 'a'. This commit makes sure surrounding quotes are normalized. This is done through a new utility function to read CSS variables. This also makes sure the values are trimmed, and colors normalized. [1]: https://github.com/odoo/odoo/commit/3a34e39caa8544059dfb1888edc29c62c3efde31