Monday, August 3, 2020
34 changes · master
Enhancements to existing features
Fleet screens are easier to read and now keep a clearer record of who was driving when a service took place. The update also improves wording and label clarity, including license plate display and current driver information on contracts.
Original PR description
- Fix the display of the licence plat on the kanban view - Store the Driver on fleet.vehicle.log.services to remember who was the driver at the time the service was done. - Rename 'Informations' to 'Information' - Rename 'Driver' to 'Current Driver' on the contract TaskID: 2289808 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Report page settings now leave more room at the bottom of printed documents. This helps company address details fit properly in the footer, especially when using the clean template with multi-line addresses.
Original PR description
Before this commit, footer were too small for "clean" template wieh the company address is displayed on 5 lines. Taskid: 2287262 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Planning users can now sort tasks based on their parent task, making grouped work easier to review and organize. This helps teams navigate project planning more efficiently when tasks are structured under larger parent tasks.
Original PR description
It is not possible to sort task by parent task in planning. This branch allow to easily sort tasks according to the parent task. Taskid: 2272604
Users can now choose default tags when configuring document sharing, so files uploaded through the portal are automatically categorized. This makes shared document intake easier to organize and reduces manual tagging after upload.
Original PR description
Currently, when we upload a document from the Portal, it's not possible to set a Tags Default Value. So in this commit, we make the 'tag_ids' field visible on the sharing feature. LINKS PR: #11832 Task-Id: 2295944
Empty pages in the Referral app now use more relevant illustrations and clearer guidance instead of a generic smiling icon. This makes reward, referral, and job position areas feel more helpful when there is no content yet.
Original PR description
Currently, In the referral module when the 'Reward' and 'My Referral' kanban view is empty then it displays a smiling face with help message. In this commit, we replace a smiling face class with a points-gift image and also improve the help message. LINKS PR: #11857 Task-Id: 2297184
Resolved issues and error corrections
This fixes an issue where buttons meant to close a dialog did not always work. Users can now dismiss dialogs as expected, making the interface more consistent and reducing confusion.
Original PR description
In a dialog, a button with `close="1"` should close the dialog when clicked. It currently only works if the dialog is a subview. Co-authored-by: fleodoo <fle@odoo.com> Co-authored-by: aab-odoo <aab@odoo.com> -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
- Create a vendor bill with amount X - Register payment of X - 5 and mark as fully paid => The vendor bill is not fully paid. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55262
Original PR description
- Create a vendor bill with amount X - Register payment of X - 5 and mark as fully paid => The vendor bill is not fully paid. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55262
A broken and unnecessary edit button for blog tags has been removed from the website blog interface. This avoids user confusion and simplifies the underlying page setup without changing core blog functionality.
Original PR description
The button was broken by [1] on top of now being useless anyway. This commit simply removes it and takes the opportunity to share some duplicated XML code at the same time. [1]: https://github.com/odoo/odoo/commit/bdcc1ea9e729dc0e3c0bc28462db97e569119cda
Purpose In merge wizard for lead and opportunity, there should be a limit of 5 leads/opps at the same time. Specifications /!\ Target is 13.0, to add as a bug fix /!\ In the merge modal, similarly to what has been done for partners, display a blocking warning message if the user selected more than 5 records and clicks on merge button. Text of the Modal should say : "To prevent data loss, Leads and Opportunities can only be merged by groups of 5." LINKS PR: #51585 Tas
Original PR description
Purpose
In merge wizard for lead and opportunity, there should be a limit of 5 leads/opps at the same time.
Specifications
/!\ Target is 13.0, to add as a bug fix /!\
In the merge modal, similarly to what has been done for partners, display a blocking warning message if the user selected more than 5 records and clicks on merge button.
Text of the Modal should say :
"To prevent data loss, Leads and Opportunities can only be merged by groups of 5."
LINKS
PR: #51585
Task-id: 2256126
Forward-Port-Of: odoo/odoo#51585Forward-Port-Of: odoo/odoo#55283
Original PR description
Forward-Port-Of: odoo/odoo#55283
- Install Inventory - Create an excel file with the following values : 1) location_id | location_dest_id | Operation Type / database ID | Stock moves / product | Stock moves / unit of measure | Stock moves / name 2) Partner Locations/Vendors | WH/Stock | 1 | Non existent product | Units | Test - Go to Inventory > Operations > Transfers and import the file - Check the "Create if doesn't exist" option for "Stock moves / Product" and click on "TEST" button Import fails because Product does n
Original PR description
- Install Inventory - Create an excel file with the following values : 1) location_id | location_dest_id | Operation Type / database ID | Stock moves / product | Stock moves / unit of measure | Stock…
- Install Inventory - Create an excel file with the following values : 1) location_id | location_dest_id | Operation Type / database ID | Stock moves / product | Stock moves / unit of measure | Stock moves / name 2) Partner Locations/Vendors | WH/Stock | 1 | Non existent product | Units | Test - Go to Inventory > Operations > Transfers and import the file - Check the "Create if doesn't exist" option for "Stock moves / Product" and click on "TEST" button Import fails because Product does not exist and is not created. "name_create_enabled_fields" is used in frontend to store which fields have to be created if they don't exist. The issue comes from the fact that the keys used in "name_create_enabled_fields" contain the full path to the related field (i.e. move_lines/product_id), but only the final field name is used when checking "name_create_enabled_fields" in the backend (i.e. product_id). The prefix from the keys in "name_create_enabled_fields" should be removed when parsing fields from One2many. opw-2282087 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55034 Forward-Port-Of: odoo/odoo#54740
Forward-Port-Of: odoo/odoo#55253 Forward-Port-Of: odoo/odoo#55196
Original PR description
Forward-Port-Of: odoo/odoo#55253 Forward-Port-Of: odoo/odoo#55196
…odel Steps to reproduce: - install helpdesk, hr_expense (the demo data has a clear example of the bug) - go to helpdesk > tickets > set a custom filter > "activities is set" Previous behavior: the results show the ticket with id=2 as if it had an activity set. Because the search sql query selects every ticket where related mail_activity has a res_id=2 and does not check res_model; it collides with other activities set on other models (hr.expense.sheet in this example) Current be
Original PR description
…odel Steps to reproduce: - install helpdesk, hr_expense (the demo data has a clear example of the bug) - go to helpdesk > tickets > set a custom filter > "activities is set" Previous behavior: the results show the ticket with id=2 as if it had an activity set. Because the search sql query selects every ticket where related mail_activity has a res_id=2 and does not check res_model; it collides with other activities set on other models (hr.expense.sheet in this example) Current behavior: the sql query is narrowed by res_model opw-2273680 Forward-Port-Of: odoo/odoo#54361
* portal, `*`: Avoid the `search_count`'s of the portal homepage in other portal pages (/my/*) Main performance gain, gains up to 50% of a portal page queries (depending on the modules installed, and the given page). * portal: Improved template to reduce queries * multiple queries avoided for the `can_edit_vat` check (on `/my/account` page, if `sale`/`account` installed). * *: do not compute archive_groups if not shown to the user (1 read_group call gained by concerned portal subpage) F
Original PR description
* portal, `*`: Avoid the `search_count`'s of the portal homepage in other portal pages (/my/*) Main performance gain, gains up to 50% of a portal page queries (depending on the modules installed, and the given page). * portal: Improved template to reduce queries * multiple queries avoided for the `can_edit_vat` check (on `/my/account` page, if `sale`/`account` installed). * *: do not compute archive_groups if not shown to the user (1 read_group call gained by concerned portal subpage) Forward-Port-Of: odoo/odoo#55199 Forward-Port-Of: odoo/odoo#52983
- Create 2 companies (A and B for instance); - Create 2 users with password, one on each company (user 'a' in company A and user 'b' in company B); - Add enough karma on both users; - Add a valid email address to both users; - As user 'b' : - open any forum topic and validate the email address; - post an answer or comment to a forum post; - As user 'a' : - open the forum and find the answer/comment made by user 'b'; - convert the answer as comment or convert a comment as answ
Original PR description
- Create 2 companies (A and B for instance); - Create 2 users with password, one on each company (user 'a' in company A and user 'b' in company B); - Add enough karma on both users; - Add a valid email address to both users; - As user 'b' : - open any forum topic and validate the email address; - post an answer or comment to a forum post; - As user 'a' : - open the forum and find the answer/comment made by user 'b'; - convert the answer as comment or convert a comment as answer; Before this commit, an error was raised : 'Access to unauthorized or invalid companies'. opw-2296470 Forward-Port-Of: odoo/odoo#55240
As this file was only used as a one shot for the windows packaging, it can be removed from the code. Forward-Port-Of: odoo/odoo#55295 Forward-Port-Of: odoo/odoo#54697
Original PR description
As this file was only used as a one shot for the windows packaging, it can be removed from the code. Forward-Port-Of: odoo/odoo#55295 Forward-Port-Of: odoo/odoo#54697
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55251
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55251
The execute method of res_config settings must not be overridden. set_values() must be overridden because the uninstall must be done at the end of transaction. Currently, the execute function lead to a traceback when some module are desinstalled with unchecked option settings. taskid: 2304307 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55235
Original PR description
The execute method of res_config settings must not be overridden. set_values() must be overridden because the uninstall must be done at the end of transaction. Currently, the execute function lead to a traceback when some module are desinstalled with unchecked option settings. taskid: 2304307 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55235
The first Journal Entry of a tuple (period, journal) has a name set by default so that the user can change it before posting. If we changed the date after the name has been given, it never changed anymore; meaning the number could not be of the same period as the date of the Journal Entry. We now always reset the name to the default one if the name has to be recomputed (change of date/journal) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Original PR description
The first Journal Entry of a tuple (period, journal) has a name set by default so that the user can change it before posting. If we changed the date after the name has been given, it never changed anymore; meaning the number could not be of the same period as the date of the Journal Entry. We now always reset the name to the default one if the name has to be recomputed (change of date/journal) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55304
Wrong usage of self in for loop. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55326
Original PR description
Wrong usage of self in for loop. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55326
Forward-Port-Of: odoo/odoo#55325
Original PR description
Forward-Port-Of: odoo/odoo#55325
After 56a8c9e4311d24c33b7ad08b8230e4be345a85b8 we check access rights in function fields_view_get, access rights are checked on hr.employee before switching to the hr.employee.public view, so a user with only 'Kiosk Attendance' right can't see public employee profile. After this commit: In attendance application, we always show public employee profile as it not useful to show more information in this application. taskId: 2298803 -- I confirm I have signed the CLA and read
Original PR description
After 56a8c9e4311d24c33b7ad08b8230e4be345a85b8 we check access rights in function fields_view_get, access rights are checked on hr.employee before switching to the hr.employee.public view, so a user with only 'Kiosk Attendance' right can't see public employee profile. After this commit: In attendance application, we always show public employee profile as it not useful to show more information in this application. taskId: 2298803 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54486
Purpose: - Purpose of this commit is to should not be change the duration automatically in time off allocation. Task: 2275933 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53014
Original PR description
Purpose: - Purpose of this commit is to should not be change the duration automatically in time off allocation. Task: 2275933 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53014
Before this commit, the address of the company in the boxed template was not properly aligned with the tag line. Taskid: 2287262 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54327
Original PR description
Before this commit, the address of the company in the boxed template was not properly aligned with the tag line. Taskid: 2287262 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54327
Currently, the "Chat" button appears in the form view when it is displayed as a modal. So in this commit, we fix this issue by disappearing the "chat" button when the view is displayed as a modal and also, the button is hidden for my own employee. LINKS PR: #54381 Task-Id: 2291340 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.od
Original PR description
Currently, the "Chat" button appears in the form view when it is displayed as a modal. So in this commit, we fix this issue by disappearing the "chat" button when the view is displayed as a modal and also, the button is hidden for my own employee. LINKS PR: #54381 Task-Id: 2291340 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54381
Part of task-2308312 Forward-Port-Of: odoo/odoo#55284
Original PR description
Part of task-2308312 Forward-Port-Of: odoo/odoo#55284
Currently, In the project module, the archived/deleted sub-task is not deducted from the count of the 'sub-tasks' stat button. Steps to reproduce: - Go to Project > Configuration > Settings > Enable 'sub-tasks' - Go to a Project with sub-tasks enabled, open a task and create a sub-task - Archive/Delete this sub-task So in this commit, we applied filter on sub-task which show only active sub-task on the stat button. LINKS PR: #54904 Task-Id: 2304887 Description of the issue/fea
Original PR description
Currently, In the project module, the archived/deleted sub-task is not deducted from the count of the 'sub-tasks' stat button. Steps to reproduce: - Go to Project > Configuration > Settings > Enable 'sub-tasks' - Go to a Project with sub-tasks enabled, open a task and create a sub-task - Archive/Delete this sub-task So in this commit, we applied filter on sub-task which show only active sub-task on the stat button. LINKS PR: #54904 Task-Id: 2304887 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55323 Forward-Port-Of: odoo/odoo#54904
Enterprise counterpart of https://github.com/odoo/odoo/pull/55284 Part of task-2308312 Forward-Port-Of: odoo/enterprise#12152
Original PR description
Enterprise counterpart of https://github.com/odoo/odoo/pull/55284 Part of task-2308312 Forward-Port-Of: odoo/enterprise#12152
Currently, The width of the inspector buttons is inconsistent. so in this commit, we fix this issue by changing the width(equal to the height) of the o_inspector_button. LINKS PR: #11585 Task-ID: 2287391 Forward-Port-Of: odoo/enterprise#11749 Forward-Port-Of: odoo/enterprise#11585
Original PR description
Currently, The width of the inspector buttons is inconsistent. so in this commit, we fix this issue by changing the width(equal to the height) of the o_inspector_button. LINKS PR: #11585 Task-ID: 2287391 Forward-Port-Of: odoo/enterprise#11749 Forward-Port-Of: odoo/enterprise#11585
Problem: As public user you reach the salary configurator page Select a new car and you got an access error since public user has no right on fleet.vehicle.model.default_total_depreciated_cost You don't get the error on fleet.vehicle.total_depreciated_cost because this field has the flag compute_sudo Solution: Add compute sudo on fleet.vehicle.model.default_total_depreciated_cost and remove useless sudo in controller onchange_advantage Forward-Port-Of: odoo/enterprise#12061
Original PR description
Problem: As public user you reach the salary configurator page Select a new car and you got an access error since public user has no right on fleet.vehicle.model.default_total_depreciated_cost You don't get the error on fleet.vehicle.total_depreciated_cost because this field has the flag compute_sudo Solution: Add compute sudo on fleet.vehicle.model.default_total_depreciated_cost and remove useless sudo in controller onchange_advantage Forward-Port-Of: odoo/enterprise#12061
1) typo in some attributes names 2) original cache was mutated Co-authored-by: fleodoo <fle@odoo.com> Forward-Port-Of: odoo/enterprise#12157
Original PR description
1) typo in some attributes names 2) original cache was mutated Co-authored-by: fleodoo <fle@odoo.com> Forward-Port-Of: odoo/enterprise#12157
Forward-Port-Of: odoo/enterprise#12143
Original PR description
Forward-Port-Of: odoo/enterprise#12143
Create 6000 records for MPS and with products that have dependencies between their BoM. The issue with the client action is that it tries to load the 6000 production schedules at once. In order to lighten the load, we will use a pager in order to load production schedules 20 per 20. However some products have parent materials that belong to other production schedules(that could be display at a different moment). In this case we still have to compute them in order to add the additional
Original PR description
Create 6000 records for MPS and with products that have dependencies between their BoM. The issue with the client action is that it tries to load the 6000 production schedules at once. In order to lighten the load, we will use a pager in order to load production schedules 20 per 20. However some products have parent materials that belong to other production schedules(that could be display at a different moment). In this case we still have to compute them in order to add the additional forecast to the current components. opw-2260481 Forward-Port-Of: odoo/enterprise#12134 Forward-Port-Of: odoo/enterprise#11989
* portal, `*`: Avoid the `search_count`'s of the portal homepage in other portal pages (/my/*) Main performance gain, gains up to 50% of a portal page queries (depending on the modules installed, and the given page). * *: do not compute archive_groups if not shown to the user (1 read_group call gained by concerned portal subpage) * `sale_subscription`: do not load all subscription ids to only compute a count... Enterprise Counterpart of odoo/odoo#52983 Forward-Port-Of: odoo/enterprise#121
Original PR description
* portal, `*`: Avoid the `search_count`'s of the portal homepage in other portal pages (/my/*) Main performance gain, gains up to 50% of a portal page queries (depending on the modules installed, and the given page). * *: do not compute archive_groups if not shown to the user (1 read_group call gained by concerned portal subpage) * `sale_subscription`: do not load all subscription ids to only compute a count... Enterprise Counterpart of odoo/odoo#52983 Forward-Port-Of: odoo/enterprise#12114 Forward-Port-Of: odoo/enterprise#11157