Wednesday, August 12, 2020
25 changes · master
Enhancements to existing features
The warning shown when deleting a bank statement linked to Point of Sale has been updated to match the actual check being performed. Instead of mentioning only open sessions, it now warns about any linked Point of Sale session, helping users better understand why deletion may be blocked.
Original PR description
Followup on 7416340e0ff96bdabb0578f9c1eccd79baf83e17 Before this commit, The warning on deleting Bank statement was referring to only Open Point of Sale session, while we are checking for any linked Session on Bank statement. Now we show a warning of Linked Point of Sale session. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Sample data now avoids showing every next activity as a warning. This makes demo and test screens look more realistic and easier for users to understand.
Original PR description
The SampleServer picks a random value for selection fields. As a consequence, field 'activity_exception_decoration' is always set, either to 'warning' or 'danger'. This means that the next activity field always displays "Warning" (it displays the next activity only if this field is not set). This special case has been handled in web, as it is the first (and only) one. In the future, if we have to implement several special cases like that, we'll setup a proper hook to allow external modules to define them from the outside. Task 2316726 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update improves how website-related features check whether optional views are enabled, avoiding reliance on cached lookups. It helps event, membership, shop comparison, wishlist, and e-learning pages reflect configuration changes more accurately for users.
Original PR description
Use is_view_active instead of viewref which one is cached. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
The calendar view now keeps its normal height unless it is specifically shown in the Time Off area. This prevents the Time Off module from unintentionally shrinking calendars elsewhere, improving readability and layout consistency for users.
Original PR description
Before this commit, calendar view's height was 89.5% of its container. It was because of hr_holidays module which reduces the calendar's height to add some elements on top of it. This commit changes the css rule that reduces the calendar's height to reduce it only when `.o_timeoff_container` is in the dom. Task id: 2193921
Miscellaneous changes
fix bugs -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55155
Original PR description
fix bugs -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55155
The India localization demo data was updated to stop using an outdated invoice posting action. This keeps sample accounting data aligned with the current system behavior and helps avoid errors when loading demos.
Original PR description
Commit https://github.com/odoo/odoo/commit/82dc0cb7b91ae59beae7e1c865b670afc5958b31 deprecated that method. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures Odoo's main workflow tests start with the required make-to-order inventory route enabled, so the test scenario matches how the flow is meant to work. It also corrects a small issue where route options could be hidden when opening a product form from a create/edit action.
Original PR description
Enable MTO route at the start of main flow tour since it's used by it. Also fix a small bug when the form view is open from a create edit where the route are hidden. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
task 337 --- ### Description of the issue/feature this PR addresses: Show partner commercial name and contact name in the inovice report instead of just the partner contact name. ### Current behavior before PR: For the example: ``` Adhoc (Commercial Partner) - Katherine Zaoral (contact) ``` The invoice report was showing: `Katherine Zaoral` (only the partner name). ### Desired behavior after PR is merged: Now will show: `Adhoc` (commercial partner name) --
Original PR description
task 337
---
### Description of the issue/feature this PR addresses:
Show partner commercial name and contact name in the inovice report instead of just the partner contact name.
### Current behavior before PR:
For the example:
```
Adhoc (Commercial Partner)
- Katherine Zaoral (contact)
```
The invoice report was showing: `Katherine Zaoral` (only the partner name).
### Desired behavior after PR is merged:
Now will show: `Adhoc` (commercial partner name)
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#55581
Forward-Port-Of: odoo/odoo#55202Before this commit, the loading order of the search panel sections was fixed: categories first, then filters. This caused issues when the categories needed to know the current valid domain to fetch new counters because a selected filter value could have been discarded when selecting a new category. Now, the filters are fetched first when toggling a category value and this problem is avoided. Enterprise PR: https://github.com/odoo/enterprise/pull/12180 Forward-Port-Of: odoo/odoo#55385
Original PR description
Before this commit, the loading order of the search panel sections was fixed: categories first, then filters. This caused issues when the categories needed to know the current valid domain to fetch new counters because a selected filter value could have been discarded when selecting a new category. Now, the filters are fetched first when toggling a category value and this problem is avoided. Enterprise PR: https://github.com/odoo/enterprise/pull/12180 Forward-Port-Of: odoo/odoo#55385
Before this Commit, Datetime on warning was not formatted based on User's lang. With this commit, we use `format_datetime` to correctly format Datetime. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#51365
Original PR description
Before this Commit, Datetime on warning was not formatted based on User's lang. With this commit, we use `format_datetime` to correctly format Datetime. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#51365
Having a non paid membership for last year and being associate with someone having a non paid membership was dispalying an 'old' membership state instead if a 'non' membership. Assumption: If an associate member is added, take the state of the associate member (tooltip of associate member). In case the associate member is a 'non member', it's stupid to associate with someone that is paying or have paid as it won't consider the state of the current paid member, the link has to be made o
Original PR description
Having a non paid membership for last year and being associate with someone having a non paid membership was dispalying an 'old' membership state instead if a 'non' membership. Assumption: If an…
Having a non paid membership for last year and being associate with
someone having a non paid membership was dispalying an 'old' membership
state instead if a 'non' membership.
Assumption:
If an associate member is added, take the state of the associate member
(tooltip of associate member).
In case the associate member is a 'non member', it's stupid to associate
with someone that is paying or have paid as it won't consider the state of
the current paid member, the link has to be made on the other side:
the 'non' paying will be associate with the 'paid'.
Create membership for
a/ 2019 (1jan to 31dec)
> For the calculation of the 'old' state
b/ 2020 (1jan to 31dec)
> For the calculation of the 'paid' state
Create few res.partner:
AA: No associate.
2019 - Paid
2020 - Paid
>> Paid member
(= ok)
CC Case 1:
Associate with AA
2019 - Invoiced (but not paid)
2020 - None
>> Paid member due to association with AA
(= ok)
CC Case 2:
Not associate:
2019 - Invoiced (but not paid)
2020 - None
>> Before fix: Old member
(= nok)
>> After fix: Non member
(= ok) As he never paid and not linked to someone that paid.
DD: Associate with AA
2019 - Invoiced not paid
2020 - Paid
>> Paid member (with or without association with AA)
(= ok)
EE Case 1:
Not associate:
2019 - Paid
2020 - None
>> Old member
(= ok)
Case 2:
Associate with DD
2019 - Invoiced (not paid)
2020 - None
>> Paid member (due to association with DD)
(= ok)
Case 3:
Associate with CC
2019 - Invoiced (not paid)
2020 - None
>> Before fix: Old member (due to none having a current 2020 invoiced)
(= nok it should take the state of CC)
>> After fix: Non member (as CC is not a member)
opw-2287050
Forward-Port-Of: odoo/odoo#55668
Forward-Port-Of: odoo/odoo#54840Before this commit we cehck first if user was publisher before to check if the exception was a 404 NotFound. What's means that we make this check (1 query sql) most of the time for no reason, and worst case, when the exception crashes the cursor, this check will reraise a new exception because isPublisher check is done with a closed cursor. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I
Original PR description
Before this commit we cehck first if user was publisher before to check if the exception was a 404 NotFound. What's means that we make this check (1 query sql) most of the time for no reason, and worst case, when the exception crashes the cursor, this check will reraise a new exception because isPublisher check is done with a closed cursor. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55780
opw-2312139 The Andhra Pradesh state code change from 28 to 37 Source :https://ddvat.gov.in/docs/List%20of%20State%20Code.pdf Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55732
Original PR description
opw-2312139 The Andhra Pradesh state code change from 28 to 37 Source :https://ddvat.gov.in/docs/List%20of%20State%20Code.pdf Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55732
task-2280166 Forward-Port-Of: odoo/odoo#55723
Original PR description
task-2280166 Forward-Port-Of: odoo/odoo#55723
Before this commit, if you don't have the sale access right, when you arrive on main website menu, the dashboard try to load some utms data and will fail with a traceback. Now we don't render utm graph it you don't have the sale access right This commit closes odoo/odoo#54695 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/s
Original PR description
Before this commit, if you don't have the sale access right, when you arrive on main website menu, the dashboard try to load some utms data and will fail with a traceback. Now we don't render utm graph it you don't have the sale access right This commit closes odoo/odoo#54695 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55785
Before this commit, the field badge could overflow from its boundaries and have part of its pill/text hidden. Now, the "overflow" mixin has been applied and the badge is properly contained. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55786
Original PR description
Before this commit, the field badge could overflow from its boundaries and have part of its pill/text hidden. Now, the "overflow" mixin has been applied and the badge is properly contained. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55786
PURPOSE Review the tips and digest layout design to make sure they have a WOW effect and increase trial conversion/retention. SPECIFICATIONS: LAYOUT Besides changing the tips, a cleaning of digest layout was performed. Emails were reported to look not neat in Outlook and somewhat random in mail.com or gmail.com. Most recent HTML CSS cannot be used to make HTML emails because each email provider renders emails its own way. This means a given email may renders differently in gmail
Original PR description
PURPOSE Review the tips and digest layout design to make sure they have a WOW effect and increase trial conversion/retention. SPECIFICATIONS: LAYOUT Besides changing the tips, a cleaning of digest…
PURPOSE Review the tips and digest layout design to make sure they have a WOW effect and increase trial conversion/retention. SPECIFICATIONS: LAYOUT Besides changing the tips, a cleaning of digest layout was performed. Emails were reported to look not neat in Outlook and somewhat random in mail.com or gmail.com. Most recent HTML CSS cannot be used to make HTML emails because each email provider renders emails its own way. This means a given email may renders differently in gmail.com and outlook. The layout of the email was composed of several levels of embedded tables which means huge maintenance effort. So it was totally rewritten with divs and CSS, but some properties are not taken into account. A lot of page component improvements were done. It consisted in replacing most of the style attribute in tags with CSS classes and ids. This step is especially useful for tip formatting because before, if a style modification was needed, it had to be performed on each tip individually. SPECIFICATIONS: TIPS Add / Improve tips in cmr, purchase, hr_recruitment, website, hr_expense, project, digest, sale_management, im_livechat, stock, mrp, account. LINKS COM PR: odoo/odoo#53580 ENT PR: odoo/enterprise#11394 Forward-Port-Of: odoo/odoo#53580
- Create Tax 0: Percentage Amount: 0 Tax Included Tax Group 0 - Create Tax 8: Percentage Amount: 8 Tax Included Tax Group 8 - Create a customer invoice with one line Quantity: 8.0 Price Unit: 15.55 Taxes: Tax 8, Tax 0 (order is important) The tax amounts are: Tax 8: 9.22 Tax 0: -0.01 If the taxes are inverted, the tax amounts Tax 8: 9.21 Tax 0: 0.00 The difference is due to the rounding of the 8% tax done differently. In the second case, t
Original PR description
- Create Tax 0: Percentage Amount: 0 Tax Included Tax Group 0 - Create Tax 8: Percentage Amount: 8 Tax Included Tax Group 8 - Create a customer invoice with one line Quantity: 8.0 Price Unit: 15.55…
- Create Tax 0: Percentage Amount: 0 Tax Included Tax Group 0 - Create Tax 8: Percentage Amount: 8 Tax Included Tax Group 8 - Create a customer invoice with one line Quantity: 8.0 Price Unit: 15.55 Taxes: Tax 8, Tax 0 (order is important) The tax amounts are: Tax 8: 9.22 Tax 0: -0.01 If the taxes are inverted, the tax amounts Tax 8: 9.21 Tax 0: 0.00 The difference is due to the rounding of the 8% tax done differently. In the second case, the computation of the 8% tax goes through: https://github.com/odoo/odoo/blob/8c5cd335a57c20ed5faa6b7c7630c296c1f2a5cf/addons/account/models/account.py#L1480 In the first case, the amount is recomputed in: https://github.com/odoo/odoo/blob/8c5cd335a57c20ed5faa6b7c7630c296c1f2a5cf/addons/account/models/account.py#L1483 The rounding is different in both cases, leading to an inconsistency. When the tax amount is zero, there is no need to save the amount in `total_included_checkpoints`. opw-2306676 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55733 Forward-Port-Of: odoo/odoo#55572
In a French based company Create a DEMO product with price 500 available in POS Have a public pricelist in which feature a line with: - product: DEMO - minimum quantity: 1 - price: 400 Open POS, Add DEMO, the price from the pricelist will be used. Now delete the product. The form will popup, choose a quantity to delete and confirm. The price of the cancel line will not be taken from the pricelist, so the two line will have different prices. This occur because the quantity of the n
Original PR description
In a French based company Create a DEMO product with price 500 available in POS Have a public pricelist in which feature a line with: - product: DEMO - minimum quantity: 1 - price: 400 Open POS, Add DEMO, the price from the pricelist will be used. Now delete the product. The form will popup, choose a quantity to delete and confirm. The price of the cancel line will not be taken from the pricelist, so the two line will have different prices. This occur because the quantity of the new line is -1 and the pricelist may have a minimum positive quantity set. Using a specific option to keep the price fix the issue opw-2312172 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55699 Forward-Port-Of: odoo/odoo#55680
PURPOSE Review the tips and digest layout design to make sure they have a WOW effect and increase trial conversion/retention. SPECIFICATIONS Enterprise counterpart of odoo/odoo#53580 . In this merge we add tips in the following apps: account_accountant, documents, planning. We improve helpdesk tips. Digest_enterprise module is added that holds base tips requiring enterprise features. LINKS Task ID-2274264 COM PR: odoo/odoo#53580 ENT PR: odoo/enterprise#11394 Forward-Port
Original PR description
PURPOSE Review the tips and digest layout design to make sure they have a WOW effect and increase trial conversion/retention. SPECIFICATIONS Enterprise counterpart of odoo/odoo#53580 . In this merge we add tips in the following apps: account_accountant, documents, planning. We improve helpdesk tips. Digest_enterprise module is added that holds base tips requiring enterprise features. LINKS Task ID-2274264 COM PR: odoo/odoo#53580 ENT PR: odoo/enterprise#11394 Forward-Port-Of: odoo/enterprise#11394
This commit fixes a small flicker in the twitter user search by forcing the main color on the dropdown text. Task 2250877 Forward-Port-Of: odoo/enterprise#10562
Original PR description
This commit fixes a small flicker in the twitter user search by forcing the main color on the dropdown text. Task 2250877 Forward-Port-Of: odoo/enterprise#10562
The summary email sent to the employee/applicant is missing the wage information. Add the wage in the Contract Information Forward-Port-Of: odoo/enterprise#11140
Original PR description
The summary email sent to the employee/applicant is missing the wage information. Add the wage in the Contract Information Forward-Port-Of: odoo/enterprise#11140
Before this commit, the loading order of the search panel sections was fixed: categories first, then filters. This caused issues when the categories needed to know the current valid domain to fetch new counters because a selected filter value could have been discarded when selecting a new category. Now, the filters are fetched first when toggling a category value and this problem is avoided. A mobile test has been adapted accordingly to these changes. Community PR: https://github.c
Original PR description
Before this commit, the loading order of the search panel sections was fixed: categories first, then filters. This caused issues when the categories needed to know the current valid domain to fetch new counters because a selected filter value could have been discarded when selecting a new category. Now, the filters are fetched first when toggling a category value and this problem is avoided. A mobile test has been adapted accordingly to these changes. Community PR: https://github.com/odoo/odoo/pull/55385 Forward-Port-Of: odoo/enterprise#12180
Currently, When try to create contract template from Employee app setting, it show duplicate templates fields. So in this commit, Hide the duplicate template fields when create contract template from employee app setting. TaskID: 2303270 Closes: #12270 Forward-Port-Of: odoo/enterprise#12270
Original PR description
Currently, When try to create contract template from Employee app setting, it show duplicate templates fields. So in this commit, Hide the duplicate template fields when create contract template from employee app setting. TaskID: 2303270 Closes: #12270 Forward-Port-Of: odoo/enterprise#12270
fix bugs Task 2298950 PR #12096 Forward-Port-Of: odoo/enterprise#12096
Original PR description
fix bugs Task 2298950 PR #12096 Forward-Port-Of: odoo/enterprise#12096