Thursday, August 13, 2020
23 changes · master
Enhancements to existing features
The Latin American invoice document module now directly includes the debit note capability it relies on. This makes setup cleaner and ensures related localization features have the right dependency in newer versions.
Original PR description
task 356 --- Add account_move_debit dependency to l10n_latam_invoice_document module -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Argentina electronic invoicing module no longer carries a dependency that belongs in the broader Latin American invoicing document module. This keeps responsibilities clearer and reduces unnecessary coupling without changing day-to-day business workflows.
Original PR description
task 356 --- Remove account_move_debit dependency from l10n_ar_edi module This dependency was added in version 13.0 in l10n_ar_edi because we were not able to add a new dependency in stable version for l10n_latam_invoice_document module. Now that we have master then we move the dependency to l10n_latam_invoice_document where it belongs
Resolved issues and error corrections
This update fixes an issue that could prevent Argentine localization demo data from installing correctly. It explicitly sets the required currency exchange accounts for specific Argentine chart templates, helping demo environments work reliably.
Original PR description
task 355 --- -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
This PR would replace this one https://github.com/odoo/odoo/pull/50177 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54925 Forward-Port-Of: odoo/odoo#50182
Original PR description
This PR would replace this one https://github.com/odoo/odoo/pull/50177 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54925 Forward-Port-Of: odoo/odoo#50182
This change makes it easier to adjust sale order details at the moment an order is confirmed. Businesses using integrations or custom workflows can now set values such as confirmation dates from external systems before they are saved.
Original PR description
Description of the issue/feature this PR addresses: Allow modifying values before they're written when confirming a sale order. Current behavior before PR: As a `write` is being triggered from within…
Description of the issue/feature this PR addresses: Allow modifying values before they're written when confirming a sale order.
Current behavior before PR: As a `write` is being triggered from within `action_confirm` there is no clean way to modify or add values in the dictionary.
Desired behavior after PR is merged: Since the `action_confirm` calls `_prepare_confirmation_values` we can easily override this function to modify or add values before they're being written. This allows something such as:
```
def _prepare_confirmation_values(self):
values = self.super(SaleOrder, self)._prepare_confirmation_values)
values['another_key'] = 'Yes we can'
return values
```
This can be handy if you, for example, create and confirm sale orders through the API and have another date for `date_order` because the actual confirmation date is not `fields.Datetime.now()` but a date from your external system.
Follow-up of https://github.com/odoo/odoo/pull/54517
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe inventory report action label is restored from “Update Quantity” to its previous wording to avoid confusing users. This makes the stock workflow easier to understand without changing the underlying inventory behavior.
Original PR description
The current action name `Update Quantity` was confusion for users using the Inventory Report.  With this commit, we restore the action name to the previous one. This commits partially reverts bee938e03d60ec097b6885581bf68b6886418c93 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an incorrect test update carried over from an earlier change in Accounting Reports. It helps keep automated checks accurate so future reporting changes can be validated reliably without affecting day-to-day users.
Original PR description
… of the test from https://github.com/odoo/enterprise/pull/10706/commits/c09d126f8afa5bdb37694e16b8b7501f0db3b05f
Currently, there's only one tax for non deductible VAT on purchase, but although the most common one (21% percentage), it's not the only one. There can be cases where there's 4% or 10% VAT that is not deductible. With this PR we add that percentages to the CoA. Forward port to v13 of odoo/odoo#48629 @Tecnativa Forward-Port-Of: odoo/odoo#55491
Original PR description
Currently, there's only one tax for non deductible VAT on purchase, but although the most common one (21% percentage), it's not the only one. There can be cases where there's 4% or 10% VAT that is not deductible. With this PR we add that percentages to the CoA. Forward port to v13 of odoo/odoo#48629 @Tecnativa Forward-Port-Of: odoo/odoo#55491
Follow up of https://github.com/odoo/odoo/commit/f8179007f9aa662be7318edeb18426ea1c906c15 Context: Many field are now synchronized from the partner_id. The address fields and other contact field. A first commit 9c9f477f04e8f4ee9b18092fe894890c2ab31b58, kept the value from the lead if the value from the partner was empty. This lead to mixed address field. A second commit fixed that behavior f8179007f9aa662be7318edeb18426ea1c906c15 Take the value from the partner if the partner is set.
Original PR description
Follow up of https://github.com/odoo/odoo/commit/f8179007f9aa662be7318edeb18426ea1c906c15 Context: Many field are now synchronized from the partner_id. The address fields and other contact field. A…
Follow up of https://github.com/odoo/odoo/commit/f8179007f9aa662be7318edeb18426ea1c906c15
Context:
Many field are now synchronized from the partner_id.
The address fields and other contact field.
A first commit 9c9f477f04e8f4ee9b18092fe894890c2ab31b58, kept the value
from the lead if the value from the partner was empty. This lead to
mixed address field. A second commit fixed that behavior f8179007f9aa662be7318edeb18426ea1c906c15
Take the value from the partner if the partner is set.
Problem:
This behavior erase too much information.
```
>>> lead_sudo.partner_name
'odotesttest'
>>> user.partner_id.name
'odotesttest6@mailinator.com'
>>> user.partner_id.parent_id
res.partner()
>>> user.partner_id.is_company
False
>>> lead_sudo.write({'partner_id': user.partner_id.id})
>>> lead_sudo.partner_name
False
```
We indeed need a consistent address but for the other field
we want to keep the maximum of data.
Solution:
For the address fields, take all the value from the partner
if one of the address fields is defined otherwise keep the information
from the lead. For all the other fields keep the lead information
if the partner information is empty.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#55825
Forward-Port-Of: odoo/odoo#55194Task ID-2314778 PR #55625 Forward-Port-Of: odoo/odoo#55642 Forward-Port-Of: odoo/odoo#55625
Original PR description
Task ID-2314778 PR #55625 Forward-Port-Of: odoo/odoo#55642 Forward-Port-Of: odoo/odoo#55625
Forward-Port-Of: odoo/odoo#55836
Original PR description
Forward-Port-Of: odoo/odoo#55836
Based on https://www.agenciatributaria.es/AEAT.internet/Inicio/La_Agencia_Tributaria/Campanas/Retenciones/Cuadro_informativo_tipos_de_retencion_aplicables__2020_.shtml Closes #34161 @Tecnativa Forward-Port-Of: odoo/odoo#54921 Forward-Port-Of: odoo/odoo#54914
Original PR description
Based on https://www.agenciatributaria.es/AEAT.internet/Inicio/La_Agencia_Tributaria/Campanas/Retenciones/Cuadro_informativo_tipos_de_retencion_aplicables__2020_.shtml Closes #34161 @Tecnativa Forward-Port-Of: odoo/odoo#54921 Forward-Port-Of: odoo/odoo#54914
task-2307201 Forward-Port-Of: odoo/odoo#55407
Original PR description
task-2307201 Forward-Port-Of: odoo/odoo#55407
[FIX] project: only internal users in "Assigned To" field of task form Values filled in "Assigned To" m2o were differing: - if I "CREATE" task with "group by" then m2o is filled with internal-users + portal-users - if I "CREATE: task without group by then it filled with internal users only. In Project also same case. To have a more coherent behaviour, we decided to put only internal users in both cases. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.c
Original PR description
[FIX] project: only internal users in "Assigned To" field of task form Values filled in "Assigned To" m2o were differing: - if I "CREATE" task with "group by" then m2o is filled with internal-users + portal-users - if I "CREATE: task without group by then it filled with internal users only. In Project also same case. To have a more coherent behaviour, we decided to put only internal users in both cases. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54776
Update the document type list names to match with the AFIP documentation Task 302 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55461
Original PR description
Update the document type list names to match with the AFIP documentation Task 302 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55461
Issue - Install "Events" module - Go to website and select an event - Edit (in frontend) the event and replace the "Register" button text - Save & Close the editor - Try to register to the event Traceback raised Cause Due to this fix on 13.0 https://github.com/odoo/odoo/commit/8579c0cae839c615415120b79d6ec22c71f7affd, the replaced arch will override the style/class if has one. In the related ticket; after renaming the "Register" button, the 'a-submit' class was rem
Original PR description
Issue - Install "Events" module - Go to website and select an event - Edit (in frontend) the event and replace the "Register" button text - Save & Close the editor - Try to register to the event Traceback raised Cause Due to this fix on 13.0 https://github.com/odoo/odoo/commit/8579c0cae839c615415120b79d6ec22c71f7affd, the replaced arch will override the style/class if has one. In the related ticket; after renaming the "Register" button, the 'a-submit' class was removed at rendering, and so, after renaming, the class is not present in the new button while it's needed to fetch register buttons. Solution Do not remove 'a-submit' class from button since needed in js to fetch register buttons. opw-2317119 Forward-Port-Of: odoo/odoo#55819
Improve mock server: - add support for mocked `fetch` - add support for `active_test` - add support for x2m `in` in domains - add support for default values computed from a function - implement a more natural "next id" compute - allow initial data without ids - ensure write and x2m commands integrity - improve bad data/bad commands error messages - always warn for failing RPC, not only in debug mode - fix all existing tests that had inconsistency data Other changes done in mail (o
Original PR description
Improve mock server: - add support for mocked `fetch` - add support for `active_test` - add support for x2m `in` in domains - add support for default values computed from a function - implement a…
Improve mock server: - add support for mocked `fetch` - add support for `active_test` - add support for x2m `in` in domains - add support for default values computed from a function - implement a more natural "next id" compute - allow initial data without ids - ensure write and x2m commands integrity - improve bad data/bad commands error messages - always warn for failing RPC, not only in debug mode - fix all existing tests that had inconsistency data Other changes done in mail (or dependents) that are not just related to tests: - remove `direct_partner` from formatter result ->`correspondent` can be computed from other keys, especially `members` - fix `livechat_visitor` convertData -> only process if there is value - add `current_partner` and `current_user_id` as `init_messaging` result -> easier to mock than session - remove usage of `need_moderation` -> that was just a search indirection to `moderation_status` - adapt `partner_id` -> `res_partner_id` key in `_notification_format` -> to be consistent with field name - add name in result of `mail_partner_format` -> sometimes display_name is not the same - remove usage of `is_moderator` -> that was just an indirection to `moderation_channel_ids` Enterprise counterpart: odoo/enterprise#11523 task-2287171 various notes: - mockrpc -> mock server (except asserts) - no initMessaging - this.data instead of this.env.models create when possible (done some, out of scope to do all of them) - records push and not override - mock models override for all modules (not fully done, outside of mail / out of scope) - mock web content/image route (was already the case) - comment reason of each data (remove useless/default data) (checked and done a decent part, too long for the rest) - only use ids above 10 in data (done when diff on line, too much work to check all of them) - mentions improve tests to check main and extra suggestions (out of scope, but necessary to ensure mock is correct) - data definition should use data and not env (current partnet etc when doing notif manually for example) (the problem is doing notif manually and not with the mock server, out of scope) - mock server for channel message not returning message / not setting channel_ids in message if pending moderation (I don't remember what I meant, not important for existing tests) - session should be set from data current partner etc (out of scope) - review all mocks naming & docstring (if from models: _MockModelMethod) - mark all require focus tests - replace message_needaction_counter by actual messages/notifs - message_unread_counter by actual messages/notifs (not done but I don't want to delay the PR further) - always use _mockCreate / _mockWrite - don't update data in place with formatters... - try to remove bus trigger in test, replace by actual actions/rpc leading to result to ensure data integrity (out of scope) Forward-Port-Of: odoo/odoo#53826
Community PR: https://github.com/odoo/odoo/pull/53826 task-2287171 Forward-Port-Of: odoo/enterprise#11523
Original PR description
Community PR: https://github.com/odoo/odoo/pull/53826 task-2287171 Forward-Port-Of: odoo/enterprise#11523
A tolerance is added to the total as it happens to have a small difference between the total of the purchase order and the actual invoice. The state of the purchase order wasn't checked (it is not part of the domain generated by _onchange_allowed_purchase_ids). Forward-Port-Of: odoo/enterprise#12380 Forward-Port-Of: odoo/enterprise#12342
Original PR description
A tolerance is added to the total as it happens to have a small difference between the total of the purchase order and the actual invoice. The state of the purchase order wasn't checked (it is not part of the domain generated by _onchange_allowed_purchase_ids). Forward-Port-Of: odoo/enterprise#12380 Forward-Port-Of: odoo/enterprise#12342
task 354 --- Now that we are using the options instead of the context then we need to get the journal_type from options always in order to properly print the information about the print preview and export xlsx correctly. Before this change when we try to print the purchase vat book export xlsx will print the sale vat book instead Forward-Port-Of: odoo/enterprise#12353
Original PR description
task 354 --- Now that we are using the options instead of the context then we need to get the journal_type from options always in order to properly print the information about the print preview and export xlsx correctly. Before this change when we try to print the purchase vat book export xlsx will print the sale vat book instead Forward-Port-Of: odoo/enterprise#12353
Small bugs : - Values filled in "Assigned To" m2o are differing in 2 different forms but should be the same - Customer Name is cropped on report Forward-Port-Of: odoo/enterprise#11402
Original PR description
Small bugs : - Values filled in "Assigned To" m2o are differing in 2 different forms but should be the same - Customer Name is cropped on report Forward-Port-Of: odoo/enterprise#11402
…' automatically This commit fixes the creation of social.push reminders for event.tracks to make them automatically scheduled. Before this change, they were created in the 'draft' stage, requiring the social manager to manually schedule each of them individually. Linked to task #2283869 Part of main 'event online' task #2252655 Forward-Port-Of: odoo/enterprise#12339
Original PR description
…' automatically This commit fixes the creation of social.push reminders for event.tracks to make them automatically scheduled. Before this change, they were created in the 'draft' stage, requiring the social manager to manually schedule each of them individually. Linked to task #2283869 Part of main 'event online' task #2252655 Forward-Port-Of: odoo/enterprise#12339
This PR would replace this one https://github.com/odoo/enterprise/pull/10201/files Forward-Port-Of: odoo/enterprise#12022 Forward-Port-Of: odoo/enterprise#10203
Original PR description
This PR would replace this one https://github.com/odoo/enterprise/pull/10201/files Forward-Port-Of: odoo/enterprise#12022 Forward-Port-Of: odoo/enterprise#10203