Monday, August 24, 2020
29 changes · master
Enhancements to existing features
Expense receipt processing now sends the user's language and company country to the extraction service. This helps interpret date formats more accurately, reducing mistakes when scanning receipts from different regions.
Original PR description
send the user language and company country code to help detect dates
Resolved issues and error corrections
The appointment type form now shows the Go to Website button consistently with the other action buttons. This removes a visual glitch caused by an extra layout container, improving the form's appearance and usability.
Original PR description
PURPOSE Appointment form view, Go to Website Button should be proper, there should not be glitch. SPEC Appointment form view has UI glitch on Go to Website Button, it should look like other stat button. TASK 2299523
Miscellaneous changes
Use the correct spelling of "Odoo S.A." No need to specify it for modules only developped by Odoo S.A. Closes odoo/odoo#54372 Forward-Port-Of: odoo/odoo#56341 Forward-Port-Of: odoo/odoo#56249
Original PR description
Use the correct spelling of "Odoo S.A." No need to specify it for modules only developped by Odoo S.A. Closes odoo/odoo#54372 Forward-Port-Of: odoo/odoo#56341 Forward-Port-Of: odoo/odoo#56249
Use the correct spelling of "Odoo S.A." No need to specify it for modules only developped by Odoo S.A. Closes odoo/odoo#54372 Forward-Port-Of: odoo/odoo#56253 Forward-Port-Of: odoo/odoo#56249
Original PR description
Use the correct spelling of "Odoo S.A." No need to specify it for modules only developped by Odoo S.A. Closes odoo/odoo#54372 Forward-Port-Of: odoo/odoo#56253 Forward-Port-Of: odoo/odoo#56249
In order to see the overflow-x scrollbar only when needed, overflow-x have been set to auto instead of scroll for agenda table. Task ID: 2314778 Forward-Port-Of: odoo/odoo#56099 Forward-Port-Of: odoo/odoo#56094
Original PR description
In order to see the overflow-x scrollbar only when needed, overflow-x have been set to auto instead of scroll for agenda table. Task ID: 2314778 Forward-Port-Of: odoo/odoo#56099 Forward-Port-Of: odoo/odoo#56094
PURPOSE In some specific flows, allow to bypass that protection. SPECIFICATIONS To be implemented in "Send by email" flows -> button on invoice / SO / PO that open full composer with default template loaded. Use cases 1> I am customer of an invoice / SO / PO I created because I want to see the result and I use a template with partner_to adding custome to partner_ids (like Send SO by email); 2> OR I add myself in recipients (Send to followers + "Myself"); 3> OR I use suggested rec
Original PR description
PURPOSE In some specific flows, allow to bypass that protection. SPECIFICATIONS To be implemented in "Send by email" flows -> button on invoice / SO / PO that open full composer with default template loaded. Use cases 1> I am customer of an invoice / SO / PO I created because I want to see the result and I use a template with partner_to adding custome to partner_ids (like Send SO by email); 2> OR I add myself in recipients (Send to followers + "Myself"); 3> OR I use suggested recipients before opening full composer; All those set myself in partner_ids of composer, not just as a follower but as requested recipient. task - 2294130 Forward-Port-Of: odoo/odoo#55809 Forward-Port-Of: odoo/odoo#54951
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56360
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56360
PURPOSE Provide fixes after internal deployment of event online modules. SPECIFICATIONS Fix glitches in exhibitor menu filters. Use Favorite name for reminder / wishlist / favorite widget of tracks. Fix track / agenda menu management. Fix demo data to have coherent tracks. See sub commits for more details. UPDATE * website_event_track_exhibitor.exhibitors_topbar_sponsorship * website_event_track_online.track_widget_reminder * website_event_track_session.session
Original PR description
PURPOSE Provide fixes after internal deployment of event online modules. SPECIFICATIONS Fix glitches in exhibitor menu filters. Use Favorite name for reminder / wishlist / favorite widget of tracks. Fix track / agenda menu management. Fix demo data to have coherent tracks. See sub commits for more details. UPDATE * website_event_track_exhibitor.exhibitors_topbar_sponsorship * website_event_track_online.track_widget_reminder * website_event_track_session.session_topbar LINKS Task ID-2312007 (demo fix) Task ID-2314778 (event online fixes) PR odoo/odoo#56254 PR odoo/enterprise#12558 Forward-Port-Of: odoo/odoo#56254
PURPOSE Provide fixes after internal deployment of event online modules. SPECIFICATIONS Fix glitches in exhibitor menu filters. Use Favorite name for reminder / wishlist / favorite widget of tracks. Fix track / agenda menu management. Fix demo data to have coherent tracks. See sub commits for more details. UPDATE * website_event_track_exhibitor.exhibitors_topbar_sponsorship * website_event_track_online.track_widget_reminder * website_event_track_session.session
Original PR description
PURPOSE Provide fixes after internal deployment of event online modules. SPECIFICATIONS Fix glitches in exhibitor menu filters. Use Favorite name for reminder / wishlist / favorite widget of tracks. Fix track / agenda menu management. Fix demo data to have coherent tracks. See sub commits for more details. UPDATE * website_event_track_exhibitor.exhibitors_topbar_sponsorship * website_event_track_online.track_widget_reminder * website_event_track_session.session_topbar LINKS Task ID-2312007 (demo fix) Task ID-2314778 (event online fixes) PR odoo/odoo#56254 PR odoo/enterprise#12558 Forward-Port-Of: odoo/odoo#56340 Forward-Port-Of: odoo/odoo#56254
f0d37c3 added a check on write access for server action. Since the fixed server action are readonly with strict access right, corresponding groups are added to avoid a warning. This was merged in master post 13.5 freeze and needs a backport backport of 149506504156c21c20799b98dfd2cb644b6cf04d Forward-Port-Of: odoo/odoo#56375
Original PR description
f0d37c3 added a check on write access for server action. Since the fixed server action are readonly with strict access right, corresponding groups are added to avoid a warning. This was merged in master post 13.5 freeze and needs a backport backport of 149506504156c21c20799b98dfd2cb644b6cf04d Forward-Port-Of: odoo/odoo#56375
`http.py` had been modified so the file could be patched correctly with the previous version of the `http.py.iotpatch` file -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56373
Original PR description
`http.py` had been modified so the file could be patched correctly with the previous version of the `http.py.iotpatch` file -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56373
With: - Anglo-saxon activated, - Costing Method: FIFO, - Inventory Valuation: Automated. Create a PO for product AAA, receive the product and archive it, create and try to POST the vendor bill. > This lead to a ZeroDivisionError: float division by zero The anglo-saxon entries cannot be generated as the product is not valued anymore. This commit is displaying a clearer error message for end users. more info from SLE on 2250451 opw-2307562, 2317338, 2320080, 2311843 Descripti
Original PR description
With: - Anglo-saxon activated, - Costing Method: FIFO, - Inventory Valuation: Automated. Create a PO for product AAA, receive the product and archive it, create and try to POST the vendor bill. > This lead to a ZeroDivisionError: float division by zero The anglo-saxon entries cannot be generated as the product is not valued anymore. This commit is displaying a clearer error message for end users. more info from SLE on 2250451 opw-2307562, 2317338, 2320080, 2311843 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55984
Commit [1] made a mistake when creating the new font family system. The values defined in the palettes took precedence over the overridding values defined in the fonts configuration map. Obviously only user values should take precedence over those. [1]: https://github.com/odoo/odoo/commit/7be1429656af3c96ac30caed28a27f5b9590009f Forward-Port-Of: odoo/odoo#56372
Original PR description
Commit [1] made a mistake when creating the new font family system. The values defined in the palettes took precedence over the overridding values defined in the fonts configuration map. Obviously only user values should take precedence over those. [1]: https://github.com/odoo/odoo/commit/7be1429656af3c96ac30caed28a27f5b9590009f Forward-Port-Of: odoo/odoo#56372
In some conditions, such as the use case shown on: https://github.com/guewen/odoo-reproduce-issues/blob/compute-qty-at-date/compute_qty_at_date/models/sale_order_line.py The order of the computations can make that we have a line without product_id (we come from an onchange because we removed the product form the line), but 'display_qty_widget' is not yet recomputed. Not checking if we have a product_id means we can end up with 'grouped_lines' that contains an entry for the line, but th
Original PR description
In some conditions, such as the use case shown on: https://github.com/guewen/odoo-reproduce-issues/blob/compute-qty-at-date/compute_qty_at_date/models/sale_order_line.py The order of the computations…
In some conditions, such as the use case shown on: https://github.com/guewen/odoo-reproduce-issues/blob/compute-qty-at-date/compute_qty_at_date/models/sale_order_line.py The order of the computations can make that we have a line without product_id (we come from an onchange because we removed the product form the line), but 'display_qty_widget' is not yet recomputed. Not checking if we have a product_id means we can end up with 'grouped_lines' that contains an entry for the line, but then 'product_qties' does not contain the product the dict comprehension that builds the dictionary 'qties_per_product' fails with a KeyError. Description of the issue/feature this PR addresses: I wrote a minimal module to reproduce the issue: https://github.com/guewen/odoo-reproduce-issues/tree/compute-qty-at-date Once the module installed, choosing then emptying the field 'product_id' on a sale order line cause the error. The only thing the module does is adding a new dependency on the compute method "SaleOrderLine._compute_qty_at_date" and call super. The full use case is in the OCA module "sale_partner_delivery_window" (https://github.com/OCA/sale-workflow/pull/1101/files#diff-94a37c2999243e8e8faf634e2cbf669aR119-R122). opw 2273768 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#52669
Create an invoice I with a tax T on an invoice line. Validate Archive T Create the credit note from I Traceback will occur because the archived value is not copied on the reversal, causing issue when matching data opw-2320472 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56223
Original PR description
Create an invoice I with a tax T on an invoice line. Validate Archive T Create the credit note from I Traceback will occur because the archived value is not copied on the reversal, causing issue when matching data opw-2320472 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56223
Bug produced in calendar refactor task, ------------------------------------------ Task Id: https://www.odoo.com/web#id=2126717&action=333&active_id=965&model=project.task&view_type=form&cids=2&menu_id=4720 Commit: https://github.com/odoo/odoo/pull/42031/commits/6bafd7c677d016e82473f01bd0a3381ac3b24bbd Purpose =========== Before, when you try to change 'start' date by future date without changing duration (which is set to 00:00 by default) will call onchange method '_compute_stop' bu
Original PR description
Bug produced in calendar refactor task, ------------------------------------------ Task Id:…
Bug produced in calendar refactor task, ------------------------------------------ Task Id: https://www.odoo.com/web#id=2126717&action=333&active_id=965&model=project.task&view_type=form&cids=2&menu_id=4720 Commit: https://github.com/odoo/odoo/pull/42031/commits/6bafd7c677d016e82473f01bd0a3381ac3b24bbd Purpose =========== Before, when you try to change 'start' date by future date without changing duration (which is set to 00:00 by default) will call onchange method '_compute_stop' but didn't set 'stop' date, because duration is unchanged and that skip the block of code in which 'stop' date is updated. same issue while selecting 'allday' selecting future date in 'start' field and then click on 'allday' checkbox called onchange '_compute_stop' method, but didn't update 'stop' field. so however you select any dates in 'start_date' and 'stop_date' field, it always generate server error with old dates. steps to reproduce issue ------------------------ selecting allday: - Goto calendar app - In meeting list view click on create - set start date of future - select allday - then set End date greater than start date - try to save record without selecting allday: - select start date of future - try to save record After this commit, -------------------- these two issues are fixed and selecting 'All day' is not breaking the flow of selecting 'start_date' and 'stop_date'. Task Id: 2299212 Forward-Port-Of: odoo/odoo#54673
task-2323670 Forward-Port-Of: odoo/odoo#56243
Original PR description
task-2323670 Forward-Port-Of: odoo/odoo#56243
The mega-menu inside "+" menu (that contains items that do not fit on one line) could not be used at all. This is because we only managed normal dropdown-menu (ul) and not mega menu (div.o_mega_menu). But once the menu is shown, there is an issue because the two main widgets are column on "lg" breakpoint, and inside the menu there is no width but we might still be on lg breakpoint. So this commit also try to reset col values (max-width and flex) as is the case in mobile view (because "col-lg"
Original PR description
The mega-menu inside "+" menu (that contains items that do not fit on one line) could not be used at all. This is because we only managed normal dropdown-menu (ul) and not mega menu (div.o_mega_menu). But once the menu is shown, there is an issue because the two main widgets are column on "lg" breakpoint, and inside the menu there is no width but we might still be on lg breakpoint. So this commit also try to reset col values (max-width and flex) as is the case in mobile view (because "col-lg" are not applied). opw-2313019 Forward-Port-Of: odoo/odoo#56367
Forward-Port-Of: odoo/odoo#56418
Original PR description
Forward-Port-Of: odoo/odoo#56418
… has an error - When an edi.document has an error and thus does not have an attachment, trying to send the invoice by mail would cause a crash Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56428
Original PR description
… has an error - When an edi.document has an error and thus does not have an attachment, trying to send the invoice by mail would cause a crash Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56428
* `read_group` usage instead of `search`, `sum` and/or `len` * `len(search)` --> `search_count` -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53053
Original PR description
* `read_group` usage instead of `search`, `sum` and/or `len` * `len(search)` --> `search_count` -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53053
* Replace `len(search)` by `search_count` for better performance. Enterprise counterpart of https://github.com/odoo/odoo/pull/53053 Forward-Port-Of: odoo/enterprise#11299
Original PR description
* Replace `len(search)` by `search_count` for better performance. Enterprise counterpart of https://github.com/odoo/odoo/pull/53053 Forward-Port-Of: odoo/enterprise#11299
…r walls The commit adds the support to search for the favorited tweets of a specific account. Currently, it's only possible to use the regular twitter search that does not allow it. This is mainly a requirement for this year's online Odoo Experience where we want to be able to search for the favorited tweets of the Odoo account. Task ID 2325137 Side note: this is a naïve and minimalist implementation for the stable branch. There are probably many ways to implement this better, e
Original PR description
…r walls The commit adds the support to search for the favorited tweets of a specific account. Currently, it's only possible to use the regular twitter search that does not allow it. This is mainly a requirement for this year's online Odoo Experience where we want to be able to search for the favorited tweets of the Odoo account. Task ID 2325137 Side note: this is a naïve and minimalist implementation for the stable branch. There are probably many ways to implement this better, especially on the functional point of view, but it would quickly require more code / more fields. Forward-Port-Of: odoo/enterprise#12603
Before this commit, calendar appointment type form view had a unnecessary `<div class="oe_button_box" /> ` within an another button box. As a result, css rules did not apply correctly, resulting in a display glitch After this commit, there is no glitch task-2299523 Forward-Port-Of: odoo/enterprise#12611
Original PR description
Before this commit, calendar appointment type form view had a unnecessary `<div class="oe_button_box" /> ` within an another button box. As a result, css rules did not apply correctly, resulting in a display glitch After this commit, there is no glitch task-2299523 Forward-Port-Of: odoo/enterprise#12611
Steps to reproduce Enable optional products in sale order Make a sale order with optional products for a portal customer with taxcloud fiscal position. Validate the order. Tax will be calculated on the sol. Access the sale order as the portal user. Add the optional product, verify the order and pay. The optional product will get the taxcloud data AFTER the order has been verified and possibly paid. As this should not occur this add the override
Original PR description
Steps to reproduce
Enable optional products in sale order
Make a sale order with optional products for a portal customer
with taxcloud fiscal position. Validate the order.
Tax will be calculated on the sol.
Access the sale order as the portal user.
Add the optional product, verify the order and pay.
The optional product will get the taxcloud data
AFTER the order has been verified and possibly paid. As this should not
occur this add the override to calculate taxcloud data right after
adding the optional product
opw-2310614
Co-authored-by: agr-odoo <agr@odoo.com>
Forward-Port-Of: odoo/enterprise#12499
Forward-Port-Of: odoo/enterprise#12474Improve onboarding tour: * Prevent SignItems from being rotated while dragged task-2322806 Forward-Port-Of: odoo/enterprise#12544
Original PR description
Improve onboarding tour: * Prevent SignItems from being rotated while dragged task-2322806 Forward-Port-Of: odoo/enterprise#12544
Improve social menu computation (forward port issue after 166e251286f6b78ad07f110df52bc0ba8304e7e4). See odoo/odoo#56340 Forward-Port-Of: odoo/enterprise#12604
Original PR description
Improve social menu computation (forward port issue after 166e251286f6b78ad07f110df52bc0ba8304e7e4). See odoo/odoo#56340 Forward-Port-Of: odoo/enterprise#12604
This commit fixes glitches when switching menus. Indeed agenda is not correctly taken into account, meaning it could get duplicated. Moreover track was constantly coming back as True event when not wanted. Behavior is: when setting website menu, force it to True, otherwise let users defined its value. Agenda is part of track menu so fix its declaration in _track and _track_online methods. Task ID-2314778 (event online fixes) PR odoo/odoo#56254 PR odoo/entreprise#12558 Forward-Port-O
Original PR description
This commit fixes glitches when switching menus. Indeed agenda is not correctly taken into account, meaning it could get duplicated. Moreover track was constantly coming back as True event when not wanted. Behavior is: when setting website menu, force it to True, otherwise let users defined its value. Agenda is part of track menu so fix its declaration in _track and _track_online methods. Task ID-2314778 (event online fixes) PR odoo/odoo#56254 PR odoo/entreprise#12558 Forward-Port-Of: odoo/enterprise#12558
Task: https://www.odoo.com/web#id=2295939&action=4043&model=project.task&view_type=form&cids=2&menu_id=4720 Forward-Port-Of: odoo/enterprise#12304 Forward-Port-Of: odoo/enterprise#12298
Original PR description
Task: https://www.odoo.com/web#id=2295939&action=4043&model=project.task&view_type=form&cids=2&menu_id=4720 Forward-Port-Of: odoo/enterprise#12304 Forward-Port-Of: odoo/enterprise#12298