Purpose ======= Get rid of the cron. Always have an up to date frequency table to compute lead probability. Clean PLS code and ensure to remove unnecessary code Specifications ============== We disable the cron: - We increment won and lost count for lead PLS params from frequency table at each won/lost - The complete set of leads won't be recomputed anymore every day - A lead probability will only be recomputed if one of the PLS parameter will be modified (stage_id, team_id + the

Purpose
=======

Get rid of the cron.
Always have an up to date frequency table to compute lead probability.
Clean PLS code and ensure to remove unnecessary code

Specifications
==============

We disable the cron:
- We increment won and lost count for lead PLS params from frequency table at each won/lost
- The complete set of leads won't be recomputed anymore every day
- A lead probability will only be recomputed if one of the PLS parameter will be modified (stage_id, team_id + the ones checked in settings)
- No more onboarding phase : as frequency table is always up to date and only the modified leads are recomputed, we can drop this.
     (So even on onboarding, winning or losing a lead won't impact other leads, except the ones we modify manually afterwards)
- We add an option to force the recompute of all the lead probabilities (kind of reset) in the settings.
- When changing the PLS start date -> recompute all lead probabilities. (as the reference base has changed)

The cron has been disabled by default.
Users can now choose to reactivate it if they want to continue updating their
lead probabilities on a daily basis.

Code have been reorganised for better structure and understanding.
Some code parts have been factorised to be usable in both Live Increment and
Full Rebuild mode.

Task ID : 2254543
original Master PR : #51030

Forward-Port-Of: odoo/odoo#57635
Forward-Port-Of: odoo/odoo#55718

Before this commit, the design of the agenda was broken on Firefox, as the 'height: 0' property on td was ignored in Chrome and not in Firefox. Probably a remnant that was not removed. After this commit, both browser are displaying the same design. Task ID: 2337855 Forward-Port-Of: odoo/odoo#57515

Before this commit, the design of the agenda was broken on Firefox, as the
'height: 0' property on td was ignored in Chrome and not in Firefox.
Probably a remnant that was not removed.

After this commit, both browser are displaying the same design.

Task ID: 2337855

Forward-Port-Of: odoo/odoo#57515

As of Python 3.8 the digestmode arg from hmac.new is not optional anymore (see https://docs.python.org/3/library/hmac.html). This aims to keep the previous behavior in stable (11.0 to saas-13.3) while making it compatible with 3.8. Future versions shouldn't have this issue since 1c7c837 introduces a handler with explicit digestmode in saas-13.4. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57263

As of Python 3.8 the digestmode arg from hmac.new
is not optional anymore (see https://docs.python.org/3/library/hmac.html).
This aims to keep the previous behavior in stable (11.0 to saas-13.3)
while making it compatible with 3.8.

Future versions shouldn't have this issue since 1c7c837 introduces
a handler with explicit digestmode in saas-13.4.


--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#57263

[FIX] *stock*: fix date_deadline of stock move date_deadline of the stock move has been reviewed: - Now, it represents the datetime when the operation must be done to be in time for the uppest document (SO/PO/MO/RR). - At the creation of stock move the date_deadline is computed in the same way than the sheduled date expected that it is not include security days (inverse the logic for PO). - When we update the delivery date (or lead time) of SO (or PO). The deadline of related stock mo

[FIX] *stock*: fix date_deadline of stock move

date_deadline of the stock move has been reviewed:
- Now, it represents the datetime when the operation must
be done to be in time for the uppest document (SO/PO/MO/RR).
- At the creation of stock move the date_deadline is computed in the same way
than the sheduled date expected that it is not include security days 
(inverse the logic for PO).
- When we update the delivery date (or lead time) of SO (or PO).
The deadline of related stock move is updated and the delta is propagate
between origin and dest moves.

[IMP] (sale_)stock,mrp: improve forcasted report.

- Add a minus before quanity if it describes a output move.
- Remove intermediate section "Pending Incoming Documents" and
"Pending Outgoing Documents". Change other label to be more descriptive.

[IMP] (sale_)stock: review forecasted information

Remove the json_forecast of the sale order line,
it was a duplicate of information with the qty_at_date_widget.
But improve this one:
- Use the forecasted move information in case of confirmed SO.
- Change the icon (i) to chart.
- Link to the forcasted change to target new forcasted report
(Unfortunately we loose the feature to see components product forcasted
of a kit)
- Change information print in the popover in case of confirmed SO.

Also refactor the json_forcasted of `stock.move` into multiple fields
to avoid to dump/loads for other model who needed the forcasted data.

task-2324039

Forward-Port-Of: odoo/odoo#56425

Add the address in purchase protal so that when in a multiple company environment, the user can see which company the purchase order comes from. Task 2328169 PR #57422 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57422

Add the address in purchase protal so that when in a multiple company
environment, the user can see which company the purchase order comes
from.

Task 2328169
PR #57422





--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#57422

Task: <a href="https://www.odoo.com/web?#action=4043&cids=2&id=2307262&menu_id=4720&model=project.task&view_type=form">2307262</a> Forward-Port-Of: odoo/odoo#57629 Forward-Port-Of: odoo/odoo#55571

Task: <a href="https://www.odoo.com/web?#action=4043&cids=2&id=2307262&menu_id=4720&model=project.task&view_type=form">2307262</a>

Forward-Port-Of: odoo/odoo#57629
Forward-Port-Of: odoo/odoo#55571

Due to the structure of this template, there is a lack of vertical spacing between the menu items and the other components. The problem is more visible after selecting some styles using the "Menu Style" option. Before: <img width="1428" alt="Screenshot 2020-09-04 at 15 44 31" src="https://user-images.githubusercontent.com/7629949/92246300-dc499800-eec5-11ea-8298-6372c13b6103.png"> After: <img width="1427" alt="Screenshot 2020-09-04 at 15 36 48" src="https://user-images.githubusercontent.

Due to the structure of this template, there is a lack of vertical spacing between the menu items and the other components. The problem is more visible after selecting some styles using the "Menu Style" option.

Before:
<img width="1428" alt="Screenshot 2020-09-04 at 15 44 31" src="https://user-images.githubusercontent.com/7629949/92246300-dc499800-eec5-11ea-8298-6372c13b6103.png">

After:
<img width="1427" alt="Screenshot 2020-09-04 at 15 36 48" src="https://user-images.githubusercontent.com/7629949/92246303-dce22e80-eec5-11ea-8cf5-325b6023d161.png">

task-2312878

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#57102

Up to Odoo 13.0, the windows setup is 32 bits and embeds an old postgresql 9.5 32 bits version too. With this commit, the postgresql server is no longer embedded in the resulting setup file. Instead, if the user choose to install the postgresql server, the 12.4 version is downloaded from the official site (version 10.14 in the case of a 32 bits windows). Also, the Python target achitecture is choosen based on the Windows system on which Odoo is installed. This imply changes on the

Up to Odoo 13.0, the windows setup is 32 bits and embeds an old
postgresql 9.5 32 bits version too.

With this commit, the postgresql server is no longer embedded in the
resulting setup file. Instead, if the user choose to install the
postgresql server, the 12.4 version is downloaded from the official site
(version 10.14 in the case of a 32 bits windows).

Also, the Python target achitecture is choosen based on the Windows
system on which Odoo is installed.

This imply changes on the KVM images used to build the installer:

    - The Windows system on the KVM as to be 64 bits.
    - A 32 bits WinPython version must be in `c:/odoobuild/WinPy32`
    - A 64 bits WinPyhton version must be in `c:/odoobuild/WinPy64`

A little bit of cleaning also comes with this commit to get rid of the
old `openerp` references.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#57155

saas-13.5 version of odoo/odoo@15f2bbd40a70d9d The tests must be only imported in a test context, not in a running context. Since 92a7f8c a new test requirement was added but it should not be necessary to run a module, only to execute the tests. Forward-Port-Of: odoo/odoo#57718

saas-13.5 version of odoo/odoo@15f2bbd40a70d9d

The tests must be only imported in a test context, not in a running
context.
Since 92a7f8c a new test requirement was added but it should
not be necessary to run a module, only to execute the tests.

Forward-Port-Of: odoo/odoo#57718

Remove Fold/unfold from the tab 'Style', as we have enough vertical space. It was not planned by the designers. There was a misunderstanding. For the UX it's better to remove it from there. taks-2327111 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56665

Remove Fold/unfold from the tab 'Style', as we have enough vertical
space. It was not planned by the designers. There was a
misunderstanding. For the UX it's better to remove it from there.

taks-2327111

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#56665

opw-[2253532](https://www.odoo.com/web#active_id=2253532&cids=1&id=2253532&model=project.task&menu_id=) It was removed in saas-12.2 to simplify the model as it was judged useless, but it wasnt. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57720 Forward-Port-Of: odoo/odoo#57537

opw-[2253532](https://www.odoo.com/web#active_id=2253532&cids=1&id=2253532&model=project.task&menu_id=)

It was removed in saas-12.2 to simplify the model as it was judged
useless, but it wasnt.





--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#57720
Forward-Port-Of: odoo/odoo#57537

Without this you have to overwrite the entire function. PR note: necessary to overload this in an internal module. Forward-Port-Of: odoo/odoo#57584

Without this you have to overwrite the entire function.

PR note: necessary to overload this in an internal module.

Forward-Port-Of: odoo/odoo#57584

Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57760

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#57760

This simply makes it less easy to screw up a database by preventing all users to do their daily tasks. Forward-Port-Of: odoo/odoo#57740

This simply makes it less easy to screw up a database by preventing all
users to do their daily tasks.

Forward-Port-Of: odoo/odoo#57740

This test ensures that method `Callbacks.run` is re-entrant, i.e., it can be called from a callback being run. The behavior is to execute the remaining callbacks, and then resume the current one. This completes https://github.com/odoo/odoo/pull/57469. Forward-Port-Of: odoo/odoo#57765

This test ensures that method `Callbacks.run` is re-entrant, i.e., it
can be called from a callback being run.  The behavior is to execute the
remaining callbacks, and then resume the current one.

This completes https://github.com/odoo/odoo/pull/57469.

Forward-Port-Of: odoo/odoo#57765

…empty Before this commit, after "autofilling" a pivot formula outside the pivot, the autofill was displayed but empty. This commit fixes this behavior. Forward-Port-Of: odoo/enterprise#13136

…empty

Before this commit, after "autofilling" a pivot formula outside the pivot, the autofill was displayed but empty.
This commit fixes this behavior.

Forward-Port-Of: odoo/enterprise#13136

The PAC (Finkok for now) was added the next validation on the CFDI generation (SAT disposition): The schemaLocation in the CFDI must have the URL and XSD of all elements in the CFDI. Before of this change, the CFDI when the external trade is installed have the next structure: ``` xmlns:cce11="http://www.sat.gob.mx/ComercioExterior11" xsi:schemaLocation="http://www.sat.gob.mx/cfd/3 http://www.sat.gob.mx/sitio_internet/cfd/3/cfdv33.xsd" ``` And when you try to stamp the CFDI ge

The PAC (Finkok for now) was added the next validation on the CFDI
generation (SAT disposition):

  The schemaLocation in the CFDI must have the URL and XSD of all elements in the CFDI.

Before of this change, the CFDI when the external trade is installed
have the next structure:

```
xmlns:cce11="http://www.sat.gob.mx/ComercioExterior11"
xsi:schemaLocation="http://www.sat.gob.mx/cfd/3
http://www.sat.gob.mx/sitio_internet/cfd/3/cfdv33.xsd"
```

And when you try to stamp the CFDI gets the next error:
Code: 738
Message: El schema http://www.sat.gob.mx/ComercioExterior11 no está definido

The correct way is:
```
xmlns:cce11="http://www.sat.gob.mx/ComercioExterior11"
xsi:schemaLocation="http://www.sat.gob.mx/cfd/3
http://www.sat.gob.mx/sitio_internet/cfd/3/cfdv33.xsd
http://www.sat.gob.mx/ComercioExterior11
http://www.sat.gob.mx/sitio_internet/cfd/ComercioExterior11/ComercioExterior11.xsd"
```

![Screen Shot 2020-08-26 at 10 35 20](https://user-images.githubusercontent.com/7606656/91325775-355c5200-e789-11ea-9372-915b29ce6283.png)

Forward-Port-Of: odoo/enterprise#12704
Forward-Port-Of: odoo/enterprise#12695

Issue - Install "CRM" & "Studio" modules - Go to Contacts app - With studio, add a many2one field to 'Lead/Opportunity' model - Go to CRM app - Open any Lead - With Studio, add a one2many field to "Lead/Opportunity (res.partner)" model - Try to edit form view of the new field. Traceback raised. Cause Ambiguous case when both models have same selection field name but different values. In case of crm.lead & res.partner models, they both have 'type' field, but 'res.

Issue

	- Install "CRM" & "Studio" modules
	- Go to Contacts app
	- With studio, add a many2one field to 'Lead/Opportunity' model
	- Go to CRM app
	- Open any Lead
	- With Studio, add a one2many field to "Lead/Opportunity (res.partner)" model
	- Try to edit form view of the new field.

	Traceback raised.

Cause

	Ambiguous case when both models have same selection field name
	but different values.
	In case of crm.lead & res.partner models, they both have 'type' field, but
	'res.partner' does not have 'opportunity' value available.
	Context is propagaded, therefore, {"default_type": "opportunity"}
        stays in context.

Solution

	Clean context when opening x2many editor.

opw-2313485

Forward-Port-Of: odoo/enterprise#13216
Forward-Port-Of: odoo/enterprise#13037

Open the pivot properties sidepanel of a pivot containing the "Count" measure. => crash Forward-Port-Of: odoo/enterprise#12958

Open the pivot properties sidepanel of a pivot containing the "Count" measure.
=> crash

Forward-Port-Of: odoo/enterprise#12958

Add forecast_expected_date to the computation of _compute_qty_at_date to avoid any errors. task-2324039 Forward-Port-Of: odoo/enterprise#13063

Add forecast_expected_date to the computation of _compute_qty_at_date
to avoid any errors.

task-2324039

Forward-Port-Of: odoo/enterprise#13063

Since a change in 13.3 consolidation reports headers have been broken, the html being not taken into account. This commit will add support for custom template for header cells in reports and use them to fix the issue. Task id #2337826 Forward-Port-Of: odoo/enterprise#13193 Forward-Port-Of: odoo/enterprise#13162

Since a change in 13.3 consolidation reports headers have been broken, the html being not taken into account.

This commit will add support for custom template for header cells in reports and use them to fix the issue.

Task id #2337826

Forward-Port-Of: odoo/enterprise#13193
Forward-Port-Of: odoo/enterprise#13162

Task: <a href="https://www.odoo.com/web#id=2320549&action=4043&model=project.task&view_type=form&cids=2&menu_id=4720">2320549</a> Forward-Port-Of: odoo/enterprise#13084

Task: <a href="https://www.odoo.com/web#id=2320549&action=4043&model=project.task&view_type=form&cids=2&menu_id=4720">2320549</a>

Forward-Port-Of: odoo/enterprise#13084