Saturday, September 19, 2020
4 changes · master
Miscellaneous changes
**Bug description:** Installing Invoicing on a database whose company is configured in the SEPA zone, results in installing Accounting **Steps to reproduce on the Runbot:** - Start from a base enterprise database - Go to Settings > Users & Companies > Companies and configure the address of MyCompany to the SEPA zone (e.g. Belgium) - Go to Apps and install Invoicing - The Accounting application has been installed **Explanation:** The module `account_sepa` depends on `account_bat
Original PR description
**Bug description:** Installing Invoicing on a database whose company is configured in the SEPA zone, results in installing Accounting **Steps to reproduce on the Runbot:** - Start from a base…
**Bug description:** Installing Invoicing on a database whose company is configured in the SEPA zone, results in installing Accounting **Steps to reproduce on the Runbot:** - Start from a base enterprise database - Go to Settings > Users & Companies > Companies and configure the address of MyCompany to the SEPA zone (e.g. Belgium) - Go to Apps and install Invoicing - The Accounting application has been installed **Explanation:** The module `account_sepa` depends on `account_batch_payment`, which depends on `account_accountant`. The `post_init_hook` of `account`, `_auto_install_l10n`, adds the `account_sepa` module to the installation if the `country_code` of the company is in the SEPA zone. The same side-effect is observed with `account_bank_statement_import_camt` which depends on `account_bank_statement_import`, which depends on `account_accountant`. The fix is to remove the installation of these modules from the `post_init_hook` of the module `account`, and add them to a new `post_init_hook` of the module `account_accountant`, that will be in a PR in the enterprise project. Forward-Port-Of: odoo/odoo#57820
Write guidelines on how to write secure code and avoid commons mistakes. Update outdated information and move existing security guidelines to the same section. Based on [security checklist](https://drive.google.com/file/d/1-BKF6kcVO-vQapH5dpSeUI7_40wDHtLa/view) Forward-Port-Of: odoo/odoo#43463
Original PR description
Write guidelines on how to write secure code and avoid commons mistakes. Update outdated information and move existing security guidelines to the same section. Based on [security checklist](https://drive.google.com/file/d/1-BKF6kcVO-vQapH5dpSeUI7_40wDHtLa/view) Forward-Port-Of: odoo/odoo#43463
…gration A statement line can't have a zero amount except after a migration. In that case, the residual amount of the statement line is also zero and then, the line having the suspense account has a balance of zero. When opening the bank reconciliation widget, it leads to a float division by zero because we try to compute the paid percentage of the statement line. task: 2341850 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: o
Original PR description
…gration A statement line can't have a zero amount except after a migration. In that case, the residual amount of the statement line is also zero and then, the line having the suspense account has a balance of zero. When opening the bank reconciliation widget, it leads to a float division by zero because we try to compute the paid percentage of the statement line. task: 2341850 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58052 Forward-Port-Of: odoo/odoo#57986
**Bug description:** Installing Invoicing on a database whose company is configured in the SEPA zone, results in installing Accounting **Steps to reproduce on the Runbot:** - Start from a base enterprise database - Go to Settings > Users & Companies > Companies and configure the address of MyCompany to the SEPA zone (e.g. Belgium) - Go to Apps and install Invoicing - The Accounting application has been installed **Explanation:** The module `account_sepa` depends on `account_bat
Original PR description
**Bug description:** Installing Invoicing on a database whose company is configured in the SEPA zone, results in installing Accounting **Steps to reproduce on the Runbot:** - Start from a base…
**Bug description:** Installing Invoicing on a database whose company is configured in the SEPA zone, results in installing Accounting **Steps to reproduce on the Runbot:** - Start from a base enterprise database - Go to Settings > Users & Companies > Companies and configure the address of MyCompany to the SEPA zone (e.g. Belgium) - Go to Apps and install Invoicing - The Accounting application has been installed **Explanation:** The module `account_sepa` depends on `account_batch_payment`, which depends on `account_accountant`. The `post_init_hook` of account, `_auto_install_l10n`, adds the `account_sepa` module to the installation if the `country_code` of the company is in the SEPA zone. The same side-effect is observed with `account_bank_statement_import_camt` which depends on `account_bank_statement_import`, which depends on `account_accountant`. This commit adds a new `post_init_hook` in the module account_accountant, that will install these two modules if the country of the company satisfies the SEPA conditions. See also: odoo/odoo#57820 Forward-Port-Of: odoo/enterprise#13264