Monday, September 21, 2020
23 changes · master
Enhancements to existing features
Point of Sale configuration screens now replace individual save buttons beside module options with explanatory messages. This helps users understand that changing these options and saving the form will reload the page, reducing confusion during setup.
Original PR description
Replace save buttons in each module field in pos.config with a message. Saving the pos.config form when a module_ or group_ field is modified will reload the page.
Resolved issues and error corrections
Point of Sale messages now use the same order label as the linked record, avoiding mismatched references in the chatter. This makes order communication clearer for users reviewing activity history.
Original PR description
We are using the reference to `pos.order` on adding the message to chatter, While we were using the name in the message. With this commit, we make record name consistent with the record reference being added to the chatter. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Solves https://github.com/odoo/odoo/issues/56803 Use case: 1) Create accounts ACC TAX A, ACC TAX B, with reconcile = True, internal_type = other 2) Create Tax A, with tax_exigibilty = on_invoice and account_id = ACC TAX A, 20% 3) Create Tax B, with tax_exigibilty = on_payment and account_id = ACC TAX B and cash_basic_account_id = ACC TAX A, 20% 4) Create invoice A, account_id = Tax A, unit_price = 1000, Valide invoice 5) Create invoice B, account_id = Tax B, unit_price = 500, V
Original PR description
Solves https://github.com/odoo/odoo/issues/56803 Use case: 1) Create accounts ACC TAX A, ACC TAX B, with reconcile = True, internal_type = other 2) Create Tax A, with tax_exigibilty = on_invoice and…
Fixed an issue where the visual droplet cue could lag behind or point to the wrong signing button during guided document signing. This makes the signing tour clearer and reduces confusion for users completing documents.
Original PR description
Currently, when signing the document during the tour, the droplet animation don't follow correctly the button. So in this commit, when tip animation is in progress, droplet reposition method is not call continuously, that's why there is lag when sign element is at bottom of document, so added step option, now droplet have correctly follow the button, or appear after the button animation TaskID: 2296010
Solves https://github.com/odoo/odoo/issues/56803 Use case: 1) Create accounts ACC TAX A, ACC TAX B, with reconcile = True, internal_type = other 2) Create Tax A, with tax_exigibilty = on_invoice and account_id = ACC TAX A, 20% 3) Create Tax B, with tax_exigibilty = on_payment and account_id = ACC TAX B and cash_basic_account_id = ACC TAX A, 20% 4) Create invoice A, account_id = Tax A, unit_price = 1000, Valide invoice 5) Create invoice B, account_id = Tax B, unit_price = 500, Valide invoice, 6) Register full payment for invoice B. The cash basis tax creates a miscellaneous operation MISC A, containing a line on ACC TAX A. 7) Create a mis operation MISC TVA, like this: line 1 : account_id = ACC TAX A, credit = 300 line 2 : account_id = 401100, debit = 300 8) Reconcile the following move lines: line of MISC A with account ACC TAX A (300) line of invoice A with account ACC TAX A (200) line of MISC TVA with account ACC TAX A (100) ==> When doing that, not full reconcile object was created between the reconciled lines, while it should have been. Forward-Port-Of: odoo/odoo#58051 Forward-Port-Of: odoo/odoo#57495
This PR attempts to update the old "website.ThemePreview.Loader" style by integrating a loading animation when theme is being installed (by click on "START NOW" button in theme form view). The same loading effect will be added when user click on 'USE THIS THEME' button in theme kanban view. task-2338062 Forward-Port-Of: odoo/odoo#57682
Original PR description
This PR attempts to update the old "website.ThemePreview.Loader" style by integrating a loading animation when theme is being installed (by click on "START NOW" button in theme form view). The same loading effect will be added when user click on 'USE THIS THEME' button in theme kanban view. task-2338062 Forward-Port-Of: odoo/odoo#57682
- Remove fields `json_forecast` of `stock.move` - Remove fields `json_forecast` of `sale.order.line` Forward-Port-Of: odoo/odoo#58017
Original PR description
- Remove fields `json_forecast` of `stock.move` - Remove fields `json_forecast` of `sale.order.line` Forward-Port-Of: odoo/odoo#58017
task-2329096 Small details reported by fp/sbu -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58061
Original PR description
task-2329096 Small details reported by fp/sbu -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58061
We are are here facilitating the inheritance of the functions that create the reurn orders Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57788
Original PR description
We are are here facilitating the inheritance of the functions that create the reurn orders Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57788
Steps to reproduce the problem: * Set up multi company with A and B companies * Set up user UB connected to B company * Set up website to company A * Install eLearning app * With user UB go to the page: /profile/ranks_badges. The text writes: "Keep learning with B. Collect points on the forum ...". This is wrong, as the website is connected to company A. The text should be: "Keep learning with A. Collect points on the forum ..." -- I confirm I have signed the CLA and read the PR gu
Original PR description
Steps to reproduce the problem: * Set up multi company with A and B companies * Set up user UB connected to B company * Set up website to company A * Install eLearning app * With user UB go to the page: /profile/ranks_badges. The text writes: "Keep learning with B. Collect points on the forum ...". This is wrong, as the website is connected to company A. The text should be: "Keep learning with A. Collect points on the forum ..." -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#52976
Steps to reproduce the bug: - Create old click data in the `link_tracker_click` table or change your computer's current date to two weeks in the future. - Go to the stats page of the link tracker Bug: Backtrace on the stats of the link tracker. opw:2321377 Forward-Port-Of: odoo/odoo#57556
Original PR description
Steps to reproduce the bug: - Create old click data in the `link_tracker_click` table or change your computer's current date to two weeks in the future. - Go to the stats page of the link tracker Bug: Backtrace on the stats of the link tracker. opw:2321377 Forward-Port-Of: odoo/odoo#57556
The SELECT FOR UPDATE clause stopped concurent executions but did not prevent from writing on other rows. By doing a real UPDATE, we now have the desired behaviour with a SerializationFailure error. Related to https://github.com/odoo/odoo/pull/55930 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57809 Forward-Port-Of: odoo/odoo#57606
Original PR description
The SELECT FOR UPDATE clause stopped concurent executions but did not prevent from writing on other rows. By doing a real UPDATE, we now have the desired behaviour with a SerializationFailure error. Related to https://github.com/odoo/odoo/pull/55930 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57809 Forward-Port-Of: odoo/odoo#57606
This is a followup to #57826: turns out discuss isn't necessarily installed (who knew?), so the tour would break if mail was not explicitly installed alongside base, which is not great. So instead of opening discuss to try and fix the profile race condition, reload the *entire web client* by navigating to `/web`. Further discovery: async run functions don't actually do anything in tours, not sure where I got that, maybe used one for the convenience of `await` then the next time around
Original PR description
This is a followup to #57826: turns out discuss isn't necessarily installed (who knew?), so the tour would break if mail was not explicitly installed alongside base, which is not great. So instead of…
This is a followup to #57826: turns out discuss isn't necessarily installed (who knew?), so the tour would break if mail was not explicitly installed alongside base, which is not great. So instead of opening discuss to try and fix the profile race condition, reload the *entire web client* by navigating to `/web`. Further discovery: async run functions don't actually do anything in tours, not sure where I got that, maybe used one for the convenience of `await` then the next time around having decided to wipe any knowledge of tours I had, I figured it wasn't possible that tours were so stupid as to not support promises. So yeah, can't just return a "pending" promise in order to force the tour manager to wait until the page has reloaded to carry on, that doesn't work. Instead use marker classes. Also remove the `async run` I had in the rest of the file to avoid being misleading, use a marker class for the one step where it probably matters. Forward-Port-Of: odoo/odoo#58119
This commit changes the angle of the shapes blocks 03 and blocks 04 so that they're a multiple of 10 degrees, so that they match the angle of blocks 01 and blocks 02 task-2342180 Forward-Port-Of: odoo/odoo#58021
Original PR description
This commit changes the angle of the shapes blocks 03 and blocks 04 so that they're a multiple of 10 degrees, so that they match the angle of blocks 01 and blocks 02 task-2342180 Forward-Port-Of: odoo/odoo#58021
PURPOSE The sponsor ribbon wasn't displayed correctly at the bottom of event page and on the exhibitor page. SPECIFICATION The website_event_track_online and website_event_track_exhibitor apps used some incorrect classes name for displaying the ribbon. LINKS Task ID : 2323295 Forward-Port-Of: odoo/odoo#56917 Forward-Port-Of: odoo/odoo#56597
Original PR description
PURPOSE The sponsor ribbon wasn't displayed correctly at the bottom of event page and on the exhibitor page. SPECIFICATION The website_event_track_online and website_event_track_exhibitor apps used some incorrect classes name for displaying the ribbon. LINKS Task ID : 2323295 Forward-Port-Of: odoo/odoo#56917 Forward-Port-Of: odoo/odoo#56597
Allow creation of room for unpublished events for base users so that they can prepare all their rooms before releasing their event in the wild. TaskID:2339835 Forward-Port-Of: odoo/odoo#57799
Original PR description
Allow creation of room for unpublished events for base users so that they can prepare all their rooms before releasing their event in the wild. TaskID:2339835 Forward-Port-Of: odoo/odoo#57799
This is necessary when field dependencies are given by a callable. This functionality was broken with the support for an explicit parameter `depends` in the fields' definition, because the implementation could not distinguish between the field parameter `depends` and the `depends` evaluated from compute functions. The fix consists in storing the field parameter `depends` into `field._depends`, and the result of the setup into `field.depends`. Forward-Port-Of: odoo/odoo#58127 Forward-Po
Original PR description
This is necessary when field dependencies are given by a callable. This functionality was broken with the support for an explicit parameter `depends` in the fields' definition, because the implementation could not distinguish between the field parameter `depends` and the `depends` evaluated from compute functions. The fix consists in storing the field parameter `depends` into `field._depends`, and the result of the setup into `field.depends`. Forward-Port-Of: odoo/odoo#58127 Forward-Port-Of: odoo/odoo#58008
Checking the log of the runbot error, there is an extra `create_from_ui` rpc call for `restaurant.floor`. This is because when table T4 is clicked, it is still an `EditableTable`. It is possible that the full rendering after toggling edit mode isn't complete and the tour proceeds because it sees table T4 in the dom, when in fact the table we want to click should not be `EditableTable` instead a `TableWidget`. This is random because the tour may proceed as long at it sees the trigger elemen
Original PR description
Checking the log of the runbot error, there is an extra `create_from_ui` rpc call for `restaurant.floor`. This is because when table T4 is clicked, it is still an `EditableTable`. It is possible that the full rendering after toggling edit mode isn't complete and the tour proceeds because it sees table T4 in the dom, when in fact the table we want to click should not be `EditableTable` instead a `TableWidget`. This is random because the tour may proceed as long at it sees the trigger element, even if the owl rendering is not finished. In this commit, we make sure that we click the correct element which is an unselected table. So we check if table T4 is unselected before clicking table T4 to open the product screen. To reproduce, follow instructions here: https://gist.github.com/caburj/ef311076a24d898132ed9c6b99367581 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58131
Before this commit, the "to followers" message inside the chatter composer was missing. Fix also some padding issue. task-2280157 Forward-Port-Of: odoo/odoo#57193
Original PR description
Before this commit, the "to followers" message inside the chatter composer was missing. Fix also some padding issue. task-2280157 Forward-Port-Of: odoo/odoo#57193
Description of the issue/feature this PR addresses: Include CLA Corporate - Escodoo -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57273
Original PR description
Description of the issue/feature this PR addresses: Include CLA Corporate - Escodoo -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57273
task-2280308 Forward-Port-Of: odoo/odoo#53846
Original PR description
task-2280308 Forward-Port-Of: odoo/odoo#53846
Forward-Port-Of: odoo/enterprise#13390
Original PR description
Forward-Port-Of: odoo/enterprise#13390
Before this commit, the partner's name was used to register a device. The problem is that this is not a mandatory field and and therefore it can be null. From now on, we'll use the user's name or the login if there is no name. This change is safe because this value is only use on our own to recognize a user/device. We are doing this fix because of errors coming from our server. It's usually on migration databases. Forward-Port-Of: odoo/enterprise#13353 Forward-Port-Of: odoo/enterpris
Original PR description
Before this commit, the partner's name was used to register a device. The problem is that this is not a mandatory field and and therefore it can be null. From now on, we'll use the user's name or the login if there is no name. This change is safe because this value is only use on our own to recognize a user/device. We are doing this fix because of errors coming from our server. It's usually on migration databases. Forward-Port-Of: odoo/enterprise#13353 Forward-Port-Of: odoo/enterprise#13348
Currently, in the sign template, if there is no user image then its alternate message overlaps with the user's Email Id. In this commit, we fix this issue by applying proper margin and padding. Task-Id : 2325190 PR: #12787 Forward-Port-Of: odoo/enterprise#12787
Original PR description
Currently, in the sign template, if there is no user image then its alternate message overlaps with the user's Email Id. In this commit, we fix this issue by applying proper margin and padding. Task-Id : 2325190 PR: #12787 Forward-Port-Of: odoo/enterprise#12787