Tuesday, September 22, 2020
34 changes · master
Resolved issues and error corrections
This fixes an issue where manufacturing deadline calculations could apply the same date to multiple production records instead of calculating each one separately. Businesses get more accurate production planning dates, helping teams prioritize and schedule work correctly.
Original PR description
## Description of the issue/feature this PR addresses: compute the right value for each record ## Current behavior before PR: compute the same value for all records ## Desired behavior after PR is merged: compute the right value for each record -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
* override `onchange` in res.users in order to properly generate and send the reified group fields alongside the rest: while default_get sets them up, those fields then get stripped by the onchange machinery as they don't actually exist on the model * add a test to check for it * fix SSF in relation with the new default/onchange system - because fields may not actually exist on the record, `record_to_values` needs to `read` the record data rather than directly access the
Original PR description
* override `onchange` in res.users in order to properly generate and
send the reified group fields alongside the rest: while default_get
sets them up, those fields then get stripped by the onchange
machinery as they don't actually exist on the model
* add a test to check for it
* fix SSF in relation with the new default/onchange system
- because fields may not actually exist on the record,
`record_to_values` needs to `read` the record data rather than
directly access the recordset: the recordset likely will not
know about fake fields
- after the initial onchange has run the form must be filled with
falsy values in case the onchange has not sent defaults for
everything
- on creation, all fields in the form should be considered modified
Task 2341153
Forward-Port-Of: odoo/odoo#57987### Task 358 **Description of the issue/feature this PR addresses:** If a document type don't have AFIP code, like "FACTURAS Y COMPROBANTES DEL EXTERIOR" or "NOTAS DE CREDITO Y REEMBOLSOS DEL EXTERIOR", we don't have to validate the document number **Current behavior before PR:** When we create an vendor bill with document type "FACTURAS Y COMPROBANTES DEL EXTERIOR" or "NOTAS DE CREDITO Y REEMBOLSOS DEL EXTERIOR" and document number without the format "xxxxx-xxxxxxxx" we get a valida
Original PR description
### Task 358 **Description of the issue/feature this PR addresses:** If a document type don't have AFIP code, like "FACTURAS Y COMPROBANTES DEL EXTERIOR" or "NOTAS DE CREDITO Y REEMBOLSOS DEL EXTERIOR", we don't have to validate the document number **Current behavior before PR:** When we create an vendor bill with document type "FACTURAS Y COMPROBANTES DEL EXTERIOR" or "NOTAS DE CREDITO Y REEMBOLSOS DEL EXTERIOR" and document number without the format "xxxxx-xxxxxxxx" we get a validation error **Desired behavior after PR is merged:** In this cases any document number will be accepted -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56327
The method _compute_probability has a dynamic depends, that depends on the crm.pls_fields config parameter. When installing the DB, the depends is evaluated. If the config parameter is modified afterwards, the depends is not re-evaluated as the registry is not rebuilt. The result is that when modifying the config parameter, if an optional pls_field's value is modified on a record, the compute won't be triggered, as that pls_field is not in the compute's depends. This commit force to r
Original PR description
The method _compute_probability has a dynamic depends, that depends on the crm.pls_fields config parameter. When installing the DB, the depends is evaluated. If the config parameter is modified afterwards, the depends is not re-evaluated as the registry is not rebuilt. The result is that when modifying the config parameter, if an optional pls_field's value is modified on a record, the compute won't be triggered, as that pls_field is not in the compute's depends. This commit force to re-setup the registry after a modification (or the creation) of the crm.pls_fields config parameter, in order to force the depends of the _compute_probability method to be updated. Task ID: 2341829 Forward-Port-Of: odoo/odoo#57962
Previously, shape colors were stored in non-normalized form (eg, would use the color's name if it was a palette color), this caused some issues if you chose a palette color for a shape, then changed the palette: the wrong color would appear in the color picker because it would look use the color of the current palette instead of the color that was actually chosen. This commit also normalizes the case of color strings before comparing them, as this was causing some colors to be considere
Original PR description
Previously, shape colors were stored in non-normalized form (eg, would use the color's name if it was a palette color), this caused some issues if you chose a palette color for a shape, then changed the palette: the wrong color would appear in the color picker because it would look use the color of the current palette instead of the color that was actually chosen. This commit also normalizes the case of color strings before comparing them, as this was causing some colors to be considered non-default because of different capitalization. Forward-Port-Of: odoo/odoo#58026
Before this commit, buttons to remove checkboxes and buttons to re-order checkboxes were styled like button. Before:  After this commit, buttons are just icons. We also improve a little bit the design of the checkbox list (add space between elements and a light border between items in the checkbox list). After:  After this commit, buttons are just icons. We also improve a little bit the design of the checkbox list (add space between elements and a light border between items in the checkbox list). After:  task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58111
[FIX] stock: change icon of replenishment Use fa-area-chart instead of fa-info-circle [FIX] stock: fix empty forecasted report. When there was no data, the graph overlaps the empty table. Remove force height in css. Forward-Port-Of: odoo/odoo#58101
Original PR description
[FIX] stock: change icon of replenishment Use fa-area-chart instead of fa-info-circle [FIX] stock: fix empty forecasted report. When there was no data, the graph overlaps the empty table. Remove force height in css. Forward-Port-Of: odoo/odoo#58101
For foreign customers (out of Italy) who do not have a VAT number, "0000000" should be used as VAT code. opw-2325991 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57966
Original PR description
For foreign customers (out of Italy) who do not have a VAT number, "0000000" should be used as VAT code. opw-2325991 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57966
Add a cron to sync events in Microsoft calendar In Google and Microsoft calendar: remove 'sync with ...' button when the synchronization is already activated, and replace it by a badge. TaskID: 2329313 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57076
Original PR description
Add a cron to sync events in Microsoft calendar In Google and Microsoft calendar: remove 'sync with ...' button when the synchronization is already activated, and replace it by a badge. TaskID: 2329313 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57076
taskId 2338803 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57761
Original PR description
taskId 2338803 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57761
Forward-Port-Of: odoo/odoo#57975
Original PR description
Forward-Port-Of: odoo/odoo#57975
The developer documentation already has a search functionality via Sphinx if you use the right URL, but it was not exposed in the frontend. This commit ports the search bar from the user documentation. Original commits: Initial search bar (rim): https://github.com/odoo/documentation-user/commit/17fc4219bd24e8993fc5ab3c00d9979f87a45e84 Mobile and CSS fixes (kts): https://github.com/odoo/documentation-user/commit/52e49eda472963e929ec7b004eae20c514364403 I tested in both regular desktop a
Original PR description
The developer documentation already has a search functionality via Sphinx if you use the right URL, but it was not exposed in the frontend. This commit ports the search bar from the user…
The developer documentation already has a search functionality via Sphinx if you use the right URL, but it was not exposed in the frontend. This commit ports the search bar from the user documentation. Original commits: Initial search bar (rim): https://github.com/odoo/documentation-user/commit/17fc4219bd24e8993fc5ab3c00d9979f87a45e84 Mobile and CSS fixes (kts): https://github.com/odoo/documentation-user/commit/52e49eda472963e929ec7b004eae20c514364403 I tested in both regular desktop and mobile layouts, to verify that the button issue kts mentioned both reproduced and was fixed. Both the user and dev search bars have an issue where their font size is 2px greater than the other buttons on the nav bar. With my current knowledge level I could fix that by hardcoding the font sizes inside the elements, but a cleaner solution would be better, so I've left it as is and might revisit later when I have a better understanding.   I've targeted 13.0 because I noticed both of the original commits appeared to target the current stable version. Let me know if 11.0 or master would be more appropriate. https://www.odoo.com/web?debug=1#id=2340175&menu_id=5195&model=project.task&view_type=form Forward-Port-Of: odoo/odoo#56467
Forward-Port-Of: odoo/odoo#58192
Original PR description
Forward-Port-Of: odoo/odoo#58192
Since a recent [refactoring](https://github.com/odoo/odoo/pull/55995) is merged, few compute methods are being called at record creation, and throws traceback because of newID. This commit fixes the traceback by improving the compute methods and thus enable users to create records of slide contents and forums. Note - compute fields should be assigned a value, and so we update the recordset with default values while creation. See the linked PR for more information. Task - 2325605
Original PR description
Since a recent [refactoring](https://github.com/odoo/odoo/pull/55995) is merged, few compute methods are being called at record creation, and throws traceback because of newID. This commit fixes the traceback by improving the compute methods and thus enable users to create records of slide contents and forums. Note - compute fields should be assigned a value, and so we update the recordset with default values while creation. See the linked PR for more information. Task - 2325605 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56573
Before this commit the redirect message was not added at the end of the countdown if the content-with option of the snippet was not Regular It was because we did an append on the '.container' class to add this message and that class is replaced when we change the content-with. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at
Original PR description
Before this commit the redirect message was not added at the end of the countdown if the content-with option of the snippet was not Regular It was because we did an append on the '.container' class to add this message and that class is replaced when we change the content-with. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55537
According to the Spanish VAT reporting (mod 303), this commit has been created to fix some inconsistencies in section number 60. Exempt taxes coming from training, for example, wouldn't be taken in consideration anymore. closes https://github.com/OCA/l10n-spain/issues/1300 @pedrobaeza That's my first approach. Looking forward for your comments. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58184 Forward-Port-Of: o
Original PR description
According to the Spanish VAT reporting (mod 303), this commit has been created to fix some inconsistencies in section number 60. Exempt taxes coming from training, for example, wouldn't be taken in consideration anymore. closes https://github.com/OCA/l10n-spain/issues/1300 @pedrobaeza That's my first approach. Looking forward for your comments. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58184 Forward-Port-Of: odoo/odoo#57724
When IAP reply when an error for partner_autocomplete, show the error instead of thinking `error` and `error_msg` are res.partner data which leads to subsequent errors. opw-2337763 opw-2341473 Forward-Port-Of: odoo/odoo#58147 Forward-Port-Of: odoo/odoo#58024
Original PR description
When IAP reply when an error for partner_autocomplete, show the error instead of thinking `error` and `error_msg` are res.partner data which leads to subsequent errors. opw-2337763 opw-2341473 Forward-Port-Of: odoo/odoo#58147 Forward-Port-Of: odoo/odoo#58024
Since [1], the editor panel is now on the right. The fullscreen mode was not adapted correctly. [1]: https://github.com/odoo/odoo/pull/57975 Forward-Port-Of: odoo/odoo#58222
Original PR description
Since [1], the editor panel is now on the right. The fullscreen mode was not adapted correctly. [1]: https://github.com/odoo/odoo/pull/57975 Forward-Port-Of: odoo/odoo#58222
Add spacing between picture and text on mobile. Before this commit there was no space between photos and team names on mobile devices task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56713
Original PR description
Add spacing between picture and text on mobile. Before this commit there was no space between photos and team names on mobile devices task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56713
task-2341690 Forward-Port-Of: odoo/odoo#58135
Original PR description
task-2341690 Forward-Port-Of: odoo/odoo#58135
task-2341787 Forward-Port-Of: odoo/odoo#58176
Original PR description
task-2341787 Forward-Port-Of: odoo/odoo#58176
Description of the issue/feature this PR addresses: * install `sale_timesheet` module * create a server action to massive confirm sale orders with: * state = 'code' * code = `records.action_confirm()`  * create its contextual action * execute the server action on more than one sale order Current behavior before PR: It raises the following error: ``` Error: Odoo
Original PR description
Description of the issue/feature this PR addresses: * install `sale_timesheet` module * create a server action to massive confirm sale orders with: * state = 'code' * code =…
Description of the issue/feature this PR addresses:
* install `sale_timesheet` module
* create a server action to massive confirm sale orders with:
* state = 'code'
* code = `records.action_confirm()`
* create its contextual action
* execute the server action on more than one sale order
Current behavior before PR:
It raises the following error:
```
Error:
Odoo Server Error
Traceback (most recent call last):
File "/data/build/odoo/odoo/models.py", line 4746, in ensure_one
_id, = self._ids
ValueError: too many values to unpack (expected 1)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/data/build/odoo/odoo/tools/safe_eval.py", line 350, in safe_eval
return unsafe_eval(c, globals_dict, locals_dict)
File "", line 10, in <module>
File "/data/build/odoo/addons/sale_timesheet/models/sale_order.py", line 55, in _action_confirm
default_company_id=self.company_id.id,
File "/data/build/odoo/odoo/fields.py", line 1010, in __get__
record.ensure_one()
File "/data/build/odoo/odoo/models.py", line 4749, in ensure_one
raise ValueError("Expected singleton: %s" % self)
ValueError: Expected singleton: sale.order(3, 2)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/data/build/odoo/odoo/http.py", line 656, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/data/build/odoo/odoo/http.py", line 314, in _handle_exception
raise pycompat.reraise(type(exception), exception, sys.exc_info()[2])
File "/data/build/odoo/odoo/tools/pycompat.py", line 87, in reraise
raise value
File "/data/build/odoo/odoo/http.py", line 698, in dispatch
result = self._call_function(**self.params)
File "/data/build/odoo/odoo/http.py", line 346, in _call_function
return checked_call(self.db, *args, **kwargs)
File "/data/build/odoo/odoo/service/model.py", line 98, in wrapper
return f(dbname, *args, **kwargs)
File "/data/build/odoo/odoo/http.py", line 339, in checked_call
result = self.endpoint(*a, **kw)
File "/data/build/odoo/odoo/http.py", line 941, in __call__
return self.method(*args, **kw)
File "/data/build/odoo/odoo/http.py", line 519, in response_wrap
response = f(*args, **kw)
File "/data/build/odoo/addons/web/controllers/main.py", line 1269, in run
result = request.env['ir.actions.server'].browse([action_id]).run()
File "/data/build/odoo/odoo/addons/base/models/ir_actions.py", line 553, in run
res = func(action, eval_context=eval_context)
File "/data/build/odoo/addons/website/models/ir_actions.py", line 57, in run_action_code_multi
res = super(ServerAction, self).run_action_code_multi(action, eval_context)
File "/data/build/odoo/odoo/addons/base/models/ir_actions.py", line 444, in run_action_code_multi
safe_eval(action.sudo().code.strip(), eval_context, mode="exec", nocopy=True) # nocopy allows to return 'action'
File "/data/build/odoo/odoo/tools/safe_eval.py", line 373, in safe_eval
pycompat.reraise(ValueError, ValueError('%s: "%s" while evaluating\n%r' % (ustr(type(e)), ustr(e), expr)), exc_info[2])
File "/data/build/odoo/odoo/tools/pycompat.py", line 86, in reraise
raise value.with_traceback(tb)
File "/data/build/odoo/odoo/tools/safe_eval.py", line 350, in safe_eval
return unsafe_eval(c, globals_dict, locals_dict)
File "", line 10, in <module>
File "/data/build/odoo/addons/sale_timesheet/models/sale_order.py", line 55, in _action_confirm
default_company_id=self.company_id.id,
File "/data/build/odoo/odoo/fields.py", line 1010, in __get__
record.ensure_one()
File "/data/build/odoo/odoo/models.py", line 4749, in ensure_one
raise ValueError("Expected singleton: %s" % self)
ValueError: <class 'ValueError'>: "Expected singleton: sale.order(3, 2)" while evaluating
"# Available variables:\n# - env: Odoo Environment on which the action is triggered\n# - model: Odoo Model of the record on which the action is triggered; is a void recordset\n# - record: record on which the action is triggered; may be void\n# - records: recordset of all records on which the action is triggered in multi-mode; may be void\n# - time, datetime, dateutil, timezone: useful Python libraries\n# - log: log(message, level='info'): logging function to record debug information in ir.logging table\n# - Warning: Warning Exception to use with raise\n# To return an action, assign: action = {...}\nrecords._action_confirm()"
```
Desired behavior after PR is merged:
the selected sale orders are confirmed.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#58235
Forward-Port-Of: odoo/odoo#55360Previously, when the user quickly hovered over many options (eg when trying to click on the last item of a select menu), all of the options that were briefly hovered would be previewed in succession. While this is not a problem for options that are fast to change, some option take some time (eg, image filters), but all of the intermediary previews would still show one after another, which is both very slow and completely useless. This commit adds a per-widget action queue. When a widget
Original PR description
Previously, when the user quickly hovered over many options (eg when trying to click on the last item of a select menu), all of the options that were briefly hovered would be previewed in succession. While this is not a problem for options that are fast to change, some option take some time (eg, image filters), but all of the intermediary previews would still show one after another, which is both very slow and completely useless. This commit adds a per-widget action queue. When a widget is called, it will immediately add an action item to this queue, but when the snippet_edition mutex becomes available to execute this action, it will first check that this action will not be immediately reverted, and if it will, the action is skipped entirely. task-2337344 Forward-Port-Of: odoo/odoo#57947
Since [1], the editor panel is now on the right. The top actions z-index was not adapted and was now too high and going above modals. It worked before because the zindex was confined into the topbar stacking context, which does not exist anymore. [1]: https://github.com/odoo/odoo/pull/57975 Forward-Port-Of: odoo/odoo#58237
Original PR description
Since [1], the editor panel is now on the right. The top actions z-index was not adapted and was now too high and going above modals. It worked before because the zindex was confined into the topbar stacking context, which does not exist anymore. [1]: https://github.com/odoo/odoo/pull/57975 Forward-Port-Of: odoo/odoo#58237
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57942
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57942
When the screencast argument is used to produce a video file of failing tests, the framerate is computed with a KISS average. This results in a misleading video flow. For example, if a tour step is stuck, the average could show a smooth transition instead of the reality. With this commit, the real duration of frames are used to produce the video. The result is a more realistic video flow. Forward-Port-Of: odoo/odoo#58264 Forward-Port-Of: odoo/odoo#58136
Original PR description
When the screencast argument is used to produce a video file of failing tests, the framerate is computed with a KISS average. This results in a misleading video flow. For example, if a tour step is stuck, the average could show a smooth transition instead of the reality. With this commit, the real duration of frames are used to produce the video. The result is a more realistic video flow. Forward-Port-Of: odoo/odoo#58264 Forward-Port-Of: odoo/odoo#58136
* Change the `addons/account/i18n/vi.po` PO file to replace the translation of `Vendor Bill` like msgids from `Công nợ nhà cung cấp` to by `Hóa đơn Nhà cung cấp`, there should be 3. What's matter is the `đ` character. * Create a brand new Vietnamese database (using `-l vi_VN` and `--load-language=vi_VN`) * Install Invoicing (`account`), an email alias constraint is raised. > You cannot use anything else than unaccented latin characters in the > alias address. During the installation
Original PR description
* Change the `addons/account/i18n/vi.po` PO file to replace the translation of `Vendor Bill` like msgids from `Công nợ nhà cung cấp` to by `Hóa đơn Nhà cung cấp`, there should be 3. What's matter is…
* Change the `addons/account/i18n/vi.po` PO file to replace the translation of `Vendor Bill` like msgids from `Công nợ nhà cung cấp` to by `Hóa đơn Nhà cung cấp`, there should be 3. What's matter is the `đ` character. * Create a brand new Vietnamese database (using `-l vi_VN` and `--load-language=vi_VN`) * Install Invoicing (`account`), an email alias constraint is raised. > You cannot use anything else than unaccented latin characters in the > alias address. During the installation of the invoicing module, an email alias is created for every journal account of purchase type. The alias is created using the current journal name. Here the journal name is `Hóa đơn Nhà cung cấp`, as mail aliases should only contain ascii characters, we attemp to remove the accents. The `tools.misc.remove_accents` successfully removes most of them but the `đ` character is left as-is, the final alias is `hoa-đon-nha-cung-cap` which is invalid as it contains some non-ascii characters. The `remove_accents` function uses the [NFKD] Unicode Compatibility Decomposition Normalization Form. This normalization process unify all abstract equivalent characters, i.e. characters only different by font or rotation. While this normalization process helps to transcript a lot of characters to their ascii compatibility equivalent, some 118,230 other non-ascii characters (mainly from the Chinese and Japanese scripts) are left as-is as they lack an ascii compatibility equivalent. The solution has been to not use the journal name but rather the journal type as email alias when the journal name is unsafe. The journal type is not translatable thus will always be ascii. One additional watchdog has been added to the sanitization function of email aliases so non-ascii characters are replaced with a '?' which is an authorized character in emails local-part. [NFKD] https://unicode.org/reports/tr15/ Closes #55492 Closes #55493 Co-authored-by: Thong Le <thongthele@users.no-reply.github.com> Forward-Port-Of: odoo/odoo#58109 Forward-Port-Of: odoo/odoo#55597
Steps to rperoduce the bug: - Let's consider a subscription template ST with manual invoice - Let's consider a subscription product SP of ST - Create a default analytic tag AT for SP - Create a subscription S with SP and set analytic tag BT - Generate an invoice from S Bug: The analytic tag set on the invoice line was AT instead of BT Due to function _compute_analytic_account defined on model account.move.line PS: This behavior is due to this line: https://github.com/odoo/o
Original PR description
Steps to rperoduce the bug: - Let's consider a subscription template ST with manual invoice - Let's consider a subscription product SP of ST - Create a default analytic tag AT for SP - Create a subscription S with SP and set analytic tag BT - Generate an invoice from S Bug: The analytic tag set on the invoice line was AT instead of BT Due to function _compute_analytic_account defined on model account.move.line PS: This behavior is due to this line: https://github.com/odoo/odoo/blob/13.0/addons/account_analytic_default/models/account_analytic_default.py#L89 But changing it in stable can lead to a lot of side effects opw:2312472 Forward-Port-Of: odoo/enterprise#13402 Forward-Port-Of: odoo/enterprise#13371
https://github.com/odoo/enterprise/commit/526cdf50c0fbc8959e5bc6cbbd2fd98d989fc599 and https://github.com/odoo/enterprise/commit/50ebe83fc09bce2743d40f97a3f18e9cd1c45d94 introduced the taxes on subscription. After discussion, it brings more drawback than useful features. These commits remove both taxes and fiscal position on the subscription. Task id: 2299937 Forward-Port-Of: odoo/enterprise#13368 Forward-Port-Of: odoo/enterprise#12111
Original PR description
https://github.com/odoo/enterprise/commit/526cdf50c0fbc8959e5bc6cbbd2fd98d989fc599 and https://github.com/odoo/enterprise/commit/50ebe83fc09bce2743d40f97a3f18e9cd1c45d94 introduced the taxes on subscription. After discussion, it brings more drawback than useful features. These commits remove both taxes and fiscal position on the subscription. Task id: 2299937 Forward-Port-Of: odoo/enterprise#13368 Forward-Port-Of: odoo/enterprise#12111
taskId 2338803 Forward-Port-Of: odoo/enterprise#13241
Original PR description
taskId 2338803 Forward-Port-Of: odoo/enterprise#13241
Issue: 1) During the renewal process we expect to see in the subscription the same lines than on the renewal sale order. It was not the case. - If you remove lines from the subscription on the quotation, the lines remains on the subscription after the confirmation - If you have one line for a given product on the subscription before the renewal you add a second line with the same product on the renewal quotation You end up with only one line on the subscription with the quantity
Original PR description
Issue: 1) During the renewal process we expect to see in the subscription the same lines than on the renewal sale order. It was not the case. - If you remove lines from the subscription on the…
Issue: 1) During the renewal process we expect to see in the subscription the same lines than on the renewal sale order. It was not the case. - If you remove lines from the subscription on the quotation, the lines remains on the subscription after the confirmation - If you have one line for a given product on the subscription before the renewal you add a second line with the same product on the renewal quotation You end up with only one line on the subscription with the quantity of the last sale order line 2) Change in template_id of the subscription may change the MRR of the subscription if the template has a different recurring rule. This change was not tracked properly in the sale.subscription.log Solution: 1) The subscription should be wiped at renewal, so the confirmation of the SO will create all the line from the so on the subscription. This way the subscription is a mirror of the renewal quotation 2) Create log if template_id is in the tracking value Forward-Port-Of: odoo/enterprise#12678 Forward-Port-Of: odoo/enterprise#11745
Task [2325324](https://www.odoo.com/web#id=2325324&action=327&model=project.task&view_type=form&cids=1&menu_id=4720) Forward-Port-Of: odoo/enterprise#12903
Original PR description
Task [2325324](https://www.odoo.com/web#id=2325324&action=327&model=project.task&view_type=form&cids=1&menu_id=4720) Forward-Port-Of: odoo/enterprise#12903
the old wsdl url will be invalidated after 28th Sept 2020. so, updated it with the new url. Task: https://www.odoo.com/web#id=2340589&action=4043&model=project.task&view_type=form&cids=2&menu_id=4720 Forward-Port-Of: odoo/enterprise#13351 Forward-Port-Of: odoo/enterprise#13254
Original PR description
the old wsdl url will be invalidated after 28th Sept 2020. so, updated it with the new url. Task: https://www.odoo.com/web#id=2340589&action=4043&model=project.task&view_type=form&cids=2&menu_id=4720 Forward-Port-Of: odoo/enterprise#13351 Forward-Port-Of: odoo/enterprise#13254
- Install account_bank_statement_import_camt - Go to Accounting > Configuration > Settings and activate Multi-Currencies - Go to Accounting > Overview - For Bank Journal, import a CAMT file where the source currency is not a currency that is enabled. A KeyError is raised with currency name. opw-2334910 Forward-Port-Of: odoo/enterprise#13376 Forward-Port-Of: odoo/enterprise#13372
Original PR description
- Install account_bank_statement_import_camt - Go to Accounting > Configuration > Settings and activate Multi-Currencies - Go to Accounting > Overview - For Bank Journal, import a CAMT file where the source currency is not a currency that is enabled. A KeyError is raised with currency name. opw-2334910 Forward-Port-Of: odoo/enterprise#13376 Forward-Port-Of: odoo/enterprise#13372