Tuesday, September 29, 2020
58 changes · master
Enhancements to existing features
CRM lead screens now show the salesperson's profile picture next to their name. This makes it easier for users to recognize assigned salespeople at a glance and improves the visual clarity of lead information.
Original PR description
This PR will improve the salesperson(user_id) field with many2one_avatar_user widget will display avatar before user name. Task Id : 2302572
Resolved issues and error corrections
This fixes a crash that could occur when website email channel alias information was requested without the necessary access rights. The change helps keep the website experience stable by handling restricted access gracefully instead of showing an error.
Original PR description
Related to https://github.com/odoo/odoo/pull/43858 Same fix for stable version (no retrocompatibility controller) (guardedCatch should be not ported after 13.1 with this patch) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
# Purpose Fix the redundancy of "Send email" menu on the crm.lead model. # Specifications A new menu was added to send an email directly to a partner from My Activities view in CRM, but the purpose was to use this action on a tree view. This PR changes the act_window tag into a simple action. task-2310462 Forward-Port-Of: odoo/odoo#55306
Original PR description
# Purpose Fix the redundancy of "Send email" menu on the crm.lead model. # Specifications A new menu was added to send an email directly to a partner from My Activities view in CRM, but the purpose was to use this action on a tree view. This PR changes the act_window tag into a simple action. task-2310462 Forward-Port-Of: odoo/odoo#55306
Twitter stream setup now uses a stronger validation rule to prevent incomplete stream configurations. Existing incorrectly configured records are handled through migration, reducing future setup errors without changing day-to-day user workflows.
Original PR description
Purpose ======= On #12551 , we fixed a bug by adding a warning message in the create of the stream type. This can not be implemented with a constraint in stable because badly-configured streams (stream of type "twitter_follow" without "twitter_followed_account_id" e.g. might exist in the database). So, we do it in the right way on master with a migration script to fix the badly-configured records. Task-2302570 Migration - odoo/upgrade/pull/1706
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57154
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57154
Description of the issue/feature this PR addresses: Missing default_partner_id in context of 'Opportunities' stat button on contact form. Current behavior before PR: No partner_id on new crm kanban card when coming from contact form 'Opportunities' stat button. Desired behavior after PR is merged: partner_id correctly set -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Task ID: 2343221 Forward-Port-Of: odoo/odoo#58229
Original PR description
Description of the issue/feature this PR addresses: Missing default_partner_id in context of 'Opportunities' stat button on contact form. Current behavior before PR: No partner_id on new crm kanban card when coming from contact form 'Opportunities' stat button. Desired behavior after PR is merged: partner_id correctly set -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Task ID: 2343221 Forward-Port-Of: odoo/odoo#58229
In order to avoid making it possible to follow the same survey multiple times at the same time, a survey cookie is added with the survey token and answer token. When starting the survey, if the cookie contains a valid answer token for that survey token, the survey session is reloaded where the participant left it. When the user finished the survey, the cookie is deleted to allow to retake the survey later, if possible. Note: A participant can still open multiple tabs with the same sur
Original PR description
In order to avoid making it possible to follow the same survey multiple times at the same time, a survey cookie is added with the survey token and answer token. When starting the survey, if the cookie contains a valid answer token for that survey token, the survey session is reloaded where the participant left it. When the user finished the survey, the cookie is deleted to allow to retake the survey later, if possible. Note: A participant can still open multiple tabs with the same survey, but it will be linked to the same survey answer. So if the user tries to submit another answer, the late answer will overwrite the previous one. Task ID: 2345468 Forward-Port-Of: odoo/odoo#58691
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57744
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57744
During the click_everywhere test, the map views are tested but leads to random failures when the view takes too long to load. Moreover, the map resources are queried on external nominatim.org servers. This could lead in the test runner being black-listed by nominatim and more indeterminism as those servers are not under our control. For those reasons, this commit will skip the map views in the click_everywhere test. Also, the general time limit is increased. Five seconds was someti
Original PR description
During the click_everywhere test, the map views are tested but leads to random failures when the view takes too long to load. Moreover, the map resources are queried on external nominatim.org servers. This could lead in the test runner being black-listed by nominatim and more indeterminism as those servers are not under our control. For those reasons, this commit will skip the map views in the click_everywhere test. Also, the general time limit is increased. Five seconds was sometimes too short, depending on external conditions (e.g.: server load or screencast enabled). Finally, on a database with all apps installed, the `Settings` menu of some apps loads the full settings and it can takes a huge amount of time to load on a clean browser (as in the tests). For that reason, the time limit for the test of those menus was also increased. Forward-Port-Of: odoo/odoo#58600 Forward-Port-Of: odoo/odoo#58520
As example, on a runbot database, there are 13 duplicated indexes ``` 4362411-14-0-all=> \d res_users_apikeys; Table "public.res_users_apikeys" Column | Type | Collation | Nullable | Default -------------+-----------------------------+-----------+----------+----------------------------------------------- id | integer | | not null | nextval('res_users_apikeys_id
Original PR description
As example, on a runbot database, there are 13 duplicated indexes ``` 4362411-14-0-all=> \d res_users_apikeys; Table "public.res_users_apikeys" Column | Type | Collation | Nullable | Default…
As example, on a runbot database, there are 13 duplicated indexes
```
4362411-14-0-all=> \d res_users_apikeys;
Table "public.res_users_apikeys"
Column | Type | Collation | Nullable | Default
-------------+-----------------------------+-----------+----------+-----------------------------------------------
id | integer | | not null | nextval('res_users_apikeys_id_seq'::regclass)
name | character varying | | not null |
user_id | integer | | not null |
scope | character varying | | |
index | character varying(8) | | |
key | character varying | | |
create_date | timestamp without time zone | | | timezone('utc'::text, now())
Indexes:
"res_users_apikeys_pkey" PRIMARY KEY, btree (id)
"res_users_apikeys_user_id_index_idx" btree (user_id, index)
"res_users_apikeys_user_id_index_idx1" btree (user_id, index)
"res_users_apikeys_user_id_index_idx10" btree (user_id, index)
"res_users_apikeys_user_id_index_idx11" btree (user_id, index)
"res_users_apikeys_user_id_index_idx12" btree (user_id, index)
"res_users_apikeys_user_id_index_idx2" btree (user_id, index)
"res_users_apikeys_user_id_index_idx3" btree (user_id, index)
"res_users_apikeys_user_id_index_idx4" btree (user_id, index)
"res_users_apikeys_user_id_index_idx5" btree (user_id, index)
"res_users_apikeys_user_id_index_idx6" btree (user_id, index)
"res_users_apikeys_user_id_index_idx7" btree (user_id, index)
"res_users_apikeys_user_id_index_idx8" btree (user_id, index)
"res_users_apikeys_user_id_index_idx9" btree (user_id, index)
Check constraints:
"res_users_apikeys_index_check" CHECK (char_length(index::text) = 8)
Foreign-key constraints:
"res_users_apikeys_user_id_fkey" FOREIGN KEY (user_id) REFERENCES res_users(id)
```
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#58726Fixes odoo/odoo#34226 Forward-Port-Of: odoo/odoo#58554
Original PR description
Fixes odoo/odoo#34226 Forward-Port-Of: odoo/odoo#58554
Description of the issue/feature this PR addresses: My signature for CLA Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58084
Original PR description
Description of the issue/feature this PR addresses: My signature for CLA Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58084
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58082
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58082
Some part of the report were in t-value attributes (so not translatable) and when the coupon was not set for a customer, no language would be used at all (now we default on current environment language). opw-2339815 X-original-commit: odoo/enterprise@d00981fe8fe2ba5bc62e078cb57b9e4101794b4f Forward-Port-Of: odoo/odoo#58688 Forward-Port-Of: odoo/odoo#58473
Original PR description
Some part of the report were in t-value attributes (so not translatable) and when the coupon was not set for a customer, no language would be used at all (now we default on current environment language). opw-2339815 X-original-commit: odoo/enterprise@d00981fe8fe2ba5bc62e078cb57b9e4101794b4f Forward-Port-Of: odoo/odoo#58688 Forward-Port-Of: odoo/odoo#58473
Currently, activities having blank summary field exported in xls or csv display False. Instead of that, need to display the activity type like Email, To Do, Call, Meeting, etc. as its display in the list view. With this commit, if the activity type has summary then it will display summary value otherwise it will display the activity type name if summary is not added. Task : 2254851 Forward-Port-Of: odoo/odoo#58654 Forward-Port-Of: odoo/odoo#58495
Original PR description
Currently, activities having blank summary field exported in xls or csv display False. Instead of that, need to display the activity type like Email, To Do, Call, Meeting, etc. as its display in the list view. With this commit, if the activity type has summary then it will display summary value otherwise it will display the activity type name if summary is not added. Task : 2254851 Forward-Port-Of: odoo/odoo#58654 Forward-Port-Of: odoo/odoo#58495
Based on https://github.com/odoo/odoo/pull/48552#discussion_r440061218 solution Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58534
Original PR description
Based on https://github.com/odoo/odoo/pull/48552#discussion_r440061218 solution Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58534
This commit fixes the style of the ribbon displayed in the exhibitor dedicated page to use the newly introduced display_ribbon_style field on the event.sponsor.type model instead of the sponsor type name (previous implementation). Task 2336247 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57392 Forward-Port-Of: odoo/odoo#57337
Original PR description
This commit fixes the style of the ribbon displayed in the exhibitor dedicated page to use the newly introduced display_ribbon_style field on the event.sponsor.type model instead of the sponsor type name (previous implementation). Task 2336247 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57392 Forward-Port-Of: odoo/odoo#57337
Bug === 1. Create a survey with the option "One page per question" 2. Create a "Multiple choice - only one value" question 3. Go to the survey, select a question 4. With the keyboard unselect the question 5. Submit You will be able to submit your answer even if nothing seems to be selected. We also want to be able to unselect answers with the keyboard. Technical ========= The event "onchange" can be triggered for the radio button even if there was no change. The reason is becau
Original PR description
Bug === 1. Create a survey with the option "One page per question" 2. Create a "Multiple choice - only one value" question 3. Go to the survey, select a question 4. With the keyboard unselect the question 5. Submit You will be able to submit your answer even if nothing seems to be selected. We also want to be able to unselect answers with the keyboard. Technical ========= The event "onchange" can be triggered for the radio button even if there was no change. The reason is because we always "write true" on the radio (even if it was already check) and we always trigger manually the event "onchange". Task-2345463 Forward-Port-Of: odoo/odoo#58384
Fix the redundancy of "Send email" menu on the crm.lead model. A new menu was added to send a email directly to a partner from My Activities views in CRM, but the purpose was to use this action on a tree view. this commit change the act_window tag into an simple action. Task-2310462 X-Original-Commit: odoo/odoo@9ded57d87f2a721492ca0028099189d303383569 Forward-Port-Of: odoo/odoo#58761
Original PR description
Fix the redundancy of "Send email" menu on the crm.lead model. A new menu was added to send a email directly to a partner from My Activities views in CRM, but the purpose was to use this action on a tree view. this commit change the act_window tag into an simple action. Task-2310462 X-Original-Commit: odoo/odoo@9ded57d87f2a721492ca0028099189d303383569 Forward-Port-Of: odoo/odoo#58761
Forward-Port-Of: odoo/odoo#58758 Forward-Port-Of: odoo/odoo#57948
Original PR description
Forward-Port-Of: odoo/odoo#58758 Forward-Port-Of: odoo/odoo#57948
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55916
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55916
Before this commit, there were some traceback while performing several actions due to context that was not properly evaluated. This commit fixes those traceback by evaluating the context and thus enabling user to perform those actions without traceback. Task Id : 2302572 Forward-Port-Of: odoo/odoo#56501
Original PR description
Before this commit, there were some traceback while performing several actions due to context that was not properly evaluated. This commit fixes those traceback by evaluating the context and thus enabling user to perform those actions without traceback. Task Id : 2302572 Forward-Port-Of: odoo/odoo#56501
This PR fixes several bugs related to CRM and mail module, which includes : - Fix traceback while launching next activity through chatter popover (mail module) - Properly update probability on creation / updation of lead - Add sequence to CRM tour to prioritise it - Properly compute `name` field in lead merge wizard See task pad for more information. TaskID - 2302572 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/od
Original PR description
This PR fixes several bugs related to CRM and mail module, which includes : - Fix traceback while launching next activity through chatter popover (mail module) - Properly update probability on creation / updation of lead - Add sequence to CRM tour to prioritise it - Properly compute `name` field in lead merge wizard See task pad for more information. TaskID - 2302572 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56910
task-2346650 Forward-Port-Of: odoo/odoo#58504
Original PR description
task-2346650 Forward-Port-Of: odoo/odoo#58504
Before this commit the height of a snippet with the full height option enabled was not correctly updated. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58760
Original PR description
Before this commit the height of a snippet with the full height option enabled was not correctly updated. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58760
Description of the issue/feature this PR addresses: Make possible to override the stock move reservation. This would allow to introduce new features like restrict a move reservation to a specific lot, a specific package or even a specific sublocation... Current behavior before PR: The stock move reservation is not overridable at all. Desired behavior after PR is merged: Make possible to override the stock move reservation in submodules to introduce new features like restricting th
Original PR description
Description of the issue/feature this PR addresses: Make possible to override the stock move reservation. This would allow to introduce new features like restrict a move reservation to a specific lot, a specific package or even a specific sublocation... Current behavior before PR: The stock move reservation is not overridable at all. Desired behavior after PR is merged: Make possible to override the stock move reservation in submodules to introduce new features like restricting the reservation to a specific lot, like it was possible to do with restrict_lot_id field in version 10. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57574
Before this commit, the width of inputs was too slow for long unit text. This commit increases the width to accommodate for them. task-2312878 Forward-Port-Of: odoo/odoo#57927
Original PR description
Before this commit, the width of inputs was too slow for long unit text. This commit increases the width to accommodate for them. task-2312878 Forward-Port-Of: odoo/odoo#57927
This was fixed in 13.0 and forward-ported twice in 14.0 with [1] and [2] But the combination of the two commit were messed up. [1]: https://github.com/odoo/odoo/commit/225ec35e50b5d71fa795f64cb9a9a6c2ceda7631 [2]: https://github.com/odoo/odoo/commit/19be84634d394f47ceb882c5ddd24585f31b50ae Forward-Port-Of: odoo/odoo#58768
Original PR description
This was fixed in 13.0 and forward-ported twice in 14.0 with [1] and [2] But the combination of the two commit were messed up. [1]: https://github.com/odoo/odoo/commit/225ec35e50b5d71fa795f64cb9a9a6c2ceda7631 [2]: https://github.com/odoo/odoo/commit/19be84634d394f47ceb882c5ddd24585f31b50ae Forward-Port-Of: odoo/odoo#58768
task-2312878 Forward-Port-Of: odoo/odoo#56161
Original PR description
task-2312878 Forward-Port-Of: odoo/odoo#56161
After each test, a check is done that there is no leftover in the DOM. If there are, the suite fails, but there is no indication on the test that left elements in the DOM. This commit logs that missing information. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58777
Original PR description
After each test, a check is done that there is no leftover in the DOM. If there are, the suite fails, but there is no indication on the test that left elements in the DOM. This commit logs that missing information. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58777
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55070
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55070
Participant count ============= When we implemented `website_jitsi` we didn't need to enter a pseudo. So, when the page was loaded, we automatically joined the room. But now, we have one more step, we need to enter our Jitsi username. During this step, the room can become full so we need to check one more time if it's not the case. Correctly use the option `check_full` in `website_event_track_exhibitor`. Do not wait for participant update if the room become full. Views ===== If
Original PR description
Participant count ============= When we implemented `website_jitsi` we didn't need to enter a pseudo. So, when the page was loaded, we automatically joined the room. But now, we have one more step, we need to enter our Jitsi username. During this step, the room can become full so we need to check one more time if it's not the case. Correctly use the option `check_full` in `website_event_track_exhibitor`. Do not wait for participant update if the room become full. Views ===== If the event is finished, we should not display the warning message "The Event starts on..." in the room page view. On website, we can join the room of an exhibitor. If we are not in the right time range, a popup is displayed. If the exhibitor room starts at 10h30, it will display 10.5 instead. Task-2345894 Forward-Port-Of: odoo/odoo#58516
The goal is to add a nice payment solution to our users. - Why Adyen? - Worldwide - Manages local payment solutions - Easy onboarding - For both PoS and eCommerce - Why Adyen for Platforms? - The onboarding will be done directly from the customer's DB. - It's quite complicated for SMEs to get a partnership with Adyen as they have high requirements for transaction volume. By registering Odoo as a Platform with Adyen Marketpay, we allow our users to register as sub
Original PR description
The goal is to add a nice payment solution to our users. - Why Adyen? - Worldwide - Manages local payment solutions - Easy onboarding - For both PoS and eCommerce - Why Adyen for Platforms? - The…
The goal is to add a nice payment solution to our users. - Why Adyen? - Worldwide - Manages local payment solutions - Easy onboarding - For both PoS and eCommerce - Why Adyen for Platforms? - The onboarding will be done directly from the customer's DB. - It's quite complicated for SMEs to get a partnership with Adyen as they have high requirements for transaction volume. By registering Odoo as a Platform with Adyen Marketpay, we allow our users to register as sub-merchants under a common account, removing this constraint. As all users are grouped under a common account, all requests need to provide the same API key. As this key cannot be shared, all requests to the Adyen API will need to be proxied. A new proxy will be created on `paymentproxy.odoo.com`. To initiate a payment, 3 values are required: - `account_holder_code`: This code is provided by Adyen and is used to identify the sub-merchant under the common account. - `adyen_uuid`: This ID is used internally to identify the user. - `proxy_token`: This token is generated by the proxy during the account creation and is used to sign all requests. The DB of the customer is the only host who has all the information required to modify the sub-merchant info or initiate a payment. If this information leak, the `proxy_token` can be reset on the proxy to revoke all access to the API. Before accessing the form to create an account, users will be redirected to www.odoo.com where they will be asked to log in. This ensures that we have contact information for this sub-merchant. TaskID: 2129218 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44582
### Task 366 In order to have an accounting tour in l10n_ar we have made the following changes: * Install by default the RI account chart in YourCompany * Remove the UserError message when the user tries to change the account chart in a company with a different AFIP responsibility. * Create a new preprinted sales journal by default called "Ventas Preimpreso". * When the user creates the first invoice of manual journals, take the "pos number" and update the journal configuration. * Im
Original PR description
### Task 366 In order to have an accounting tour in l10n_ar we have made the following changes: * Install by default the RI account chart in YourCompany * Remove the UserError message when the user tries to change the account chart in a company with a different AFIP responsibility. * Create a new preprinted sales journal by default called "Ventas Preimpreso". * When the user creates the first invoice of manual journals, take the "pos number" and update the journal configuration. * Improve the journal configuration constraint in order to protect sales/purchase journals from being modified if they already have posted invoices. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56959
Usecase to reproduce: 1. Create a reception with 2 products (p1, p2), fifo auto 2. Set the quantity done for p1 and leave p2 to 0, validate the picking. 3. Create the backorder for p2, set the quantity done and validate it. -> p2 has 2 stock valuation layers linked 4. Create a landed cost for both the reception and the backorder. The landed cost will add its cost on the wrong linked layer (the one without remaining quantity). The time the product will leave the stock, run_fifo() wil
Original PR description
Usecase to reproduce: 1. Create a reception with 2 products (p1, p2), fifo auto 2. Set the quantity done for p1 and leave p2 to 0, validate the picking. 3. Create the backorder for p2, set the quantity done and validate it. -> p2 has 2 stock valuation layers linked 4. Create a landed cost for both the reception and the backorder. The landed cost will add its cost on the wrong linked layer (the one without remaining quantity). The time the product will leave the stock, run_fifo() will consume a stock valuation layer that not have the landed cost added. This commit bypass the stock valuation layer creation in case of empty stock move. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58743 Forward-Port-Of: odoo/odoo#57565
**PURPOSE** Fix the broken tour **SPECIFICATIONS** The tour fails randomly in saas-13.4 and master. It happens rarely, 4 times since 2020-06-16. TaskID - 2323196 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57140
Original PR description
**PURPOSE** Fix the broken tour **SPECIFICATIONS** The tour fails randomly in saas-13.4 and master. It happens rarely, 4 times since 2020-06-16. TaskID - 2323196 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57140
task-2348372 Forward-Port-Of: odoo/odoo#58769
Original PR description
task-2348372 Forward-Port-Of: odoo/odoo#58769
Create a product category with automated inventory valuation but no accounts defined for expense/income Create a stored product with such category but again without expense/income accounts. Create an invoice with such product and a jounral on which default credit/debit accounts are defined. Save and Post the invoice. Journal entries related to the inventory move (COGS) are not created because the accounts are missing, but the system should take the default defined on the jounral inste
Original PR description
Create a product category with automated inventory valuation but no accounts defined for expense/income Create a stored product with such category but again without expense/income accounts. Create an invoice with such product and a jounral on which default credit/debit accounts are defined. Save and Post the invoice. Journal entries related to the inventory move (COGS) are not created because the accounts are missing, but the system should take the default defined on the jounral instead of skipping the operation opw-2339168 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58194
This commit adds a condition to the algorithm that redirects the track viewers to another talk when the one they looked at ended up. The next talk must be still ongoing. It avoids to redirect to a talk that started less than 10 minutes ago but that is already done. Task ID: 2344522 Forward-Port-Of: odoo/odoo#58642 Forward-Port-Of: odoo/odoo#58551
Original PR description
This commit adds a condition to the algorithm that redirects the track viewers to another talk when the one they looked at ended up. The next talk must be still ongoing. It avoids to redirect to a talk that started less than 10 minutes ago but that is already done. Task ID: 2344522 Forward-Port-Of: odoo/odoo#58642 Forward-Port-Of: odoo/odoo#58551
[IMP] (sale_)stock: forecast button with warehouse In case of multi-warehouse, the forecast button won't take in account the related warehouse and redirect to the forecast report of first warehouse of the company. To ease the understand of the forecast report redirect with the right warehouse in the context. [FIX] stock: bad warehouse forecast In the forecast data computation of `stock.move`, the warehouse wasn't take in account in the call of `_get_report_lines` for the quantity
Original PR description
[IMP] (sale_)stock: forecast button with warehouse In case of multi-warehouse, the forecast button won't take in account the related warehouse and redirect to the forecast report of first warehouse of the company. To ease the understand of the forecast report redirect with the right warehouse in the context. [FIX] stock: bad warehouse forecast In the forecast data computation of `stock.move`, the warehouse wasn't take in account in the call of `_get_report_lines` for the quantity available computation. Add the `location` key to the context with all location related to the warehouse in the `_get_report_lines`. Forward-Port-Of: odoo/odoo#58560
**Current behavior before PR:** Currently, mail tour only working for a private channel. **Desired behavior after PR is merged:** Now mail tour will be workable for the both public or private channel **LINK** PR https://github.com/odoo/odoo/pull/55913 Task-2313321 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58778 Forward-Port-Of: odoo/odoo#55913
Original PR description
**Current behavior before PR:** Currently, mail tour only working for a private channel. **Desired behavior after PR is merged:** Now mail tour will be workable for the both public or private channel **LINK** PR https://github.com/odoo/odoo/pull/55913 Task-2313321 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58778 Forward-Port-Of: odoo/odoo#55913
Add a z-index on remove btn in media dialog because before that the button was hidden behind images. Also review a little bit the style of the button. task-2312878 Forward-Port-Of: odoo/odoo#58815
Original PR description
Add a z-index on remove btn in media dialog because before that the button was hidden behind images. Also review a little bit the style of the button. task-2312878 Forward-Port-Of: odoo/odoo#58815
task-2346786 Forward-Port-Of: odoo/odoo#58550
Original PR description
task-2346786 Forward-Port-Of: odoo/odoo#58550
task-2343800 Forward-Port-Of: odoo/odoo#58496
Original PR description
task-2343800 Forward-Port-Of: odoo/odoo#58496
task-2276589 Forward-Port-Of: odoo/odoo#57811
Original PR description
task-2276589 Forward-Port-Of: odoo/odoo#57811
Also fix compute of local counter in some specific situations. task-2341740 Forward-Port-Of: odoo/odoo#58855 Forward-Port-Of: odoo/odoo#57997
Original PR description
Also fix compute of local counter in some specific situations. task-2341740 Forward-Port-Of: odoo/odoo#58855 Forward-Port-Of: odoo/odoo#57997
task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56936
Original PR description
task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56936
Before this commit the layout of the front-end edition of tags in blog was broken. And the default value of the select element was not filled. Before:  We fixed those design issues and also improve some small design details. And for the select issue, we add a return value in the computeWidgetState of the addTag method because even if the value will still be empty we need to r
Original PR description
Before this commit the layout of the front-end edition of tags in blog was broken. And the default value of the select element was not filled. Before:…
Before this commit the layout of the front-end edition of tags in blog was broken. And the default value of the select element was not filled. Before:  We fixed those design issues and also improve some small design details. And for the select issue, we add a return value in the computeWidgetState of the addTag method because even if the value will still be empty we need to return something because we want the select to be filled by the default value of setValue() wich is "/". After:  task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58307
Forward-Port-Of: odoo/odoo#58850
Original PR description
Forward-Port-Of: odoo/odoo#58850
task-2336251 Forward-Port-Of: odoo/odoo#58539
Original PR description
task-2336251 Forward-Port-Of: odoo/odoo#58539
Before this commit active navbar links were not correctly updated with the scroll position. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58505
Original PR description
Before this commit active navbar links were not correctly updated with the scroll position. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58505
The task will require adding new files which we don't want to do in stable. Forward-Port-Of: odoo/odoo#58872
Original PR description
The task will require adding new files which we don't want to do in stable. Forward-Port-Of: odoo/odoo#58872
- Set an account A with "Automatic Asset Creation" set - Create an invoice - Add a product, set the account to A - Add an analytic account and tags - Post the invoice The anatic account and tags are not carried to the asset creation. opw-2335929 Forward-Port-Of: odoo/enterprise#13582 Forward-Port-Of: odoo/enterprise#13510
Original PR description
- Set an account A with "Automatic Asset Creation" set - Create an invoice - Add a product, set the account to A - Add an analytic account and tags - Post the invoice The anatic account and tags are not carried to the asset creation. opw-2335929 Forward-Port-Of: odoo/enterprise#13582 Forward-Port-Of: odoo/enterprise#13510
The design was ok on community but broken on enterprise. This is because the editor used to have two different designs to maintain while it is only one now. This may need to be backported. Forward-Port-Of: odoo/enterprise#13659
Original PR description
The design was ok on community but broken on enterprise. This is because the editor used to have two different designs to maintain while it is only one now. This may need to be backported. Forward-Port-Of: odoo/enterprise#13659
Issue - Install "Documents - Accounting" app - Ensure you have iap credit for service 'invoice_ocr' - Enable multi currencies in settings - Change "Rounding Factor" of Euro currency (for test purpose) - Go to Documents and upload a vendor bill with "€" as currency and multiple move lines - On right side menu, click on "Create vendor bill" - Click on "Send file through ocr" then 'Update status' until you see values in form Wrong amount extracted. Cause Currency rounding
Original PR description
Issue - Install "Documents - Accounting" app - Ensure you have iap credit for service 'invoice_ocr' - Enable multi currencies in settings - Change "Rounding Factor" of Euro currency (for test purpose) - Go to Documents and upload a vendor bill with "€" as currency and multiple move lines - On right side menu, click on "Create vendor bill" - Click on "Send file through ocr" then 'Update status' until you see values in form Wrong amount extracted. Cause Currency rounding is hardcoded to 0.01. Solution Use rounding of currency instead and check with `is_zero` currency feature to know if need to update amount or not. opw-2337097 Forward-Port-Of: odoo/enterprise#13643 Forward-Port-Of: odoo/enterprise#13633
The route /maps/place is becoming unreliable and will randomly fail when called from certain browers/countries. Google has since provided a new universal cross-platform friendly URL that achieved the same result. As we are already using these new urls in other modules, itmakes sense to align this behavior on sign reports. See https://developers.google.com/maps/documentation/urls/get-started Forward-Port-Of: odoo/enterprise#13647
Original PR description
The route /maps/place is becoming unreliable and will randomly fail when called from certain browers/countries. Google has since provided a new universal cross-platform friendly URL that achieved the same result. As we are already using these new urls in other modules, itmakes sense to align this behavior on sign reports. See https://developers.google.com/maps/documentation/urls/get-started Forward-Port-Of: odoo/enterprise#13647
Forward-Port-Of: odoo/enterprise#13571
Original PR description
Forward-Port-Of: odoo/enterprise#13571
The current SAT rule has been replaced by the rule 2.7.1.43 which establish that invoice payment term should be PPD as soon as the due date is after the last day of the month (the month of the invoice date). Example: Invoice date: 09/23/2020 Due date: 10/03/2020 Payment term: PPD. Task ID : 2345638 Forward-Port-Of: odoo/enterprise#13646 Forward-Port-Of: odoo/enterprise#13484
Original PR description
The current SAT rule has been replaced by the rule 2.7.1.43 which establish that invoice payment term should be PPD as soon as the due date is after the last day of the month (the month of the invoice date). Example: Invoice date: 09/23/2020 Due date: 10/03/2020 Payment term: PPD. Task ID : 2345638 Forward-Port-Of: odoo/enterprise#13646 Forward-Port-Of: odoo/enterprise#13484