Friday, October 2, 2020
24 changes · master
Enhancements to existing features
This update adds coverage for how new message separators behave in less common mail scenarios. It helps ensure users see message boundaries consistently in chat windows and thread views, reducing the risk of confusing conversation displays.
Original PR description
task-2348620
The web interface can now hide the button that opens records matching a domain field when that shortcut is not useful. This gives teams more control over screen behavior and reduces unnecessary navigation options for users.
Original PR description
Current a domain field always show a button that can redirect to the matched records. It's not useful in some cases. This commit makes it possible to not show that. Task 2281266 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change centralizes how the OdooBot avatar is handled in the partner information used by the mail app. It should make the messaging experience easier to maintain and more consistent without changing day-to-day user workflows.
Original PR description
task-2348684
Resolved issues and error corrections
This change adjusts an internal web test so it no longer fails because of harmless background requests during action switching. It helps keep automated checks stable without changing what users see or how the application behaves.
Original PR description
In general, the last actionManager's operation has priority over hanging previous ones. This means that the order of the RPC's done by the actionManager is deterministic. i.e. load_action, load_views…
In general, the last actionManager's operation has priority over hanging previous ones. This means that the order of the RPC's done by the actionManager is deterministic. i.e. load_action, load_views However, when testing the concurrency, some RPC of an hanging actionManager operation (in this case a switchView to a form triggers a 'read'), may be fired anyway. Those are superfluous but irrelevant as long as the last displayed item is the one last asked by the user. This commit fixes the test 'execute a new action while switching to another controller' to not be bothered with an irrelevant controller's RPC messing with the orders of RPC. This is admittedly brutal, but justified with the current implementation of actionManager. X-original-commit: 4344d50a74b04ffed7a7113e8af2b8ad6800693e Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
The Gengo modules were removed with: https://github.com/odoo/odoo/commit/b38b72e456a https://github.com/odoo/odoo/commit/9b1f0962baa But there are still references to it. opw-2349904 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58931
Original PR description
The Gengo modules were removed with: https://github.com/odoo/odoo/commit/b38b72e456a https://github.com/odoo/odoo/commit/9b1f0962baa But there are still references to it. opw-2349904 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58931
This fixes an issue where users could no longer quickly create a new referenced record from a reference field. The change restores the expected creation behavior and adds a test to prevent the problem from returning.
Original PR description
An older commit had refactor part of the basic field _applyX2ManyOperations. During this refactor, the reference field was forgotten to be included in a condition that made the field no longer do the quick create behavior. The name_create function in the backend was no longer called. Adds a test for the reference field checking the call to the name_create function and fixes the problem. Task id 2322048
The Sign app’s automated test now waits for the interface to finish unblocking before ending. This prevents occasional test crashes and helps keep development and release validation more stable without changing user-facing behavior.
Original PR description
Before this commit, when executing the test "simple rendering" there was sometimes a crash because the blockUI div was still in the dom after the test ended. debug mode must be 0 to maximize execution speed and therefore have a chance to reproduce. This was because sign relies on DOM_updated event, which is not interceptable reliably by the test and that this event fired long after the test ended according to QUnit. After this commit and in compliance with b8afb9965d781ab0978a1e7c2db168997ce9d390, we wait until the UI is unblocked to finish the test. X-original-commit: 5586a5468656b75b9755d2c50f46278fc3170b4f
When in `debug=tests` and in unidentified moments in `debug=assets`, there is two loading of website.utils which was throwing an error. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58901
Original PR description
When in `debug=tests` and in unidentified moments in `debug=assets`, there is two loading of website.utils which was throwing an error. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58901
When coming from the dashboard (dashboard => Bills to pay => Bill) The context contains information about the purchase journal and not the move line, causing issues in the wizard. This change will make sure the context always contains the necessary move line information Task id #2344722 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58316
Original PR description
When coming from the dashboard (dashboard => Bills to pay => Bill) The context contains information about the purchase journal and not the move line, causing issues in the wizard. This change will make sure the context always contains the necessary move line information Task id #2344722 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58316
This commit makes some minor changes to the Youtube video & chat layouts when embedded in an event to ensure a better viewing experience. Changes in details: - Improve the "chat tab" to ensure the width is sufficient to display all of the Youtube chat iframe on any resolution ; - If the video is "live" and has a chat tab, the chat is now displayed as the first tab (before this change, the "other tracks" tab was always displayed first) ; - When displaying the next suggestion, add
Original PR description
This commit makes some minor changes to the Youtube video & chat layouts when embedded in an event to ensure a better viewing experience. Changes in details: - Improve the "chat tab" to ensure the width is sufficient to display all of the Youtube chat iframe on any resolution ; - If the video is "live" and has a chat tab, the chat is now displayed as the first tab (before this change, the "other tracks" tab was always displayed first) ; - When displaying the next suggestion, add a covering block to avoid a potential flicker while fetching the suggestion to go to. Task 2345887 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58700 Forward-Port-Of: odoo/odoo#58674
This commit updates owl from v1.0.9 to v1.0.10. Forward-Port-Of: odoo/odoo#58951
Original PR description
This commit updates owl from v1.0.9 to v1.0.10. Forward-Port-Of: odoo/odoo#58951
This PR lays the groundwork for the new editor by adding empty files to the assets in order to change them later on. The new editor is not stable enough to be merged right now, but delaying it to 15.0 would be problematic as the current editor has many bugs that we are unable to fix because of how summernote interacts with browser-dependent code as well as all the hacks that were done on top of it for Odoo since 8.0. This PR also removes the gengo modules as they are not going to be supported
Original PR description
This PR lays the groundwork for the new editor by adding empty files to the assets in order to change them later on. The new editor is not stable enough to be merged right now, but delaying it to 15.0 would be problematic as the current editor has many bugs that we are unable to fix because of how summernote interacts with browser-dependent code as well as all the hacks that were done on top of it for Odoo since 8.0. This PR also removes the gengo modules as they are not going to be supported anymore. This removal is not necessarily linked with the new editor. It just happened that we were facing the question of what to do with these modules and it was decided that Odoo would drop the support for them. As such, we went on to remove them in the new editor branch, which is why these commits appear here rather than somewhere else. Forward-Port-Of: odoo/odoo#58678
In general, the last actionManager's operation has priority over hanging previous ones. This means that the order of the RPC's done by the actionManager is deterministic. i.e. load_action, load_views However, when testing the concurrency, some RPC of an hanging actionManager operation (in this case a switchView to a form triggers a 'read'), may be fired anyway. Those are superfluous but irrelevant as long as the last displayed item is the one last asked by the user. This commit fixes
Original PR description
In general, the last actionManager's operation has priority over hanging previous ones. This means that the order of the RPC's done by the actionManager is deterministic. i.e. load_action, load_views…
In general, the last actionManager's operation has priority over hanging previous ones. This means that the order of the RPC's done by the actionManager is deterministic. i.e. load_action, load_views However, when testing the concurrency, some RPC of an hanging actionManager operation (in this case a switchView to a form triggers a 'read'), may be fired anyway. Those are superfluous but irrelevant as long as the last displayed item is the one last asked by the user. This commit fixes the test 'execute a new action while switching to another controller' to not be bothered with an irrelevant controller's RPC messing with the orders of RPC. This is admittedly brutal, but justified with the current implementation of actionManager. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57849
Because the current doc does not mean anything clear :D Forward-Port-Of: odoo/odoo#58735 Forward-Port-Of: odoo/odoo#58547
Original PR description
Because the current doc does not mean anything clear :D Forward-Port-Of: odoo/odoo#58735 Forward-Port-Of: odoo/odoo#58547
Before this commit, when editing a column in a kanban view, in project for instance, the translations weren't loaded. Now, the translations are correctly loaded. opw-2340125 Forward-Port-Of: odoo/odoo#58336
Original PR description
Before this commit, when editing a column in a kanban view, in project for instance, the translations weren't loaded. Now, the translations are correctly loaded. opw-2340125 Forward-Port-Of: odoo/odoo#58336
As survey session only works correctly when current tab is the master tab on the bus, an error message is shown to user when this is not the case. The user should close all other tabs on the same hostname before taking the survey. Task ID: 2345468 Forward-Port-Of: odoo/odoo#58394
Original PR description
As survey session only works correctly when current tab is the master tab on the bus, an error message is shown to user when this is not the case. The user should close all other tabs on the same hostname before taking the survey. Task ID: 2345468 Forward-Port-Of: odoo/odoo#58394
Task 2346547 Forward-Port-Of: odoo/odoo#58810
Original PR description
Task 2346547 Forward-Port-Of: odoo/odoo#58810
task-2350534 Forward-Port-Of: odoo/odoo#58999
Original PR description
task-2350534 Forward-Port-Of: odoo/odoo#58999
task-2347732 Forward-Port-Of: odoo/odoo#59004
Original PR description
task-2347732 Forward-Port-Of: odoo/odoo#59004
When a module creates a disabled user during its installation or upgrade (e.g. demo data), the UserError `"You cannot perform this action on an archived user"` breaks the whole installation process. Instead of that, let's just silently ignore that the mail could not be sent for some users if the context tells us that we are installing a module. OPW-2350267 Forward-Port-Of: odoo/odoo#57650
Original PR description
When a module creates a disabled user during its installation or upgrade (e.g. demo data), the UserError `"You cannot perform this action on an archived user"` breaks the whole installation process. Instead of that, let's just silently ignore that the mail could not be sent for some users if the context tells us that we are installing a module. OPW-2350267 Forward-Port-Of: odoo/odoo#57650
Consider a one2many field with a corresponding many2one field that is computed. After modifying the many2one field's dependencies, the cached value of the one2many field is inconsistent until the many2one field has been recomputed. Therefore, one has to force the computation of the many2one field before accessing the cached value of the one2many field. Forward-Port-Of: odoo/odoo#58159
Original PR description
Consider a one2many field with a corresponding many2one field that is computed. After modifying the many2one field's dependencies, the cached value of the one2many field is inconsistent until the many2one field has been recomputed. Therefore, one has to force the computation of the many2one field before accessing the cached value of the one2many field. Forward-Port-Of: odoo/odoo#58159
task-2350534 Forward-Port-Of: odoo/enterprise#13770
Original PR description
task-2350534 Forward-Port-Of: odoo/enterprise#13770
[FIX] account_reports: fix actions' parameters Since https://github.com/odoo/odoo/commit/d5c16492397047ceb97a0879aa61f068a0eeeca8#diff-4c19939afda19d36d6d57eda5f0a5c9eR337 , the fields passed to js for action dictionaries are filtered. Custom stuff injected for accounting reports were hence ignored. We now pass them through the 'params' key. [FIX] account_accountant: fix reconciliation of payable with receivable The call to the transfer wizard hadn't been fully update after https://github.
Original PR description
[FIX] account_reports: fix actions' parameters Since https://github.com/odoo/odoo/commit/d5c16492397047ceb97a0879aa61f068a0eeeca8#diff-4c19939afda19d36d6d57eda5f0a5c9eR337 , the fields passed to js for action dictionaries are filtered. Custom stuff injected for accounting reports were hence ignored. We now pass them through the 'params' key. [FIX] account_accountant: fix reconciliation of payable with receivable The call to the transfer wizard hadn't been fully update after https://github.com/odoo/odoo/commit/0ea9254c81ea42a7fd9af455f05d70e3ca227460 . Task: 2346547 Forward-Port-Of: odoo/enterprise#13676
Still an error in fix https://github.com/odoo/enterprise/pull/13744 Forward-Port-Of: odoo/enterprise#13753 Forward-Port-Of: odoo/enterprise#13747
Original PR description
Still an error in fix https://github.com/odoo/enterprise/pull/13744 Forward-Port-Of: odoo/enterprise#13753 Forward-Port-Of: odoo/enterprise#13747