Friday, October 2, 2020
3 changes · master
Resolved issues and error corrections
This change adjusts an internal web test so it no longer fails because of harmless background requests during action switching. It helps keep automated checks stable without changing what users see or how the application behaves.
Original PR description
In general, the last actionManager's operation has priority over hanging previous ones. This means that the order of the RPC's done by the actionManager is deterministic. i.e. load_action, load_views…
In general, the last actionManager's operation has priority over hanging previous ones. This means that the order of the RPC's done by the actionManager is deterministic. i.e. load_action, load_views However, when testing the concurrency, some RPC of an hanging actionManager operation (in this case a switchView to a form triggers a 'read'), may be fired anyway. Those are superfluous but irrelevant as long as the last displayed item is the one last asked by the user. This commit fixes the test 'execute a new action while switching to another controller' to not be bothered with an irrelevant controller's RPC messing with the orders of RPC. This is admittedly brutal, but justified with the current implementation of actionManager. X-original-commit: 4344d50a74b04ffed7a7113e8af2b8ad6800693e Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where users could no longer quickly create a new referenced record from a reference field. The change restores the expected creation behavior and adds a test to prevent the problem from returning.
Original PR description
An older commit had refactor part of the basic field _applyX2ManyOperations. During this refactor, the reference field was forgotten to be included in a condition that made the field no longer do the quick create behavior. The name_create function in the backend was no longer called. Adds a test for the reference field checking the call to the name_create function and fixes the problem. Task id 2322048
The Sign app’s automated test now waits for the interface to finish unblocking before ending. This prevents occasional test crashes and helps keep development and release validation more stable without changing user-facing behavior.
Original PR description
Before this commit, when executing the test "simple rendering" there was sometimes a crash because the blockUI div was still in the dom after the test ended. debug mode must be 0 to maximize execution speed and therefore have a chance to reproduce. This was because sign relies on DOM_updated event, which is not interceptable reliably by the test and that this event fired long after the test ended according to QUnit. After this commit and in compliance with b8afb9965d781ab0978a1e7c2db168997ce9d390, we wait until the UI is unblocked to finish the test. X-original-commit: 5586a5468656b75b9755d2c50f46278fc3170b4f