Monday, October 5, 2020
27 changes · master
Enhancements to existing features
Numeric fields now insert the decimal separator that matches the user's display language when the numpad decimal key is pressed. This makes data entry more reliable for users with different keyboard layouts and regional number formats.
Original PR description
Until now, the numpad decimal key was not properly handled for some keyboard layouts. This commit will ensure that when this key will get pressed inside a numeric field, the user's display language decimal separator will get inserted. Taskid: 1913999 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
The documentation website now shows the correct "master" label in its version switcher instead of "14.0". This prevents confusion for readers viewing the latest documentation and helps them confirm they are using the intended version.
Original PR description
This commit lands in master, the version switcher was displayed as "14.0" instead of "master" when published to https://www.odoo.com/documentation/master
Miscellaneous changes
An older commit had refactor part of the basic field _applyX2ManyOperations. During this refactor, the reference field was forgotten to be included in a condition that made the field no longer do the quick create behavior. The name_create function in the backend was no longer called. Adds a test for the reference field checking the call to the name_create function and fixes the problem. Task id 2322048 Forward-Port-Of: odoo/odoo#59013 Forward-Port-Of: odoo/odoo#58992
Original PR description
An older commit had refactor part of the basic field _applyX2ManyOperations. During this refactor, the reference field was forgotten to be included in a condition that made the field no longer do the quick create behavior. The name_create function in the backend was no longer called. Adds a test for the reference field checking the call to the name_create function and fixes the problem. Task id 2322048 Forward-Port-Of: odoo/odoo#59013 Forward-Port-Of: odoo/odoo#58992
Map pop-ups now show the full address including the state, making locations clearer for users viewing records on a map. This helps avoid confusion when similar city or street names exist across different states or regions.
Original PR description
The state was missing from the address displayed un the pop up markers on the map view. Task: 2348328
The display of the content of we-button was changed at some point from flex to block, this caused the width and height property of the color preview for ribbons to no longer have any effect. This commit fixes that by making the color-previews use the inline-block display mode. It also makes the preview round so as to be consistent with color-pickers, and aligns in in the middle so that it doesn't look off. Forward-Port-Of: odoo/odoo#58553
Original PR description
The display of the content of we-button was changed at some point from flex to block, this caused the width and height property of the color preview for ribbons to no longer have any effect. This commit fixes that by making the color-previews use the inline-block display mode. It also makes the preview round so as to be consistent with color-pickers, and aligns in in the middle so that it doesn't look off. Forward-Port-Of: odoo/odoo#58553
Steps to reproduce the bug: - Create a product with 123.1 units on hand - Click the eCommerce tab - In Availability, choose "Show inventory on website and prevent sales if not enough stock" - Save - Go to Website Bug: 123.10000000000001 is displayed instead of 123.1 opw:2348216 Forward-Port-Of: odoo/odoo#58979
Original PR description
Steps to reproduce the bug: - Create a product with 123.1 units on hand - Click the eCommerce tab - In Availability, choose "Show inventory on website and prevent sales if not enough stock" - Save - Go to Website Bug: 123.10000000000001 is displayed instead of 123.1 opw:2348216 Forward-Port-Of: odoo/odoo#58979
Before this commit, when sharing a survey 'Login required' to a non logged in user, the redirection was made to the home page. The reason is: when the survey is not started yet, no user input is already created for this survey and this user. So if no user_input has been created, yet, that means that the user has never started the survey before and user need first to login before continuing. After this commit, we redirect to the loggin page. Task ID: 2246430 Forward-Port-Of: odoo/odoo
Original PR description
Before this commit, when sharing a survey 'Login required' to a non logged in user, the redirection was made to the home page. The reason is: when the survey is not started yet, no user input is already created for this survey and this user. So if no user_input has been created, yet, that means that the user has never started the survey before and user need first to login before continuing. After this commit, we redirect to the loggin page. Task ID: 2246430 Forward-Port-Of: odoo/odoo#58641 Forward-Port-Of: odoo/odoo#50623
Add CLA for EasyPME (French Polynesia) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39359
Original PR description
Add CLA for EasyPME (French Polynesia) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39359
And other reported English mistakes in source string Courtesy of Transifex translators Forward-Port-Of: odoo/odoo#59002
Original PR description
And other reported English mistakes in source string Courtesy of Transifex translators Forward-Port-Of: odoo/odoo#59002
Steps to reproduce the bug: - Create POS (P) - Create journal (J) and link it to (P) - Open a new session in (P) - Exit the session without closing it - Delete (J) Bug: You cannot close the session nor assign a new journal to the POS. opw:2347169 Forward-Port-Of: odoo/odoo#59076
Original PR description
Steps to reproduce the bug: - Create POS (P) - Create journal (J) and link it to (P) - Open a new session in (P) - Exit the session without closing it - Delete (J) Bug: You cannot close the session nor assign a new journal to the POS. opw:2347169 Forward-Port-Of: odoo/odoo#59076
The border radius configuration is available on elements whose background color or border is set. For cards, it should always be available since the background color option is different there and there is no way to remove the color entirely anyway. Forward-Port-Of: odoo/odoo#59082
Original PR description
The border radius configuration is available on elements whose background color or border is set. For cards, it should always be available since the background color option is different there and there is no way to remove the color entirely anyway. Forward-Port-Of: odoo/odoo#59082
With the recent addition of the parallax option on all snippets, background-image urls were being converted from relative to absolute on snippet-drop. This was caused by trying to read the background-image's url and setting it back onto the target, but there is no way to reliably read a background-image url in relative form, so it was returned in absolute form and then written back to the element as is. This commit fixes that by always converting the absolute URL to relative when they a
Original PR description
With the recent addition of the parallax option on all snippets, background-image urls were being converted from relative to absolute on snippet-drop. This was caused by trying to read the background-image's url and setting it back onto the target, but there is no way to reliably read a background-image url in relative form, so it was returned in absolute form and then written back to the element as is. This commit fixes that by always converting the absolute URL to relative when they are on the same origin as the database. task-2312878 Forward-Port-Of: odoo/odoo#59098
Introduced by: https://github.com/odoo/odoo/commit/f9ef2c8cd980ecb9eee22d4cc43d5291953471ef `self.id` is making an `ensure_one` raising a traceback when trying to open the wizard with more than one selected line. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59078
Original PR description
Introduced by: https://github.com/odoo/odoo/commit/f9ef2c8cd980ecb9eee22d4cc43d5291953471ef `self.id` is making an `ensure_one` raising a traceback when trying to open the wizard with more than one selected line. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59078
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59095
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59095
commit ca3e898481f4091c420a8e9ed498624a591303e9 introduce an editable view for vendor price-list on product variant and template. However this view is missing product_name and product_code that are editable field in the form view. This commit re add them. Fix #59099 Forward-Port-Of: odoo/odoo#59104
Original PR description
commit ca3e898481f4091c420a8e9ed498624a591303e9 introduce an editable view for vendor price-list on product variant and template. However this view is missing product_name and product_code that are editable field in the form view. This commit re add them. Fix #59099 Forward-Port-Of: odoo/odoo#59104
Forward-Port-Of: odoo/odoo#59136
Original PR description
Forward-Port-Of: odoo/odoo#59136
Forward-Port-Of: odoo/odoo#59140
Original PR description
Forward-Port-Of: odoo/odoo#59140
Before this commit, synchronizing an Amazon sale with missing personal information on the customer would create an anonymized partner. As the Amazon API recently stopped to communicate some of those personal information, partners were anonymized although some personal information were provided, hence losing them in the process. This commit changes the behavior of the synchronisation to stop anonymizing partners if some of the expected information is missing and rather create a new partn
Original PR description
Before this commit, synchronizing an Amazon sale with missing personal information on the customer would create an anonymized partner. As the Amazon API recently stopped to communicate some of those…
Before this commit, synchronizing an Amazon sale with missing personal information on the customer would create an anonymized partner. As the Amazon API recently stopped to communicate some of those personal information, partners were anonymized although some personal information were provided, hence losing them in the process. This commit changes the behavior of the synchronisation to stop anonymizing partners if some of the expected information is missing and rather create a new partner with all the available information when it is the customer's first order, or if any information has changed since the last order. If the buyer name if not provided, a placeholder name is used instead. This allows storing all the personal information provided by the API regardless of whether some field could be missing. Additionally, issuing an invoice now relies on the correct contact details, should the personal information be updated after that the order is placed. opw-2327010 Forward-Port-Of: odoo/enterprise#13354
Before this commit, coordinates were fetched all in once because of that, we got banned from openstreetmap's server every time we load the view, it took a long time to load. Now, model doesn't wait the coordinates to be fetched anymore but still fetch them and trigger an update of the view when a coordinate is fetched. Coordinates are fetched every seconds to not get banned from openstreetmap's server. Task id: 2320271 Forward-Port-Of: odoo/enterprise#13155
Original PR description
Before this commit, coordinates were fetched all in once because of that, we got banned from openstreetmap's server every time we load the view, it took a long time to load. Now, model doesn't wait the coordinates to be fetched anymore but still fetch them and trigger an update of the view when a coordinate is fetched. Coordinates are fetched every seconds to not get banned from openstreetmap's server. Task id: 2320271 Forward-Port-Of: odoo/enterprise#13155
As mock was removed from the requirements.txt, it must be used through unittest Forward-Port-Of: odoo/enterprise#13778
Original PR description
As mock was removed from the requirements.txt, it must be used through unittest Forward-Port-Of: odoo/enterprise#13778
Without the "RateRequestTypes" set to "PREFERRED", the service only returns the rate in the account's base currency. This causes an error when we attempt to read the result (in ProviderFedex.fedex_rate_shipment). With RateRequestTypes = PREFERRED Fedex will return the rates in both currencies (the one requested + the base account), so there should be no impact on existing instance. Steps to reproduce (on 12.0 or 13.0): - Configure a warehouse in UK. Make sure to enter a valid UK
Original PR description
Without the "RateRequestTypes" set to "PREFERRED", the service only
returns the rate in the account's base currency. This causes an error
when we attempt to read the result (in
ProviderFedex.fedex_rate_shipment). With RateRequestTypes = PREFERRED
Fedex will return the rates in both currencies (the one requested + the
base account), so there should be no impact on existing instance.
Steps to reproduce (on 12.0 or 13.0):
- Configure a warehouse in UK. Make sure to enter a valid UK address
- I used 10 Downing Street, London SW1A 2AA
- Configure Fedex International shipping method
- Company currency is not relevant - I used USD. It is not necessary for multi currency to be enabled.
- Make a Sales order in USD. Select the UK warehouse as origin, and select a valid US address as destination.
- Add Shipping and click Get Rate
opw-2343445
Forward-Port-Of: odoo/enterprise#13741
Forward-Port-Of: odoo/enterprise#13723And other reported English mistakes in source string Courtesy of Transifex translators Enterprise part of odoo/odoo#59002 Forward-Port-Of: odoo/enterprise#13776
Original PR description
And other reported English mistakes in source string Courtesy of Transifex translators Enterprise part of odoo/odoo#59002 Forward-Port-Of: odoo/enterprise#13776
The template only includes the signature for a verified mandate. This fix marks the mandate as verified right before generating the email, rather than right after. Steps to reproduce the bug: - Activate SDD (not necessary to have credentials for the Settings) - Activate SDD as a Payment Acquirer - Add an IBAN bank account on the BANK journal with BIC - Have a second test IBAN bank account for user - Make payment on webshop using SDD - be sure you select an European country for the a
Original PR description
The template only includes the signature for a verified mandate. This fix marks the mandate as verified right before generating the email, rather than right after. Steps to reproduce the bug: - Activate SDD (not necessary to have credentials for the Settings) - Activate SDD as a Payment Acquirer - Add an IBAN bank account on the BANK journal with BIC - Have a second test IBAN bank account for user - Make payment on webshop using SDD - be sure you select an European country for the address - Go to Accounting > Customers > Direct Debit Mandates - Item is signed on Odoo, but not on the PDF Example video at https://drive.google.com/file/d/1iyyrRUFL4gNm6y9Og-7WhtJNVa9Myl9W/view opw-2336521 Forward-Port-Of: odoo/enterprise#13728
**PURPOSE** When you collapse and expand the group header in Gantt view, the expanded row will not be droppable. like when you drag the pill from different row and try drop into collapsed and expanded row, pill will not be dropped as row is not droppable once it is collapsed and expanded. **SPEC** we have resolved this issue by resetting the row droppable again in updateRow method. Task : 2283977 Forward-Port-Of: odoo/enterprise#13662 Forward-Port-Of: odoo/enterprise#12543
Original PR description
**PURPOSE** When you collapse and expand the group header in Gantt view, the expanded row will not be droppable. like when you drag the pill from different row and try drop into collapsed and expanded row, pill will not be dropped as row is not droppable once it is collapsed and expanded. **SPEC** we have resolved this issue by resetting the row droppable again in updateRow method. Task : 2283977 Forward-Port-Of: odoo/enterprise#13662 Forward-Port-Of: odoo/enterprise#12543
Forward-Port-Of: odoo/enterprise#13766
Original PR description
Forward-Port-Of: odoo/enterprise#13766
fw-port of 1bb802ecfdc9cdc8f72e092d79a53bc3de3cd549 - Create an asset with: Depreciation Dates: Based on Last Day of Purchase Period Prorata Temporis: true Number of Depreciations: 12 Number of Months in a Period: 1 - Compute the depreciation The depreciation day should be the last day of the month, each month. However, it is not the case and ultimately becomes the 28th or 29th. The use case is already taken into account for when Prorata Temporis is false. There is no good reason
Original PR description
fw-port of 1bb802ecfdc9cdc8f72e092d79a53bc3de3cd549 - Create an asset with: Depreciation Dates: Based on Last Day of Purchase Period Prorata Temporis: true Number of Depreciations: 12 Number of Months in a Period: 1 - Compute the depreciation The depreciation day should be the last day of the month, each month. However, it is not the case and ultimately becomes the 28th or 29th. The use case is already taken into account for when Prorata Temporis is false. There is no good reason to not do it in this case. opw-2341728 Forward-Port-Of: odoo/enterprise#13732
Before this commit, when executing the test "simple rendering" there was sometimes a crash because the blockUI div was still in the dom after the test ended. debug mode must be 0 to maximize execution speed and therefore have a chance to reproduce. This was because sign relies on DOM_updated event, which is not interceptable reliably by the test and that this event fired long after the test ended according to QUnit. After this commit and in compliance with b8afb9965d781ab0978a1e7c2db168
Original PR description
Before this commit, when executing the test "simple rendering" there was sometimes a crash because the blockUI div was still in the dom after the test ended. debug mode must be 0 to maximize execution speed and therefore have a chance to reproduce. This was because sign relies on DOM_updated event, which is not interceptable reliably by the test and that this event fired long after the test ended according to QUnit. After this commit and in compliance with b8afb9965d781ab0978a1e7c2db168997ce9d390, we wait until the UI is unblocked to finish the test. Forward-Port-Of: odoo/enterprise#13280