Tuesday, October 6, 2020
48 changes · master
Enhancements to existing features
Automatically generated mailing and campaign source names are now easier to understand and kept unique when duplicates occur. Demo marketing data was also adjusted to avoid unnecessary translation entries, reducing clutter for administrators.
Original PR description
* Simpler and more user friendly generated source name * Avoid duplicate source name in the DB * Add name in mailing.mailing demo data to avoid creating unnecessary i18n lines task id : 2245823
When users test a newly configured outgoing mail server successfully, Odoo now shows a green success notification instead of an orange warning-style message. This makes the result easier to understand and reduces confusion during email setup.
Original PR description
Previously --------------- When user successfully configured outgoing mail server and test connection, system display title and message with 'warning' type in orange box. Now -------- Title is removed and message is updated with 'success' type, will be displayed in green box. Task Id : 2321763
The website editor now shows a clearer confirmation message when a page reload is needed. This helps users better understand what action is required and reduces confusion while editing website content.
Original PR description
PURPOSE The message saying that we need to reload the page isn't clear... SPECIFICATION Before: https://tinyurl.com/y9bkg5pz After: https://tinyurl.com/y9jwmnal task-2349785 Closes https://github.com/odoo/odoo/pull/59115 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
The web editor media dialog now properly shows the option to delete images. This restores an expected editing action that had become hidden, helping users manage page content without confusion.
Original PR description
Make image deletion visible in web editor media dialog. The button was covered by the 'div.o_we_media_dialog_img_wrapper' in commit : 94b59b1 task-2316712
Miscellaneous changes
This random runbot error happens when the tour manager is steps ahead of the rendering: 1. clicks Second Floor button 2. checks T1 - this won't fail even if the Second Floor hasn't finished rendering because Main Floor has tables that start with `T1`. 3. clicks a table in Main Floor with T1 in name 4. Then error because the back to floor button should be Second Floor. Tables that start with `T1` is created in Main Floor during the tour, however, we also have one in Second Floor. To mak
Original PR description
This random runbot error happens when the tour manager is steps ahead of the rendering: 1. clicks Second Floor button 2. checks T1 - this won't fail even if the Second Floor hasn't finished rendering because Main Floor has tables that start with `T1`. 3. clicks a table in Main Floor with T1 in name 4. Then error because the back to floor button should be Second Floor. Tables that start with `T1` is created in Main Floor during the tour, however, we also have one in Second Floor. To make sure that the runbot correctly waits and clicks for the right table, we use T3 in Second Floor instead of it's T1. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59145
This change adds the company country information to bank statements so related screens and logic can use it consistently. It helps ensure country-specific accounting behavior is available where bank statement data is managed.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Linearity is not always perfect, managing more template will sometimes lead to slighlty more than a linear ratio randomly. The maximum observed ratio was 10.9. 12 seems a good value to catch non linear treatment while avoiding false positive. Forward-Port-Of: odoo/odoo#58958 Forward-Port-Of: odoo/odoo#58923
Original PR description
Linearity is not always perfect, managing more template will sometimes lead to slighlty more than a linear ratio randomly. The maximum observed ratio was 10.9. 12 seems a good value to catch non linear treatment while avoiding false positive. Forward-Port-Of: odoo/odoo#58958 Forward-Port-Of: odoo/odoo#58923
The outstanding payment account must be used instead. task: 2348361 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58852 Forward-Port-Of: odoo/odoo#58812
Original PR description
The outstanding payment account must be used instead. task: 2348361 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58852 Forward-Port-Of: odoo/odoo#58812
Updating currency in the form shall not depend on context in default_journal_id, otherwise we may have different behavior on creating bill via Dashboard and via Accounting >> Vendors >> Bills menu opw-2339966 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58977 Forward-Port-Of: odoo/odoo#5
Original PR description
Updating currency in the form shall not depend on context in default_journal_id, otherwise we may have different behavior on creating bill via Dashboard and via Accounting >> Vendors >> Bills menu opw-2339966 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58977 Forward-Port-Of: odoo/odoo#58705
This PR aims at preventing the cluttering of the ServiceWorker's cache by filtering out non-necessary assets and preventing "opaque" responses from being cached. Also, it registers earlier the listener for the PWA install event, allowing to properly show the installation's banner in most of the case. Finally, it fixes the optional URL's language parsing by allowing custom language naming. Forward-Port-Of: odoo/odoo#58994
Original PR description
This PR aims at preventing the cluttering of the ServiceWorker's cache by filtering out non-necessary assets and preventing "opaque" responses from being cached. Also, it registers earlier the listener for the PWA install event, allowing to properly show the installation's banner in most of the case. Finally, it fixes the optional URL's language parsing by allowing custom language naming. Forward-Port-Of: odoo/odoo#58994
In the function `create_missing_dropship_picking_type()`, the way to search companies that already have dropship picking type was not robust enough as it used the translatable `name` field in a search domain and the ORM `search` method used the translated value of `Dropship` name value instead of the raw value. A better approach is to search `stock.picking.type` with a default source location usage set to `supplier` and a default destination location usage set to `customer`. Related to
Original PR description
In the function `create_missing_dropship_picking_type()`, the way to search companies that already have dropship picking type was not robust enough as it used the translatable `name` field in a search domain and the ORM `search` method used the translated value of `Dropship` name value instead of the raw value. A better approach is to search `stock.picking.type` with a default source location usage set to `supplier` and a default destination location usage set to `customer`. Related to upgrade request: #54154 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59117
Currently the help of stock_inventory.date includes: "If the inventory adjustment is validated, date at which the inventory adjustment has been validated." But for some reason this isn't the case. This commit makes it so we now update the `date` when the inventory is validated. Since no one previously complained about this, we only apply it to newly validated inventories and leave existing ones as is. Note this change makes the `accounting_date` help accurate (i.e generated account move
Original PR description
Currently the help of stock_inventory.date includes: "If the inventory adjustment is validated, date at which the inventory adjustment has been validated." But for some reason this isn't the case. This commit makes it so we now update the `date` when the inventory is validated. Since no one previously complained about this, we only apply it to newly validated inventories and leave existing ones as is. Note this change makes the `accounting_date` help accurate (i.e generated account moves already use the date when the inventory is validated when no accounting date set, so before this fix the dates won't match). Discovered during task: 2336455 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58997
Currently when trying to find duplicates of a lead with an email that cannot be normalized and without partner, a crash appears as there is no domain part to form a valid domain. Fix it by returning a void set if no valid email and no valid partner is set on the lead as we cannot determine any duplicate based on void information. Forward-Port-Of: odoo/odoo#59111 Forward-Port-Of: odoo/odoo#59101
Original PR description
Currently when trying to find duplicates of a lead with an email that cannot be normalized and without partner, a crash appears as there is no domain part to form a valid domain. Fix it by returning a void set if no valid email and no valid partner is set on the lead as we cannot determine any duplicate based on void information. Forward-Port-Of: odoo/odoo#59111 Forward-Port-Of: odoo/odoo#59101
Quant search domain was missing a '|', this made it so locations with non-zero quants in it could still be archived. Also added a missing space in warning message when there are multiple locations because it's better that way. Discovered during task: 2336455 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Po
Original PR description
Quant search domain was missing a '|', this made it so locations with non-zero quants in it could still be archived. Also added a missing space in warning message when there are multiple locations because it's better that way. Discovered during task: 2336455 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58998
Previously the ribbon editing UI was missing some indentation symbols that have been added recently in the rest of the web_editor (⌙), this commit adds those where needed. This commit also fixes an issue where both the ribbon editing UI and the ribbon select-menu were visible at the same time, caused by changes to how the visibility of widgets is computed. task-2339986 Forward-Port-Of: odoo/odoo#59077
Original PR description
Previously the ribbon editing UI was missing some indentation symbols that have been added recently in the rest of the web_editor (⌙), this commit adds those where needed. This commit also fixes an issue where both the ribbon editing UI and the ribbon select-menu were visible at the same time, caused by changes to how the visibility of widgets is computed. task-2339986 Forward-Port-Of: odoo/odoo#59077
before this commit, the sample data is displayed in the modal even though there are no records. displaying the sample data in the modal doesn't make sense because search simply not returning any result after this commit, the sample data should not be displayed in modal task - 2311408 Forward-Port-Of: odoo/odoo#55992
Original PR description
before this commit, the sample data is displayed in the modal even though there are no records. displaying the sample data in the modal doesn't make sense because search simply not returning any result after this commit, the sample data should not be displayed in modal task - 2311408 Forward-Port-Of: odoo/odoo#55992
Since fbf347498f1cc7b74ef373179b7bcae201715c24, when opening a view in a dialog, the favorite filters were not loaded. For example on the runbot: 1. In CRM, open any lead, edit it, and open the Customer dropdown 2. Create a custom filter, save it as favorite, and close the dialog 3. Open the dialog again: you don't see your new filter With this commit, you will see your filter at step nr. 3 Closes #58846, as the bug was not present before saas-13.3. Forward-Port-Of: odoo/odoo#59109
Original PR description
Since fbf347498f1cc7b74ef373179b7bcae201715c24, when opening a view in a dialog, the favorite filters were not loaded. For example on the runbot: 1. In CRM, open any lead, edit it, and open the Customer dropdown 2. Create a custom filter, save it as favorite, and close the dialog 3. Open the dialog again: you don't see your new filter With this commit, you will see your filter at step nr. 3 Closes #58846, as the bug was not present before saas-13.3. Forward-Port-Of: odoo/odoo#59109
In its current state, the code contacting the iap service was prone to fail in case of huge batches of leads being processed due to 2 factors: - the call could timeout; - any processed lead that was modified somewhere else in the meantime would trigger a serialization failure and ultimately make the whole batch fail. This commit ensures that we process the leads by smaller batches and that we avoid serialization failures by acquiring a lock on the current batch. We now also avoid us
Original PR description
In its current state, the code contacting the iap service was prone to fail in case of huge batches of leads being processed due to 2 factors: - the call could timeout; - any processed lead that was modified somewhere else in the meantime would trigger a serialization failure and ultimately make the whole batch fail. This commit ensures that we process the leads by smaller batches and that we avoid serialization failures by acquiring a lock on the current batch. We now also avoid useless calls to iap when an email address is linked to well-known email providers to alleviate the payload and speed up the server's reponse. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59065 Forward-Port-Of: odoo/odoo#58533
PURPOSE Priority widget should not be clickable if it has readonly attribute SPEC Priority widget in list view should not have hover effect if it is readonly and also not clickable if it is readonly TASK 2339680 Closes https://github.com/odoo/odoo/issues/40641 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57732
Original PR description
PURPOSE Priority widget should not be clickable if it has readonly attribute SPEC Priority widget in list view should not have hover effect if it is readonly and also not clickable if it is readonly TASK 2339680 Closes https://github.com/odoo/odoo/issues/40641 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57732
Currently, when click on refuse action on applicant it will call the toogle_active and applicant is archived then it will going to open the wizard for refuse reason due to that even if user cancel the wizard the applicant is archived. So in this commit, On click of the 'refuse' on applicant just open the wizard for refuse reason and click of apply archive the applicant with reason. It will not affect the opening of wizard on archive of applicant from action menu. TaskID: 2333037
Original PR description
Currently, when click on refuse action on applicant it will call the toogle_active and applicant is archived then it will going to open the wizard for refuse reason due to that even if user cancel the wizard the applicant is archived. So in this commit, On click of the 'refuse' on applicant just open the wizard for refuse reason and click of apply archive the applicant with reason. It will not affect the opening of wizard on archive of applicant from action menu. TaskID: 2333037 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58629 Forward-Port-Of: odoo/odoo#58345
Steps to reproduce the bug: - Open the calendar view of the quotations in Sales - Select a time slot and enter a summary (A) - Click "Create", fill in the required values and add an order line - Save and Confirm - Click the "Delivery" smart button Bug: The delivery order has the summary (A) for name and not the computed sequence. Cause: Context key 'default_name' is added here: https://github.com/odoo/odoo/blob/0db882ce3eddc88adb3e5046f9b8d14685ffc8a8/addons/web/static/src/js/views
Original PR description
Steps to reproduce the bug: - Open the calendar view of the quotations in Sales - Select a time slot and enter a summary (A) - Click "Create", fill in the required values and add an order line - Save and Confirm - Click the "Delivery" smart button Bug: The delivery order has the summary (A) for name and not the computed sequence. Cause: Context key 'default_name' is added here: https://github.com/odoo/odoo/blob/0db882ce3eddc88adb3e5046f9b8d14685ffc8a8/addons/web/static/src/js/views/calendar/calendar_controller.js#L231 And it's propagated up to here: https://github.com/odoo/odoo/blob/0db882ce3eddc88adb3e5046f9b8d14685ffc8a8/addons/stock/models/stock_picking.py#L483 opw:2335541 Forward-Port-Of: odoo/odoo#59080 Forward-Port-Of: odoo/odoo#58772
- Create a ticket product. - Add it to an event. - Uncheck it as ticket. - Sell it on the website. A traceback is raised here: https://github.com/odoo/odoo/blob/88e32c5af9f47981bebea560de456a1404b4e382/addons/website_event_sale/models/sale_order.py#L88 It happens because a ticket is found, but `new_qty` is a `string` while while `old_qty` is a `float`. It is coming from `add_qty` which is a string while a `float` is expected. opw-2347633 Description of the issue/feature thi
Original PR description
- Create a ticket product. - Add it to an event. - Uncheck it as ticket. - Sell it on the website. A traceback is raised here: https://github.com/odoo/odoo/blob/88e32c5af9f47981bebea560de456a1404b4e382/addons/website_event_sale/models/sale_order.py#L88 It happens because a ticket is found, but `new_qty` is a `string` while while `old_qty` is a `float`. It is coming from `add_qty` which is a string while a `float` is expected. opw-2347633 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58934
This commit makes it so that the icons of the website new-content menu are closer to the icon of the app they are related to. task-2329291 Forward-Port-Of: odoo/odoo#57746
Original PR description
This commit makes it so that the icons of the website new-content menu are closer to the icon of the app they are related to. task-2329291 Forward-Port-Of: odoo/odoo#57746
This patch optimizes the performance of prefetching when iterating on large recordsets. The optimization is *transparent*, i.e., it requires no code change for it to apply. The worst-case scenario for prefetching is the following: the ORM has to fetch a field for a given `record`, `record._prefetch_ids` (its prefetch set) is *very* large (many thousands), and most records in the prefetch set are already in cache. This requires the ORM to iterate a lot on the prefetch set in order to m
Original PR description
This patch optimizes the performance of prefetching when iterating on large recordsets. The optimization is *transparent*, i.e., it requires no code change for it to apply. The worst-case scenario…
This patch optimizes the performance of prefetching when iterating on
large recordsets. The optimization is *transparent*, i.e., it requires
no code change for it to apply.
The worst-case scenario for prefetching is the following: the ORM has to
fetch a field for a given `record`, `record._prefetch_ids` (its prefetch
set) is *very* large (many thousands), and most records in the prefetch
set are already in cache. This requires the ORM to iterate a lot on the
prefetch set in order to make a batch of records not having the field in
cache.
records = model.browse(ids) # large recordset
for record in records:
record.foo # fetch 'foo' every 1k records
When running such a loop on an empty cache, the overhead of prefetching
(determine a batch) grows as the loop progresses. The time complexity
of this loop is actually O(N²)...
The overhead of prefetching is minimal when `record._prefetch_ids` is
about the size of a prefetching unit, i.e., 1k records. This commit
modifies the iterator method such that every record returned by the
iterator has a prefetch set of maximum 1k records.
We measured the time taken by the loop above on an empty cache, before
and after this commit, on a simple model (res.partner.category) with
100k records. The third measure is a reference one: a `_read` on all
prefetched fields (to fill in the cache) followed by the loop.
Total time Time per 1k records
Before this commit 3.690s 30ms - 45ms
After this commit 1.176s 12ms
Read then loop 1.161s -
The measures are enlightening: the overhead of prefetching was more than
200% of the reference time, and the time to prefetch records grows as
the iteration goes on! This commit reduces the overhead of prefetching
to less than 2% of the reference time, and make it scale gracefully with
data size.
Forward-Port-Of: odoo/odoo#59008Correct URL for Runbot Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59055
Original PR description
Correct URL for Runbot Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59055
When we wanted to add data to google spreadsheet in crm or accounting => it raised an error Error because it couldn't find a propriety of an undefined object. Now we're getting the query element from searchModel and not model. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57609
Original PR description
When we wanted to add data to google spreadsheet in crm or accounting => it raised an error Error because it couldn't find a propriety of an undefined object. Now we're getting the query element from searchModel and not model. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57609
This PR fixes multiples bugs in services app. Timesheet : fixes visibility issues on the portal. Expense : hides an unusable action from users to avoid tracebacks. Sale_project : fixes the SO stat button on tasks Project : disables the creation of users from a project form Task : 2299286 Forward-Port-Of: odoo/odoo#58621 Forward-Port-Of: odoo/odoo#58190
Original PR description
This PR fixes multiples bugs in services app. Timesheet : fixes visibility issues on the portal. Expense : hides an unusable action from users to avoid tracebacks. Sale_project : fixes the SO stat button on tasks Project : disables the creation of users from a project form Task : 2299286 Forward-Port-Of: odoo/odoo#58621 Forward-Port-Of: odoo/odoo#58190
This PR fixes a bug that happened when posting accounting entries from an expense report. It also adds the radio button widget on a selection field in sale_expense to avoid user error. Task : 2299286 Forward-Port-Of: odoo/odoo#58625 Forward-Port-Of: odoo/odoo#58188
Original PR description
This PR fixes a bug that happened when posting accounting entries from an expense report. It also adds the radio button widget on a selection field in sale_expense to avoid user error. Task : 2299286 Forward-Port-Of: odoo/odoo#58625 Forward-Port-Of: odoo/odoo#58188
- Go to the Contacts app - Click on the Azure Interior company, or any other company with multiple associated people - Set the country to Mexico - Edit the VAT field and enter the following string: UAC070620MB3 Traceback will happen after hitting save. It happens because `self` is a recordset in this case. opw-2348045 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the C
Original PR description
- Go to the Contacts app - Click on the Azure Interior company, or any other company with multiple associated people - Set the country to Mexico - Edit the VAT field and enter the following string: UAC070620MB3 Traceback will happen after hitting save. It happens because `self` is a recordset in this case. opw-2348045 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59200 Forward-Port-Of: odoo/odoo#59010
This feature description had stayed there since v8. Back at the day, we used to create one tax code per tax the module created. We removed this in v9, as similar result can be achieved by looking at the generic tax report. Forward-Port-Of: odoo/odoo#59127
Original PR description
This feature description had stayed there since v8. Back at the day, we used to create one tax code per tax the module created. We removed this in v9, as similar result can be achieved by looking at the generic tax report. Forward-Port-Of: odoo/odoo#59127
Description of the issue/feature this PR addresses: 1. Lead to loose the tour: Remove the step of the tour that asks to set an address (the address is auto-completed at free trial based on domain name) 2. Bug: At step 3, it redirects to the invoice settings to select a localization, when you click on "install more packages", you are sent back to the sales app. 3. Bug: Tour blocks at last step "send by email" on quotation. After clicking on "sent" on the pop-up, there should be rainbow
Original PR description
Description of the issue/feature this PR addresses: 1. Lead to loose the tour: Remove the step of the tour that asks to set an address (the address is auto-completed at free trial based on domain name) 2. Bug: At step 3, it redirects to the invoice settings to select a localization, when you click on "install more packages", you are sent back to the sales app. 3. Bug: Tour blocks at last step "send by email" on quotation. After clicking on "sent" on the pop-up, there should be rainbow effect to mark the end of the tour. 4. Bug: Sale order line: fix the blue color on Invoiced Quantity only, instead of the full line 5. Put the "sample product" in active= false (it's necessary for the sample invoice but should not be visible to the user, they should create their own) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56347 Forward-Port-Of: odoo/odoo#54134
Before this commit to select a section, an element you had to click on its title in the left panel. After this commit, we can still click on the title but also on the whole line. task-2327182 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56986
Original PR description
Before this commit to select a section, an element you had to click on its title in the left panel. After this commit, we can still click on the title but also on the whole line. task-2327182 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56986
[FIX] account: editable export, traceback on "Tax Cash Basis Entry of" Steps to reproduce the bug: - Select an invoice in the list - Click Action -> Export - Select "I want to update data (import-compatible export)" - Click the field "Tax Cash Basis Entry of" Bug: Traceback Cause: Crashes because of a KeyError here: https://github.com/odoo/odoo/blob/2d860cdddf29b9fbd1a5401082c9f743028d2fb5/addons/web/controllers/main.py#L1743 The KeyError occurs because AccountPartialReconcile h
Original PR description
[FIX] account: editable export, traceback on "Tax Cash Basis Entry of" Steps to reproduce the bug: - Select an invoice in the list - Click Action -> Export - Select "I want to update data (import-compatible export)" - Click the field "Tax Cash Basis Entry of" Bug: Traceback Cause: Crashes because of a KeyError here: https://github.com/odoo/odoo/blob/2d860cdddf29b9fbd1a5401082c9f743028d2fb5/addons/web/controllers/main.py#L1743 The KeyError occurs because AccountPartialReconcile hasn't got a `name` field; `rec_name` is therefore `None`. Setting it to any field fixes the issue and `id` is the safest. opw:2349511 Forward-Port-Of: odoo/odoo#59219 Forward-Port-Of: odoo/odoo#59091
Adding both my individual CLA and corporate CLA (for the company I work for) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58954
Original PR description
Adding both my individual CLA and corporate CLA (for the company I work for) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58954
Although `coupon` is not a single app, when a user tries to install this module alone, warnings are triggered because no access rules are defined. Those warnings are pointing the fact that models without access rules are a bad practice. Forward-Port-Of: odoo/odoo#59193
Original PR description
Although `coupon` is not a single app, when a user tries to install this module alone, warnings are triggered because no access rules are defined. Those warnings are pointing the fact that models without access rules are a bad practice. Forward-Port-Of: odoo/odoo#59193
Ideally we should let background & text-color adapt to the current color-preset. Since icons bg are forced to `$gray-100` though, this commit will just increase readability allowing user's customisation -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59203
Original PR description
Ideally we should let background & text-color adapt to the current color-preset. Since icons bg are forced to `$gray-100` though, this commit will just increase readability allowing user's customisation -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59203
**Description of the issue/feature this PR addresses**: If add share function in a model without `partner_id`, open wizard, select any partner and "Send" appear Exception error. **Current behavior before PR**: Appear Exception error in "Send" button when `partner_id` field not exist in model. **Desired behavior after PR is merged**: Althought model haven't `partner_id` field error exception dissapear in "Share" button wizard. **Impacted versions**: - 12.0 - 13.0 - 14.0
Original PR description
**Description of the issue/feature this PR addresses**: If add share function in a model without `partner_id`, open wizard, select any partner and "Send" appear Exception error. **Current behavior before PR**: Appear Exception error in "Send" button when `partner_id` field not exist in model. **Desired behavior after PR is merged**: Althought model haven't `partner_id` field error exception dissapear in "Share" button wizard. **Impacted versions**: - 12.0 - 13.0 - 14.0 cc @Tecnativa TT25647 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59269 Forward-Port-Of: odoo/odoo#59123
issue occurs due view mode is saved as base view not as extension view. before commit: when user open website on edit mode and drag and drop snippet from snippet panel to sidebar and click save button.changes of user is not visible in sidebar for ex. if user open open website in edit mode and drag and drop Title snippet from snippet panel to Follow Us in sidebar and click on save button website reload automatically after reload website Title snippet is
Original PR description
issue occurs due view mode is saved as base view not as extension view.
before commit:
when user open website on edit mode and drag and drop snippet from
snippet panel to sidebar and click save button.changes of user is not
visible in sidebar
for ex. if user open open website in edit mode and drag and drop
Title snippet from snippet panel to Follow Us in sidebar and click
on save button website reload automatically after reload website Title
snippet is not visible in Follow Us in sidebar.
task-2311520
Forward-Port-Of: odoo/odoo#55908Hide the add images button of the gallery snippet when not in edit mode. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59325 Forward-Port-Of: odoo/odoo#57257
Original PR description
Hide the add images button of the gallery snippet when not in edit mode. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59325 Forward-Port-Of: odoo/odoo#57257
The Ingenico terminal sometimes send messages that odoo does not need, so the body is empty and the conversion of the crc to hex throws an error For the function 'unhexlify(hexstr)' where hexstr must contain an even number of hexadecimal digits (which can be upper or lower case), otherwise a TypeError is raised. So for the hexstr we send a bytestring empty if the inner innerBody is empty Forward-Port-Of: odoo/enterprise#13827
Original PR description
The Ingenico terminal sometimes send messages that odoo does not need, so the body is empty and the conversion of the crc to hex throws an error For the function 'unhexlify(hexstr)' where hexstr must contain an even number of hexadecimal digits (which can be upper or lower case), otherwise a TypeError is raised. So for the hexstr we send a bytestring empty if the inner innerBody is empty Forward-Port-Of: odoo/enterprise#13827
Forward-Port-Of: odoo/enterprise#13825
Original PR description
Forward-Port-Of: odoo/enterprise#13825
Before this commit: When we click on a entry to update amount of days, the total is not updated. The total is only updated when we leave the cell. But it isn't clear when we are on focus on a cell or not. taskID 2346122 Forward-Port-Of: odoo/enterprise#13592 Forward-Port-Of: odoo/enterprise#13549
Original PR description
Before this commit: When we click on a entry to update amount of days, the total is not updated. The total is only updated when we leave the cell. But it isn't clear when we are on focus on a cell or not. taskID 2346122 Forward-Port-Of: odoo/enterprise#13592 Forward-Port-Of: odoo/enterprise#13549
Before this commit: The total in the barchart does not update accordingly taskID 2346114 Forward-Port-Of: odoo/enterprise#13586 Forward-Port-Of: odoo/enterprise#13522
Original PR description
Before this commit: The total in the barchart does not update accordingly taskID 2346114 Forward-Port-Of: odoo/enterprise#13586 Forward-Port-Of: odoo/enterprise#13522
Forward-Port-Of: odoo/enterprise#13580 Forward-Port-Of: odoo/enterprise#13507
Original PR description
Forward-Port-Of: odoo/enterprise#13580 Forward-Port-Of: odoo/enterprise#13507
account_disallowed_expenses: manifest contains entry for unexisting uninstall_hook. account_reports: tries to create a new kind of action without changing the `_table`, meaning it overwrites the base ir_actions table and when uninstalled, deletes said table and all depending tables (ir_act_*) with it, in true kamikaze fashion. opw-2351427 opw-2350868 opw-2350863 (and many others) Forward-Port-Of: odoo/enterprise#13820
Original PR description
account_disallowed_expenses: manifest contains entry for unexisting uninstall_hook. account_reports: tries to create a new kind of action without changing the `_table`, meaning it overwrites the base ir_actions table and when uninstalled, deletes said table and all depending tables (ir_act_*) with it, in true kamikaze fashion. opw-2351427 opw-2350868 opw-2350863 (and many others) Forward-Port-Of: odoo/enterprise#13820
PURPOSE The usual blurry effect behind the helper is missing in the gantt view: SPEC Halo effect should be there around helper. TASK 2323592 Forward-Port-Of: odoo/enterprise#12639
Original PR description
PURPOSE The usual blurry effect behind the helper is missing in the gantt view: SPEC Halo effect should be there around helper. TASK 2323592 Forward-Port-Of: odoo/enterprise#12639
In planning module, when we create & save a new shift with other start & end times than the default one and then we open it & change the allocated percentage, the start & end times are changed. In fact, start & end times are adjusted with our hour interval but it should not. This commit checks if there was an existing start & end datetimes and if there is, it will not update datetimes Task id: 2333145 Forward-Port-Of: odoo/enterprise#13677
Original PR description
In planning module, when we create & save a new shift with other start & end times than the default one and then we open it & change the allocated percentage, the start & end times are changed. In fact, start & end times are adjusted with our hour interval but it should not. This commit checks if there was an existing start & end datetimes and if there is, it will not update datetimes Task id: 2333145 Forward-Port-Of: odoo/enterprise#13677
On mobile, when the user selects a folder in the search panel the action buttons stay disabled, preventing from uploading, add a URL... This commit fixes it by properly re-assigning the merged buttons (into a dropdown) to `this.$buttons` instead of keeping the old node's (now empty) reference. opw-2333922 Forward-Port-Of: odoo/enterprise#13774 Forward-Port-Of: odoo/enterprise#13377
Original PR description
On mobile, when the user selects a folder in the search panel the action buttons stay disabled, preventing from uploading, add a URL... This commit fixes it by properly re-assigning the merged buttons (into a dropdown) to `this.$buttons` instead of keeping the old node's (now empty) reference. opw-2333922 Forward-Port-Of: odoo/enterprise#13774 Forward-Port-Of: odoo/enterprise#13377