Wednesday, October 28, 2020
23 changes · master
Enhancements to existing features
This update simplifies how the mail module sends background requests by letting the central session handling manage empty context information. It reduces duplicate handling in the mail code and supports more consistent request behavior across the system.
Original PR description
PURPOSE we need to pass empty context so it can be overriden in session.js. we should be able to not specify any context and let session handle it. SPECIFICATION - removed empty context from thread rpc - as there is already managed empty context in session, so no need to manage empty context in rpc LINKS Task 2243187 PR https://github.com/odoo/odoo/pull/54512 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The mail app now gives users clearer help when browser push notifications have been blocked. Users can copy the relevant browser settings address directly from the warning, making it easier to re-enable notifications without support help.
Original PR description
PURPOSE Once the push notifications have been blocked, message in the preferences is not straightforward enough for users to allow them. SPECIFICATION User can easily copy current browser setting's URL by copy button in the message. LINKS PR https://github.com/odoo/odoo/pull/47919 Task-2188584 I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Financial report names are now shortened visually when they are too long, helping reports stay clean and easier to scan. This improves the user experience without changing the underlying report data.
Original PR description
Task ID: 2311363
Miscellaneous changes
When we want to upgrade the IoT box to the lastest version we need install kpartx to the third partition. However the source are not up to date and we can't fetch the package. So we must update this partition before fetch the package Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60638 Fo
Original PR description
When we want to upgrade the IoT box to the lastest version we need install kpartx to the third partition. However the source are not up to date and we can't fetch the package. So we must update this partition before fetch the package Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60638 Forward-Port-Of: odoo/odoo#60591
The 'Mark as lost' server action raises an AccessError when executed by a non administrator. Due to de4213b771f641cbc218ebb1f759b09e064100bf opw-2371490 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60857
Original PR description
The 'Mark as lost' server action raises an AccessError when executed by a non administrator. Due to de4213b771f641cbc218ebb1f759b09e064100bf opw-2371490 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60857
Fine-tune of #59524. If the delivery address doesn't have any delivery method assigned, you get an undesired change of behavior: no delivery method is populated in that cases. Note that the delivery method is not a commercial field that is propagated from parent to children. With this patch, we get a very similar behavior, which is fallbacking to the commercial partner's delivery method if there's no delivery method in the delivery address. The only different behavior will be if the
Original PR description
Fine-tune of #59524. If the delivery address doesn't have any delivery method assigned, you get an undesired change of behavior: no delivery method is populated in that cases. Note that the delivery method is not a commercial field that is propagated from parent to children. With this patch, we get a very similar behavior, which is fallbacking to the commercial partner's delivery method if there's no delivery method in the delivery address. The only different behavior will be if the partner of the order is different from the commercial partner of the delivery address. @Tecnativa TT26344 Forward-Port-Of: odoo/odoo#60861 Forward-Port-Of: odoo/odoo#60460
When an event is registered during the tour, a link is clicked without waiting for any result. As a consequence, the tour stops and the browser cookies are cleaned. This leads to random failures because sometimes the remaining requests generated by the link click have enough time to be completed and sometimes not. With this commit a simple step is added, that waits for the clicked link page to be loaded. Forward-Port-Of: odoo/odoo#60875
Original PR description
When an event is registered during the tour, a link is clicked without waiting for any result. As a consequence, the tour stops and the browser cookies are cleaned. This leads to random failures because sometimes the remaining requests generated by the link click have enough time to be completed and sometimes not. With this commit a simple step is added, that waits for the clicked link page to be loaded. Forward-Port-Of: odoo/odoo#60875
task-2362022 Forward-Port-Of: odoo/odoo#60088
Original PR description
task-2362022 Forward-Port-Of: odoo/odoo#60088
When the test starts after 00:00:00 UTC, the test fails. Forward-Port-Of: odoo/odoo#60238
Original PR description
When the test starts after 00:00:00 UTC, the test fails. Forward-Port-Of: odoo/odoo#60238
Analytic defaults keep their old value Value not changing: opw-[2371132](https://www.odoo.com/web#cids=1&id=2371132&menu_id=&model=project.task) Analytic should not be on every line initial: opw-[2269757](https://www.odoo.com/web#cids=1&id=2269757&menu_id=&model=project.task) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60340
Original PR description
Analytic defaults keep their old value Value not changing: opw-[2371132](https://www.odoo.com/web#cids=1&id=2371132&menu_id=&model=project.task) Analytic should not be on every line initial: opw-[2269757](https://www.odoo.com/web#cids=1&id=2269757&menu_id=&model=project.task) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60340
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60829
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60829
Don't delay the insert of partners or channels until it actually takes too much time. Don't await `_initMentionPartnerSuggestions` as it is just nice to have. task-2371485 Forward-Port-Of: odoo/odoo#60826
Original PR description
Don't delay the insert of partners or channels until it actually takes too much time. Don't await `_initMentionPartnerSuggestions` as it is just nice to have. task-2371485 Forward-Port-Of: odoo/odoo#60826
Before this commit, the state of the composer was not properly saving its state when focusing out, which caused erroneous composer states in some corner cases, like when posting messages on mobile in some browsers. This commit fixes this issue. opw-2366374 Co-authored-by: Sébastien Theys <seb@odoo.com> Forward-Port-Of: odoo/odoo#60841
Original PR description
Before this commit, the state of the composer was not properly saving its state when focusing out, which caused erroneous composer states in some corner cases, like when posting messages on mobile in some browsers. This commit fixes this issue. opw-2366374 Co-authored-by: Sébastien Theys <seb@odoo.com> Forward-Port-Of: odoo/odoo#60841
Before this, misc operations always used the balance of the base line as the tax_base_amount of the tax line. This was inconsistent with the invoices, for which we invert its sign when making a sale invoice or a purchase refund (as for those operations, positive amounts are put in credit). This commit should make everything behave in the same way. Forward-Port-Of: odoo/odoo#60831 Forward-Port-Of: odoo/odoo#60548
Original PR description
Before this, misc operations always used the balance of the base line as the tax_base_amount of the tax line. This was inconsistent with the invoices, for which we invert its sign when making a sale invoice or a purchase refund (as for those operations, positive amounts are put in credit). This commit should make everything behave in the same way. Forward-Port-Of: odoo/odoo#60831 Forward-Port-Of: odoo/odoo#60548
Before this commit, with an opened DropdownMenu component, when the user clicks on a Bootstrap's dropdown the DropdownMenu doesn't close. This issue is due to a conflict between the global click listener registered to close the DropdownMenu and the listener registered by the Bootstrap dropdown: the last one prevents the event from bubbling up to the `window` element and be handled by the first one. This commit fixes it by enabling the `capture` flag on the DropdownMenu global click li
Original PR description
Before this commit, with an opened DropdownMenu component, when the user clicks on a Bootstrap's dropdown the DropdownMenu doesn't close. This issue is due to a conflict between the global click listener registered to close the DropdownMenu and the listener registered by the Bootstrap dropdown: the last one prevents the event from bubbling up to the `window` element and be handled by the first one. This commit fixes it by enabling the `capture` flag on the DropdownMenu global click listener, giving it the opportunity to handling it properly and close the DropdownMenu. Note: this commit also fixes an issue when a dialog is opened from a DropdownMenu (like the favorite's delete action) and prevents it from closing in the background (e.g. when the dialog is still opened). opw-1879566 Forward-Port-Of: odoo/odoo#60909 Forward-Port-Of: odoo/odoo#59753
Issue - Install "Accounting" - Enable "Qr Code" - Enable "Join open Invoices" in "Configuration/Follow-up Levels" - Go to "Customers/Follow-up Reports" - Click "Print Letter" button Cause The 'qr_code_urls' variable doesnt exist. Solution Add 'report.account_followup.report_followup_print_all' model and create '_get_report_values' to generate the dict needed by the view opw-2369075 Forward-Port-Of: odoo/enterprise#14442
Original PR description
Issue
- Install "Accounting"
- Enable "Qr Code"
- Enable "Join open Invoices" in "Configuration/Follow-up Levels"
- Go to "Customers/Follow-up Reports"
- Click "Print Letter" button
Cause
The 'qr_code_urls' variable doesnt exist.
Solution
Add 'report.account_followup.report_followup_print_all' model and
create '_get_report_values' to generate the dict needed by the view
opw-2369075
Forward-Port-Of: odoo/enterprise#14442Problem ------- user with no langage defined see only the anchor date on grid view on week mode. The method that get the start and the end of the day depends on the user langage and does not fallback on a default value Solution -------- If no langage is set on the user fallback on default begin and end of the week as defined in the ISO 8601: monday as the begining and sunday as the end. Forward-Port-Of: odoo/enterprise#14448
Original PR description
Problem ------- user with no langage defined see only the anchor date on grid view on week mode. The method that get the start and the end of the day depends on the user langage and does not fallback on a default value Solution -------- If no langage is set on the user fallback on default begin and end of the week as defined in the ISO 8601: monday as the begining and sunday as the end. Forward-Port-Of: odoo/enterprise#14448
BEFORE: some terms are not available to translate AFTER: ther terms are available to translate WHY: * ``trans_export`` cannot magically guess what are possible values for ButtonName in ``_t(ButtonName)``. It just searches for string _t("...") in js files. https://github.com/odoo/odoo/blob/8c988631e615182763098b91f72c534627150c80/odoo/tools/translate.py#L1110-L1117 * Forms ``_t(ButtonName)`` may work only if value of ButtonName is marked for translation somewhere else, but it'
Original PR description
BEFORE: some terms are not available to translate
AFTER: ther terms are available to translate
WHY:
* ``trans_export`` cannot magically guess what are possible values for
ButtonName in ``_t(ButtonName)``. It just searches for string _t("...") in js
files.
https://github.com/odoo/odoo/blob/8c988631e615182763098b91f72c534627150c80/odoo/tools/translate.py#L1110-L1117
* Forms ``_t(ButtonName)`` may work only if value of ButtonName is marked for
translation somewhere else, but it's not the case (there is no such value
in *.pot files)
* field ``redirect_url_text`` contains values made by user, so those terms
cannot be extracted otherwise than marking it as for translate
---
opw-2357399
Forward-Port-Of: odoo/enterprise#14439
Forward-Port-Of: odoo/enterprise#14389The following commit https://github.com/odoo/enterprise/commit/852f6bc was right about removing taxes, but it should be done in all lines and not only for those having l10n_es_reports_mod349_invoice_type = 'A', as we are already doing it for the summary section. We should also do it when computing the total number of operations in the summary (for consistency only, as it is grouped by partner anyway). opw-2358450 Forward-Port-Of: odoo/enterprise#14441 Forward-Port-Of: odoo/enterprise#144
Original PR description
The following commit https://github.com/odoo/enterprise/commit/852f6bc was right about removing taxes, but it should be done in all lines and not only for those having l10n_es_reports_mod349_invoice_type = 'A', as we are already doing it for the summary section. We should also do it when computing the total number of operations in the summary (for consistency only, as it is grouped by partner anyway). opw-2358450 Forward-Port-Of: odoo/enterprise#14441 Forward-Port-Of: odoo/enterprise#14434
Steps to reproduce the bug: - Let's consider a pricelist PL set with 'show public price and discount' - Set on PL a pricelist item PI with 10% of discount on every products - Let's consider a service product P1 set with: - Service tracking = 'Create a task in an existing project' - Project = Field Service - Create a SO with P1 and confirm it - Go to the created task T and add an other product P2 (with button Products) Bug: The discount on the line with P2 was not displayed op
Original PR description
Steps to reproduce the bug: - Let's consider a pricelist PL set with 'show public price and discount' - Set on PL a pricelist item PI with 10% of discount on every products - Let's consider a service product P1 set with: - Service tracking = 'Create a task in an existing project' - Project = Field Service - Create a SO with P1 and confirm it - Go to the created task T and add an other product P2 (with button Products) Bug: The discount on the line with P2 was not displayed opw:2332622 Forward-Port-Of: odoo/enterprise#13411 Forward-Port-Of: odoo/enterprise#13379
STEPS: In Studio change menu order BEFORE: changes are not saved AFTER: changes are saved WHY: parent_id was renamed to parent_menu_id https://github.com/odoo/enterprise/commit/f10b3cdab287d049c0483b3b20c3fa8646bf5697 --- opw-2357116 Forward-Port-Of: odoo/enterprise#14417
Original PR description
STEPS: In Studio change menu order BEFORE: changes are not saved AFTER: changes are saved WHY: parent_id was renamed to parent_menu_id https://github.com/odoo/enterprise/commit/f10b3cdab287d049c0483b3b20c3fa8646bf5697 --- opw-2357116 Forward-Port-Of: odoo/enterprise#14417
The complement for EstadoDeCuentaCombustible was updated to version 1.2, and to allow stamp, is necessary to update the XSD to ensure the validation. More info in https://www.sat.gob.mx/cs/Satellite?blobcol=urldata&blobkey=id&blobtable=MungoBlobs&blobwhere=1579314002476&ssbinary=true opw #2369034 Forward-Port-Of: odoo/enterprise#14350
Original PR description
The complement for EstadoDeCuentaCombustible was updated to version 1.2, and to allow stamp, is necessary to update the XSD to ensure the validation. More info in https://www.sat.gob.mx/cs/Satellite?blobcol=urldata&blobkey=id&blobtable=MungoBlobs&blobwhere=1579314002476&ssbinary=true opw #2369034 Forward-Port-Of: odoo/enterprise#14350
Steps to reproduce: => Install inventory => Install l10n_mx_edi_extended => Select tariff fraction in product opw-2370420 Forward-Port-Of: odoo/enterprise#14373
Original PR description
Steps to reproduce: => Install inventory => Install l10n_mx_edi_extended => Select tariff fraction in product opw-2370420 Forward-Port-Of: odoo/enterprise#14373