Friday, October 30, 2020
25 changes · master
Enhancements to existing features
The company setup form has been reorganized to more closely match the layout used for company contacts. This makes the interface more consistent and easier for users to navigate when managing company information.
Original PR description
The res company and res partner company forms are very similar, if not for a few fields placed differently. This will make them both more similar by moving around a few fields in the res company form view. task id #2358954 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
Fixed an issue where disabling descriptions in the website pricelist snippet did not remove them after saving the page. This helps website editors keep published product pricing sections consistent with their chosen display settings, alongside supporting editor stability updates.
Original PR description
Bug report : > [BVR] Drop a pricelist snippet in your page, disable descriptions, save the page. ---> descriptions are not removed as it should
Miscellaneous changes
Courtesy of translators Reexport .pot of modified modules Forward-Port-Of: odoo/odoo#61002
Original PR description
Courtesy of translators Reexport .pot of modified modules Forward-Port-Of: odoo/odoo#61002
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60739 Forward-Port-Of: odoo/odoo#60689
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60739 Forward-Port-Of: odoo/odoo#60689
An AccessError can be raised when checking Fiscal Position of user's last order if connected user belongs to a different company than the company of the order. opw-2370903 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61005 Forward-Port-Of: odoo/odoo#60972
Original PR description
An AccessError can be raised when checking Fiscal Position of user's last order if connected user belongs to a different company than the company of the order. opw-2370903 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61005 Forward-Port-Of: odoo/odoo#60972
`product_id.invoice_policy` dependency was missing. When changing the policy from "delivery" to "order" of a product, the quantity of invoiceable products was not recomputed and remained 0 Closes odoo/odoo#60674 Forward-Port-Of: odoo/odoo#61015
Original PR description
`product_id.invoice_policy` dependency was missing. When changing the policy from "delivery" to "order" of a product, the quantity of invoiceable products was not recomputed and remained 0 Closes odoo/odoo#60674 Forward-Port-Of: odoo/odoo#61015
Issue - Install "Accounting" - Go to "Configuration/Reconciliation Models" - Create new reconciliation model "Test" with "620000 Bank Fees" account - Go to "Customers/Payments" and try to reconcile a payment via "Manual Operations" by clicking on "Test" button Cause This instruction "st_line.company_currency_id.is_zero(residual_balance)" needs at least one element in st_line Solution Skip this instruction if "st_line" is empty opw-2370034
Original PR description
Issue
- Install "Accounting"
- Go to "Configuration/Reconciliation Models"
- Create new reconciliation model "Test" with "620000 Bank Fees" account
- Go to "Customers/Payments" and try to reconcile a payment via "Manual Operations"
by clicking on "Test" button
Cause
This instruction "st_line.company_currency_id.is_zero(residual_balance)"
needs at least one element in st_line
Solution
Skip this instruction if "st_line" is empty
opw-2370034
Forward-Port-Of: odoo/odoo#60945When printing an invoice with an iban qrcode using l10n_ch module, a little ch flag appears in the center of the qr code. When odoo is started from elsewhere than the root of the odoo code, the flag does not appear. The cause is that a relative path is used to find the flag image. With this commit, an absolute path is computed to find the flag. Forward-Port-Of: odoo/odoo#61043
Original PR description
When printing an invoice with an iban qrcode using l10n_ch module, a little ch flag appears in the center of the qr code. When odoo is started from elsewhere than the root of the odoo code, the flag does not appear. The cause is that a relative path is used to find the flag image. With this commit, an absolute path is computed to find the flag. Forward-Port-Of: odoo/odoo#61043
PURPOSE This merge commit fixes a few wording and view issues on the "event online" layouts, as well as minor templates adjustments. SPECS - Avoid breaking the talk description page when description is very long - Modify all occurrences of "starts at" to "starts on" (better wording) - Move the "hide sponsor" concept from _exhibitor to _track_online To be able to hide the sponsors on the "registration confirmed" template - Hide the sponsor block in "mobile" view (breakpoint md) -
Original PR description
PURPOSE This merge commit fixes a few wording and view issues on the "event online" layouts, as well as minor templates adjustments. SPECS - Avoid breaking the talk description page when description is very long - Modify all occurrences of "starts at" to "starts on" (better wording) - Move the "hide sponsor" concept from _exhibitor to _track_online To be able to hide the sponsors on the "registration confirmed" template - Hide the sponsor block in "mobile" view (breakpoint md) - Have a common css definition for background color based on color field - Reorganize track list display - Make some minor layout adjustments (agenda colors / ...) See underlying commits for details. LINKS Task ID 2325327 Forward-Port-Of: odoo/odoo#56508 Forward-Port-Of: odoo/odoo#56430
When the exchange difference journal entry shouldn't be created, don't check its configuration in order to avoid an UserError in single-currency company. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61039
Original PR description
When the exchange difference journal entry shouldn't be created, don't check its configuration in order to avoid an UserError in single-currency company. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61039
- Activate UoM - Create 3 products: AB, A & B - Create a kit BoM for AB - 1 units of A - 1 kg of B - Sell 1 unit of AB, confirm The error "The unit of measure Units defined on the order line doesn't belong to the same category...". This happens because `_compute_quantity` is called on `stock.moves` related to different products. As a first step, we simply keep only the moves of the same product, meaning that the `qty_available_today` and `free_qty_today` are not supported f
Original PR description
- Activate UoM - Create 3 products: AB, A & B - Create a kit BoM for AB - 1 units of A - 1 kg of B - Sell 1 unit of AB, confirm The error "The unit of measure Units defined on the order line doesn't belong to the same category...". This happens because `_compute_quantity` is called on `stock.moves` related to different products. As a first step, we simply keep only the moves of the same product, meaning that the `qty_available_today` and `free_qty_today` are not supported for kits. opw-2372676 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61057
This causes more trouble than it's worth, especially with mobile keyboards. It also prevents from selecting any text in chat window threads. task-2372553 Part of task-2277543 Forward-Port-Of: odoo/odoo#61031
Original PR description
This causes more trouble than it's worth, especially with mobile keyboards. It also prevents from selecting any text in chat window threads. task-2372553 Part of task-2277543 Forward-Port-Of: odoo/odoo#61031
task-2282325 Forward-Port-Of: odoo/odoo#60524
Original PR description
task-2282325 Forward-Port-Of: odoo/odoo#60524
On mobile, when tours are run on changing month, the "Register Payment" step often fails with the following error: AssertionError: The test code "odoo.startTour('main_flow_tour')" failed Tour main_flow_tour failed at step Register Payment (trigger: .o_statusbar_buttons button:enabled:contains('Register Payment')) Please note before going further: * The main flow is a tour. The tour manager waits for the trigger and the extra trigger to be reachable before executing the step. * On mob
Original PR description
On mobile, when tours are run on changing month, the "Register Payment" step often fails with the following error: AssertionError: The test code "odoo.startTour('main_flow_tour')" failed Tour…
On mobile, when tours are run on changing month, the "Register Payment"
step often fails with the following error:
AssertionError: The test code "odoo.startTour('main_flow_tour')" failed
Tour main_flow_tour failed at step Register Payment (trigger:
.o_statusbar_buttons button:enabled:contains('Register Payment'))
Please note before going further:
* The main flow is a tour. The tour manager waits for the trigger and
the extra trigger to be reachable before executing the step.
* On mobile the status bar buttons are wrapped in a dropdown.
So the stepUtils.statusbarButtonsSteps is composed by two actions:
1 - Open the dropdown if present.
2 - Click on the button.
Before this commit, the extra trigger doesn't look like the best one:
when this tour is executed during month change, the account
module has to perform some heavier (and longer) processes.
When the "Validate" call button is made (previous step), a lot of RPC
are made and, usually, the previous extra trigger works fine.
But for some reasons, the _renderStatusbarButtons is called
between the two steps in the statusbarButtonsSteps.
So this is the flow:
- Running the tour until...
- Click "Validate" button (this generates a bunch of RPC).
- Open the dropdown.
- Some RPC respond, which refresh the "state" and call _renderStatusbarButtons
(dropdown is not open anymore).
- Try to click on "Register Payment" => BUG
(button is present but not visible, so unreachable).
After this commit, the extra trigger is changed to force waiting for
the RPC that change the "state" and call _renderStatusbarButtons
before executing the "Register Payment" step.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#61072
Forward-Port-Of: odoo/odoo#60528Issue - Install "Project" modules - Set user language as "Hebrew" - Go to Project and open any project - Go to 'gantt' view - Try to resize a task Everything is reversed. Cause Jquery-ui 'resizable' widget do not manage RTL feature. Solution Update the the `position.left` props according to the language direction (LTR or RTL). opw-2367692 Forward-Port-Of: odoo/odoo#60823
Original PR description
Issue - Install "Project" modules - Set user language as "Hebrew" - Go to Project and open any project - Go to 'gantt' view - Try to resize a task Everything is reversed. Cause Jquery-ui 'resizable' widget do not manage RTL feature. Solution Update the the `position.left` props according to the language direction (LTR or RTL). opw-2367692 Forward-Port-Of: odoo/odoo#60823
Issue - Install "Time Off" - Create new time off and approve it We can no longer refuse it Cause The refuse button is invisible if the status is not equal to 'validate', in this case it is equal to 'validate1' Solution Change the attrs to display the refuse button when the status is 'validate1' opw-2361929 Forward-Port-Of: odoo/odoo#61033
Original PR description
Issue
- Install "Time Off"
- Create new time off and approve it
We can no longer refuse it
Cause
The refuse button is invisible if the status is not equal to 'validate', in this case it is equal to 'validate1'
Solution
Change the attrs to display the refuse button when the status is 'validate1'
opw-2361929
Forward-Port-Of: odoo/odoo#61033task-2275828 Forward-Port-Of: odoo/odoo#60930
Original PR description
task-2275828 Forward-Port-Of: odoo/odoo#60930
Issue - Install 'Project' module - Set user language as "Hebrew" - Go to Project and open any project - Go to 'gantt' view - Try to drag & drop a task Everything is reversed. Cause The gantt view does not manage RTL feature. Solution Adapt code to work with RTL. related jquery-ui fix : odoo/odoo#60823 opw-2367692 Forward-Port-Of: odoo/enterprise#14412
Original PR description
Issue - Install 'Project' module - Set user language as "Hebrew" - Go to Project and open any project - Go to 'gantt' view - Try to drag & drop a task Everything is reversed. Cause The gantt view does not manage RTL feature. Solution Adapt code to work with RTL. related jquery-ui fix : odoo/odoo#60823 opw-2367692 Forward-Port-Of: odoo/enterprise#14412
Behavior prior to this commit: If a package max weight is specified as 0, this is rounded up to 0.1oz, and the shipments are divided in many packages. Behavior after this commit: If a package max weight is specified as 0, it is not taken into account for splitting shipments (this restores the behavior prior to https://github.com/odoo/enterprise/pull/14293 in this respect) opw-2370965 Forward-Port-Of: odoo/enterprise#14403 Forward-Port-Of: odoo/enterprise#14391
Original PR description
Behavior prior to this commit: If a package max weight is specified as 0, this is rounded up to 0.1oz, and the shipments are divided in many packages. Behavior after this commit: If a package max weight is specified as 0, it is not taken into account for splitting shipments (this restores the behavior prior to https://github.com/odoo/enterprise/pull/14293 in this respect) opw-2370965 Forward-Port-Of: odoo/enterprise#14403 Forward-Port-Of: odoo/enterprise#14391
task-2282325 Forward-Port-Of: odoo/enterprise#14481
Original PR description
task-2282325 Forward-Port-Of: odoo/enterprise#14481
Behavior prior to the fix: When editing the "activity domain" on a marketing campaign activity, the changes are not inherited by the child activities (though it does work when editing the domain on the campaign) Behavior after the fix: Changes to the activity domain are re-computed on the child activities. opw-2367116 Forward-Port-Of: odoo/enterprise#14390 Forward-Port-Of: odoo/enterprise#14362
Original PR description
Behavior prior to the fix: When editing the "activity domain" on a marketing campaign activity, the changes are not inherited by the child activities (though it does work when editing the domain on the campaign) Behavior after the fix: Changes to the activity domain are re-computed on the child activities. opw-2367116 Forward-Port-Of: odoo/enterprise#14390 Forward-Port-Of: odoo/enterprise#14362
- Install Sales, Inventory and Barcode - Go to Inventory > Configuration > Settings and enable "Lots & Serial Numbers" - Go to Inventory > Master Data > Products and create 2 Storable Products tracked by lots: Name | Barcode Product A | AAAA Product B | BBBB - Update Qty on hand to 100 for both Products and use the same lot name during the process (i.e. Lot 1) - Go to Sales and create a Quotation with Product A and Product B - Confirm - A delivery is created -
Original PR description
- Install Sales, Inventory and Barcode - Go to Inventory > Configuration > Settings and enable "Lots & Serial Numbers" - Go to Inventory > Master Data > Products and create 2 Storable Products…
- Install Sales, Inventory and Barcode
- Go to Inventory > Configuration > Settings and enable "Lots & Serial Numbers"
- Go to Inventory > Master Data > Products and create 2 Storable Products tracked by lots:
Name | Barcode
Product A | AAAA
Product B | BBBB
- Update Qty on hand to 100 for both Products and use the same lot name during the process (i.e. Lot 1)
- Go to Sales and create a Quotation with Product A and Product B
- Confirm
- A delivery is created
- Go to Barcode
- Scan "stock.picking" barcode
- Scan barcode of Product A => Product A will be highlighted
- Scan barcode of Lot 1 => Product A will be incremented
- Scan barcode of Product B => Product B will be highlighted
- Scan barcode of Lot 1 => Product A will be incremented instead of Product B
When scanning the barcode of a lot, a search is performed on the move lines to retrieve
the first line where the lot is used. The incremented Product is the one from this line.
However, in this case, several lines (Products) are associated to the scanned lot name.
Only retrieving the first found one is leading to this issue.
This commit will retrieve all move lines associated to the scanned lot.
If there are several lines, the chosen one will depend on the Product associated to the
last scanned line.
opw-2367966
Forward-Port-Of: odoo/enterprise#14492
Forward-Port-Of: odoo/enterprise#14453When doing xpath on the XML response from SAT to extract the status, it is returning a list. We should take the first argument of it to correctly retrieve the status. opw-2362262 Forward-Port-Of: odoo/enterprise#14488
Original PR description
When doing xpath on the XML response from SAT to extract the status, it is returning a list. We should take the first argument of it to correctly retrieve the status. opw-2362262 Forward-Port-Of: odoo/enterprise#14488
Before this commit, when opening the reconciliation page of a given `account.journal`, `action_open_reconcile` was returning an action object containing all the `account.bank.statement.lines` of this journal since the beginning of times. However, only the unreconcilied ones are needed, as the reconciliation widget will ignore the ones that are already reconciled. Since odoo/odoo@caeb782841fc (saas~13.4), `account.bank.statement.lines` have a new stored field `is_reconciled` that allows us
Original PR description
Before this commit, when opening the reconciliation page of a given `account.journal`, `action_open_reconcile` was returning an action object containing all the `account.bank.statement.lines` of this journal since the beginning of times. However, only the unreconcilied ones are needed, as the reconciliation widget will ignore the ones that are already reconciled. Since odoo/odoo@caeb782841fc (saas~13.4), `account.bank.statement.lines` have a new stored field `is_reconciled` that allows us to easily exclude these lines from the output. Let's use it! Forward-Port-Of: odoo/enterprise#14469
Courtesy of translators Reexport .pot of modified modules Forward-Port-Of: odoo/enterprise#14485
Original PR description
Courtesy of translators Reexport .pot of modified modules Forward-Port-Of: odoo/enterprise#14485