This update fixes an issue in the Indian payroll contract form caused by a previous change. It helps ensure payroll contract information can be displayed or edited correctly for users working with India payroll.

Fix bug introduced in odoo/odoo#58120

Behavior prior to this commit: When editing a lead, if we log a note, it will refresh the record and cause the changes to be lost. In version 13, it would only refresh the record if `@` mentions were added. Behavior after this commit: The record will only refresh if it is not dirty. Note: It is not clear why the record would in fact ever need to refresh as there is no visible change on the lead form when a note is logged, whether or not followers are added (the message thread

Behavior prior to this commit:

When editing a lead, if we log a note, it will refresh the record and
cause the changes to be lost.  In version 13, it would only refresh the
record if `@` mentions were added.

Behavior after this commit:

The record will only refresh if it is not dirty.

Note:

It is not clear why the record would in fact ever need to refresh
as there is no visible change on the lead form when a note is logged,
whether or not followers are added (the message thread, which shows the
number of followers, refreshes regardless).  In this commit I chose the
approach which would cause the least change.  There is still a need for
a longer term solution to orchestrate the refreshes, which will take
place once the rest of the web application is converted to use Owl.

opw-2369162



--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#60949

STEPS: * install pad * switch to a company different from res.users::company_id (Default Company for user) * set credentials for that company * Open a form with pad, e.g. project.task BEFORE: it doesn't work, pad_generate_url returns empty values AFTER: it works WHY: Since Odoo 13.0, current company is computed by context values provided by company swither, while user.company_id is default value https://github.com/odoo/odoo/blob/d6d26ea8ac0c160b1fa12f86083965a087aedc75/odoo/a

STEPS:

* install pad
* switch to a company different from res.users::company_id (Default Company for
user)
* set credentials for that company
* Open a form with pad, e.g. project.task

BEFORE: it doesn't work, pad_generate_url returns empty values

AFTER: it works

WHY: Since Odoo 13.0, current company is computed by context values provided by
company swither, while user.company_id is default value

https://github.com/odoo/odoo/blob/d6d26ea8ac0c160b1fa12f86083965a087aedc75/odoo/addons/base/models/res_users.py#L245-L246

https://github.com/odoo/odoo/blob/5c79992f1f0f1b5a8ac4c1f464347abc10a6d8d8/odoo/api.py#L555-L562

---

bug is founding during work on
opw-2369677

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61141

We extract the `price_unit` and `tax_ids` recomputation logic from the `_onchange_product_id` method. This way, it can be called programmatically. opw-2371934 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61459

We extract the `price_unit` and `tax_ids` recomputation logic from the
`_onchange_product_id` method. This way, it can be called
programmatically.

opw-2371934

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61459

Small refactoring to allow calling the method to update the debug manager action independently from `current_action_updated`. Needed for https://github.com/odoo/enterprise/pull/14551. opw-2365539 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61297 Forward-Port-Of: odoo/odoo#61229

Small refactoring to allow calling the method to update the debug
manager action independently from `current_action_updated`.  Needed for
https://github.com/odoo/enterprise/pull/14551.

opw-2365539




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61297
Forward-Port-Of: odoo/odoo#61229

Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61348 Forward-Port-Of: odoo/odoo#61261

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61348
Forward-Port-Of: odoo/odoo#61261

We can have payment.transaction references of >20 characters. This happens automatically if you have long sale.{order,subscription} sequences (especially through website_payment because it adds multiple suffixes, e.g. SO2020/1234567 could turn into SO2020/1234567-12-1-1-1). We POST the full reference via the x_invoice_num variable. Unfortunately Authorize specifies a maximum length of 20 for this field [1]. So when Authorize POSTs back to /payment/authorize/return it only specifies the fi

We can have payment.transaction references of >20 characters. This
happens automatically if you have long sale.{order,subscription}
sequences (especially through website_payment because it adds multiple
suffixes, e.g. SO2020/1234567 could turn into
SO2020/1234567-12-1-1-1). We POST the full reference via the
x_invoice_num variable. Unfortunately Authorize specifies a maximum
length of 20 for this field [1]. So when Authorize POSTs back to
/payment/authorize/return it only specifies the first 20 characters in
x_invoice_num. E.g. when POSTing

{
...
'x_invoice_num': 'SO2020/1234567-12-1-1-1',
...
}

we receive back in /payment/authorize/return:

{
...
'x_invoice_num': 'SO2020/1234567-12-1-',
...
}

This causes _authorize_form_get_tx_from_data() to not find the
transaction which results in a ValidationError.

To fix this also pass the reference in the x_description field. It has
a more generous 255 character limit [1]. Then search using both.

We can't get rid of x_invoice_num entirely because we cannot assume
the payment_authorize.authorize_form will be updated (even more so
because it's a noupdate="1" template). By still using it in
_authorize_form_get_tx_from_data() we ensure that everything keeps
working regardless of whether or not x_description is included in the
template.

[1] p39 in https://www.authorize.net/content/dam/anet-redesign/documents/AIM_guide.pdf

opw-2373433

Forward-Port-Of: odoo/odoo#61102

- Activate UoM - Create 3 products: AB, A & B - Create a kit BoM for AB - 1 units of A - 1 kg of B - Sell 1 unit of AB, confirm The `qty_available_today` and the `free_qty_today` remains zero. We apply a logic which is similar to the computation of the delivered quantity of kits. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at ww

- Activate UoM
- Create 3 products: AB, A & B
- Create a kit BoM for AB
  - 1 units of A
  - 1 kg of B
- Sell 1 unit of AB, confirm

The `qty_available_today` and the `free_qty_today` remains zero.

We apply a logic which is similar to the computation of the delivered
quantity of kits.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61058

task-2366680 Forward-Port-Of: odoo/odoo#60593

task-2366680

Forward-Port-Of: odoo/odoo#60593

This fixes a very obscure bug that happens on workers serving multiple databases. Consider two databases A and B with the same model M, that does not have a field 'name', but has a custom field 'x_name' only on database A. The bug can be reproduced with the module 'account' and its model 'account.register.payments'. Assume the server loads a registry for database A. In that registry, the model M uses 'x_name' as its _rec_name, and the field 'display_name' on model M determines its de

This fixes a very obscure bug that happens on workers serving multiple
databases.  Consider two databases A and B with the same model M, that
does not have a field 'name', but has a custom field 'x_name' only on
database A.  The bug can be reproduced with the module 'account' and its
model 'account.register.payments'.

Assume the server loads a registry for database A.  In that registry,
the model M uses 'x_name' as its _rec_name, and the field 'display_name'
on model M determines its dependencies to be the field 'x_name'.

Now assume the server load a registry for database B.  In that registry,
the model M has no _rec_name.  However, an optimization reuses the field
'display_name' for the model M on the registry of A.  The field's
attribute 'depends' is equal to the tuple ('x_name',).  When the ORM
tries to resolve the field's dependencies, it does not find the field
'x_name' on M and crashes.

In order to avoid this situation, we forbid the usage of 'x_name' as
_rec_name on non-custom models.

OPW 2349238

Forward-Port-Of: odoo/odoo#61436
Forward-Port-Of: odoo/odoo#61395

In some cases, the edit mode on the production form view is not already rendered when hte tour try to write '1' in the qty_producing field. This lead to a fail of the Main Flow Tour. This commit specifically trigger the input tag to be sure the text will be inserted in edit mode. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com

In some cases, the edit mode on the production form view is not already
rendered when hte tour try to write '1' in the qty_producing field. This
lead to a fail of the Main Flow Tour.

This commit specifically trigger the input tag to be sure the text will
be inserted in edit mode.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61437

Create a sale tax 100% included in price Create an invoice with the tax on the line Change unit price The total does not change This occur because when having 100% tax debit/credit are unchanged. So the onchange `_onchange_mark_recompute_taxes` is not triggered and the tax lines are not updated, thus not changing the total (as in this case the invoice total is just the tax value) opw-2370861 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Create a sale tax 100% included in price
Create an invoice with the tax on the line
Change unit price

The total does not change

This occur because when having 100% tax debit/credit are unchanged.
So the onchange `_onchange_mark_recompute_taxes` is not triggered and
the tax lines are not updated, thus not changing the
total (as in this case the invoice total is just the tax value)

opw-2370861

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61356

Since the `sequence` field is used with a `widget="handle"`, we need to sort by sequence, otherwise the reordering has no effect visually. opw-2378255 Forward-Port-Of: odoo/enterprise#14657

Since the `sequence` field is used with a `widget="handle"`, we need to
sort by sequence, otherwise the reordering has no effect visually.

opw-2378255

Forward-Port-Of: odoo/enterprise#14657

- Install Subscriptions and Invoicing (not Accounting) - Go to Subscriptions > Configuration > Subscription Templates - Create or edit a Template (i.e. Mon - Monthly Subscription) with "Send" for "Create Invoice" - Create a Subscription: * Subscription Template: Mon - Monthly Subscription * Subscription Lines: [Any a product] - Switch Subscription state from "Draft" to "In Progress" - Click on "Generate Invoice" button An error is raised when trying to access "attachment_ids" field o

- Install Subscriptions and Invoicing (not Accounting)
- Go to Subscriptions > Configuration > Subscription Templates
- Create or edit a Template (i.e. Mon - Monthly Subscription) with "Send" for "Create Invoice"
- Create a Subscription:
  * Subscription Template: Mon - Monthly Subscription
  * Subscription Lines: [Any a product]
- Switch Subscription state from "Draft" to "In Progress"
- Click on "Generate Invoice" button
An error is raised when trying to access "attachment_ids" field of invoice because
the field is defined in Accounting and not Invoicing.

opw-2371417
opw-2373670

Forward-Port-Of: odoo/enterprise#14653
Forward-Port-Of: odoo/enterprise#14626

Since it is not possible to reconcile lines whose date is before the fiscal lock, they should be ignored by the query that selects the lines to show in the reconciliation widget. Forward-Port-Of: odoo/enterprise#14493

Since it is not possible to reconcile lines whose date is before the fiscal lock, they should be ignored by the query that selects the lines to show in the reconciliation widget.

Forward-Port-Of: odoo/enterprise#14493

When getting the ir rules queries needed to be applied in `_get_bank_statement_line_partners` a simple `replace` is used to rename the table res_partner to p3. This can be an issue when there are fields or other tables with the string 'res_partner' within their names. The usage of a regex ensuring an exact match it is a more robust way to do it. X-original-commit: https://github.com/odoo/odoo/fe3a35006b8397425a702333cf4115a80171f94e Forward-Port-Of: odoo/enterprise#14648

When getting the ir rules queries needed to be applied in
`_get_bank_statement_line_partners` a simple `replace` is used to
rename the table res_partner to p3. This can be an issue when
there are fields or other tables with the string 'res_partner'
within their names. The usage of a regex ensuring an exact match
it is a more robust way to do it.

X-original-commit: https://github.com/odoo/odoo/fe3a35006b8397425a702333cf4115a80171f94e

Forward-Port-Of: odoo/enterprise#14648

That option was only working with the bank reconciliation widget. Forward-Port-Of: odoo/enterprise#14631

That option was only working with the bank reconciliation widget.

Forward-Port-Of: odoo/enterprise#14631

Behavior prior to the commit: When opening a dialog from the home menu (for example, the preference dialog), the home menu stays displayed. Then, when opening a window action from that dialog, the action can't display, since the home menu shadows the web client. For the actions that are triggered from the home menu itself, or the dropdown menu, there is already an override (do_action) in the Enterprise web client that turns off the home menu. But this override does not get invoked for

Behavior prior to the commit:

When opening a dialog from the home menu (for example, the preference
dialog), the home menu stays displayed. Then, when opening a window
action from that dialog, the action can't display, since the home menu
shadows the web client.
For the actions that are triggered from the home menu itself, or the
dropdown menu, there is already an override (do_action) in the
Enterprise web client that turns off the home menu. But this override
does not get invoked for actions that are triggered from within a form.

Behavior after the commit:

The home menu is toggled off when invoking a window action, even when
this is not done directly under the web client.

Note:

- Correction of commit cce561e568ef9a1ff947c3f43d3688aca10e59e3 which did
the override of current_action_updated incorrectly.
- Depends on https://github.com/odoo/odoo/pull/61229
- See comments on https://github.com/odoo/enterprise/pull/14474 for the original PR which had to be corrected

opw-2365539

Forward-Port-Of: odoo/enterprise#14576
Forward-Port-Of: odoo/enterprise#14551

See https://github.com/odoo/enterprise/commit/c28428d5d8b1edf7576130a05998d83ca22651c0 Forward-Port-Of: odoo/enterprise#14632

See https://github.com/odoo/enterprise/commit/c28428d5d8b1edf7576130a05998d83ca22651c0

Forward-Port-Of: odoo/enterprise#14632

- Install hr_payroll - Do not install hr_contract_salary - Go to Payroll > Payslips > All payslips - Create and confirm a payslip An error is raised. Payslip report template is trying to display "contract_type" field of "hr.contract", but this field is defined in "hr_contract_salary" module. opw-2370852 Forward-Port-Of: odoo/enterprise#14562

- Install hr_payroll
- Do not install hr_contract_salary
- Go to Payroll > Payslips > All payslips
- Create and confirm a payslip
An error is raised.

Payslip report template is trying to display "contract_type" field of "hr.contract",
but this field is defined in "hr_contract_salary" module.

opw-2370852

Forward-Port-Of: odoo/enterprise#14562