When validating a picking of an entire package (e.g. internal transfer) that has an associated owner, we are looking for a quant matching stricly all criteria, including the owner. However, the owner is not filled in on the move lines and is only inherited from the picking item. As we do not find the existing quant, we are creating a new one, and we logically have the error message "You cannot move the same package content more than once in the same transfer or split the same package in

When validating a picking of an entire package (e.g. internal transfer)
that has an associated owner, we are looking for a quant matching
stricly all criteria, including the owner. However, the owner is not
filled in on the move lines and is only inherited from the picking item.

As we do not find the existing quant, we are creating a new one, and
we logically have the error message "You cannot move the same package
content more than once in the same transfer or split the same package
into two location."

To allow all transfers of packages, we should add the owner of the quant
when creating the move lines when setting the package level as done.

Description of the issue/feature this PR addresses:
opw-2377634

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61450

When clicking on the stat button "Meetings" on a contact: - before dac91bc18 (November 2019): only meetings with participant matching contact name are shown - after dac91bc18 (November 2019): all meetings are shown => this was because the view was used to create new meeting, so it makes sense to see other meetings and not have a conflict. - after 16206d72 (August 2020): only meeting of the contact are shown - after 7449c8a6 and d11fb611 (November 2020): more complicated logic that wi

When clicking on the stat button "Meetings" on a contact:

- before dac91bc18 (November 2019): only meetings with participant
  matching contact name are shown

- after dac91bc18 (November 2019): all meetings are shown => this was
  because the view was used to create new meeting, so it makes sense to
  see other meetings and not have a conflict.

- after 16206d72 (August 2020): only meeting of the contact are shown

- after 7449c8a6 and d11fb611 (November 2020): more complicated logic
  that will also show partner events, and child partner events.

Since August 2020, when you create a new event, since we are showing a
list of IDs at the time the button was clicked, the new event will not
appear unless you go back to the contact, then click on "Meetings" anew.

With this changeset, we still show a list of IDs, but add an alternative
to also show the events of the current partner (that should be in the
list of IDs, but will match new events).

opw-2374021

Forward-Port-Of: odoo/odoo#61497
Forward-Port-Of: odoo/odoo#61490

STEPS: * install website_sale * setup few delivery options * setup online payment (e.g. paypal) * at website add products to cart and proceed to checkout page * slow down internet speed * click "Pay now" BEFORE: while it's loading, you can change delivery option. So, you have SO changed, while in payment page you see old total amount AFTER: it's not possible to change delivery options WHY: this is dirty hack to fix the issue. A better way should be done in master --- opw-

STEPS:

* install website_sale
* setup few delivery options
* setup online payment (e.g. paypal)
* at website add products to cart and proceed to checkout page
* slow down internet speed
* click "Pay now"

BEFORE: while it's loading, you can change delivery option. So, you have SO
changed, while in payment page you see old total amount

AFTER: it's not possible to change delivery options

WHY: this is dirty hack to fix the issue. A better way should be done in master

---

opw-2324543

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61493

Make the draggable snippets "wizz" when the user clicks on an empty oe_structure and the other way around. Related to task-2363616 Forward-Port-Of: odoo/odoo#60837

Make the draggable snippets "wizz" when the user clicks on an empty
oe_structure and the other way around.

Related to task-2363616

Forward-Port-Of: odoo/odoo#60837

Before this fix, in the pos.payment form, you were able to select any pos.payment.method. Saving with a pos.payment.method that is not allowed in the pos.config of the session caused a traceback. opw-2372025 Forward-Port-Of: odoo/odoo#61686 Forward-Port-Of: odoo/odoo#61369

Before this fix, in the pos.payment form, you were able
to select any pos.payment.method. Saving with a
pos.payment.method that is not allowed in the
pos.config of the session caused a traceback.

opw-2372025

Forward-Port-Of: odoo/odoo#61686
Forward-Port-Of: odoo/odoo#61369

We noticed users may have difficulties noticing where the tip is in the page, even when searching explicitly for it. This commit reviews the design and improves the scss: the tip shape is now made of an unique transformed element with a white border all around. The box shadow was also made more visible. The visibility over white elements stays the same as before but it is now way more visible over dark content (like the website editor panel). task-2357170 Forward-Port-Of: odoo/odoo#617

We noticed users may have difficulties noticing where the tip is in the
page, even when searching explicitly for it. This commit reviews the
design and improves the scss: the tip shape is now made of an unique
transformed element with a white border all around. The box shadow was
also made more visible. The visibility over white elements stays the
same as before but it is now way more visible over dark content (like
the website editor panel).

task-2357170

Forward-Port-Of: odoo/odoo#61708

- Install and configure Mexican localization (https://www.odoo.com/documentation/user/14.0/accounting/fiscal_localizations/localizations/mexico.html) - Go to Accounting > Customers > Invoices and create an Invoice - Confirm it and send it to CFDI (3.3) - Send & Print, then check the invoice The Digital stamp SAT is missing. It is due to the fact that checking value of a retrieved node from CFDI xml may return a False-equivalent value, even if it is not. opw-2371114 Forward-Port-Of:

- Install and configure Mexican localization
(https://www.odoo.com/documentation/user/14.0/accounting/fiscal_localizations/localizations/mexico.html)
- Go to Accounting > Customers > Invoices and create an Invoice
- Confirm it and send it to CFDI (3.3)
- Send & Print, then check the invoice
The Digital stamp SAT is missing.

It is due to the fact that checking value of a retrieved node from CFDI xml may
return a False-equivalent value, even if it is not.

opw-2371114

Forward-Port-Of: odoo/enterprise#14699

Issue - Install 'l10n_ar_edi' module. - Switch to "(AR) Responsable Inscripto" company - In v13 configure an electronic invoice journal, in v14 it comes with the demo data - Create a customer with CUIT = 30-50148338-5 - Create an invoice and select client, product, and electronic invoice journal - Post Traceback raised. Cause Trying to cast VAT (CUIT) to integer. Solution Remove dashes (most common used character) in VAT request param. opw-2376698 Forward-Port

Issue

	- Install 'l10n_ar_edi' module.
	- Switch to "(AR) Responsable Inscripto" company
	- In v13 configure an electronic invoice journal, in v14 it comes with the demo data
	- Create a customer with CUIT = 30-50148338-5
	- Create an invoice and select client, product, and electronic invoice journal
	- Post

	Traceback raised.

Cause

	Trying to cast VAT (CUIT) to integer.

Solution

	Remove dashes (most common used character) in VAT request param.

opw-2376698

Forward-Port-Of: odoo/enterprise#14710

Due to constraint introduced by https://github.com/odoo/odoo/pull/61686, the pos.payment.method should be set in the pos.config. Forward-Port-Of: odoo/enterprise#14720

Due to constraint introduced by https://github.com/odoo/odoo/pull/61686,
the pos.payment.method should be set in the pos.config.

Forward-Port-Of: odoo/enterprise#14720

In field service, if a user adds an existing SO to a task, and if this SO contains at least one section or one note, when clicking on 'x Products', it raises an error. Step to reproduce: 1. Create a SO: - Add few products - Add at least one section or one note 2. Save it 3. Field Service > Create a task - Fill in the field "Sales Order" with the SO 4. Save it 5. Click on "X Products" (in the Task header) => It raises an error with a traceback This fix checks t

In field service, if a user adds an existing SO to a task,
and if this SO contains at least one section or one note,
when clicking on 'x Products', it raises an error.

Step to reproduce:
1. Create a SO:
        - Add few products
        - Add at least one section or one note
2. Save it
3. Field Service > Create a task
	- Fill in the field "Sales Order" with the SO
4. Save it
5. Click on "X Products" (in the Task header)

=> It raises an error with a traceback

This fix checks the SO content and ignores the notes/sections
before generating the products page

OPW-2376431

Forward-Port-Of: odoo/enterprise#14718

Some barcode scanner similate the tipping of the barcode's chars, which could to lead to trigger the shortcut we manually set on the buttons in the Barcode App. The purpose of this commit is to remove these shortcuts and use instead the Odoo default shortcuts (the ones who appears when the user press Alt key). task-2333834 Forward-Port-Of: odoo/enterprise#13621

Some barcode scanner similate the tipping of the barcode's chars, which could to lead to trigger the shortcut we manually set on the buttons in the Barcode App.
The purpose of this commit is to remove these shortcuts and use instead the Odoo default shortcuts (the ones who appears when the user press Alt key).

task-2333834

Forward-Port-Of: odoo/enterprise#13621

- Install `account_sepa` - Create a Swiss company, switch to this company - In the settings, change the SEPA Pain Version to the Swiss version - Save The SEPA Pain Version is reset to the Generic one. There are actually 2 issues: - the condition if/else is incorrect, leading to the Generic version being always selected. - The field is editable, but not stored... So making it editable is useless. opw-2381521 Forward-Port-Of: odoo/enterprise#14721

- Install `account_sepa`
- Create a Swiss company, switch to this company
- In the settings, change the SEPA Pain Version to the Swiss version
- Save

The SEPA Pain Version is reset to the Generic one.

There are actually 2 issues:
- the condition if/else is incorrect, leading to the Generic version
  being always selected.
- The field is editable, but not stored... So making it editable is
  useless.

opw-2381521

Forward-Port-Of: odoo/enterprise#14721

What are the steps to reproduce your issue? 1. Install 'survey' 2. Install 'hr_appraisal_survey' 3. Uninstall 'hr_appraisal_survey' What is currently happening? Error raised when trying to access 'survey' What are you expecting to happen? Use 'survey' normally even after uninstalling 'hr_appraisal_survey' Why is this happening? 'hr_appraisal_survey' modifies the records rules which 'survey' needs when installing. In particular, it adds a co

What are the steps to reproduce your issue?

    1. Install 'survey'

    2. Install 'hr_appraisal_survey'

    3. Uninstall 'hr_appraisal_survey'

What is currently happening?

    Error raised when trying to access 'survey'

What are you expecting to happen?

    Use 'survey' normally even after uninstalling 'hr_appraisal_survey'

Why is this happening?

    'hr_appraisal_survey' modifies the records rules which 'survey' needs when installing.
    In particular, it adds a condition to the domain: `('survey_id.is_appraisal', '=', 'False')`.
    Once 'hr_appraisal_survey' is uninstalled, this condition remains in the rules,
    as 'is_appraisal' was defined by this module,
    'survey' does not launch anymore because the records rules are wrong

How to fix the bug ?

    When uninstalling 'hr_appraisal_survey' replace all domains
    containing a reference to this application with a truly condition (`(1, '=', 1)`).

opw-2378155

Forward-Port-Of: odoo/enterprise#14719

Steps to reproduce: - Activate (manufacturing) Settings > "Work Orders" and "Quality" - Create a new product with Inventory > Routes > "Manufacture" active - Create a new routing in Master Data > Routings - Add a new "Operation" to the routing and upload a multi-page PDF as the worksheet - Add 2 quality control (QC) point "Steps" to the routing where products = <your new product>, operation types = Manufacturing, Work Order Operation = <your new Operation>, and Worksheet Page = <an

Steps to reproduce:
- Activate (manufacturing) Settings > "Work Orders" and "Quality"
- Create a new product with Inventory > Routes > "Manufacture" active
- Create a new routing in Master Data > Routings
- Add a new "Operation" to the routing and upload a multi-page PDF as
  the worksheet
- Add 2 quality control (QC) point "Steps" to the routing where products
  = <your new product>, operation types = Manufacturing, Work Order
  Operation = <your new Operation>, and Worksheet Page = <any page but
  1>
- Create + start a new manufacturing order for your new product
- Go to the workorder and push Process
- Go through (or skip) steps

PDF will not automatically switch to the QC's worksheet page when it
should.

Two things are changed to fix this.
1. One is a refactoring error in the backend that made it so the page
   would never be changed.
2. The other appears to be due to pdfjs upgrade to 2.2.228 making it so
   the pdfViewer being created and set after our widget tries to save
   it. Therefore we save the PDFViewerApplication instead and expect the
   pdfViewer to be created by the time the rest of the page is rendered.

Task: 2353046

Forward-Port-Of: odoo/enterprise#14124

Steps to reproduce: - insert a pivot - update a record aggregated in the pivot such that it falls into anoter group - re-insert the pivot => the record does not appear in its new group. To re-insert the pivot we need to refetch the cache to get the new structure. As a performance optimization, the previous cache was kept and re-used to avoid having to re-apply (potential) filters. This is wrong since some measure might have also changed and the user expect to have up-to-date data in

Steps to reproduce:
- insert a pivot
- update a record aggregated in the pivot such that it falls into anoter group
- re-insert the pivot

=> the record does not appear in its new group.

To re-insert the pivot we need to refetch the cache to get the new structure.
As a performance optimization, the previous cache was kept and re-used to avoid
having to re-apply (potential) filters.
This is wrong since some measure might have also changed and the user expect to
have up-to-date data in a pivot he just inserted.

Unfortunatly, this means potentially fetching the cache twice:
1) without filters to have the full structure (and get up-to-date data)
2) with the filters

Forward-Port-Of: odoo/enterprise#13863