Since 14.0, the javascript code of snippets is moved inside a `/static/src/snippets` directory Will add missing translations of snippets in `website` and `website_form` opw-2381030 Forward-Port-Of: odoo/odoo#61809

Since 14.0, the javascript code of snippets is moved inside a
`/static/src/snippets` directory
Will add missing translations of snippets in `website` and `website_form`

opw-2381030

Forward-Port-Of: odoo/odoo#61809

Before this commit, click on a button stat from the website dashboard, don't always respect the current filter. Date filter was missing, website_id wrongly filtered, or domain not exactly the same. Now, we try to align the dashboard data with the actions. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61883 Forward-Port-Of: odoo/odoo#61333

Before this commit, click on a button stat from the website dashboard, don't always respect the current filter.

Date filter was missing, website_id wrongly filtered, or domain not exactly the same.

Now, we try to align the dashboard data with the actions.



--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61883
Forward-Port-Of: odoo/odoo#61333

PURPOSE When opening the same form view 2 times in quick succession (e.g. clicking twice on the name of an employee from a chat window), there is a traceback SPECIFICATION It should open public employee form and not raise any error LINKS Task - 2371687 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61457

PURPOSE

When opening the same form view 2 times in quick succession (e.g. clicking twice
on the name of an employee from a chat window), there is a traceback

SPECIFICATION

It should open public employee form and not raise any error

LINKS

Task - 2371687

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61457

TO DO: - banner image - link to code Forward-Port-Of: odoo/odoo#61051

TO DO: 

- banner image
- link to code

Forward-Port-Of: odoo/odoo#61051

As part of QoL PR #26267 the way the recursion limit was managed (where it is checked) was changed, effectively decreasing the recursion limit by 1 (to the originally expected limit of 2). According to #29877 this is an inconvenient change / regression in e.g. accounting context: if an object has journal entries, updating a field of a journal item requires 3 levels of indirection (entries -> items -> field). The same would occur if an object is e.g. linked to multiple projects (projects

As part of QoL PR #26267 the way the recursion limit was
managed (where it is checked) was changed, effectively decreasing the
recursion limit by 1 (to the originally expected limit of 2).

According to #29877 this is an inconvenient change / regression in
e.g. accounting context: if an object has journal entries, updating a
field of a journal item requires 3 levels of indirection (entries ->
items -> field). The same would occur if an object is e.g. linked to
multiple projects (projects -> tasks -> field) or SO (-> lines ->
field).

Therefore bump the recursion limit up to 3.

Closes #29877

Forward-Port-Of: odoo/odoo#61934

The compute `_compute_outdated` of `stock.inventory.line` didn't manage inventory lines of different `inventory_id` because of the ensure_one of `_get_quantities` (coming from 68518af). Call `_get_quantities` by inventory and save it in a dict to be use in the loop after. Forward-Port-Of: odoo/odoo#61950

The compute `_compute_outdated` of `stock.inventory.line` didn't manage
inventory lines of different `inventory_id` because of the
ensure_one of `_get_quantities` (coming from
68518af).

Call `_get_quantities` by inventory and save it in a dict to be use in
the loop after.

Forward-Port-Of: odoo/odoo#61950

`display_name` is a magic field automatically added to all models. On a custom/manual model, it depends on `x_name` As it is automatically added by the ORM, `display_name` is considered as a `base` field, while `x_name` is considered as a `manual` field. On loading the transitive dependencies of `display_name` of a custom/manual model, for which the loading of the `x_name` has been skipped because it depends on field not yet loaded, the exception was not ignored because exceptions a

`display_name` is a magic field automatically added to all models.
On a custom/manual model, it depends on `x_name`

As it is automatically added by the ORM,
`display_name` is considered as a `base` field,
while `x_name` is considered as a `manual` field.

On loading the transitive dependencies of `display_name` of a
custom/manual model, for which the loading of the `x_name`
has been skipped because it depends on field not yet loaded,
the exception was not ignored because exceptions
are ignored only for `manual` field,
and `display_name` is considered a `base` field.

Upgrade request 56274

Forward-Port-Of: odoo/odoo#61969
Forward-Port-Of: odoo/odoo#61672

To reproduce the error: 1. Invoicing > Reconciliation Models > Create 2. Add name 3. (Counterpart Values) Add a line - Amount Type: Percentage of balance - Amount: Something bigger than 100 4. Save => UserError raised ("The amount is not a percentage") This is an error. A user should be able to set a percentage greater than 100. The fix removes the constaint. OPW-2375462 Forward-Port-Of: odoo/odoo#61944

To reproduce the error:
1. Invoicing > Reconciliation Models > Create
2. Add name
3. (Counterpart Values) Add a line
        - Amount Type: Percentage of balance
        - Amount: Something bigger than 100
4. Save

=> UserError raised ("The amount is not a percentage")

This is an error. A user should be able to set a percentage greater than 100.
The fix removes the constaint.

OPW-2375462

Forward-Port-Of: odoo/odoo#61944

As of v14 and #53335 (6c97a6d), access to `ir.actions*` models has been restricted to admins, except in specific context such as via the `/web/action/load` route. This commit updates the `/website/action/` route to follow that logic, and allow custom server actions to be exposed as "custom controllers". The principle is that the action is located in a sudo environment, but executed using the request environment. Access will only be permitted if the model of the action is writable for the c

As of v14 and #53335 (6c97a6d), access to `ir.actions*` models has been restricted to admins, except in specific context such as via the `/web/action/load` route.

This commit updates the `/website/action/` route to follow that logic, and allow custom server actions to be exposed as "custom controllers".

The principle is that the action is located in a sudo environment, but executed using the request environment. Access will only be permitted if the model of the action is writable for the current user, or if any action "groups" are set and the user belongs to one of them (cfr f0d37c384b299e5f35cddda02d3f56c6ad37a9a7 for that part).

Forward-Port-Of: odoo/odoo#61863

- Install accounting app - Go to "Charts of Accounts" view by setup panel - Create a new record A traceback occurs because `self.ids` is empty in the context of the creation of a new record. opw-2379463 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62001

- Install accounting app
- Go to "Charts of Accounts" view by setup panel
- Create a new record

A traceback occurs because `self.ids` is empty in the context of the
creation of a new record.

opw-2379463

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#62001

Return RatingPopupComposer from portal_rating_composer.js -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61940

Return RatingPopupComposer from portal_rating_composer.js



--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61940

Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61945

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61945

STEPS: * install module "account" * activate at least one additional languages * go to Settings as set value to "Default Terms & Conditions" * click Save * again at Settings make any changes in any field * click Save BEFORE: * while page is reloading you see alert "Please update translations of: Terms & Conditions" * once page is reloaded the alert is gone * the alert doesn't depend on weither translations are done or not AFTER: no annoying alerts WHY: * in res.config.setting

STEPS:
* install module "account"
* activate at least one additional languages
* go to Settings as set value to "Default Terms & Conditions"
* click Save
* again at Settings make any changes in any field
* click Save

BEFORE:
* while page is reloading you see alert "Please update translations of: Terms &
Conditions"
* once page is reloaded the alert is gone
* the alert doesn't depend on weither translations are done or not

AFTER: no annoying alerts

WHY:
* in res.config.settings any field with default values (i.e. almost all fields)
are marked as changed

  https://github.com/odoo/odoo/blob/d652dbb9655d98b4121ac685e6444bbf7e303292/odoo/addons/base/models/res_config.py#L493
  https://github.com/odoo/odoo/blob/93a2e85ae7b11f9a390f40f74e6d78e1ec876fc3/addons/web/static/src/js/views/basic/basic_model.js#L254

* the idea of alert is suggesting to translate just changed fields

  https://github.com/odoo/odoo/blob/93a2e85ae7b11f9a390f40f74e6d78e1ec876fc3/addons/web/static/src/js/views/form/form_renderer.js#L136-L140

* saving settings always leads to reloading
  https://github.com/odoo/odoo/blob/93a2e85ae7b11f9a390f40f74e6d78e1ec876fc3/odoo/addons/base/models/res_config.py#L639-L647

* So, the alert cannot work for Settings page. There is no better option for
stable branch than just disabling it

---

opw-2346644

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61865

This merge commit slightly improves the crm onboarding: - Move a tip "bubble" position to avoid blocking text - Set the default crm alias to "contact@" instead of "info@" to avoid collisions See underlying commits for more details. Task 2373095 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odo

This merge commit slightly improves the crm onboarding:

- Move a tip "bubble" position to avoid blocking text
- Set the default crm alias to "contact@" instead of "info@" to avoid collisions

See underlying commits for more details.

Task 2373095

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61025

There is a user whose email login is "joe@examplé.com", notice the latin "é" in the domain. This domain is a valid IDNA-2008 domain but the smtplib of python is incompatible with such domain and raises a UnicodeError because the character is not ascii. Note the removed comment about bytestring is a leftover of a dark python2 age and is no more valid. Closes #61972 Forward-Port-Of: odoo/odoo#61994

There is a user whose email login is "joe@examplé.com", notice the
latin "é" in the domain. This domain is a valid IDNA-2008 domain but
the smtplib of python is incompatible with such domain and raises a
UnicodeError because the character is not ascii.

Note the removed comment about bytestring is a leftover of a dark
python2 age and is no more valid.

Closes #61972

Forward-Port-Of: odoo/odoo#61994

opw-2379384 opw-2381830 opw-2381936 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61992

opw-2379384
opw-2381830
opw-2381936



--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#61992

Indeed the non-pinned thread are not displayed in the menu and should not be taken into account for its counter either. task-2389824 Forward-Port-Of: odoo/odoo#62033

Indeed the non-pinned thread are not displayed in the menu and should not be
taken into account for its counter either.

task-2389824

Forward-Port-Of: odoo/odoo#62033

Behavior prior to the commit: The Sign module allows sending a request from the dashboard with a new PDF in 4 ways, but one does not work: - by uploading a new template with the "Upload a PDF Template" button, which creates a new template, then clicking "Send" to immediately send that request - by upload a new template (with "Upload a PDF Template") then clicking "Share", which creates a link that can be accessed to generate a new request on the fly - by clicking "Send a reques

Behavior prior to the commit:

The Sign module allows sending a request from the dashboard with a new
PDF in 4 ways, but one does not work:
 - by uploading a new template with the "Upload a PDF Template" button,
 which creates a new template, then clicking "Send" to immediately send
 that request
 - by upload a new template (with "Upload a PDF Template") then clicking
 "Share", which creates a link that can be accessed to generate a new
 request on the fly
 - by clicking "Send a request", which creates an inactive template and
 send the corresponding request immediately
 - finally, there is also a "Share" button when using the "Send a
 Request" button, which seems to be intended to trigger the same flow as
 when uploading a new template, but since the corresponding template is
 created as Inactive the link does not work.

Behavior after this commit:

The commit removes the 4th, defective, way of sending a request: the
Share button will be removed when sending a request with an inactive
template.

opw-2360525

Forward-Port-Of: odoo/enterprise#14804
Forward-Port-Of: odoo/enterprise#14704

Steps to reproduce the bug: - Log as user on Safari - Make an incoming call to your voip number Bug: A traceback was raised: Error: undefined is not an object (evaluating 'window.Notification.requestPermission().then') https://www.odoo.com/web/content/27161571-49b7377/web.assets_backend.js:10771:353 asyncFunctionResume@[native code] [native code] promiseReactionJob@[native code] Ref: https://stackoverflow.com/questions/38114266/notification-requestpermission-throws-an-error-i

Steps to reproduce the bug:

- Log as user on Safari
- Make an incoming call to your voip number

Bug:

A traceback was raised:

Error: undefined is not an object (evaluating 'window.Notification.requestPermission().then')
https://www.odoo.com/web/content/27161571-49b7377/web.assets_backend.js:10771:353
asyncFunctionResume@[native code]
[native code]
promiseReactionJob@[native code]

Ref: https://stackoverflow.com/questions/38114266/notification-requestpermission-throws-an-error-in-mac-versions-of-safari

opw:2377360

Forward-Port-Of: odoo/enterprise#14799