Sunday, November 22, 2020
4 changes · master
Miscellaneous changes
Before this commit, tips were bouncing from 6px from the anchor to 0px from the anchor. Now they bounce from 3px from the anchor to 3px inside the anchor. Forward-Port-Of: odoo/odoo#61846
Original PR description
Before this commit, tips were bouncing from 6px from the anchor to 0px from the anchor. Now they bounce from 3px from the anchor to 3px inside the anchor. Forward-Port-Of: odoo/odoo#61846
STEPS: * open website page with a form (e.g. /contactus) * click edit * slow down connection speed * click fast between form input lines or change order of the lines BEFORE: * 7 svg files are requested every click * get_authorized_fields is called every click * random error "'classList' of undefined" in SelectUserValueWidget::close * random similar errors when a method is called before initialization AFTER: * svg and get_authorized_fields are requested once * random errors are no
Original PR description
STEPS: * open website page with a form (e.g. /contactus) * click edit * slow down connection speed * click fast between form input lines or change order of the lines BEFORE: * 7 svg files are…
STEPS:
* open website page with a form (e.g. /contactus)
* click edit
* slow down connection speed
* click fast between form input lines or change order of the lines
BEFORE:
* 7 svg files are requested every click
* get_authorized_fields is called every click
* random error "'classList' of undefined" in SelectUserValueWidget::close
* random similar errors when a method is called before initialization
AFTER:
* svg and get_authorized_fields are requested once
* random errors are no reproduced or it's hard to do it
* performance of switching between inputs doesn't depend on connection
speed (though, still not instant)
WHY:
* about changing in SelectUserValueWidget::close: posible reason why
this.menuTogglerEl may be undefined is because method start is async
* the rest updates just implement caching
* ananymous functions is used just to keep original indent:
this.existingFields = (fields => {
---
opw-2368928
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#61598Previously the default message when sharing a blog article was hardcoded, meaning it was always in English and not translatable, this commit fixes that. closes 31173 task-2369420 Forward-Port-Of: odoo/odoo#62070 Forward-Port-Of: odoo/odoo#61665
Original PR description
Previously the default message when sharing a blog article was hardcoded, meaning it was always in English and not translatable, this commit fixes that. closes 31173 task-2369420 Forward-Port-Of: odoo/odoo#62070 Forward-Port-Of: odoo/odoo#61665
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62097
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62097