Monday, November 23, 2020
6 changes · master
Resolved issues and error corrections
Automated menu tests now skip the Add Bank Account option because it connects to an external service. This helps prevent unnecessary outside calls during testing and keeps test runs more reliable without changing normal user behavior.
Original PR description
Since odoo/enterprise@93ac6e5116 a the `Add Bank Account` menu is using an new proxy server. As it's an external service, it's not desirable to click on this menu during the test.
Replacing an image in the web editor now updates the image type correctly, so users see the right editing options for the new file. This prevents irrelevant JPEG settings from appearing when an image is replaced with an SVG, reducing confusion while editing website content.
Original PR description
Prior to this fix, replacing a jpeg image with an svg illustration didn't properly update its mimetype in its dataset. As an effect, the jpeg image options still appeared, that were irrelevant for an svg. This was caused by a premature update of the image in Jabberwock's vdom, before the mimetype was updated, and by the fact that the current image was not being passed to the constructor of the media dialog, causing it to create the image from scratch on save instead of replacing the src attribute of the current image like it did before introducing Jabberwock. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The table options button in the website editor now appears inside the editing toolbar where users expect it. This makes table editing clearer and avoids confusion when managing content layouts.
This fixes an issue where selected filters in dynamic website and shop snippets were lost after saving a page. Website editors can now rely on product snippets keeping their chosen filtering setup, preventing unexpected content changes on published pages.
Original PR description
This addresses the following bug: > Seems that the dynamic snippet data-filter-id attribute is no more saved in master (OK in 14.0). Steps to reproduce: Edit website and drop website_sale dynamic product snippet. After having saved, the data-filter-id attribute has disappeared. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a website editor issue where an empty color value could be lost when editing another setting, which could break the countdown snippet. The change helps keep page editing stable and prevents unexpected errors for users customizing website content.
Original PR description
bug report :
4. [QSM] I have a forward-port reaching master that I r+ despite the fact it is buggy in master: https://github.com/odoo/odoo/pull/61682 what happens is that a call to editorHelpers.setAttribute with an empty string as value works as expected (setting an empty value)... but then if you try to edit another attribute of the same node, the first edited attribute disappears. I made a video showing a bug that could happen because of it: https://drive.google.com/file/d/19R3TVgA_t7R8kVtLsoJLVadv6Kj56s5z/view?usp=sharing
╰─[AGE] note to self regarding the traceback: ColorpickerWidget.convertCSSColorToRgba -> cssColor is undefine
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prPayslip PDFs printed from the menu now use the employee’s preferred language, matching the behavior of the form view print button. This ensures employees receive payroll documents in the expected language regardless of the logged-in user’s language settings.
Original PR description
Steps to reproduce the bug: - Let's consider an employee E with lang's home adress (address_home_id.lang) in French - Let's consider the current logged user U in English - Go to a payslip P of E and print it from button 'Print' in the form view header - A PDF report in french is printed - Print P from the context menu print/payslip Bug: The report is in English Inspired from https://github.com/odoo/odoo/blob/14.0/addons/sale/report/sale_report_templates.xml#L5 https://github.com/odoo/odoo/commit/222fcb137bc9c25d15ee0ad851078caa99e16bdf opw:2380631