Thursday, December 3, 2020
35 changes · master
Resolved issues and error corrections
This fixes an inconsistency where company information could be returned with elevated access in some situations but not others. The change makes access behavior predictable and reduces the risk of operations unintentionally using higher privileges.
Original PR description
Before this commit, the company recordset returned by env.company/env.companies was sometimes in sudo and sometimes not. * If 'allowed_company_ids' was specified in the context, the returned recordset wasn't sudoed. * If no company was specified through the context, company/companies was using env.user.company_id(s) as fallback, which is always sudoed since env.user is always sudoed. With this commit, the behavior is now consistent, the returned recordset is only sudoed if the environment is sudoed. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a display issue where list views on desktop screens showed the first column too close to the edge. Restoring the left padding makes tables easier to scan and gives the interface a more polished appearance.
Original PR description
PURPOSE The listview first column does not have left padding, list view missing left padding on first column. SPEC listview should have left padding on first column. TASK 2393718
Miscellaneous changes
In the hr localization, some of the tax report lines have a line code without tag name and are then used in some formulas. This is incorrect since the tag name is needed to get a balance. This PR will fix this by removing the codes and their appearance in the formulas since these lines have no incidence in the result. Task id #2376724 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61413
Original PR description
In the hr localization, some of the tax report lines have a line code without tag name and are then used in some formulas. This is incorrect since the tag name is needed to get a balance. This PR will fix this by removing the codes and their appearance in the formulas since these lines have no incidence in the result. Task id #2376724 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61413
This PR makes three of the invoicing tour steps optional so that avoiding one doesn't break the flow of the tour anymore. It also entirely removes the step for changing the sequence of invoice as it's an advanced feature task id #2368759 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61219
Original PR description
This PR makes three of the invoicing tour steps optional so that avoiding one doesn't break the flow of the tour anymore. It also entirely removes the step for changing the sequence of invoice as it's an advanced feature task id #2368759 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61219
If we try to write on a multi recordset warehouses, we get a singleton error -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62696
Original PR description
If we try to write on a multi recordset warehouses, we get a singleton error -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62696
When opening all the statement lines from a bank journal, the default sequence was used. We change that for a more user-friendly ordering. Backported and improved version from https://github.com/odoo/odoo/pull/62286 Forward-Port-Of: odoo/odoo#62751 Forward-Port-Of: odoo/odoo#62731
Original PR description
When opening all the statement lines from a bank journal, the default sequence was used. We change that for a more user-friendly ordering. Backported and improved version from https://github.com/odoo/odoo/pull/62286 Forward-Port-Of: odoo/odoo#62751 Forward-Port-Of: odoo/odoo#62731
Description of the issue/feature this PR addresses: Chatter is in wrong place  @tivisse -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62739
Original PR description
Description of the issue/feature this PR addresses: Chatter is in wrong place  @tivisse -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62739
Steps: - Install eCommerce and a delivery method (here, UPS) - Go to Website > Configuration > Settings - Select Pricing > Product Prices > Tax-Included - Go to Configuration > eCommerce/Shipping Methods - Click UPS US and publish it - Go to the eCommerce - Add a product to the cart (here, Customizable Desk) - Click My Cart > Process Checkout - UPS has a delivery price - Select UPS Bug: The delivery price of the UPS line has changed Explanation: When we first arrive to the deli
Original PR description
Steps: - Install eCommerce and a delivery method (here, UPS) - Go to Website > Configuration > Settings - Select Pricing > Product Prices > Tax-Included - Go to Configuration > eCommerce/Shipping…
Steps: - Install eCommerce and a delivery method (here, UPS) - Go to Website > Configuration > Settings - Select Pricing > Product Prices > Tax-Included - Go to Configuration > eCommerce/Shipping Methods - Click UPS US and publish it - Go to the eCommerce - Add a product to the cart (here, Customizable Desk) - Click My Cart > Process Checkout - UPS has a delivery price - Select UPS Bug: The delivery price of the UPS line has changed Explanation: When we first arrive to the delivery selection, prices are computed by calling the carrier's API and are shown straight away. However, when a list item is clicked, a "Delivery" sale order line is generated and the price on the list is copied from that sale order line. Before 13.0, we explicitly asked customers to click on a delivery method to see its price. Now, it's automatically computed. This fix makes sure the taxes are applied to the delivery prices before clicking on them. opw:2392281 Forward-Port-Of: odoo/odoo#62723
Steps to reproduce the bug: - Connect to Odoo on Safari - Go in the POS - Make an order O - Pay O - Print the receipt of O Bug: Nothing was displayed on the receipt opw:2391810 Forward-Port-Of: odoo/odoo#62708
Original PR description
Steps to reproduce the bug: - Connect to Odoo on Safari - Go in the POS - Make an order O - Pay O - Print the receipt of O Bug: Nothing was displayed on the receipt opw:2391810 Forward-Port-Of: odoo/odoo#62708
Because the Belgian edi format is UBL and therefore dependent of the base module Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62730
Original PR description
Because the Belgian edi format is UBL and therefore dependent of the base module Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62730
Improves performances, notably on the method https://github.com/odoo/odoo/blame/14.0/addons/resource/models/resource.py#L487 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62791
Original PR description
Improves performances, notably on the method https://github.com/odoo/odoo/blame/14.0/addons/resource/models/resource.py#L487 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62791
The rating_card view was not translated for a portal user  Forward-Port-Of: odoo/odoo#62687
Original PR description
The rating_card view was not translated for a portal user  Forward-Port-Of: odoo/odoo#62687
Thos two fields shoulb be the same, following https://github.com/odoo/odoo/pull/43985 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62745
Original PR description
Thos two fields shoulb be the same, following https://github.com/odoo/odoo/pull/43985 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62745
Steps to reproduce the bug: 1. Install PoS 2. Change the Shop type to "Bar/restaurant" (into its setting) then save 3. Go into the newly created "Bar" settings 4. Enable "Direct devices" (with any IP) 5. Open a session on Bar 6. Pick a table 7. Ignore the "Connection to the printer Failed" error 8. Take a coca 9. Click on the "Bill" button 10. On the Bill Printing screen, pick "Print" Bug: A traceback was raised opw:2382350 Forward-Port-Of: odoo/odoo#62742
Original PR description
Steps to reproduce the bug: 1. Install PoS 2. Change the Shop type to "Bar/restaurant" (into its setting) then save 3. Go into the newly created "Bar" settings 4. Enable "Direct devices" (with any IP) 5. Open a session on Bar 6. Pick a table 7. Ignore the "Connection to the printer Failed" error 8. Take a coca 9. Click on the "Bill" button 10. On the Bill Printing screen, pick "Print" Bug: A traceback was raised opw:2382350 Forward-Port-Of: odoo/odoo#62742
Bug === Sometimes, the registration testing tour failed. The bug can be semi-deterministic if we add a "sleep(1)" in the endpoint "/event/<event>/track". Reason ====== The reason for that is the service worker. It will pre-fetch all the links in the page (see "prefetch-pages"), so for the "Online Reveal" we will pre-fetch ~100 pages... If the server is slow, it can cause issues. If one endpoint takes some time, all other HTTP requests done by the service worker will be waiting
Original PR description
Bug === Sometimes, the registration testing tour failed. The bug can be semi-deterministic if we add a "sleep(1)" in the endpoint "/event/<event>/track". Reason ====== The reason for that is the…
Bug === Sometimes, the registration testing tour failed. The bug can be semi-deterministic if we add a "sleep(1)" in the endpoint "/event/<event>/track". Reason ====== The reason for that is the service worker. It will pre-fetch all the links in the page (see "prefetch-pages"), so for the "Online Reveal" we will pre-fetch ~100 pages... If the server is slow, it can cause issues. If one endpoint takes some time, all other HTTP requests done by the service worker will be waiting for it. So, at the end of the testing tour, the service worker will continue to make HTTP requests (because it makes the request sequentially) and so some threads will still be created after the tour. Even if "_wait_remaining_requests" is called to wait those threads, as the service worker is still running, it will still continue to make HTTP requests, creating new threads... Fix === The solution to this issue is to kill the service workers of the browser when we stop the tour before waiting for the end of the "HTTP request threads". Task 2381066 Forward-Port-Of: odoo/odoo#62248
We go back to the fake textarea to avoid a flickering created by the `this._textareaRef.el.style.height = "0px";`. This height reset create an unwanted scrollbar jump that could hide the content of the textarea (not aside mode). task-2390354 Forward-Port-Of: odoo/odoo#62588
Original PR description
We go back to the fake textarea to avoid a flickering created by the `this._textareaRef.el.style.height = "0px";`. This height reset create an unwanted scrollbar jump that could hide the content of the textarea (not aside mode). task-2390354 Forward-Port-Of: odoo/odoo#62588
revert of commit 2027721601890870e14b396ae4bb8b6c6dea1ac0 I tried to remove the BoM feature since mrp refactoring it would probably create some issue and I thought that the feature was not used. However it seems that it's write in the documentation and some people really use it so. opw-2393302 Forward-Port-Of: odoo/odoo#62804
Original PR description
revert of commit 2027721601890870e14b396ae4bb8b6c6dea1ac0 I tried to remove the BoM feature since mrp refactoring it would probably create some issue and I thought that the feature was not used. However it seems that it's write in the documentation and some people really use it so. opw-2393302 Forward-Port-Of: odoo/odoo#62804
EAN13 is not a field, barcode is the correct field Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62729
Original PR description
EAN13 is not a field, barcode is the correct field Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62729
- Activate Multi-Currency, set a rate for a foreign currency - Create a product with a cost of 10 - Create a PO - Add the product The price remains 10: it is not converted in the foreign currency. Up to 13.0, a price of zero was set if no seller was found. This was changed in 6b41dbf6831517523d47e to set the standard price instead. However, no currency conversion is performed. opw-2394076 Description of the issue/feature this PR addresses: Current behavior before PR: Desir
Original PR description
- Activate Multi-Currency, set a rate for a foreign currency - Create a product with a cost of 10 - Create a PO - Add the product The price remains 10: it is not converted in the foreign currency. Up to 13.0, a price of zero was set if no seller was found. This was changed in 6b41dbf6831517523d47e to set the standard price instead. However, no currency conversion is performed. opw-2394076 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62809
steps to reproduce: - start a certification with time limit - close it and go to it back after time limit +10 seconds is passed => an "There was an error during the validation of the survey." appear that prevent to finish the survey or do it a second time until the ongoing survey.user_input of the user is deleted. This was done to prevent people from cheating by answering after the time limit end. With this changeset, when we go back to the survey after its end, we will finish it withou
Original PR description
steps to reproduce: - start a certification with time limit - close it and go to it back after time limit +10 seconds is passed => an "There was an error during the validation of the survey." appear that prevent to finish the survey or do it a second time until the ongoing survey.user_input of the user is deleted. This was done to prevent people from cheating by answering after the time limit end. With this changeset, when we go back to the survey after its end, we will finish it without saving the answers. opw-2390623 Forward-Port-Of: odoo/odoo#62752
- use a default scale when the viewer is shown, to fit the document to the available space - avoid using CSS scaling on the canvas, as this makes the output blurry - add some zoom controls in the viewer opw-2389716 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62637
Original PR description
- use a default scale when the viewer is shown, to fit the document to the available space - avoid using CSS scaling on the canvas, as this makes the output blurry - add some zoom controls in the viewer opw-2389716 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62637
It doesn't make sense asking translators to translate "%s (#s)". Also, modelName is already translated as field ir.model::name Forward-Port-Of: odoo/enterprise#14901
Original PR description
It doesn't make sense asking translators to translate "%s (#s)". Also, modelName is already translated as field ir.model::name Forward-Port-Of: odoo/enterprise#14901
Purpose ======= The employee should receive his payslips in his own language. Fix some stuffs that were not translated, or not translated correctly, and update the translation for the module l10n_be_hr_payroll in german, dutch and french to make it work correctly on a real situation. TaskID: 2410761 Forward-Port-Of: odoo/enterprise#15118
Original PR description
Purpose ======= The employee should receive his payslips in his own language. Fix some stuffs that were not translated, or not translated correctly, and update the translation for the module l10n_be_hr_payroll in german, dutch and french to make it work correctly on a real situation. TaskID: 2410761 Forward-Port-Of: odoo/enterprise#15118
It's too complicated and easy to break:  @mart-e can we make an exception and change this term? Forward-Port-Of: odoo/enterprise#15107
Original PR description
It's too complicated and easy to break:  @mart-e can we make an exception and change this term? Forward-Port-Of: odoo/enterprise#15107
In odoo/odoo@6cbe82487 fas and far icons were removed, this commit adds back the previously used `fa` icon. issue seen when checking opw-2389716 Forward-Port-Of: odoo/enterprise#15133
Original PR description
In odoo/odoo@6cbe82487 fas and far icons were removed, this commit adds back the previously used `fa` icon. issue seen when checking opw-2389716 Forward-Port-Of: odoo/enterprise#15133
Steps to reproduce the bug: - Create a BOM kit K with two components C1 and C2 - Set an operation Op on K - Create a quality point QP from Op - Set Register Consumed Materials as Type on QP Bug: It was impossible to select C1 or C2 as product to register opw:2393302 Forward-Port-Of: odoo/enterprise#15130
Original PR description
Steps to reproduce the bug: - Create a BOM kit K with two components C1 and C2 - Set an operation Op on K - Create a quality point QP from Op - Set Register Consumed Materials as Type on QP Bug: It was impossible to select C1 or C2 as product to register opw:2393302 Forward-Port-Of: odoo/enterprise#15130
…' in context. When the key 'no_new_invoice' is present in context, message_post should not make try to parse the attachment with OCR. Forward-Port-Of: odoo/enterprise#15124
Original PR description
…' in context. When the key 'no_new_invoice' is present in context, message_post should not make try to parse the attachment with OCR. Forward-Port-Of: odoo/enterprise#15124
STEPS: * Create a new database and install Marketing automation. * Create a new campaign. BEFORE: There is no "Add New Activity" button AFTER: The button is visible WHY: Odoo 14.0 has mix of owl and old framework code, so we need some workarounds for a while. Here, we need to remount component * https://github.com/odoo/owl/blob/master/doc/reference/component.md If a component is mounted inside an element or a fragment which is not in the DOM, then it will be rendered
Original PR description
STEPS:
* Create a new database and install Marketing automation.
* Create a new campaign.
BEFORE: There is no "Add New Activity" button
AFTER: The button is visible
WHY: Odoo 14.0 has mix of owl and old framework code, so we need some
workarounds for a while. Here, we need to remount component
* https://github.com/odoo/owl/blob/master/doc/reference/component.md
If a component is mounted inside an element or a fragment which is not in the
DOM, then it will be rendered fully, but not active: the mounted hooks will not
be called. This is sometimes useful if we want to load an application in memory.
In that case, we need to mount the root component again in an element which is
in the DOM:
* here is where the component is mounted first:
https://github.com/odoo/odoo/blob/b0934721267632b2be6c2327fd7583fe1ea8d837/addons/web/static/src/js/fields/relational_fields.js#L1112
---
opw-2405108
Forward-Port-Of: odoo/enterprise#15096- Install Studio - Go to Settings > Users & Companies > Users - Activate Studio and create a Report - In Report tab, create a Paper format - Once created, go back to Dashboard and export Cuztomizations For "report.paperformat" model, "__last_update" field (CONCURRENCY_CHECK_FIELD) is also exported. The code removing CONCURRENCY_CHECK_FIELD from fields to export is incorrect. opw-2379754 Forward-Port-Of: odoo/enterprise#15108
Original PR description
- Install Studio - Go to Settings > Users & Companies > Users - Activate Studio and create a Report - In Report tab, create a Paper format - Once created, go back to Dashboard and export Cuztomizations For "report.paperformat" model, "__last_update" field (CONCURRENCY_CHECK_FIELD) is also exported. The code removing CONCURRENCY_CHECK_FIELD from fields to export is incorrect. opw-2379754 Forward-Port-Of: odoo/enterprise#15108
Forward-Port-Of: odoo/enterprise#15061
Original PR description
Forward-Port-Of: odoo/enterprise#15061
…ng payments The 'filtered' is only filtering using the debit account that is wrong. Also, the same logic must be applied as on liquidity lines (blue lines). Forward-Port-Of: odoo/enterprise#15103
Original PR description
…ng payments The 'filtered' is only filtering using the debit account that is wrong. Also, the same logic must be applied as on liquidity lines (blue lines). Forward-Port-Of: odoo/enterprise#15103
Purpose ======= If a public time off occurs the same day than a credit time off, the credit time off should be set on the work entries + the public time off is lost. Currently, nothing is created, preventing to create the payslip batch. Now everything is fine. TaskID: 2410605 Forward-Port-Of: odoo/enterprise#15091
Original PR description
Purpose ======= If a public time off occurs the same day than a credit time off, the credit time off should be set on the work entries + the public time off is lost. Currently, nothing is created, preventing to create the payslip batch. Now everything is fine. TaskID: 2410605 Forward-Port-Of: odoo/enterprise#15091
Steps to reproduce the bug: - Enable the option "Reprint Receipt" in the POS settings and set a loyalty program LP such as 1€ make 10 points - Open a session in the POS - Set a customer C - Add a product P at 100€ - Make the payment - 10000 points has been won - Click on button 'New Order' - Click on the loop and chosse the order you just paid - Print the receipt Bug: The total points was 20000 instead of 10000 opw:2388558 Forward-Port-Of: odoo/enterprise#14983
Original PR description
Steps to reproduce the bug: - Enable the option "Reprint Receipt" in the POS settings and set a loyalty program LP such as 1€ make 10 points - Open a session in the POS - Set a customer C - Add a product P at 100€ - Make the payment - 10000 points has been won - Click on button 'New Order' - Click on the loop and chosse the order you just paid - Print the receipt Bug: The total points was 20000 instead of 10000 opw:2388558 Forward-Port-Of: odoo/enterprise#14983
If a complement is added (External Trade for example), the prefix and namespace must be ser in the ``Comprobante`` to avoid the next error: ``` Code : CCE999 Message : El prefijo y namespace usados para comercio exterior son incorrectos o no están localizados a nivel cfdi:Comprobante. ``` Now is fixed. Note: Is not the better fix, because adds the prefix in all CFDIs, but is the same solution that here: https://github.com/odoo/enterprise/commit/1265284c0d6d0cfa1103bb10d2b6abeb5494e
Original PR description
If a complement is added (External Trade for example), the prefix and namespace must be ser in the ``Comprobante`` to avoid the next error: ``` Code : CCE999 Message : El prefijo y namespace usados para comercio exterior son incorrectos o no están localizados a nivel cfdi:Comprobante. ``` Now is fixed. Note: Is not the better fix, because adds the prefix in all CFDIs, but is the same solution that here: https://github.com/odoo/enterprise/commit/1265284c0d6d0cfa1103bb10d2b6abeb5494e3a5 Forward-Port-Of: odoo/enterprise#15056
A user with read access to a sale subscription can not post any message. To reproduce the error: 1. Use an account with "See Subscriptions" as access rights 2. Generate a subscription 3. Try to post a comment => No permission OPW-2400241 Forward-Port-Of: odoo/enterprise#15081
Original PR description
A user with read access to a sale subscription can not post any message. To reproduce the error: 1. Use an account with "See Subscriptions" as access rights 2. Generate a subscription 3. Try to post a comment => No permission OPW-2400241 Forward-Port-Of: odoo/enterprise#15081