Wednesday, December 9, 2020
15 changes · master
Enhancements to existing features
Odoo can now pass a setting that prevents users from selecting multiple related records when opening a sub-record dialog. This helps guide users through workflows where related items, such as marketing automation activities, need to be created and linked one at a time.
Original PR description
…option The open_one2many_record trigger method now takes the disable_multiple_selection option in parameter to pass it to the FormViewDialog constructor. Task ID : 2087993 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
This fixes an intermittent automated test issue where the website editor cleanup could finish after the test had already ended. The change helps keep development validation stable and reduces false failures in the build process.
Original PR description
Fix an error in the QUnit tests that would sometimes pop up when the `editor.stop()` is a bit slow and the QUnit test case is over before the editor html is properly cleaned.
**Bug report :**
[XDO] Undeterministic runbot error: https://runbot.odoo.com/runbot/build/5082722 Body still contains undesirable elements: jw-follow-range
╰─[DMO] This was already reported and already marked as fixed. However, it seems this bug still appears as this build is from master today (Nov 19). If I remember correctly, the fix was to add an await in the test for the closing of the editor. However, I was surprised that this await wasn't needed in the other editor tests. Maybe this is why the bug is till there ? That it is another test that exhibits the same shortcoming ?
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prMiscellaneous changes
Fix a bug introduced by #62032 and which causing the creation of unwanted additional SO line with multistep delivery. Forward-Port-Of: odoo/odoo#63041
Original PR description
Fix a bug introduced by #62032 and which causing the creation of unwanted additional SO line with multistep delivery. Forward-Port-Of: odoo/odoo#63041
This update fixes and stabilizes tests across several country-specific accounting and e-invoicing features. It helps ensure localization features work reliably regardless of demo data or currency settings, reducing risk in compliance-related workflows.
Steps to reproduce: - Create a customer invoice I for a total of 1000€ - Confirm I - Register a payment Bug: The default amout in the wizard was 0€ instead of 1000€ The default amount is computed by _get_wizard_values_from_batch with the sum of amount_residual of all the lines. But in function _compute_amount_residual, it checked line.id and this case, all the lines were in cache with NewId opw:2413064 Forward-Port-Of: odoo/odoo#63023
Original PR description
Steps to reproduce: - Create a customer invoice I for a total of 1000€ - Confirm I - Register a payment Bug: The default amout in the wizard was 0€ instead of 1000€ The default amount is computed by _get_wizard_values_from_batch with the sum of amount_residual of all the lines. But in function _compute_amount_residual, it checked line.id and this case, all the lines were in cache with NewId opw:2413064 Forward-Port-Of: odoo/odoo#63023
Create a coupon code use it in a quote A cancel the quote A use it in a quote B confirm B go back to quote A set to quotation confirm Result: you used the coupon code twice opw-2410684 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62916 Forward-Port-Of: odoo/odoo#62767
Original PR description
Create a coupon code use it in a quote A cancel the quote A use it in a quote B confirm B go back to quote A set to quotation confirm Result: you used the coupon code twice opw-2410684 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62916 Forward-Port-Of: odoo/odoo#62767
…plate id changes Fine-tuning of 0106fcd59c8c97b1a1e39a263f305650978c0606 Have a SO with a partner in another language Apply a quote template to a SO Customize the portal view to show website_description of a product on the template Translate it Show the SO on the portal Before this commit, the description of the product was not translated This was because the field was not included in the onchange of template_id causing that field to never have changed, that is, it kept the descr
Original PR description
…plate id changes Fine-tuning of 0106fcd59c8c97b1a1e39a263f305650978c0606 Have a SO with a partner in another language Apply a quote template to a SO Customize the portal view to show website_description of a product on the template Translate it Show the SO on the portal Before this commit, the description of the product was not translated This was because the field was not included in the onchange of template_id causing that field to never have changed, that is, it kept the description done injected with the first write After this commit, the description is changed according to the partner's lang opw-2366738 Forward-Port-Of: odoo/odoo#62999
Before this commit: - If the user did not have sufficient rights (only group_hr_timesheet_user), then the update of the SOL on the task did not trigger an update on all not invoiced timesheets but only on the one of the user. - An exception was raised when updating the sale_line_id of the sale_line_employee_ids of a project as it tries to update the related employees project timesheets (which can be different from the current user). After this co
Original PR description
Before this commit:
- If the user did not have sufficient rights (only group_hr_timesheet_user),
then the update of the SOL on the task did not trigger an update on all
not invoiced timesheets but only on the one of the user.
- An exception was raised when updating the sale_line_id of the
sale_line_employee_ids of a project as it tries to update
the related employees project timesheets (which can be different
from the current user).
After this commit:
- All the not invoiced timesheets of the task are updated when changing
the task SOL.
- The exception will not be thrown as the write opperation is made
with sudo rights.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#62678Bug === When we start the Event tour, if we go outside of Event during the tour we might see the tour bubble in the other application. It should be visible only in Event. Task 2381898 Forward-Port-Of: odoo/odoo#62736
Original PR description
Bug === When we start the Event tour, if we go outside of Event during the tour we might see the tour bubble in the other application. It should be visible only in Event. Task 2381898 Forward-Port-Of: odoo/odoo#62736
STEPS: * install pos_cache in clean database without demo * open pos * click OK on popup "Would you like to load demo data" BEFORE: error, products are not loaded even after refreshing AFTER: no errors, products are loaded Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62955
Original PR description
STEPS: * install pos_cache in clean database without demo * open pos * click OK on popup "Would you like to load demo data" BEFORE: error, products are not loaded even after refreshing AFTER: no errors, products are loaded Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62955
This case shouldn't appear in a normal usage of the statement lines because there is no way to cancel them. However, this case should be supported in 14.0 due to a choice we made for the migration. Indeed, we don't want to create draft journal entries in a locked period during the migration but the statement lines that are not reconciled in a locked period shouldn't be deleted in order to keep the statement starting/ending balance consistency. So, the journal entries created in a locked perio
Original PR description
This case shouldn't appear in a normal usage of the statement lines because there is no way to cancel them. However, this case should be supported in 14.0 due to a choice we made for the migration. Indeed, we don't want to create draft journal entries in a locked period during the migration but the statement lines that are not reconciled in a locked period shouldn't be deleted in order to keep the statement starting/ending balance consistency. So, the journal entries created in a locked period for not reconciled statement lines are cancelled and then, we don't want to block the locking of any period because of that. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63097
Remove traceback by checking if the label is undefined or not TaskID: 2352438 Forward-Port-Of: odoo/enterprise#14302
Original PR description
Remove traceback by checking if the label is undefined or not TaskID: 2352438 Forward-Port-Of: odoo/enterprise#14302
… set. Before, if no bank was set in the invoice (e. g. cash payment), the generic RfCEmisorCtaOrd for foreign countries was set, implying that a financial institution is involved. It should simply not be set. See Task 2363916 Forward-Port-Of: odoo/enterprise#15200
Original PR description
… set. Before, if no bank was set in the invoice (e. g. cash payment), the generic RfCEmisorCtaOrd for foreign countries was set, implying that a financial institution is involved. It should simply not be set. See Task 2363916 Forward-Port-Of: odoo/enterprise#15200
When the user tried to "Add a line" (Alt+i), the timer for the project with key "i" was also increased. This commit ensures the project's timer are not incremented when the Alt key is pressed. TaskID: 2373824 Forward-Port-Of: odoo/enterprise#14520
Original PR description
When the user tried to "Add a line" (Alt+i), the timer for the project with key "i" was also increased. This commit ensures the project's timer are not incremented when the Alt key is pressed. TaskID: 2373824 Forward-Port-Of: odoo/enterprise#14520
Sometimes, importing a Coda file fails because the bank add comments on a bank statement by adding a line with an amount at zero. With this change, the statement lines will have an additional filter, which will remove lines with an amount at zero before creating the bank statement in odoo. task id #2403369 Forward-Port-Of: odoo/enterprise#15057
Original PR description
Sometimes, importing a Coda file fails because the bank add comments on a bank statement by adding a line with an amount at zero. With this change, the statement lines will have an additional filter, which will remove lines with an amount at zero before creating the bank statement in odoo. task id #2403369 Forward-Port-Of: odoo/enterprise#15057