Odoo Changelog — 2020-12-16

Wednesday, December 16, 2020

20 changes · master

Improvements(1)

Enhancements to existing features

[IMP] test_lint: adjust ES version for supported browsers

Coremastertest_lint

The testing rules for Odoo’s JavaScript code now align with the browsers currently supported by Odoo 14 and later. This allows teams to use newer browser capabilities already present in Odoo while dropping checks aimed at outdated Edge and older iOS versions.

Original PR description

This reverts commit d431f94c759f9811c640d81a274e90301276d001 and even upgrade the EcmaScript version further to ES10/2019. The original commit mainly targeted the support of MS Edge (pre-Chromium)…

This reverts commit d431f94c759f9811c640d81a274e90301276d001 and even
upgrade the EcmaScript version further to ES10/2019.

The original commit mainly targeted the support of MS Edge
(pre-Chromium) and earlier versions of iOS 11.

As with the release of Odoo 14, we don't support either of those (MS
Edge only Chromium-based and iOS 12), the original restriction can be
lifted and again target EcmaScript 9/2018.

But furthermore, some features of ES10/2019 are already in use in Odoo
14+ (e.g. `Object.fromEntries()` used in SpreadSheet, PoS, WebEditor,
Website Sale...) and the only browser not supporting them is Safari on
iOS versions < 12.2.

As there is no drop of supported devices between iOS 11 and 12 and they
all have access to - at least - the latest revision of iOS 12 (cf.
12.5), it looks reasonable to target the latest revision only and not
the earlier ones. This policy also matches the "ever-green-browsers"
policy applied on desktop.

Note: please note that the tool (es-check) used for testing the
EcmaScript version targeted has for primary goal to catch unsupported
syntax and reserved keywords only, but not the actual APIs available for
a given EcmaScript version. (e.g. async/await keywords or string
literals are tested *but not* Object.fromEntries() or
Array.prototype.flatMap()).

References:
- https://kangax.github.io/compat-table/es2016plus/
- https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/fromEntries
- https://en.wikipedia.org/wiki/IOS_12

#browser support#javascript#testing

Other(19)

Miscellaneous changes

[FW][FIX] lunch: Use extra toppings without problem

PR #63435

Coremasterlunch

Original PR description

1) Extra Items

Issue: Adding an extra to one menu item, automatically adds it to the other food items in the same order.

Expected Behavior: When adding an extra, it should only be associated to
the food item for which it was selected, and NOT applied to the other ordered items.
For example, if I select a "Ranch" dressing for the "Chef Salad",
the ranch should not appear as an extra for the "Cheeseburger" or "Cookie of the Day".

2) Unable to Submit Certain Orders

Issue: Odoo prevents the user from submitting an order in the following case
(better illustrated through an example). If you select a "Chef Salad", you will be prompted to select a "Dressing Choice",
because the configuration is set to select one and only one extra.
You cannot add the salad to the cart without selecting a dressing,
nor can you proceed if you have more than one dressing selected;
this is functioning as expected. The problem, however, comes when you
select a dressing and add the salad to the cart, and now you try to add a
dressing as its own order item (separate from any salad). Even though the
salad has its own dressing selected, and the separate dressing is its own item,
the error message: "You have to order one and only one Dressing choice" appears and
prevents the order from being submitted. This issue may be a consequence of the behavior observed in the first issue.

Expected Behavior: The user should be able to submit the order in
this case because the salad had only one dressing associated with it,
and the extra dressing is supposed to be its own item.
This should not create a conflict with the "only one" extra logic.

Step to reproduce (video: edv)
Reproducible on runbot.
1) Extra Items
https://drive.google.com/file/d/1yos9coFqd55pq8qNbNs1OqGNMNSdgxDX/view

2) Unable to Submit Certain Orders
https://drive.google.com/file/d/1M0ZEElu-hYwU9bmCwEx_tqEZRAPG_UEt/view

opw-2391070

Forward-Port-Of: odoo/odoo#63228

This reverts commit d431f94c759f9811c640d81a274e90301276d001 and even upgrade the EcmaScript version further to ES10/2019. The original commit mainly targeted the support of MS Edge (pre-Chromium) and earlier versions of iOS 11. As with the release of Odoo 14, we don't support either of those (MS Edge only Chromium-based and iOS 12), the original restriction can be lifted and again target EcmaScript 9/2018. But furthermore, some features of ES10/2019 are already in use in Odoo 14+ (e.g. `Object.fromEntries()` used in SpreadSheet, PoS, WebEditor, Website Sale...) and the only browser not supporting them is Safari on iOS versions < 12.2. As there is no drop of supported devices between iOS 11 and 12 and they all have access to - at least - the latest revision of iOS 12 (cf. 12.5), it looks reasonable to target the latest revision only and not the earlier ones. This policy also matches the "ever-green-browsers" policy applied on desktop. Note: please note that the tool (es-check) used for testing the EcmaScript version targeted has for primary goal to catch unsupported syntax and reserved keywords only, but not the actual APIs available for a given EcmaScript version. (e.g. async/await keywords or string literals are tested *but not* Object.fromEntries() or Array.prototype.flatMap()). References: - https://kangax.github.io/compat-table/es2016plus/ - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/fromEntries - https://en.wikipedia.org/wiki/IOS_12

1) Extra Items Issue: Adding an extra to one menu item, automatically adds it to the other food items in the same order. Expected Behavior: When adding an extra, it should only be associated to the food item for which it was selected, and NOT applied to the other ordered items. For example, if I select a "Ranch" dressing for the "Chef Salad", the ranch should not appear as an extra for the "Cheeseburger" or "Cookie of the Day". 2) Unable to Submit Certain Orders Issue: Odoo prevents the user from submitting an order in the following case (better illustrated through an example). If you select a "Chef Salad", you will be prompted to select a "Dressing Choice", because the configuration is set to select one and only one extra. You cannot add the salad to the cart without selecting a dressing, nor can you proceed if you have more than one dressing selected; this is functioning as expected. The problem, however, comes when you select a dressing and add the salad to the cart, and now you try to add a dressing as its own order item (separate from any salad). Even though the salad has its own dressing selected, and the separate dressing is its own item, the error message: "You have to order one and only one Dressing choice" appears and prevents the order from being submitted. This issue may be a consequence of the behavior observed in the first issue. Expected Behavior: The user should be able to submit the order in this case because the salad had only one dressing associated with it, and the extra dressing is supposed to be its own item. This should not create a conflict with the "only one" extra logic. Step to reproduce (video: edv) Reproducible on runbot. 1) Extra Items https://drive.google.com/file/d/1yos9coFqd55pq8qNbNs1OqGNMNSdgxDX/view 2) Unable to Submit Certain Orders https://drive.google.com/file/d/1M0ZEElu-hYwU9bmCwEx_tqEZRAPG_UEt/view opw-2391070 Forward-Port-Of: odoo/odoo#63228

[FIX] sign: Download signed PDF even with several signatures What are the steps to reproduce your issue ? 1. Install "sign" 2. Create a request with a new template 3. Add two signatures with two person (Azure Interior and Deco Addict for example) 4. Send request 5. Check the first mail request and sign 6. Try to download PDF What is currently happening ? A password will be requested for the first person trying to download PDF And the document will not be up to date for all other signers if that the first signer downloaded the document before it is fully signed. What are you expecting to happen ? Do not ask for the password if the PDF is not encrypted Why is this happening ? A password is requested if the document data is not complete. The data is complete when all people have signed. But when requesting to download the pdf all the people have not yet finished signing and therefore the data is not complete, which means a password request How to fix the bug ? Request a password only if there is no data after all people have signed In case the person wants to download after signing the document but he is not the only signer. Generate the pdf so that he has access to the latest version. opw-2390906 Forward-Port-Of: odoo/enterprise#15333 Forward-Port-Of: odoo/enterprise#15095

Improvements(1)

[IMP] test_lint: adjust ES version for supported browsers

Other(19)

[FW][FIX] lunch: Use extra toppings without problem

Improvements(1)

[IMP] test_lint: adjust ES version for supported browsers

Other(19)

[FW][FIX] lunch: Use extra toppings without problem

[FW]14.0 mail composer attachments delete four fix tso

[FW][FIX] l10n_ch_qriban: Impossible to create a vendor bill

[FW][FIX] website: gallery img inside anchor is too large

[FW][FIX] account: display account.journal's currency_id field at the right place in form view

[FW][FIX] mail: removes event listener on unmount

[FW][FIX] mail: mark all needaction as read when opening the thread

[FW][FIX] core: accounting groups field dropped from users' form view

[FW][FIX] mail: visually show the activity creation on kanban record

[FW][REV] account: remove the ability for the automatic entries wizard to generate multiple entries at once

[FW][FIX] calendar, calendar_sms: stop sending wrong reminders

[FW][FIX] mass_mailing: adapt tour to the new editor design.

[FW][FIX] l10n_ch, l10n_ch_qriban: Impossible to create a vendor bill

[FW]Revert "[FIX] l10n_mx_edi_landing: customs number unique by company"

[FW][FIX] sign: Download signed PDF even with several signatures

[FW][FIX] approvals, documents: fix the kanban card when chatter open

[FW][FIX] stock_account_enterprise: Wrong inventory value in Warehouse Analysis Dashboard

[FW][IMP] account_asset: depreciation report: don't cut long asset names when exporting to xls or pdf

[FW][FIX] hr_contract_salary : Add name to simulation link