Thursday, December 17, 2020
21 changes · master
Enhancements to existing features
Odoo's code quality checks now allow a newer JavaScript standard, reflecting current browser support. This helps teams using TypeScript keep generated code closer to the original source, making it easier to read and debug internally.
Original PR description
Commit d431f94 fixed the supported ES version to ES8 because Edge did not support "Spread in destructuring" of higher version. It's now supported since Edge version 79. Hence we can support the next version. We now have several libraries written in Typescript. If we stick to an older ES version, we would need to compile the Typescript code to this older version. The source code and compiled code would then be quite different. The compiled code would also be much less readable and therefore more difficult to debug in Odoo where we have the compiled code only. We might support ES10/ES2019 before V15. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update streamlines how IoT device drivers choose and run actions such as display, keyboard, printer, and serial operations. It makes the driver code easier to maintain and extend, reducing the chance of future issues when adding new device behaviors.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The IoT hardware driver system now uses a clearer mapping to connect incoming actions with the right driver behavior. This makes camera and payment terminal drivers easier to maintain and extend, reducing the risk of errors when adding future device actions.
Original PR description
Add possibilities to map actions for the drivers To avoid a sequence of "if elif else" we integrate in the metaclass of drivers a '_set_actions()' function which initializes a '_actions()' dictionary where the key is the name of the action and the value is the name of the function to be executed in the drivers with the action data as a parameter
Resolved issues and error corrections
This fix updates the partner import template and improves how states or regions are found during imports. It helps reduce import errors and makes customer or contact data setup more reliable.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
before this commit: When parent tax type_tax_use is sale and child taxes type_tax_use is none then tax_base_amount sign is negative in invoice also inversion of tag is null when child tax is used After this commit: tax_base_amount sign is positive in invoice set right tag when inversion of tag opw: 2410943 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63440 Forward-Port-Of: odoo/odoo#63244
Original PR description
before this commit: When parent tax type_tax_use is sale and child taxes type_tax_use is none then tax_base_amount sign is negative in invoice also inversion of tag is null when child tax is used After this commit: tax_base_amount sign is positive in invoice set right tag when inversion of tag opw: 2410943 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63440 Forward-Port-Of: odoo/odoo#63244
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63412
Original PR description
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63412
Purpose when user archive a course content, it's still visible on the course itself, without real difference between active content and archived. it was confusing. Specifications remove the active test from context the other part, the archive mechanism, is not that dumb, keep it PR #63204 task-id: 2411211 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63204
Original PR description
Purpose when user archive a course content, it's still visible on the course itself, without real difference between active content and archived. it was confusing. Specifications remove the active test from context the other part, the archive mechanism, is not that dumb, keep it PR #63204 task-id: 2411211 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63204
This account is intended to be used on a bank journal instead of the bank account. Making it reconcilable is required so that it can be reconciled with a statement made in another bank journal (representing the actual bank account). https://github.com/odoo/odoo/commit/7df9704845f99ad985607940386bacf691ef28db changed this account's type to liquidity, but that breaks the above use case, as a liquidity account is not supposed to be reconcilable at all (and so, instead of creating a writeoff, onl
Original PR description
This account is intended to be used on a bank journal instead of the bank account. Making it reconcilable is required so that it can be reconciled with a statement made in another bank journal (representing the actual bank account). https://github.com/odoo/odoo/commit/7df9704845f99ad985607940386bacf691ef28db changed this account's type to liquidity, but that breaks the above use case, as a liquidity account is not supposed to be reconcilable at all (and so, instead of creating a writeoff, only statement_line_id is set on the check's line, and the statement balances of each journals don't match the general ledger). OPW 2356956 Forward-Port-Of: odoo/odoo#63476 Forward-Port-Of: odoo/odoo#63472
in crm while editing lead demo data and saving without any changes a warning which says that the customer phone number will be updated shows like a loop. This commit fixes this issue by preventing the lead partner phone number from having mismatching format. Task-id: 2390287 Forward-Port-Of: odoo/odoo#62397
Original PR description
in crm while editing lead demo data and saving without any changes a warning which says that the customer phone number will be updated shows like a loop. This commit fixes this issue by preventing the lead partner phone number from having mismatching format. Task-id: 2390287 Forward-Port-Of: odoo/odoo#62397
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63507
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63507
**PURPOSE** The url list within the editor panel is a bit narrow: https://tinyurl.com/y56lfona **SPECIFICATION** Use the left size within the panel to give more space to the list. Same for the Google Map address: https://cdn.discordapp.com/attachments/729965872931930167/766278675175571466/Screenshot_2020-10-15_at_14.37.13.png **LINKS** TaskID: 2352870 Closes: https://github.com/odoo/odoo/pull/60735 Forward-Port-Of: odoo/odoo#60735
Original PR description
**PURPOSE**
The url list within the editor panel is a bit narrow:
https://tinyurl.com/y56lfona
**SPECIFICATION**
Use the left size within the panel to give more space to the list.
Same for the Google Map address: https://cdn.discordapp.com/attachments/729965872931930167/766278675175571466/Screenshot_2020-10-15_at_14.37.13.png
**LINKS**
TaskID: 2352870
Closes: https://github.com/odoo/odoo/pull/60735
Forward-Port-Of: odoo/odoo#60735The style of discuss new message (+) and chat window new message should be consistent, as they both cover the exact same feature. Forward-Port-Of: odoo/odoo#63496
Original PR description
The style of discuss new message (+) and chat window new message should be consistent, as they both cover the exact same feature. Forward-Port-Of: odoo/odoo#63496
In some languages, if the thousands/decimals separators are different from ','/'.' , when scanning a barcode that contains a decimal quantity, the conversion won't be correct. To reproduce the error: 1. Go to Settings > Inventory 2. Enable "Units of Measure" 3. Go to Point of Sale > Products > Products 4. Create a Product P - Set a barcode, e.g. 2112345000008 - Set UoM to 'kg' 5. Go to Settings > Translations > Languages 6. Add and switch to French (BE) 7. Run one POS 8. Use the
Original PR description
In some languages, if the thousands/decimals separators are different from ','/'.' , when scanning a barcode that contains a decimal quantity, the conversion won't be correct. To reproduce the error: 1. Go to Settings > Inventory 2. Enable "Units of Measure" 3. Go to Point of Sale > Products > Products 4. Create a Product P - Set a barcode, e.g. 2112345000008 - Set UoM to 'kg' 5. Go to Settings > Translations > Languages 6. Add and switch to French (BE) 7. Run one POS 8. Use the debugging window to simulate a scan - Enter the code, e.g. 2112345087550 (It means 8.755kg of product P) - Click on "Scan EAN-13" => Here is the error: it actually adds 8755kg of P-product. This comes from the quantity conversion. The barcode provides the qty as a number with basic decimal notation (.) but later, it is converted using the user's language configuration. OPW-2412561 Forward-Port-Of: odoo/odoo#63406
Behavior prior to this commit: If I have a pre-existing order (confirmed, but without available product) on a product with an MTO route, and I now place a new order on that product then confirm the generated PO, in the forecast report the quantities from the PO will be shown as being applied to the pre-existing order first. For example: - create a product with an MTO route (set a vendor) - create a SO (SO1) for 5 units of that product and confirm it. Verify that a PO (PO1) was gene
Original PR description
Behavior prior to this commit: If I have a pre-existing order (confirmed, but without available product) on a product with an MTO route, and I now place a new order on that product then confirm the…
Behavior prior to this commit: If I have a pre-existing order (confirmed, but without available product) on a product with an MTO route, and I now place a new order on that product then confirm the generated PO, in the forecast report the quantities from the PO will be shown as being applied to the pre-existing order first. For example: - create a product with an MTO route (set a vendor) - create a SO (SO1) for 5 units of that product and confirm it. Verify that a PO (PO1) was generated. Cancel the PO. - create a new SO (SO2) for 10 units of the product and confirm it. Confirm the PO (PO2) that is generated. - run the forecast report. It should show: ``` | Replenishment | Quantity | Used By | |------------------------------------| | PO | 10 | SO2 | | Not available | -5 | SO1 | ``` But instead it shows: ``` | Replenishment | Quantity | Used By | |------------------------------------| | PO | 5 | SO1 | | PO | 5 | SO2 | | Not available | -5 | SO2 | ``` When the product is received for PO, the quantity received is correctly applied to SO2, not SO1. Behavior after this commit: - when generating the forecast report, we have to tie each outgoing shipment with 0 or more incoming shipment. After this commit, the computation will be made without considering candidate incoming shipments that are linked (via `move_dest_ids`) to a different outgoing shipment. - for receipts that are not tied to another move (move_dest_ids is empty), there is no change of behavior - for receipts that are "over-delivering", for example if there was a generated PO for 10 units but they manually increased it to 15 to cover both SO, there is no change of behavior: it will still show as replenishing both SO. opw-2412137 Forward-Port-Of: odoo/odoo#63179
When you have a localisation like the french one that does not allow you to decrease the value of a line, you cannot make returns because the popup that shows you new value to encode, does not let you enter negative numbers. To allow those negative values, we let the modification of the line if we are on the last line, and the quantity is equal to 1 which is the default value of the line. It is the same behavior as in 13.0. OPW-2411356 Description of the issue/feature this PR addre
Original PR description
When you have a localisation like the french one that does not allow you to decrease the value of a line, you cannot make returns because the popup that shows you new value to encode, does not let you enter negative numbers. To allow those negative values, we let the modification of the line if we are on the last line, and the quantity is equal to 1 which is the default value of the line. It is the same behavior as in 13.0. OPW-2411356 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63451
When you are using a discount product with a tax, you get a traceback when trying to add the discount. It is caused by a typo and is fixed here. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63545
Original PR description
When you are using a discount product with a tax, you get a traceback when trying to add the discount. It is caused by a typo and is fixed here. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63545
To reproduce: 1. Start an odoo instance without demo with point_of_sale module. 2. Install a generic fiscal local if not automatically installed. 3. Create a product. 4. Open a pos session. 5. BUG: no search bar This is because the search bar is rendered inside ProductsWidgetControlPanel which is only rendered when there are categories. Instead, we render it always but we pass the hasNoCategory information to selectively render it's part. This now always show the search bar. OPW: 2
Original PR description
To reproduce: 1. Start an odoo instance without demo with point_of_sale module. 2. Install a generic fiscal local if not automatically installed. 3. Create a product. 4. Open a pos session. 5. BUG: no search bar This is because the search bar is rendered inside ProductsWidgetControlPanel which is only rendered when there are categories. Instead, we render it always but we pass the hasNoCategory information to selectively render it's part. This now always show the search bar. OPW: 2418858 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63517
this is more safe way than previously applied in #62939 because it doesn't require updating account_edi module in cases when it worked correctly, i.e. when _compute_edi_web_services_to_process is called, but computes empty string value --- opw-2414500 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Por
Original PR description
this is more safe way than previously applied in #62939 because it doesn't require updating account_edi module in cases when it worked correctly, i.e. when _compute_edi_web_services_to_process is called, but computes empty string value --- opw-2414500 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63397
- While trying to open Password Protected Page Throws Trackback Step to Reproduced 1: Open Page Properties 2: Set Visibly as Password 3: Save It 4: Log-out and Try to Open Without Login and try Login With Another Account (Portal) task-2281216 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55692
Original PR description
- While trying to open Password Protected Page Throws Trackback Step to Reproduced 1: Open Page Properties 2: Set Visibly as Password 3: Save It 4: Log-out and Try to Open Without Login and try Login With Another Account (Portal) task-2281216 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55692
What are the steps to reproduce your issue ? 1. Install "eSign" 2. Put 2 signatures on a new template 3. Send template via mail What is currently happening ? When the first signer sign the document, the button "Certificate" is already available What are you expecting to happen ? Hide the "Certificate" button if the document is not fully signed opw-2407149 Forward-Port-Of: odoo/enterprise#15365 Forward-Port-Of: odoo/enterprise#15356
Original PR description
What are the steps to reproduce your issue ?
1. Install "eSign"
2. Put 2 signatures on a new template
3. Send template via mail
What is currently happening ?
When the first signer sign the document, the button "Certificate" is already available
What are you expecting to happen ?
Hide the "Certificate" button if the document is not fully signed
opw-2407149
Forward-Port-Of: odoo/enterprise#15365
Forward-Port-Of: odoo/enterprise#15356Before that, we only put the date in the name of the SCT xml files. Because of that, generating several files on the same day created files with the same name, which was confusing for the user. Forward-Port-Of: odoo/enterprise#15361 Forward-Port-Of: odoo/enterprise#15348
Original PR description
Before that, we only put the date in the name of the SCT xml files. Because of that, generating several files on the same day created files with the same name, which was confusing for the user. Forward-Port-Of: odoo/enterprise#15361 Forward-Port-Of: odoo/enterprise#15348