Wednesday, December 30, 2020
9 changes · master
Miscellaneous changes
Description of the issue/feature this PR addresses: `qty_processed_per_product` should be in uom of product. Go to runbot : - create a product A, put 13 in stock - create SO - add a line with product A and unit `dozen` - add a line with product A and unit `dozen` you see that all are in stock (it is wrong because you have 13 in stock)  @nim-odoo -- I confirm I h
Original PR description
Description of the issue/feature this PR addresses: `qty_processed_per_product` should be in uom of product. Go to runbot : - create a product A, put 13 in stock - create SO - add a line with product A and unit `dozen` - add a line with product A and unit `dozen` you see that all are in stock (it is wrong because you have 13 in stock)  @nim-odoo -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63669
Steps to reproduce the bug: - Let's consider a sales team ST and a POS session PS - Set ST on PS - Open PS and make an invoice I from an order Bug: The sales team set on I was not ST opw:2418806 Forward-Port-Of: odoo/odoo#63831
Original PR description
Steps to reproduce the bug: - Let's consider a sales team ST and a POS session PS - Set ST on PS - Open PS and make an invoice I from an order Bug: The sales team set on I was not ST opw:2418806 Forward-Port-Of: odoo/odoo#63831
Failed to remove a line at conflict resolution during JW revert at [1]. [1]: https://github.com/odoo/odoo/commit/e5572c317a7775a58675ed73efc89b5c9f6c0c39 task-2424849 Forward-Port-Of: odoo/odoo#63902
Original PR description
Failed to remove a line at conflict resolution during JW revert at [1]. [1]: https://github.com/odoo/odoo/commit/e5572c317a7775a58675ed73efc89b5c9f6c0c39 task-2424849 Forward-Port-Of: odoo/odoo#63902
those field sizes were deleted from orm definition in 2014 https://github.com/odoo/odoo/commit/026e38b48f3963aed08bba4e76a0a796d662f6a4 STEPS: * set manifest's summary attribute to a long string * create empty database BEFORE: error ``` 2020-12-28 10:44:51,325 1 ERROR ? odoo.sql_db: bad query: UPDATE ir_module_module SET state='installed' WHERE state IN ('to remove', 'to upgrade') ERROR: relation "ir_module_module" does not exist LINE 1: UPDATE ir_module_module SET state='installed
Original PR description
those field sizes were deleted from orm definition in 2014 https://github.com/odoo/odoo/commit/026e38b48f3963aed08bba4e76a0a796d662f6a4 STEPS: * set manifest's summary attribute to a long string *…
those field sizes were deleted from orm definition in 2014 https://github.com/odoo/odoo/commit/026e38b48f3963aed08bba4e76a0a796d662f6a4
STEPS:
* set manifest's summary attribute to a long string
* create empty database
BEFORE: error
```
2020-12-28 10:44:51,325 1 ERROR ? odoo.sql_db: bad query: UPDATE ir_module_module SET state='installed' WHERE state IN ('to remove', 'to upgrade')
ERROR: relation "ir_module_module" does not exist
LINE 1: UPDATE ir_module_module SET state='installed' WHERE state IN...
^
2020-12-28 10:44:51,325 1 ERROR ? odoo.modules.registry: Failed to load registry
Traceback (most recent call last):
File "/opt/odoo/custom/src/odoo/odoo/modules/registry.py", line 86, in new
odoo.modules.load_modules(registry._db, force_demo, status, update_module)
File "/opt/odoo/custom/src/odoo/odoo/modules/loading.py", line 338, in load_modules
odoo.modules.db.initialize(cr)
File "/opt/odoo/custom/src/odoo/odoo/modules/db.py", line 63, in initialize
info['sequence'], info['summary']))
File "/opt/odoo/custom/src/odoo/odoo/sql_db.py", line 173, in wrapper
return f(self, *args, **kwargs)
File "/opt/odoo/custom/src/odoo/odoo/sql_db.py", line 250, in execute
res = self._obj.execute(query, params)
psycopg2.DataError: value too long for type character varying(256)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/opt/odoo/custom/src/odoo/odoo/modules/registry.py", line 88, in new
odoo.modules.reset_modules_state(db_name)
File "/opt/odoo/custom/src/odoo/odoo/modules/loading.py", line 558, in reset_modules_state
"UPDATE ir_module_module SET state='installed' WHERE state IN ('to remove', 'to upgrade')"
File "/opt/odoo/custom/src/odoo/odoo/sql_db.py", line 173, in wrapper
return f(self, *args, **kwargs)
File "/opt/odoo/custom/src/odoo/odoo/sql_db.py", line 250, in execute
res = self._obj.execute(query, params)
psycopg2.ProgrammingError: relation "ir_module_module" does not exist
LINE 1: UPDATE ir_module_module SET state='installed' WHERE state IN...
```
AFTER: database successfully created
---
opw-2415057
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#63820FLOW TO REPRODUCE : 1. Drop the snippet 'Discussion Group' on a page. 2. Open this page with incognito mode 3. Register your email. 4. Subscribe => traceback (because there is no discussion group created). The goal of this PR is to let the user create/select the channel linked to the discussion group snippet. Desired behavior after PR is merged: When a new snippet dropped from d&d menu (edit mode): - if we have already created channels => select the first one - else =>
Original PR description
FLOW TO REPRODUCE :
1. Drop the snippet 'Discussion Group' on a page.
2. Open this page with incognito mode
3. Register your email.
4. Subscribe => traceback (because there is no discussion group created).
The goal of this PR is to let the user create/select the channel
linked to the discussion group snippet.
Desired behavior after PR is merged:
When a new snippet dropped from d&d menu (edit mode):
- if we have already created channels => select the first one
- else => modal prompt (create a new channel)
and user won't be able to subscribe to non-existing channels (e.g. default id = 0).
task-2356955
Forward-Port-Of: odoo/odoo#63842
Forward-Port-Of: odoo/odoo#60608Issue - Install "Time-Off" module - Set user language to "Arabic" - Open "Time-Off" Traceback raised. Cause Python 'datetime' library does not manage arabic date. Solution Convert date format for the "server". In this case, it will also translate arabic numbers. Also, adapt "dateToServer" to handle any format. opw-2421268 Forward-Port-Of: odoo/odoo#63833
Original PR description
Issue - Install "Time-Off" module - Set user language to "Arabic" - Open "Time-Off" Traceback raised. Cause Python 'datetime' library does not manage arabic date. Solution Convert date format for the "server". In this case, it will also translate arabic numbers. Also, adapt "dateToServer" to handle any format. opw-2421268 Forward-Port-Of: odoo/odoo#63833
Issue - Install 'Subscription' module - Create 2 product : one only that can be sold (set it as a 'Subscription product'), and one that can only be purchased. - Create a subscription and add the 'can be sold' product - Generate invoice and open it - Try to add product 'can be sold' Only the product 'can be purchased' is suggested. Cause Wrong context: by clicking "Invoices" stat button, it will call `account.action_move_out_invoice_type` action but without keeping
Original PR description
Issue - Install 'Subscription' module - Create 2 product : one only that can be sold (set it as a 'Subscription product'), and one that can only be purchased. - Create a subscription and add the 'can be sold' product - Generate invoice and open it - Try to add product 'can be sold' Only the product 'can be purchased' is suggested. Cause Wrong context: by clicking "Invoices" stat button, it will call `account.action_move_out_invoice_type` action but without keeping the action-context. Solution Add 'default_type' to context. opw-2411373 Forward-Port-Of: odoo/enterprise#15475 Forward-Port-Of: odoo/enterprise#15473
What are the steps to reproduce your issue ? 1. Install eSign 2. Go to user and uner the preference, add a signature (load image) 3. On the sign app, sign a document What is currently happening ? There will be a line on the signature and every time you sign a document an additionnal line appears in signature What are you expecting to happen ? Sign documents without added lines Why is this happening ? Each time a signature is made a line is by d
Original PR description
What are the steps to reproduce your issue ? 1. Install eSign 2. Go to user and uner the preference, add a signature (load image) 3. On the sign app, sign a document What is currently happening ?…
What are the steps to reproduce your issue ?
1. Install eSign
2. Go to user and uner the preference, add a signature (load image)
3. On the sign app, sign a document
What is currently happening ?
There will be a line on the signature and every time you sign a document
an additionnal line appears in signature
What are you expecting to happen ?
Sign documents without added lines
Why is this happening ?
Each time a signature is made a line is by default
inserted in the signature area.
But for each document signed the signature is saved in the user
signature which adds a line to the original signature.
So on each time a new line will be added to the original signature
How to fix the bug ?
Do not display the line when one of these conditions is true:
- The signature is an imported image
- The signature has been previously saved in the user
(no matter whether it is imported or drawn,
it is not necessary to redraw over it and keep it as it is)
See the PR for more détails
opw-2342050
Forward-Port-Of: odoo/enterprise#15465Steps to reproduce the bug: - Let's consider a user U with no employee linked to him - Log with U - Go to Timesheets and click on Start - Try to add a project Bug: A traceback was raised. opw:2415423 Forward-Port-Of: odoo/enterprise#15494
Original PR description
Steps to reproduce the bug: - Let's consider a user U with no employee linked to him - Log with U - Go to Timesheets and click on Start - Try to add a project Bug: A traceback was raised. opw:2415423 Forward-Port-Of: odoo/enterprise#15494