Have a product category Inventory Valuation Automatic Create a SO and deliver the product in such category Create return and validate In Journal Entry the accounting move related to return will not have partner id opw-2421393 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#64730

Have a product category Inventory Valuation Automatic
Create a SO and deliver the product in such category
Create return and validate

In Journal Entry the accounting move related to return will not have
partner id

opw-2421393

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#64730

cache_value could be empty string rather than None. I'm not sure why it was different before. STEPS: * install an app that adds menu Products (e.g. Sales) * activate second language and switch to it * create new product, set some value to field description ("Internal Notes"), save * click edit, remove description, save BEFORE: the value is not removed AFTER: value is empty, translations are removed --- https://github.com/odoo/odoo/commit/543a5523a30c993f60eba3c6d56d54dea2857

cache_value could be empty string rather than None. I'm not sure why it was
different before.

STEPS:
* install an app that adds menu Products (e.g. Sales)
* activate second language and switch to it
* create new product, set some value to field description ("Internal Notes"),
save
* click edit, remove description, save

BEFORE: the value is not removed

AFTER: value is empty, translations are removed

---

https://github.com/odoo/odoo/commit/543a5523a30c993f60eba3c6d56d54dea2857eb3#
opw-2426724

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#64591
Forward-Port-Of: odoo/odoo#64241

Use case to reproduce: - Go to MO form produce at least 2 units of a product with a component tracked by serial number. - Edit the producing quantity to 1.0 - Save - Edit the producing quantity to 2.0 The move lines are removed. It happens because the lot_ids field is empty and thus the setter remove the existing stock.move.line. It's empty because the compute try to do a match on existing id. However the stock.move.line in the onchange could have a new virtual id. fine tuning o

Use case to reproduce:
- Go to MO form produce at least 2 units of a product with a component
tracked by serial number.
- Edit the producing quantity to 1.0
- Save
- Edit the producing quantity to 2.0

The move lines are removed.

It happens because the lot_ids field is empty and thus the setter remove
the existing stock.move.line. It's empty because the compute try to do
a match on existing id. However the stock.move.line in the onchange
could have a new virtual id.

fine tuning of commit 8dfee8cb2d60942641b73eaa6489b02aa378c5ac

Forward-Port-Of: odoo/odoo#64747

'percentage' is computed by default whatever the wizard action (change_period/change_account) but there is a constraint raised when the percentage is != 100 in change_account. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#64736

'percentage' is computed by default whatever the wizard action (change_period/change_account) but there is a constraint raised when the percentage is != 100 in change_account.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#64736

The call model.browse('xxx').exists() should not return the record. Instead, it should fail as the string 'xxx' is not a valid ID. Forward-Port-Of: odoo/odoo#64765

The call model.browse('xxx').exists() should not return the record.
Instead, it should fail as the string 'xxx' is not a valid ID.

Forward-Port-Of: odoo/odoo#64765

**Description of the issue/feature this PR addresses:** In case the currency is not set during onchange all currency actions will throw a traceback **Current behavior before PR:** Traceback Fun ``` Odoo Server Error Traceback (most recent call last): File ".../odoo/models.py", line 5099, in ensure_one _id, = self._ids ValueError: not enough values to unpack (expected 1, got 0) During handling of the above exception, another exception occurred: Traceback (most recent call l

**Description of the issue/feature this PR addresses:**
In case the currency is not set during onchange all currency actions will throw a traceback

**Current behavior before PR:**
Traceback Fun
```
Odoo Server Error
Traceback (most recent call last):
  File ".../odoo/models.py", line 5099, in ensure_one
    _id, = self._ids
ValueError: not enough values to unpack (expected 1, got 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File ".../odoo/http.py", line 624, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File ".../odoo/http.py", line 310, in _handle_exception
    raise pycompat.reraise(type(exception), exception, sys.exc_info()[2])
  File ".../odoo/tools/pycompat.py", line 14, in reraise
    raise value
  File ".../odoo/http.py", line 669, in dispatch
    result = self._call_function(**self.params)
  File ".../odoo/http.py", line 350, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File ".../odoo/service/model.py", line 94, in wrapper
    return f(dbname, *args, **kwargs)
  File ".../odoo/http.py", line 339, in checked_call
    result = self.endpoint(*a, **kw)
  File ".../odoo/http.py", line 915, in __call__
    return self.method(*args, **kw)
  File ".../odoo/http.py", line 515, in response_wrap
    response = f(*args, **kw)
  File ".../addons/web/controllers/main.py", line 1327, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File ".../addons/web/controllers/main.py", line 1319, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File ".../odoo/api.py", line 387, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File ".../odoo/api.py", line 374, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File ".../addons/account/models/account_move.py", line 1014, in onchange
    return super(AccountMove, self.with_context(recursive_onchanges=False)).onchange(values, field_name, field_onchange)
  File ".../odoo/models.py", line 6247, in onchange
    record._onchange_eval(name, field_onchange[name], result)
  File ".../odoo/models.py", line 6026, in _onchange_eval
    method_res = method(self)
  File ".../addons/purchase/models/account_invoice.py", line 75, in _onchange_purchase_auto_complete
    self._onchange_currency()
  File ".../addons/account/models/account_move.py", line 389, in _onchange_currency
    self._recompute_dynamic_lines(recompute_tax_base_amount=True)
  File ".../addons/account/models/account_move.py", line 1000, in _recompute_dynamic_lines
    invoice._recompute_payment_terms_lines()
  File ".../addons/account/models/account_move.py", line 962, in _recompute_payment_terms_lines
    new_terms_lines = _compute_diff_payment_terms_lines(self, existing_terms_lines, account, to_compute)
  File ".../addons/account/models/account_move.py", line 914, in _compute_diff_payment_terms_lines
    if self.journal_id.company_id.currency_id.is_zero(balance) and len(to_compute) > 1:
  File ".../odoo/addons/base/models/res_currency.py", line 171, in is_zero
    self.ensure_one()
  File ".../odoo/models.py", line 5102, in ensure_one
    raise ValueError("Expected singleton: %s" % self)
ValueError: Expected singleton: res.currency()

```

**Desired behavior after PR is merged:**
Preparation of not yet saved purchase invoice works as expected



--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#64502
Forward-Port-Of: odoo/odoo#64339

To fully allow f4e67d8ae174d7e2ee75a1de1083b31a6ff2af8b we need also to disable to check on account when the constraint field has been used to set the account on the journal opw-2394959 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#64667

To fully allow f4e67d8ae174d7e2ee75a1de1083b31a6ff2af8b
we need also to disable to check on account when
the constraint field has been used to set the account on
the journal

opw-2394959

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#64667

Before this commit, the `on_attach_callback` and `on_detach_callback` callbacks are not called all the time on the `Dialog` widget when it's attached/detached to the DOM. Relying on those callbacks could result in unpredictable behaviours. To be more precise, the `on_attach_callback` isn't executed on a regular Dialog#open() call. But executing a client action into a Dialog will execute it (due to being called by the ActionManager). This difference prevents from properly binding those

Before this commit, the `on_attach_callback` and `on_detach_callback`
callbacks are not called all the time on the `Dialog` widget when it's
attached/detached to the DOM. Relying on those callbacks could result in
unpredictable behaviours.

To be more precise, the `on_attach_callback` isn't executed on a regular
Dialog#open() call. But executing a client action into a Dialog will
execute it (due to being called by the ActionManager).

This difference prevents from properly binding those callbacks later on
through an extend or include of the Dialog widget as we have no way to
know if they have already been called or not (e.g. which can result in
calling them twice).

This commit normalize this situation by ensuring that the
`on_attach_callback` and `on_detach_callback` callbacks are properly
called by the Dialog widget and allows any extension of this widget to
rely on them. Therefore the ActionManager is adapted accordingly.

opw-2438534

Forward-Port-Of: odoo/odoo#64780

Some added readonly attributes in the unbuild form view were overriding the `states={'done': [('readonly', True)]}` attributes in the models' fields. So we add the readonly when state='done' to the view as well. Note that same issue exists in saas-12.3 and 13.0, but only for 2 of the 4 fields fixed in this commit (i.e. it probably isn't a big deal for these older versions.) Discovered during task: 2033341 Description of the issue/feature this PR addresses: Current behavior before

Some added readonly attributes in the unbuild form view were overriding
the `states={'done': [('readonly', True)]}` attributes in the models'
fields. So we add the readonly when state='done' to the view as well.

Note that same issue exists in saas-12.3 and 13.0, but only for 2 of the
4 fields fixed in this commit (i.e. it probably isn't a big deal for
these older versions.)

Discovered during task: 2033341

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#63537

…paid lines Create a promotion auto applied with 0 minimum amount on any product in catalog. Have a DEMO product invoiced on delivery Create a sale order with DEMO, apply the promotion. Confirm. Click on 'Create Invoice'. The invoice will only contain the promotion because the line for DEMO is to be invoiced only after delivery, while by default the promotion product has the invoice policy 'on order' opw-2414630 Description of the issue/feature this PR addresses: Current beh

…paid lines

Create a promotion auto applied with 0 minimum amount on any product in
catalog.
Have a DEMO product invoiced on delivery
Create a sale order with DEMO, apply the promotion. Confirm.
Click on 'Create Invoice'.

The invoice will only contain the promotion because the line for
DEMO is to be invoiced only after delivery, while by default the
promotion product has the invoice policy 'on order'

opw-2414630

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#64721
Forward-Port-Of: odoo/odoo#63717

Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#64799

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#64799

task-2388600 Forward-Port-Of: odoo/odoo#62446

task-2388600

Forward-Port-Of: odoo/odoo#62446

With the switch to Owl, some code is now (temporarily) asynchronous, because we need to go through multiple phases of rendering. Because of that, we need to wait for all of it to be done. Forward-Port-Of: odoo/enterprise#15861

With the switch to Owl, some code is now (temporarily) asynchronous,
because we need to go through multiple phases of rendering. Because of
that, we need to wait for all of it to be done.

Forward-Port-Of: odoo/enterprise#15861

The fields product_line_ids, amount, quantity were still editable when the request was approved. opw:2431149 Forward-Port-Of: odoo/enterprise#15837

The fields product_line_ids, amount, quantity were still editable when the request was
approved.

opw:2431149

Forward-Port-Of: odoo/enterprise#15837

Since commit odoo/enterprise@96beff3d22e7083ec7a51d29fc6fdaef29cee912 the BackButtonEventMixin (via its BackButtonManager) prevents from registering multiple times the same Widget/Components's instance as a listener for the "backbutton" event (available in the mobile app). Sadly the Dialog widget original implementation didn't call the `on_attach_callback` and `on_detach_callback` callbacks which required us to implement them in our Dialog's implementation of the backbutton. But. I

Since commit odoo/enterprise@96beff3d22e7083ec7a51d29fc6fdaef29cee912
the BackButtonEventMixin (via its BackButtonManager) prevents from
registering multiple times the same Widget/Components's instance as a
listener for the "backbutton" event (available in the mobile app).

Sadly the Dialog widget original implementation didn't call the
`on_attach_callback` and `on_detach_callback` callbacks which required
us to implement them in our Dialog's implementation of the backbutton.

But.

In some cases, `on_attach_callback` was actually called (specifically
when a client action is opened in a dialog), resulting in this callback
being executed twice! And since the BackButtonManager is stricter,
calling this callback a second time results in a "Listener already
registered!" error.

This commit is a followup of its counterpart in community which makes
Dialog reliably call those callbacks. This allows to simplify the
implementation of the Dialog's backbutton support.

Also, the related test verify that the native method
`overrideBackButton` is properly called like the other "backbutton"
tests.

opw-2438534

Forward-Port-Of: odoo/enterprise#15849

If an account like "251.04.01" with the tag "251.04 Acreedores diversos a largo plazo nacional parte relacionada" is present in a mexican COA report, the account will be considered as misconfigured and the export for SAT button will trigger an error. In the code, the domain used in the report for the code "MX_COA_251" contained two times the tag "251.03" and no mention of "251.04". Thus the tag "251.04" was added in the report and now accounts with this tags are no longer considered as mi

If an account like "251.04.01" with the tag "251.04 Acreedores diversos a largo plazo nacional parte relacionada"
is present in a mexican COA report, the account will be considered as misconfigured and the export for SAT
button will trigger an error.

In the code, the domain used in the report for the code "MX_COA_251" contained two times the tag "251.03" and
no mention of "251.04". Thus the tag "251.04" was added in the report and now accounts with this tags are no
longer considered as misconfigured.

opw-2424711

Forward-Port-Of: odoo/enterprise#15807

Commit [1] changed the design of the HTML field to not hack the default style. It is now decided that the hack is worth it. [1]: https://github.com/odoo/enterprise/commit/6b3643d8789d246095876d8da9a706ce9c5dd137 Forward-port of https://github.com/odoo/enterprise/pull/14196 Forward-Port-Of: odoo/enterprise#15826

Commit [1] changed the design of the HTML field to not hack the default
style. It is now decided that the hack is worth it.

[1]: https://github.com/odoo/enterprise/commit/6b3643d8789d246095876d8da9a706ce9c5dd137

Forward-port of https://github.com/odoo/enterprise/pull/14196

Forward-Port-Of: odoo/enterprise#15826