Friday, February 5, 2021
4 changes · master
Enhancements to existing features
Employee work locations are now managed as reusable records instead of free-text entries. This makes location information more consistent across HR-related processes and helps connected apps such as attendance, expenses, holidays, appraisal, and payroll use the same standardized data.
Original PR description
The work location of an employee was previously a fields.Char. That was changed to a Many2one field to a the new model called work.location. That had some consequences in other modules that had to be slightly adjusted. The modules impacted were hr, hr_appraisal, hr_payroll. Task id: 2335646 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update improves payroll workflows by making payslips easier to access from employee contract screens and contract history. It also enhances Belgian payroll reporting by adding NISS tracking for employees, validating it for tax sheet generation, and reorganizing Belgian reporting menus for easier navigation.
Employee work locations are now managed as structured records instead of free-text entries. This improves consistency across HR-related workflows and helps appraisal, payroll, and timesheet features reference locations more reliably.
Original PR description
The work location of an employee was previously a fields.Char. That was changed to a Many2one field to a the new model called work.location. That had some consequences in other modules that had to be slightly adjusted. The modules impacted were hr, hr_appraisal, hr_payroll. TaskID: 2335646
Resolved issues and error corrections
This fixes an issue where scheduled actions with an exact time could run too early and then be skipped. The change helps ensure reminders, emails, and other automated tasks are triggered as soon as possible after their scheduled moment, reducing the risk of long delays.
Original PR description
You have have a scheduled activity precisely at 8:12:34 AM (send an email, anything). You trigger the cron using that precise moment. The cron runs at 8:12:00 AM which is before the scheduled moment so the activity is skipped. Imagine there is no other scheduled activity that coudld trigger the cron, it is only run at worst 23h59 minutes later thanks to the daily cron execution fallback. The assumption of a29bb54 is wrong, it groups the moments the cron should be triggered by grouping the moments on the rounded down minute. This is not consistent with the trigger API that promises the cron will run *as soon as possible but **not before*** the scheduled moment. Task: 2452697