Friday, February 5, 2021
2 changes · master
Resolved issues and error corrections
This fixes an issue where scheduled actions with an exact time could run too early and then be skipped. The change helps ensure reminders, emails, and other automated tasks are triggered as soon as possible after their scheduled moment, reducing the risk of long delays.
Original PR description
You have have a scheduled activity precisely at 8:12:34 AM (send an email, anything). You trigger the cron using that precise moment. The cron runs at 8:12:00 AM which is before the scheduled moment so the activity is skipped. Imagine there is no other scheduled activity that coudld trigger the cron, it is only run at worst 23h59 minutes later thanks to the daily cron execution fallback. The assumption of a29bb54 is wrong, it groups the moments the cron should be triggered by grouping the moments on the rounded down minute. This is not consistent with the trigger API that promises the cron will run *as soon as possible but **not before*** the scheduled moment. Task: 2452697
Corrects how depreciation schedule report lines are identified so users are directed to the right asset details. This prevents confusion when opening report line actions after recent reporting changes.
Original PR description
This is needed with 8ceeb7df4a350f89d7480a1d652ec3178345fe7b Even though there is a fallback for legacy report line ids in _get_caret_option_target_id, it is not working with the Depreciation Schedule since it is a string too.