Wednesday, February 10, 2021
16 changes · master
Enhancements to existing features
The appraisal survey sample data has been adjusted to stay aligned with recent survey changes. This keeps demo appraisal surveys accurate and easier to use for evaluation, training, and demonstrations.
Original PR description
This PR adapts the demo data of the survey to adapt the changes done in https://github.com/odoo/odoo/pull/62712 TaskID - 2389434
Code cleanup and technical improvements
Barcode validation has been reorganized so the system can verify check digits more consistently across barcode-related workflows. This internal cleanup helps prepare barcode scanning for future GS1-128 support while preserving existing behavior through added test coverage.
Original PR description
Refactor the way barcode nomenclature verifies the barcode check digit in order to prepare the support of GS1-128 encoded barcode. task-1968113
Event-related access control files were reorganized and renamed consistently across event modules. Security tests were moved into the full event test suite so future permission changes in related modules can be checked more reliably.
Original PR description
Purpose ======= In event, many files have different naming format. We want to clean them, to group the lines by models before changing and adding a new event group. Task ID-2204364 COM PR odoo/odoo#65867 Migration odoo/upgrade#2150
STEPS: * Add related phone field to a form (e.g. partner_id.phone to sale.order form) * Use widget "phone" + activate sms feature * Create a record * Click edit, select partner that has phone specified (e.g. +1 234), edit partner's phone (e.g. +1 234 555), save BEFORE: ``+1 234 []SMS`` is converted to ``+1 234 555 +1 234 555`` AFTER: ``+1 234 555 []SMS`` WHY: * FieldPhone is inherited from FieldEmail https://github.com/odoo/odoo/blob/0de069b8ca9fb005ba5b076984f5677de25889ee/a
Original PR description
STEPS: * Add related phone field to a form (e.g. partner_id.phone to sale.order form) * Use widget "phone" + activate sms feature * Create a record * Click edit, select partner that has phone…
STEPS: * Add related phone field to a form (e.g. partner_id.phone to sale.order form) * Use widget "phone" + activate sms feature * Create a record * Click edit, select partner that has phone specified (e.g. +1 234), edit partner's phone (e.g. +1 234 555), save BEFORE: ``+1 234 []SMS`` is converted to ``+1 234 555 +1 234 555`` AFTER: ``+1 234 555 []SMS`` WHY: * FieldPhone is inherited from FieldEmail https://github.com/odoo/odoo/blob/0de069b8ca9fb005ba5b076984f5677de25889ee/addons/web/static/src/js/fields/basic_fields.js#L1549 * sms module adds SMS button to ``$el`` https://github.com/odoo/odoo/blob/0de069b8ca9fb005ba5b076984f5677de25889ee/addons/sms/static/src/js/fields_phone_widget.js#L91 * So this commit filters ``$el`` before updating it --- opw-2425949 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65713 Forward-Port-Of: odoo/odoo#64156
…sfully parsed it is posted in the chatter Before this commit, the attachment was only posted if no decoder was able to parse the attachment. See https://github.com/odoo/enterprise/pull/16138 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65822
Original PR description
…sfully parsed it is posted in the chatter Before this commit, the attachment was only posted if no decoder was able to parse the attachment. See https://github.com/odoo/enterprise/pull/16138 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65822
Steps: - Install studio, website_form - Go to Settings > Users & Companies > Users - Click the Studio icon - On the top bar, click Website - Click New Form - In edition mode, click the first label - Select Customize > Add an Existing Field Bug: Traceback here: https://github.com/odoo/odoo/blob/3ff00944fe6a439bd5d7bddb846206d3d6cac3a0/addons/website_form/models/models.py#L73 KeyError: 'readonly' Explanation: Dynamic selection fields don't declare a 'readonly' attribute: https://
Original PR description
Steps: - Install studio, website_form - Go to Settings > Users & Companies > Users - Click the Studio icon - On the top bar, click Website - Click New Form - In edition mode, click the first label - Select Customize > Add an Existing Field Bug: Traceback here: https://github.com/odoo/odoo/blob/3ff00944fe6a439bd5d7bddb846206d3d6cac3a0/addons/website_form/models/models.py#L73 KeyError: 'readonly' Explanation: Dynamic selection fields don't declare a 'readonly' attribute: https://github.com/odoo/odoo/blob/3ff00944fe6a439bd5d7bddb846206d3d6cac3a0/odoo/addons/base/models/res_users.py#L1275-L1282 opw:2449356 Forward-Port-Of: odoo/odoo#65862 Forward-Port-Of: odoo/odoo#65784
Before this commit, calling do_hide/do_show/do_toggle on a widget that had been destroyed before being rendered crashed (because this.$el was undefined). Obviously, calling those methods in this situation is useless, but with asynchronous code, it might happen that you call them in an handler, and they have been destroyed meanwhile. This commit checks if this.$el is set before accessing it to avoid the crash. Description of the issue/feature this PR addresses: Current behavior b
Original PR description
Before this commit, calling do_hide/do_show/do_toggle on a widget that had been destroyed before being rendered crashed (because this.$el was undefined). Obviously, calling those methods in this situation is useless, but with asynchronous code, it might happen that you call them in an handler, and they have been destroyed meanwhile. This commit checks if this.$el is set before accessing it to avoid the crash. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65870
This commit update owl from 1.2.3 to 1.2.4, and introduces a few fixes for code that was broken (because it accesses private owl values) Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65886
Original PR description
This commit update owl from 1.2.3 to 1.2.4, and introduces a few fixes for code that was broken (because it accesses private owl values) Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65886
PURPOSE The 'date picker' of date(time) fields does not unfold in the pivot groupby dropdown SPEC The 'date picker' of date(time) fields should be unfolded in the pivot groupby dropdown TASK 2452033 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65689
Original PR description
PURPOSE The 'date picker' of date(time) fields does not unfold in the pivot groupby dropdown SPEC The 'date picker' of date(time) fields should be unfolded in the pivot groupby dropdown TASK 2452033 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65689
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65865
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65865
Issue - Install "Accounting" module - Ensure there is more then 20 journals ( or must do a zoom-in on the browser) - Go to Accounting -> Reporting -> Profit and Loss - Click on "Journals" filter Not all journals are displayed. Cause No scroll or max-height set on dropdown. Solution Set a max-height and an overflow:auto on `.dropdown-menu` and `o_dropdown_menu` css classes. TASK 2452033 Forward-Port-Of: odoo/enterprise#16180
Original PR description
Issue - Install "Accounting" module - Ensure there is more then 20 journals ( or must do a zoom-in on the browser) - Go to Accounting -> Reporting -> Profit and Loss - Click on "Journals" filter Not all journals are displayed. Cause No scroll or max-height set on dropdown. Solution Set a max-height and an overflow:auto on `.dropdown-menu` and `o_dropdown_menu` css classes. TASK 2452033 Forward-Port-Of: odoo/enterprise#16180
Since 6a6d363d3cf4f87f8d257afafd9e06ed213df1f8, the spreadsheet obtained are only the ones the user contributed to. This commit restore the expected behaviour, i.e. get the list of accessible spreadsheet, ordered by contribution date. Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com> Forward-Port-Of: odoo/enterprise#16261
Original PR description
Since 6a6d363d3cf4f87f8d257afafd9e06ed213df1f8, the spreadsheet obtained are only the ones the user contributed to. This commit restore the expected behaviour, i.e. get the list of accessible spreadsheet, ordered by contribution date. Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com> Forward-Port-Of: odoo/enterprise#16261
It can happen that we receive no new transactions but that the balance of the account has already been updated. In which case the balance would write itself in the previous existing statement in Odoo which we don't want. -> Ignore writing balance on the latest statement if no new transactions have been fetched. Also add a chatter message whenever we reset a statement to draft, not just when the statement was in done mode. Forward-Port-Of: odoo/enterprise#16202
Original PR description
It can happen that we receive no new transactions but that the balance of the account has already been updated. In which case the balance would write itself in the previous existing statement in Odoo which we don't want. -> Ignore writing balance on the latest statement if no new transactions have been fetched. Also add a chatter message whenever we reset a statement to draft, not just when the statement was in done mode. Forward-Port-Of: odoo/enterprise#16202
An error happened when a user tries to fetch his transactions because the reconciliation widget ask for a journal_id and we couldn't give it one. So, the widget search this id via the active_id but the active_id, in this case, is not the journal id but the account online link id. To resolve this problem, we verify that the active_model is an "account.journal". Forward-Port-Of: odoo/enterprise#15347
Original PR description
An error happened when a user tries to fetch his transactions because the reconciliation widget ask for a journal_id and we couldn't give it one. So, the widget search this id via the active_id but the active_id, in this case, is not the journal id but the account online link id. To resolve this problem, we verify that the active_model is an "account.journal". Forward-Port-Of: odoo/enterprise#15347
Before this commit, it was not possible to cut and paste a formula Forward-Port-Of: odoo/enterprise#16246
Original PR description
Before this commit, it was not possible to cut and paste a formula Forward-Port-Of: odoo/enterprise#16246