Thursday, February 11, 2021
21 changes · master
Enhancements to existing features
The Activities form now shows which document an activity is linked to, making it easier for users to understand its context. Unnecessary action buttons were removed from this technical view to make the form cleaner and less confusing.
Original PR description
**PURPOSE** The current form view of Activities(from the technical settings) is not very useful. There is no indication of which document the activity is linked and the buttons like save/discard etc. looks weird within the form view. **SPECIFICATION** -Adding field 'res_name' for indication of document at the top of the form which is read-only. -Removing 'save', 'discard', 'mark as done' and 'done & schedule next' buttons within the form and simply make a form view without buttons. **LINKS** PR https://github.com/odoo/odoo/pull/63121 Task-2371023
CRM lead cards in the kanban view now show the same tag colors configured elsewhere. This makes it easier for users to visually identify and organize leads at a glance.
Original PR description
Currently if we create coloured tags for leads in crm from the form view the same is not appearing in the respective kanban view. So in this improvement we fixed this tag colour in kanban view. Task-id : 2453047
The Marketing Automation mailing trace form was updated so the Marketing trace field appears in the right place after related community changes. This keeps the form layout consistent and easier to read for users reviewing mailing activity.
Original PR description
make the Marketing trace field positionned below the message_id field to adapt to community changes, see community PR: https://github.com/odoo/odoo/pull/65469 Task-2440420
Resolved issues and error corrections
The product form’s extra action buttons now open without showing an unnecessary scrollbar in Chrome. This makes the dropdown look cleaner and avoids a small visual distraction when users create or edit products.
Original PR description
Description of the issue/feature this PR addresses: Fix scrollbar on products stat buttons Current behavior before PR: go to inventory > products > products click on create > more there is a scrollbar for the extra stat buttons Desired behavior after PR is merged: there is no scrollbar in Chrome task_id: 2453250 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Create a standard tax included in the product price. Add that tax to a product and the down payment product. Create a sales order (i.e. 1 line, 100$ total, 15% tax incl). Create a percentage down payment invoice, i.e. 50%. Post the downpayment invoice. Go back to the sale order The sale order line relative to the downpayment was asjusted to remove the tax amout while this should not occur when dealing with tax included in price Added test opw-2426294 Description of the issue/f
Original PR description
Create a standard tax included in the product price. Add that tax to a product and the down payment product. Create a sales order (i.e. 1 line, 100$ total, 15% tax incl). Create a percentage down payment invoice, i.e. 50%. Post the downpayment invoice. Go back to the sale order The sale order line relative to the downpayment was asjusted to remove the tax amout while this should not occur when dealing with tax included in price Added test opw-2426294 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65813
Steps: - Go to Settings > Users & Companies > Companies - Create a new company (1) - Install a payment acquirer and Website - Go to Website > Configuration > Settings: - Select "My Website 2" - Assign it to company (1) - Add a custom domain - Save - Switch to company (1) - Go to Invoicing - Create a new Invoice: - Add a product line - Post it - Click Action > Generate a Payment Link Bug: The base domain is used instead of the domain of the website linked to the invoicing com
Original PR description
Steps: - Go to Settings > Users & Companies > Companies - Create a new company (1) - Install a payment acquirer and Website - Go to Website > Configuration > Settings: - Select "My Website 2" - Assign it to company (1) - Add a custom domain - Save - Switch to company (1) - Go to Invoicing - Create a new Invoice: - Add a product line - Post it - Click Action > Generate a Payment Link Bug: The base domain is used instead of the domain of the website linked to the invoicing company. Explanation: The app only uses the URL on which the user has logged in to generate a payment link. If the user has multiple companies, this can confuse customers if they land on another domain than the one they are used to. This commit makes the app use the domain of the website of the record linked to the payment if it has one. opw:2440251 Forward-Port-Of: odoo/odoo#65589
PURPOSE Badge widget displayed in listview but displayed vertically aligned top, it should display vertical-align middle. SPEC Display badge widget in vertical-align middle. TASK 2351554 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59401
Original PR description
PURPOSE Badge widget displayed in listview but displayed vertically aligned top, it should display vertical-align middle. SPEC Display badge widget in vertical-align middle. TASK 2351554 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59401
**PURPOSE** Currently, the user doesn't receive any feedback or notification when updating his subscription preferences. Therefore, he might be prompted to open the subscription modal again to double-check that his modifications were correctly applied or not. **SPECIFICATION** We are now displaying screen notifications using notify method of the notification widget. **Task : 2445481** Forward-Port-Of: odoo/odoo#65514
Original PR description
**PURPOSE** Currently, the user doesn't receive any feedback or notification when updating his subscription preferences. Therefore, he might be prompted to open the subscription modal again to double-check that his modifications were correctly applied or not. **SPECIFICATION** We are now displaying screen notifications using notify method of the notification widget. **Task : 2445481** Forward-Port-Of: odoo/odoo#65514
When changing a contract's state to "Expired", if the contract has an end date, the latter is not updated. As a result, contracts' reporting contains some error. To reproduce the error: 1. Create an employee E 2. Create a contract C - Employee: E - Start date: in the past - End Date: in the future (! at least after the current month) 3. Set contract's state to "Expired" 4. Go to Employee > Reporting > Contracts 5. On pivot view, change the rows: - Total must be spli
Original PR description
When changing a contract's state to "Expired", if the contract has an end date, the latter is not updated. As a result, contracts' reporting contains some error. To reproduce the error: 1. Create an…
When changing a contract's state to "Expired", if the contract has an
end date, the latter is not updated. As a result, contracts' reporting
contains some error.
To reproduce the error:
1. Create an employee E
2. Create a contract C
- Employee: E
- Start date: in the past
- End Date: in the future (! at least after the current month)
3. Set contract's state to "Expired"
4. Go to Employee > Reporting > Contracts
5. On pivot view, change the rows:
- Total must be split into "Date > Month"
- Current month must be split into "Employee"
Error: on current month, "# Departure Employee" of E-employee is 0. It
should be 1. This value's computation is based on `contract.date_end`,
but when changing the state to "Expired", the variable will not be
updated if it already has a value. So "# Departure Employee" will be
equal to 1 for the month of end date defined on step 2, instead of
current month.
Note: The fix result can not be directly tested. The end date must be
done for the departure to be effective (`contract.date_end` < 'today').
Since this fix updates `contract.date_end` to 'today', "# Departure
Employee" will not count this contract until the following day.
OPW-2445504
Forward-Port-Of: odoo/odoo#65863Before this commit, occurences of 'null', 'true' and 'false' strings as autocomplete values in the search view were replaced respectively by None, True and False. Fixes #65743 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65900 Forward-Port-Of: odoo/odoo#65779
Original PR description
Before this commit, occurences of 'null', 'true' and 'false' strings as autocomplete values in the search view were replaced respectively by None, True and False. Fixes #65743 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65900 Forward-Port-Of: odoo/odoo#65779
According to its description, the field `is_valid_balance_start` of the `account_bank_statement` model shall be `False` if the starting balance of the current statement, is different from the previous ending balance. That means, it shall be set to `True` when no previous statement has been set (`previous_statement_id` is NULL), whatever the starting balance value. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65733
Original PR description
According to its description, the field `is_valid_balance_start` of the `account_bank_statement` model shall be `False` if the starting balance of the current statement, is different from the previous ending balance. That means, it shall be set to `True` when no previous statement has been set (`previous_statement_id` is NULL), whatever the starting balance value. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65733
RATIONALE Stored editable fields receive their values either from compute either from user input. If a user input is given to create / write compute method is not called. If multiple fields are computed through the same method giving one field value discard call to compute method and other fields are not called. SPECIFICATIONS Split ``_compute_contact_info`` compute method on registration model so that partner related fields are independent. Split ``_compute_from_event_type`` com
Original PR description
RATIONALE Stored editable fields receive their values either from compute either from user input. If a user input is given to create / write compute method is not called. If multiple fields are…
RATIONALE Stored editable fields receive their values either from compute either from user input. If a user input is given to create / write compute method is not called. If multiple fields are computed through the same method giving one field value discard call to compute method and other fields are not called. SPECIFICATIONS Split ``_compute_contact_info`` compute method on registration model so that partner related fields are independent. Split ``_compute_from_event_type`` compute method so that event template configuration related fields are independent. Split ``_compute_from_event_type`` compute method on event model so that event type related fields are independent. Add tests related to registration / partner contact fields synchronization. Add tests with user input and/or partner synchronization to ensure editable stored fields work as expected on lead model LINKS Task ID-2455165 COM PR odoo/odoo#65688 Forward-Port-Of: odoo/odoo#65923 Forward-Port-Of: odoo/odoo#65688
Before this commit, non-editable forms could switch to edit mode when clicking on a field or a label. Now, the edit right is checked when the quick edit is triggered. task 2456324 Forward-Port-Of: odoo/odoo#65820
Original PR description
Before this commit, non-editable forms could switch to edit mode when clicking on a field or a label. Now, the edit right is checked when the quick edit is triggered. task 2456324 Forward-Port-Of: odoo/odoo#65820
PURPOSE Displaying the subject when the name of the record is exactly the same is redundant and crowds the interface needlessly SPECIFICATION The subject should only be displayed if it is different than the name of the record LINKS TaskId: 2363130 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61044
Original PR description
PURPOSE Displaying the subject when the name of the record is exactly the same is redundant and crowds the interface needlessly SPECIFICATION The subject should only be displayed if it is different than the name of the record LINKS TaskId: 2363130 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61044
Steps: - Install website_event_sale - Go to Events - Create a new event: - Add a line: - Sales Start: yesterday - Sales End: tomorrow - Click the "Go to Website" smart button Bug: The sales end date is not displayed. It's displayed when there are more items. Explanation: When there is only one item, the layout is not the same. This commit adds "Sales end on" next to the price. opw:2449080 Forward-Port-Of: odoo/odoo#65945
Original PR description
Steps:
- Install website_event_sale
- Go to Events
- Create a new event:
- Add a line:
- Sales Start: yesterday
- Sales End: tomorrow
- Click the "Go to Website" smart button
Bug:
The sales end date is not displayed. It's displayed when there are more
items.
Explanation:
When there is only one item, the layout is not the same.
This commit adds "Sales end on" next to the price.
opw:2449080
Forward-Port-Of: odoo/odoo#65945Due to asynchronous rendering, the attachment template can be rendered when its attachment is undefined, this was causing an issue with an unguarded getter call that was attempting to access the attachment. This commit fixes this issue. opw-2457983 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65972 Forward-Port-Of: odoo/odoo#65944
Original PR description
Due to asynchronous rendering, the attachment template can be rendered when its attachment is undefined, this was causing an issue with an unguarded getter call that was attempting to access the attachment. This commit fixes this issue. opw-2457983 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65972 Forward-Port-Of: odoo/odoo#65944
Steps: - Install mrp - Go to Manufacturing > Master Data > Bills of Materials - Create a BoM - Components: - Add a component - Save - Click the component - Close the modal window - Click the component once more Bug: Traceback here: https://github.com/odoo/odoo/blob/55a6642a9621fa9683895d5d45a015bb04c3017b/addons/web/static/src/js/views/basic/basic_view.js#L147 Error: can't convert undefined to object Explanation: As seen on the line just above: https://github.com/odoo/o
Original PR description
Steps:
- Install mrp
- Go to Manufacturing > Master Data > Bills of Materials
- Create a BoM
- Components:
- Add a component
- Save
- Click the component
- Close the modal window
- Click the component once more
Bug:
Traceback here:
https://github.com/odoo/odoo/blob/55a6642a9621fa9683895d5d45a015bb04c3017b/addons/web/static/src/js/views/basic/basic_view.js#L147
Error: can't convert undefined to object
Explanation:
As seen on the line just above:
https://github.com/odoo/odoo/blob/55a6642a9621fa9683895d5d45a015bb04c3017b/addons/web/static/src/js/views/basic/basic_view.js#L146
`fieldsInfo` might not have the view we are looking for.
opw:2452142
Forward-Port-Of: odoo/odoo#65805
Forward-Port-Of: odoo/odoo#65737These two commits where not forward-ported after 14.0 because reasons Forward-Port-Of: odoo/odoo#65956
Original PR description
These two commits where not forward-ported after 14.0 because reasons Forward-Port-Of: odoo/odoo#65956
**PURPOSE** Actually, We don't want to distract the admin with an unnecessary notification on General Channel. The main focus should be on odoobot's tour, not on the general channel's welcome message. And it is also not a good idea to remove the general channel as it would reduce the discoverability of the feature. **SPECIFICATION** So, we are marking the first message as read at least for the admin user. therefore admin can not distract over the unnecessary welcome notifications an
Original PR description
**PURPOSE** Actually, We don't want to distract the admin with an unnecessary notification on General Channel. The main focus should be on odoobot's tour, not on the general channel's welcome message. And it is also not a good idea to remove the general channel as it would reduce the discoverability of the feature. **SPECIFICATION** So, we are marking the first message as read at least for the admin user. therefore admin can not distract over the unnecessary welcome notifications and focus more on the rest of the functionality. PS: we can not use "_set_last_seen_message" method as it takes partner_id of SUPERUSER because this method calls once during installation and installation is taken place by SUPERUSER But we required admin users to mark the first message as read. **Task : 2442023** Forward-Port-Of: odoo/odoo#65982 Forward-Port-Of: odoo/odoo#65440
Using a new team rd-notif-muted Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65997
Original PR description
Using a new team rd-notif-muted Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65997
… anymore Introduced by d6054ae140b0ff45741aea0253812d57352a2a6e This resulted in an error in the test, which we solved here. Forward-Port-Of: odoo/enterprise#16280
Original PR description
… anymore Introduced by d6054ae140b0ff45741aea0253812d57352a2a6e This resulted in an error in the test, which we solved here. Forward-Port-Of: odoo/enterprise#16280