Monday, February 22, 2021
2 changes · master
Resolved issues and error corrections
The Belgian EDI process now checks that the related PDF still exists before trying to include it in the XML file. This prevents invoice printing from failing in cases where the attachment was removed or is no longer available.
Original PR description
Before this commit, on some cases the attachment of the Belgian EDI might not exist any longer when printing the pdf, which caused a crash when trying to embed it into the xml. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change fixes an internal automated test that could fail unpredictably depending on network timing. It makes the test wait for the required error dialog component to load, improving development reliability without changing user-facing behavior.
Original PR description
Since commit 2716828f25c5837fff7a90a1cbb9c957b056e853, the error dialog has an additional JS lib dependency, which means that it may needs to perform a request before it opens up. However, a test in the crashmanager was only waiting for a next tick, which is possibly too short for a network request. So, depending on the network speed (and on the test order), this test could fail. To fix it, we simply make sure that the test also wait for the library to be loaded Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr