Commit e5ab8cf missed a use case. Steps to reproduce: - Activiate "Packages" setting in Inventory - Configure an operation type to "Move Entire Packages" - Create a "Planned Transfer" picking with that operation type and add a package to be moved - Turn off "Move Entire Packages" and try set the destination package of the move line to nothing (False). Expected result: Move line has no destination package + package level is deleted as expected. Another bug will still exist

Commit e5ab8cf missed a use case.

Steps to reproduce:

- Activiate "Packages" setting in Inventory
- Configure an operation type to "Move Entire Packages"
- Create a "Planned Transfer" picking with that operation type and add a
  package to be moved
- Turn off "Move Entire Packages" and try set the destination
  package of the move line to nothing (False).

Expected result:
Move line has no destination package + package level is deleted as
expected.

Another bug will still exist due to the design of package_level where if
in addition to the above use case, if a different package is used instead
of deleting it and "Move Entire Packages" is reactived => final package
shown in the Detailed Operations will show all move lines as being part
of the same package even though they are not. Data appears to be correct
in the database otherwise and a reasonable fix doesn't seem feasible for
now so we leave this bug as is.

Related to Task: 2418907

fixes: odoo/odoo#66542
fixes: odoo/odoo#66517

Forward-Port-Of: odoo/odoo#66556

Scenario: - go to /slides and start editing the page - change the position of background banner - save => traceback Why: The code for pan tool duplicates the target element in an overlay. In the given use case, it means a node with .o_editable class is created that will cause an error when saving because the code expect the cloned element to be an editor (in `RTEWidget.save()`) but it is not (and is eg. missing `.data('options')`). opw-2427560 Forward-Port-Of: odoo/odoo#66639

Scenario:

- go to /slides and start editing the page
- change the position of background banner
- save

=> traceback

Why:

The code for pan tool duplicates the target element in an overlay. In
the given use case, it means a node with .o_editable class is created
that will cause an error when saving because the code expect the cloned
element to be an editor (in `RTEWidget.save()`) but it is not (and is
eg. missing `.data('options')`).

opw-2427560

Forward-Port-Of: odoo/odoo#66639

The executing function for FieldCommand should return boolean value to indicate whether the value changed for triggering the re-computation. Forward-Port-Of: odoo/odoo#66648

The executing function for FieldCommand should return boolean value
to indicate whether the value changed for triggering the re-computation.

Forward-Port-Of: odoo/odoo#66648

Instead of using weird ad-hoc mock-like things. Forward-Port-Of: odoo/odoo#66649 Forward-Port-Of: odoo/odoo#66437

Instead of using weird ad-hoc mock-like things.

Forward-Port-Of: odoo/odoo#66649
Forward-Port-Of: odoo/odoo#66437

…order Description of the issue/feature this PR addresses: Solve backorder launch when it should not. Current behavior before PR: Do a transfer in two steps with several move lines (e.g.: Vendors => Input => Stock). In the first picking, set quantity = 0 on a single line. Transfer it and say 'No backorder'. In the second picking, set all quantities (you have two move lines confirmed and one canceled). Validate the transfer. The backorder wizard is launched. It should not. D

…order

Description of the issue/feature this PR addresses:

Solve backorder launch when it should not.

Current behavior before PR:

Do a transfer in two steps with several move lines (e.g.: Vendors => Input => Stock).

In the first picking, set quantity = 0 on a single line. Transfer it and say 'No backorder'.

In the second picking, set all quantities (you have two move lines confirmed and one canceled). Validate the
transfer. The backorder wizard is launched. It should not.

Desired behavior after PR is merged:

Do a transfer in two steps with several move lines (e.g.: Vendors => Input => Stock).

In the first picking, set quantity = 0 on a single line. Transfer it and say 'No backorder'.

In the second picking, set all quantities (you have two move lines confirmed and one canceled). Validate the
transfer.

The backorder wizard is not launched


--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#66272
Forward-Port-Of: odoo/odoo#66122

The `mail` module logs bus notifications it does not handle. However, some notifications are not meant to be handled by `mail` and it's perfectly fine. This commit removes the log to avoid useless noise in the console. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66661

The `mail` module logs bus notifications it does not handle. However, some
notifications are not meant to be handled by `mail` and it's perfectly fine.

This commit removes the log to avoid useless noise in the console.


--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#66661

This commit unpins a livechat channel initiated by an admin when it's closed and no message has been sent task-id: 2276571 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66178

This commit unpins a livechat channel initiated by an admin when it's closed and no message has been sent

task-id: 2276571

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#66178

If a field is sanitized, a6e2b484e2 would hide the video button because the video does not show in backend. It is better for the consistency but if the field appear in frontend, the video would still show so we prevent something that worked (but is very not user friendly when editing in backend). This changeset go back to the previous behavior (keeping the code simplification), at one point there should be a fix so at least when editing we see the video (currently we see an empty div in given c

If a field is sanitized, a6e2b484e2 would hide the video button because
the video does not show in backend. It is better for the consistency but
if the field appear in frontend, the video would still show so we
prevent something that worked (but is very not user friendly when
editing in backend).

This changeset go back to the previous behavior (keeping the code
simplification), at one point there should be a fix so at least when
editing we see the video (currently we see an empty div in given
conditions).

opw-2463746

Forward-Port-Of: odoo/odoo#66434

Issue - Install Inventory module - Go to Inventory -> Reporting -> Inventory Valuation - Click on "Inventory At Date" button - Select any date The datetime in breadcrumb is displayed in UTC. Solution Display datetime in current user timezone. opw-2464744 Forward-Port-Of: odoo/odoo#66533

Issue

	- Install Inventory module
	- Go to Inventory -> Reporting -> Inventory Valuation
	- Click on "Inventory At Date" button
	- Select any date

	The datetime in breadcrumb is displayed in UTC.

Solution

	Display datetime in current user timezone.

opw-2464744

Forward-Port-Of: odoo/odoo#66533

To reproduce: 1. Activate pos_hr feature. 2. Authorize an employee with pin. 3. Open a pos session and login with that employee. 4. [BUG] The popup to input pin is broken. This is because of the 'minus' button. In this commit, we make sure to hide the 'minus' button when the popup is used to ask for pin. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66688

To reproduce:

1. Activate pos_hr feature.
2. Authorize an employee with pin.
3. Open a pos session and login with that employee.
4. [BUG] The popup to input pin is broken.

This is because of the 'minus' button. In this commit, we make sure
to hide the 'minus' button when the popup is used to ask for pin.


--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#66688

Before this commit, the SOL in the helpdesk ticket is visible only if the use_helpdesk_sale_timesheet=True and the partner is defined and at least a timesheet is defined in this ticket. The last condition has been removed because we added it when the sale_line_id is not stored in this model but is no longer the case now. This commit removes this last condition since this condition is no longer usefull and now this field will be visible is the use_helpdesk_sale_timesheet=True and the p

Before this commit, the SOL in the helpdesk ticket is visible only if
the use_helpdesk_sale_timesheet=True and the partner is defined and at
least a timesheet is defined in this ticket.

The last condition has been removed because we added it when the
sale_line_id is not stored in this model but is no longer the case now.

This commit removes this last condition since this condition is no
longer usefull and now this field will be visible is the
use_helpdesk_sale_timesheet=True and the partner is defined in the
ticket.

Forward-Port-Of: odoo/enterprise#16527

In the documents settings, you can select a workspace for the accounting. If you are in a multi-company, if a workspace is assigned to a company, it is not available in the list of workspace, even if you are in that company. opw:2452512 Forward-Port-Of: odoo/enterprise#16484

In the documents settings, you can select a workspace for the accounting.
If you are in a multi-company, if a workspace is assigned to a company,
it is not available in the list of workspace, even if you are in that company.

opw:2452512

Forward-Port-Of: odoo/enterprise#16484

Forward-Port-Of: odoo/enterprise#16474

Forward-Port-Of: odoo/enterprise#16474

This commit adds the `id` field to the debug mode list view to facilitate debugging. Forward-Port-Of: odoo/enterprise#16483

This commit adds the `id` field to the debug mode list view to
facilitate debugging.

Forward-Port-Of: odoo/enterprise#16483

In some structured communications, we are expecting float values when parsing the communication (example: volume for transaction type fuel in communication 113). But this data is not always filled in, and we should not crash in that case but rather just set a default 0 value to allow the import of CODA statements. opw-2463827 Forward-Port-Of: odoo/enterprise#16519

In some structured communications, we are expecting float values when parsing the
communication (example: volume for transaction type fuel in communication 113). But
this data is not always filled in, and we should not crash in that case but rather
just set a default 0 value to allow the import of CODA statements.

opw-2463827

Forward-Port-Of: odoo/enterprise#16519

Forward-Port-Of: odoo/enterprise#16556

Forward-Port-Of: odoo/enterprise#16556

- While running the cron to update the status of an invoice on the OCR cron. We never commit, meaning we hold locks during the cron run time. This can be blocking for people working on invoices that are marked as locked and have to wait until the cron has finished running. Forward-Port-Of: odoo/enterprise#16572 Forward-Port-Of: odoo/enterprise#16509

- While running the cron to update the status of an invoice
   on the OCR cron.
   We never commit, meaning we hold locks during the cron run time.

   This can be blocking for people working on invoices that are marked
   as locked and have to wait until the cron has finished running.

Forward-Port-Of: odoo/enterprise#16572
Forward-Port-Of: odoo/enterprise#16509

Neither server, no browser cannot handle unlimited number of lines at the same time. On server side it leads to series of heavy sql requests. On client side, browser will eat all the memory on trying to render all of those lines. This also prevents loading reconciled lines ids to browser. Size of the batches can be customized via System Parameter ``account.reconcile.batch`` Details: * ``action_bank_reconcile_bank_statements`` is used on clicking `[Reconcile]` button in ``account.ba

Neither server, no browser cannot handle unlimited number of lines at the same
time. On server side it leads to series of heavy sql requests. On client side,
browser will eat all the memory on trying to render all of those lines.

This also prevents loading reconciled lines ids to browser.

Size of the batches can be customized via System Parameter
``account.reconcile.batch``

Details:
* ``action_bank_reconcile_bank_statements`` is used on clicking `[Reconcile]`
button in ``account.bank.statement`` form
* ``action_open_reconcile`` is used on clicking `[Reconcile]` for a journal in
Account Dashboard

---

PR to v13: https://github.com/odoo/odoo/pull/65789
opw-2424992
opw-2344807

Forward-Port-Of: odoo/enterprise#16491

Depending on the user's location, the date format that is chosen may return the wrong date. If you want to format a date as of January 1, 2021. The formatting returns "2020-01-01". To fix this bug, we have to replace "YYYY" by "yyyy". **See also:** https://github.com/python-babel/babel/issues/419 Forward-Port-Of: odoo/enterprise#16558

Depending on the user's location, the date format that is chosen may return the wrong date. If you want to format a date as of
January 1, 2021. The formatting returns "2020-01-01".  To fix this bug, we have to replace "YYYY" by "yyyy".
**See also:** https://github.com/python-babel/babel/issues/419

Forward-Port-Of: odoo/enterprise#16558