Wednesday, February 24, 2021
2 changes · master
Resolved issues and error corrections
Fixes an issue where choosing a background color in the website editor could trigger an error when custom colors were disabled. This makes editing transparent headers and similar design elements more reliable for users.
Original PR description
traceback, when you select bg-color for transparent header TypeError: this.colorPicker is undefined https://6276834-master.runbot40.odoo.com/web/assets/1537-d789439/1/web_editor.assets_wysiwyg.min.js:608 Traceback: _selectColor@https://6276834-master.runbot40.odoo.com/web/assets/1537-d789439/1/web_editor.assets_wysiwyg.min.js:608:53 _onColorButtonClick@https://6276834-master.runbot40.odoo.com/web/assets/1537-d789439/1/web_editor.assets_wysiwyg.min.js:608:551 proxy/<@https://6276834-master.runbot40.odoo.com/web/assets/1525-8743097/1/web.assets_common_lazy.min.js:4660:11 dispatch@https://6276834-master.runbot40.odoo.com/web/assets/1525-8743097/1/web.assets_common_lazy.min.js:1617:447 add/elemData.handle@https://6276834-master.runbot40.odoo.com/web/assets/1525-8743097/1/web.assets_common_lazy.min.js:1603:166 task-2464340 Closes -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Error dialogs now generate their clipboard copy button using the same processed error details shown to the user. This helps support teams receive clearer, more accurate troubleshooting information, including better details for unhandled promise errors and Chrome stack traces.
Original PR description
Before this commit, the way we managed the clipboard button in an error dialog was the following: 1. crashmanager create an error dialog and give it the error information 2. error dialog does some…
Before this commit, the way we managed the clipboard button in an error dialog was the following: 1. crashmanager create an error dialog and give it the error information 2. error dialog does some processing to format error traceback and display it 3. crashmanager wait for it to be ready, then will manipulate the dom to add the clipboard button, by using the information it knows (NOT the processed information bye the dialot) This is obviously a mistake, so what we simply do in this commit is add the clipboard button in the error dialog, so it has updated information. Note that we also fix two other small issues: - errors coming from promise crashes (unhandled rejections) were not decorated with correct file information - chrome traceback was not correct because it has some native information that does not correspond to a stackframe Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr