Thursday, February 25, 2021
36 changes · master
Enhancements to existing features
Time Off activity messages are simplified by removing hard-to-read date details from the activity summary. Users can still see dates in the proper format on the leave request form, making activity lists cleaner and easier to scan.
Original PR description
Currently, dates displaying on activities of Time Off application are not easy to read for users. So in this commit, we improve the dates displaying on activities of Time off application. LINKS PR: #60610 Task-Id: 2339411 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update improves how web startup and test errors are shown in browser consoles, especially when using debugging tools. It helps developers identify issues faster by preserving better error details and source mapping, reducing time spent diagnosing frontend problems.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The calendar reporting interface was adjusted to remove a confusing option that allowed users to chart internal record identifiers. The update also includes small visual improvements, making calendar reports easier to understand and use.
Original PR description
TODO
The fleet-related payroll settings text has been revised to make the configuration clearer for users in Belgium. This helps administrators better understand the available options without changing the underlying behavior.
Original PR description
Task ID: 2389823
Resolved issues and error corrections
The project and task forms now show the chatter area cleanly when editing records that use a form layout without a sheet section. This removes visual glitches and makes the communication panel easier to read and use.
Original PR description
**Before this commit:** In edit mode, glitching of chatter is visible in project.project and project.task's form view(without sheet tag). **After this commit:** Removed this glinch of chatter and displaying it with full width in the form (without sheet tag). **LINKS** PR https://github.com/odoo/odoo/pull/66314 Task- 2411632
Miscellaneous changes
When creating a new currency from the list view, the currency was given 1.0 as rate since this was the field's default value. The "onchange" on rate would then trigger. If 1.0 is more than 20% different than the latest rate, a warning was popped. This warning prevented the creation of the new rate. Meaning one could not create a new currency rate if the latest rate > 1.25 or < 0.833. This is fixed by setting the latest rate as default value. Task: 2450747 Forward-Port-Of: odoo/odoo#66
Original PR description
When creating a new currency from the list view, the currency was given 1.0 as rate since this was the field's default value. The "onchange" on rate would then trigger. If 1.0 is more than 20% different than the latest rate, a warning was popped. This warning prevented the creation of the new rate. Meaning one could not create a new currency rate if the latest rate > 1.25 or < 0.833. This is fixed by setting the latest rate as default value. Task: 2450747 Forward-Port-Of: odoo/odoo#66693
This change fixes an internal error in the base module caused by a naming conflict in a call to shared system behavior. It helps keep Odoo's module management more reliable, with no expected change to everyday user workflows.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Project feedback replies now show only the rating smiley in the activity chatter, without an extra subtype description. This makes customer feedback messages clearer and less cluttered for users reviewing completed tasks.
Original PR description
**Before this commit:** For an example, when task is going to 'Done' state at that time mail is sent to customer for feedback, answering of that mail contain smiley face plus subtype description in chatter. **After this commit:** A subtype description is removed to the smiley face from message. **Links** PR https://github.com/odoo/odoo/pull/66137 Task-2373127
Helpdesk customer feedback replies now show the rating smiley without an extra subtype description in the conversation history. This makes rating messages cleaner and easier for users to read.
Original PR description
**Before this commit:** For an example, when task is going to 'Done' state at that time mail is sent to customer for feedback, answering of that mail contain smiley face plus subtype description in chatter. **After this commit:** A subtype description is removed to the smiley face from message. **Links** PR https://github.com/odoo/enterprise/pull/16340 Task-2373127
Before this commit, the user can select a sales order which is always a quotation and he cannot select a sales order line because the state of the sales order is not equal to 'sale' or 'done'. This commit adds ('state', 'in' ['sale', 'done']) in the domain of the sale_order_id field in project.project model. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66782 Forward-Port-Of: odoo/odoo#66756
Original PR description
Before this commit, the user can select a sales order which is always a
quotation and he cannot select a sales order line because the state of
the sales order is not equal to 'sale' or 'done'.
This commit adds ('state', 'in' ['sale', 'done']) in the domain of the
sale_order_id field in project.project model.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#66782
Forward-Port-Of: odoo/odoo#66756Zeep replaced suds but Debian and Rpm packaging were not updated. Ofxparse is required but did not appear in Debian nor Rpm packaging. Forward-Port-Of: odoo/odoo#66784 Forward-Port-Of: odoo/odoo#66780
Original PR description
Zeep replaced suds but Debian and Rpm packaging were not updated. Ofxparse is required but did not appear in Debian nor Rpm packaging. Forward-Port-Of: odoo/odoo#66784 Forward-Port-Of: odoo/odoo#66780
**Before this commit:** In edit mode, glitching of chatter is visible in project.project's form view (without sheet tag). **After this commit:** Removed this glinch of chatter and displaying it with full width in the form (without sheet tag). **LINKS** PR https://github.com/odoo/odoo/pull/65448 Task- 2411632 Forward-Port-Of: odoo/odoo#65448
Original PR description
**Before this commit:** In edit mode, glitching of chatter is visible in project.project's form view (without sheet tag). **After this commit:** Removed this glinch of chatter and displaying it with full width in the form (without sheet tag). **LINKS** PR https://github.com/odoo/odoo/pull/65448 Task- 2411632 Forward-Port-Of: odoo/odoo#65448
**Before this commit:** In edit mode, glitching of chatter is visible in project.task's form view (without sheet tag). **After this commit:** Removed this glinch of chatter and displaying it with full width in the form (without sheet tag). **LINKS** PR https://github.com/odoo/odoo/pull/65447 Task- 2411632 Forward-Port-Of: odoo/odoo#65447
Original PR description
**Before this commit:** In edit mode, glitching of chatter is visible in project.task's form view (without sheet tag). **After this commit:** Removed this glinch of chatter and displaying it with full width in the form (without sheet tag). **LINKS** PR https://github.com/odoo/odoo/pull/65447 Task- 2411632 Forward-Port-Of: odoo/odoo#65447
Only the 'action' requests have the 'data' parameter set, so any other request triggering a 'device_changed' failed. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66792
Original PR description
Only the 'action' requests have the 'data' parameter set, so any other request triggering a 'device_changed' failed. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66792
[FIX] website: hide block in mobile display mode Before this commit, the display mode is changed to block after hiding it in mobile mode. After this commit, only change display mode for mobile and use inherited mode otherwise. Task-2431659 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65716
Original PR description
[FIX] website: hide block in mobile display mode Before this commit, the display mode is changed to block after hiding it in mobile mode. After this commit, only change display mode for mobile and use inherited mode otherwise. Task-2431659 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65716
Currently, if there is a year scale in the full calendar, the space above the scroll. After this commit, there will be no space above the scroll. Forward-Port-Of: odoo/odoo#65679
Original PR description
Currently, if there is a year scale in the full calendar, the space above the scroll. After this commit, there will be no space above the scroll. Forward-Port-Of: odoo/odoo#65679
… full reconcile Suppose an invoice of 1200USD = 3600EUR reconciled with a payment 1800USD = 3600EUR. The generated exchange difference journal entry is: 600USD = 0EUR because 1800 - 1200 - 600 = 0 and 3600 - 3600 = 0 => Everything is reconciled and all residual amounts are 0. Remove the reconciliation. The exchange difference entry is reversed in other to cancel it. Because the current exchange difference entry contains a line of 600USD, the reversal is creating a line of -600USD.
Original PR description
… full reconcile Suppose an invoice of 1200USD = 3600EUR reconciled with a payment 1800USD = 3600EUR. The generated exchange difference journal entry is: 600USD = 0EUR because 1800 - 1200 - 600 = 0…
… full reconcile Suppose an invoice of 1200USD = 3600EUR reconciled with a payment 1800USD = 3600EUR. The generated exchange difference journal entry is: 600USD = 0EUR because 1800 - 1200 - 600 = 0 and 3600 - 3600 = 0 => Everything is reconciled and all residual amounts are 0. Remove the reconciliation. The exchange difference entry is reversed in other to cancel it. Because the current exchange difference entry contains a line of 600USD, the reversal is creating a line of -600USD. Before this commit: Because both lines were sharing the same foreign currency (EUR) but have an amount_residual_currency of 0, no partial was created and then, a new exchange difference was generated in order to fix the amount_residual of 600 in USD. After this commit: A partial is created to handle the residual amount in USD even the residual amount in foreign currency is already zero. opw: 2450699 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66653
Purpose ======= When we want to retrieve all the contract (running for instance), we don't care about the fact that the employee is archived or not. For example when we generate the work entries to generate the payslips, we actually pay the employee, even if he's archived (which is the normal flow). Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR gu
Original PR description
Purpose ======= When we want to retrieve all the contract (running for instance), we don't care about the fact that the employee is archived or not. For example when we generate the work entries to generate the payslips, we actually pay the employee, even if he's archived (which is the normal flow). Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66750
**Before this commit:** For chatter in window, the name of the record is not in an appropriate place in header as there is an empty space before name. **After this commit:** The name of the record is aligned to the left, and there is no empty space before the name. **LINKS** Task- 2442652 PR https://github.com/odoo/odoo/pull/65600 Forward-Port-Of: odoo/odoo#65600
Original PR description
**Before this commit:** For chatter in window, the name of the record is not in an appropriate place in header as there is an empty space before name. **After this commit:** The name of the record is aligned to the left, and there is no empty space before the name. **LINKS** Task- 2442652 PR https://github.com/odoo/odoo/pull/65600 Forward-Port-Of: odoo/odoo#65600
- install e-commerce and l10n_ar; - as a Public user open a product on the shop. Before this commit, an 403 error was raised. Now, the public user can navigate through the products. opw-2462477 Forward-Port-Of: odoo/odoo#66795
Original PR description
- install e-commerce and l10n_ar; - as a Public user open a product on the shop. Before this commit, an 403 error was raised. Now, the public user can navigate through the products. opw-2462477 Forward-Port-Of: odoo/odoo#66795
Since commit odoo/odoo@c96e3b96f307685d03d240fac81fb0e83ca85f1d the TouchEvent constructor was added to the test utils. In FireFox (no touch mode) and Safari (desktop) this constructor doesn't exist and so the test suite won't start anymore. This commit, inserts TouchEvent constructor only when it's supported by the browser. So now we can run the tests in FireFox and Safari again. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-O
Original PR description
Since commit odoo/odoo@c96e3b96f307685d03d240fac81fb0e83ca85f1d the TouchEvent constructor was added to the test utils. In FireFox (no touch mode) and Safari (desktop) this constructor doesn't exist and so the test suite won't start anymore. This commit, inserts TouchEvent constructor only when it's supported by the browser. So now we can run the tests in FireFox and Safari again. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66775
When reconciling a statement line from the bank reconciliation widget, the journal entry of the statement line is already posted and then, the analytic lines was never created. This commit fixes the issue by refreshing the analytic lines at the end of the statement line's reconciliation. opw: 2466236 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66800
Original PR description
When reconciling a statement line from the bank reconciliation widget, the journal entry of the statement line is already posted and then, the analytic lines was never created. This commit fixes the issue by refreshing the analytic lines at the end of the statement line's reconciliation. opw: 2466236 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66800
In case a yearly sequence is set for out_invoice/in_invoice types and if we set a monthly sequence on the corresponding out_refund/in_refund type, we will not be able to validate the refund the next month as it will be wrongly identified as a yearly sequence. Therefore, the constraint on date sequence is preventing to validate it. We should include the move type when retrieving the last sequence name to solve it. Description of the issue/feature this PR addresses: opw-2456008 Curre
Original PR description
In case a yearly sequence is set for out_invoice/in_invoice types and if we set a monthly sequence on the corresponding out_refund/in_refund type, we will not be able to validate the refund the next month as it will be wrongly identified as a yearly sequence. Therefore, the constraint on date sequence is preventing to validate it. We should include the move type when retrieving the last sequence name to solve it. Description of the issue/feature this PR addresses: opw-2456008 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66729
Before this commit, a page reload or a redirect could raise following error: ``` Uncaught (in promise) TypeError: this.env.services.bus_service is undefined ``` This happens due to `Messaging` model relying on `bus_service` in its teardown method `_willDelete`. This is sometimes unsafe because the bus service may not have been deployed yet. Task-2468469 Forward-Port-Of: odoo/odoo#66818
Original PR description
Before this commit, a page reload or a redirect could raise following error: ``` Uncaught (in promise) TypeError: this.env.services.bus_service is undefined ``` This happens due to `Messaging` model relying on `bus_service` in its teardown method `_willDelete`. This is sometimes unsafe because the bus service may not have been deployed yet. Task-2468469 Forward-Port-Of: odoo/odoo#66818
We have two new programmers. Please update our CLA. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66767
Original PR description
We have two new programmers. Please update our CLA. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66767
Before this commit, the selector 'o_cp_top_left' was used to target a descendent element. The 'o_cp_top_left' class was added in this commit odoo/odoo@533db5991a5bb871198485cd71a63f75a8c6becf But 'o_cp_top_left' class is only available on desktop. On mobile the layout of the control panel is different. This produce a bug on Mobile. After this commit, we use a less restrictive querySelector to match the element in mobile too. Note: we remove the 'div' for clarity/consistency Steps
Original PR description
Before this commit, the selector 'o_cp_top_left' was used to target a descendent element. The 'o_cp_top_left' class was added in this commit odoo/odoo@533db5991a5bb871198485cd71a63f75a8c6becf But 'o_cp_top_left' class is only available on desktop. On mobile the layout of the control panel is different. This produce a bug on Mobile. After this commit, we use a less restrictive querySelector to match the element in mobile too. Note: we remove the 'div' for clarity/consistency Steps to reproduce: * Open Odoo in "Mobile mode" (small screen) * Go to Apps * Install a module that need website or website it self * You are redirect to the "chose theme" => Bug -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66613
Because of the weird behavior of the ORM regarding related field pointing to computed fields, `on_time_rate` was taking account of all companies when asking it through `purchase.order.on_time_rate` but it was single-company when asked through `res.partner.on_time_rate`. It was observed during an upgrade request issue analysis, and in that case the problem was not even the fact it was miscomputed, but the fact this computed field, computed as sudo, leaded to fill the cache for `purchas
Original PR description
Because of the weird behavior of the ORM regarding related field pointing to computed fields, `on_time_rate` was taking account of all companies when asking it through `purchase.order.on_time_rate` but it was single-company when asked through `res.partner.on_time_rate`. It was observed during an upgrade request issue analysis, and in that case the problem was not even the fact it was miscomputed, but the fact this computed field, computed as sudo, leaded to fill the cache for `purchase.order.line.move_ids` with `stock.move` belonging to other companies than the user one, and then when attempting to read values from these stock moves a multi-company access error was raised. upg-8106 Forward-Port-Of: odoo/odoo#66840
… library This commit removes the necessity of having the firebase_admin python library installed to be able to send push notifications. As the firebase_admin library is not officially supported in debian packages, it was causing some deployment issues when trying to install the social_push_notifications module. We now allow having either the "firebase_admin" library installed OR simply the "google_auth" library. As firebase_admin depends on google_auth, this should work nicely for
Original PR description
… library This commit removes the necessity of having the firebase_admin python library installed to be able to send push notifications. As the firebase_admin library is not officially supported in…
… library This commit removes the necessity of having the firebase_admin python library installed to be able to send push notifications. As the firebase_admin library is not officially supported in debian packages, it was causing some deployment issues when trying to install the social_push_notifications module. We now allow having either the "firebase_admin" library installed OR simply the "google_auth" library. As firebase_admin depends on google_auth, this should work nicely for existing databases without needing to change anything. The "google_auth" library is much lighter and most importantly officially supported in debian packages. Which makes it a good replacement. The implementation is also not so different from directly using the firebase library, the important difference stands in the "return" type when sending messages that is much more raw (POST request VS method call that returns objects encapsulating the message result / batching / ...). Task 2361171 Forward-Port-Of: odoo/enterprise#16668 Forward-Port-Of: odoo/enterprise#14450
**Current behavior before PR:** Method delete_call_in_queue is sending on the bus res.partner but it is sending the user id instead of the partner id. **Desired behavior after PR is merged:** Method delete_call_in_queue is sending on the bus res.partner with the the partner id. **LINKS:** PR #16565 Task-2464546 Forward-Port-Of: odoo/enterprise#16565
Original PR description
**Current behavior before PR:** Method delete_call_in_queue is sending on the bus res.partner but it is sending the user id instead of the partner id. **Desired behavior after PR is merged:** Method delete_call_in_queue is sending on the bus res.partner with the the partner id. **LINKS:** PR #16565 Task-2464546 Forward-Port-Of: odoo/enterprise#16565
[FIX] l10n_be_reports: correctly place <Representative> node in XML export when needed https://github.com/odoo/enterprise/commit/11567ad2dae739f1b8905438c95bc0960d756c54 introduced support for the representative, but didn't put it under the right node in the generated XML files. [IMP] l10n_be_reports: add missing mention to VAT number in the error message when using a non-fully configured representative OPW 2454136 Forward-Port-Of: odoo/enterprise#16657 Forward-Port-Of: odoo/enterprise#1
Original PR description
[FIX] l10n_be_reports: correctly place <Representative> node in XML export when needed https://github.com/odoo/enterprise/commit/11567ad2dae739f1b8905438c95bc0960d756c54 introduced support for the representative, but didn't put it under the right node in the generated XML files. [IMP] l10n_be_reports: add missing mention to VAT number in the error message when using a non-fully configured representative OPW 2454136 Forward-Port-Of: odoo/enterprise#16657 Forward-Port-Of: odoo/enterprise#16650
**Before this commit:** An activity "call" is already marked as "done" in chatter, after that user schedule an activity "call" again and actually make that call and hang up the call, traceback will be occured. And another issue is when page will be refreshed, this activity will be marked as "done" and appears in chatter. **After this commit:** Hangs up the call for the second time, the activity will be marked as "done", and appear in the chatter with the original notes ( in "Today"
Original PR description
**Before this commit:** An activity "call" is already marked as "done" in chatter, after that user schedule an activity "call" again and actually make that call and hang up the call, traceback will be occured. And another issue is when page will be refreshed, this activity will be marked as "done" and appears in chatter. **After this commit:** Hangs up the call for the second time, the activity will be marked as "done", and appear in the chatter with the original notes ( in "Today" activities section ) without any traceback. **Links** PR https://github.com/odoo/enterprise/pull/16464 Task- 2457219 Forward-Port-Of: odoo/enterprise#16464
Forward-Port-Of: odoo/enterprise#16636
Original PR description
Forward-Port-Of: odoo/enterprise#16636
The function _get_batches expects a singleton Forward-Port-Of: odoo/enterprise#16635
Original PR description
The function _get_batches expects a singleton Forward-Port-Of: odoo/enterprise#16635
Warning: 'The foreign currency must be different than the journal one' 'currency_id' field is renamed into the 'foreign_currency_id' in v14. In this commit, set foreign_currency_id false when same as journal's currency_id while importing csv file. opw: 2428095 Forward-Port-Of: odoo/enterprise#16595
Original PR description
Warning: 'The foreign currency must be different than the journal one' 'currency_id' field is renamed into the 'foreign_currency_id' in v14. In this commit, set foreign_currency_id false when same as journal's currency_id while importing csv file. opw: 2428095 Forward-Port-Of: odoo/enterprise#16595
Forward-Port-Of: odoo/enterprise#16533 Forward-Port-Of: odoo/enterprise#11245
Original PR description
Forward-Port-Of: odoo/enterprise#16533 Forward-Port-Of: odoo/enterprise#11245
…eport Before this commit, if an asset was encoded on a foreign currency (example, euros if the company currency is dollars). On the deprecation schedule report, the values shown was the ones of the foreign currency with the company currency logo. Now, all the foreign currency assets are convert into company currency on the acquisition date. opw-2451383 Forward-Port-Of: odoo/enterprise#16220
Original PR description
…eport Before this commit, if an asset was encoded on a foreign currency (example, euros if the company currency is dollars). On the deprecation schedule report, the values shown was the ones of the foreign currency with the company currency logo. Now, all the foreign currency assets are convert into company currency on the acquisition date. opw-2451383 Forward-Port-Of: odoo/enterprise#16220