Friday, February 26, 2021
2 changes · master
Resolved issues and error corrections
Event meeting rooms now receive a default maximum capacity when none is selected, preventing confusing validation errors during room creation. Chat room setup also preserves the capacity choice made by users, so rooms use the intended settings instead of falling back unexpectedly.
Original PR description
PURPOSE When one tries to create a room without selecting a max capacity it was throwing a 'Validation Error' which is not proper warning message. The purpose of this commit is to provide a default value for that field which was not getting in the respective situation, and in a way we can eliminate this error. SPECIFICATIONS Currently there are two solutions proposed for this task either - to simply raise a proper warning message if the field is empty or - override the room_max_capacity field in 'event.meeting.room' and set some default value. In this commit, we chose the second one as the solution because still we could give that default value. LINKS PR #65676 Task 2448435
This change fixes an issue where a JavaScript module alias could accidentally include the end of a comment marker when no space was present. It helps ensure asset definitions are named correctly and avoids subtle loading or reference problems in Odoo's web assets.
Original PR description
When you define an @odoo-module with an alias without any space between
the alias and the **/, the alias contains the **/.
The purpose of this commit is to no longer add the **/ to the alias.
Example:
/** @odoo-module alias=web.base**/
Before:
odoo.define(`web.base**/`, function(require) {
After:
odoo.define(`web.base`, function(require) {
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr