Monday, March 1, 2021
23 changes · master
Enhancements to existing features
When users open the app list from Accounting to look for a localization, the extra category search panel is now hidden. This reduces visual clutter and makes it easier to focus on the relevant localization options.
Original PR description
The search panel showing app categories in the app list is unnecessary when opening the list with the context of searching for a localization. This will change it so that panel is hidden in this case. task id #2370971 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update improves Odoo's automated testing process by allowing certain test groups to run in a required order. It helps ensure upgrade-related checks run reliably and reduces false failures in internal quality validation.
Original PR description
We have some tests in odoo/upgrade that are sensitive to the order on which they are executed. Specifically: IntegrityCase tests need to be run after all UpgradeCase tests across all Odoo modules. To support this we implemented a sorting mechanism for tests based on the test_sequence class attribute. This is intended to be used by meta cases, not by individual tests. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Odoo now treats fields used for model inheritance in a more consistent way when filtering records. This helps ensure that searches return the same results whether users search inherited fields directly or through their linked parent record, without weakening existing access rules.
Original PR description
The field that supports inheritance should be auto_join=True. This guarantees that searching on an inherited field (X) or its explicit related expression (foo_id.X) gives the same query. Note that adding auto_join=True on that field does not weakens the model's security, since searching on the model automatically injects the parent model's security rules into the query (see _apply_ir_rules).
Resolved issues and error corrections
This fixes visual issues in the online shop where gift card-related products could appear without the right image and cart popover images could sit too close to text. Customers will see cleaner, more consistent product presentation during checkout and gift card use.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Context ------- Lead assignement is now based on PLS probability. We want to avoid giving the same score to real email addresses and email addresses that are just well formed Flanker try to acheive that be checking specific criteria according to the domain, check the dns and mx record Improvement ----------- If flanker is installed, use flanker to check correctness of email addresses. It should help the PLS to give a bad score to well formed addresses that flanker suspect to be w
Original PR description
Context ------- Lead assignement is now based on PLS probability. We want to avoid giving the same score to real email addresses and email addresses that are just well formed Flanker try to acheive…
Context ------- Lead assignement is now based on PLS probability. We want to avoid giving the same score to real email addresses and email addresses that are just well formed Flanker try to acheive that be checking specific criteria according to the domain, check the dns and mx record Improvement ----------- If flanker is installed, use flanker to check correctness of email addresses. It should help the PLS to give a bad score to well formed addresses that flanker suspect to be wrong. Setup ----- NB: flanker is not available as debian package, we make it optional To install flanker ``` pip install flanker pip install redis pip install dnsq ``` or ``` python3 -m pip install flanker[validator] ``` If you have installed it as root you may need to run ```py from flanker.addresslib import address ``` as root for the first initialisation -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66063
Description of the issue/feature this PR addresses: When double validation is enabled, purchase orders can still be approved by non-manager purchase users using RPC calls. Current behavior before PR: Non-manager purchase users can approve orders under double validation restriction Desired behavior after PR is merged: Non-manager purchase users can not approve orders under double validation restriction -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/
Original PR description
Description of the issue/feature this PR addresses: When double validation is enabled, purchase orders can still be approved by non-manager purchase users using RPC calls. Current behavior before PR: Non-manager purchase users can approve orders under double validation restriction Desired behavior after PR is merged: Non-manager purchase users can not approve orders under double validation restriction -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66505
To reproduce the error: (Need MX configuration) 1. Go to Accounting > Customers > Receipts 2. Create a Receipt 3. Post and Print it Error: An error message is displayed: "Only invoices could be printed." However, MX should be allowed to print the receipts. OPW-2456374 Forward-Port-Of: odoo/odoo#66910
Original PR description
To reproduce the error: (Need MX configuration) 1. Go to Accounting > Customers > Receipts 2. Create a Receipt 3. Post and Print it Error: An error message is displayed: "Only invoices could be printed." However, MX should be allowed to print the receipts. OPW-2456374 Forward-Port-Of: odoo/odoo#66910
The terms in the search bar of the ticket screen are not translated. This commit fixes this issue by passing the translated form of the terms to the search bar component. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66939 Forward-Port-Of: odoo/odoo#65038
Original PR description
The terms in the search bar of the ticket screen are not translated. This commit fixes this issue by passing the translated form of the terms to the search bar component. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66939 Forward-Port-Of: odoo/odoo#65038
Such requests could be done via Products list and there is no reason to don't use optimization --- opw-2452728 https://github.com/odoo/odoo/commit/9daf3f85a8a3b012a79226fe13d3cde2293fcce0 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66652
Original PR description
Such requests could be done via Products list and there is no reason to don't use optimization --- opw-2452728 https://github.com/odoo/odoo/commit/9daf3f85a8a3b012a79226fe13d3cde2293fcce0 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66652
In the crm.pls_start_date is not valid (or not set / deleted), than set the predictive_lead_scoring_start_date of settings to a date 8 days prior to current date. if date is not set or deleted than user get the traceback after this commit user can not get the traceback in crm settings. **TaskId: 2448248** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66242 Forward-Port-Of: odoo/odoo#65111
Original PR description
In the crm.pls_start_date is not valid (or not set / deleted), than set the predictive_lead_scoring_start_date of settings to a date 8 days prior to current date. if date is not set or deleted than user get the traceback after this commit user can not get the traceback in crm settings. **TaskId: 2448248** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66242 Forward-Port-Of: odoo/odoo#65111
PURPOSE fix the filter for search by name SPECIFICATIONS in the sales_team -> search view of team members the filter apply for search by name, it does not working because in the name filter the field is **name** but actually there is no field **name** , so the filter is not working properly, if user is trying to search by name it does not work so it must have to search by user_id, using this commit search filter is fixed and we can search team member easily by its name. LI
Original PR description
PURPOSE fix the filter for search by name SPECIFICATIONS in the sales_team -> search view of team members the filter apply for search by name, it does not working because in the name filter the field is **name** but actually there is no field **name** , so the filter is not working properly, if user is trying to search by name it does not work so it must have to search by user_id, using this commit search filter is fixed and we can search team member easily by its name. LINKS PR: #66514 Task Id:2460697 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66514
The following warning is very long in absolute position. The following text: "Calendar Mismatch : The employee's calendar does not match its current contract calendar. This could lead to unexpected behaviors." is invisible but takes a lot of width on the same line. Now, the item is a block of 0px height and doesn't take space. This avoids the horizontal scroll on mobile. Note that the item is displayed at the wrong place anyway. This will be fixed in master. Steps to reproduce: -
Original PR description
The following warning is very long in absolute position. The following text: "Calendar Mismatch : The employee's calendar does not match its current contract calendar. This could lead to unexpected behaviors." is invisible but takes a lot of width on the same line. Now, the item is a block of 0px height and doesn't take space. This avoids the horizontal scroll on mobile. Note that the item is displayed at the wrong place anyway. This will be fixed in master. Steps to reproduce: - Payroll / Employees / All contracts - Change "Working Schedule" field Task-ID: 1929043 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66858
pos_cache is used speed up opening POS in databases with large number of products. In some cases it's not enough and thousands of records cannot be cached in a single request, because reading information may take more time than maximum allowed. As a workaround, this commits adds posibility to split request into few small requests. To activate the feature set system parameter ``pos_cache.limit_products_per_request`` to appropriate value depending on your server capacity. --- opw-24
Original PR description
pos_cache is used speed up opening POS in databases with large number of products. In some cases it's not enough and thousands of records cannot be cached in a single request, because reading information may take more time than maximum allowed. As a workaround, this commits adds posibility to split request into few small requests. To activate the feature set system parameter ``pos_cache.limit_products_per_request`` to appropriate value depending on your server capacity. --- opw-2439347 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66539
Context ------- in the module website_calendar, the controller create an event with alarm with the Public user and the company of the public user and set partner_ids that may belong to a different company Issue ----- The company of the user that create the event remains in the context and _notify_next_alarm check for each user which event should be notify using with user of the partner that may be notified and check the access rules to filter the event the partner should actually
Original PR description
Context ------- in the module website_calendar, the controller create an event with alarm with the Public user and the company of the public user and set partner_ids that may belong to a different company Issue ----- The company of the user that create the event remains in the context and _notify_next_alarm check for each user which event should be notify using with user of the partner that may be notified and check the access rules to filter the event the partner should actually see. The check of the acces rules need env.companies that remains the company of the user that create the event which the current user may not see which trigger the following error. "Access to unauthorized or invalid companies." Solution -------- Wipe the company in the context when calling get_next_notif -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66933
[FIX] survey : fix the function extract comment from the answers Steps to follow to reproduce the bug: -Go to survey -Choose any survey with at least one "single text box" question -In the survey form -Click on the button test -Complete the survey, but in a "single text box" question, write the word "comment" -Validate the survey -An error is triggered. Problem : In the function which extracts comments from answers, it doesn't check the type in which the answer is stored. W
Original PR description
[FIX] survey : fix the function extract comment from the answers Steps to follow to reproduce the bug: -Go to survey -Choose any survey with at least one "single text box" question -In the survey…
[FIX] survey : fix the function extract comment from the answers Steps to follow to reproduce the bug: -Go to survey -Choose any survey with at least one "single text box" question -In the survey form -Click on the button test -Complete the survey, but in a "single text box" question, write the word "comment" -Validate the survey -An error is triggered. Problem : In the function which extracts comments from answers, it doesn't check the type in which the answer is stored. When there is a comment, it is stored in a dict under the key: "comment". To find the comment, the function checks if "comment"(key) is in the answer. But in the case of "single text box" question, the answer is stored in a string. If the word "comment" is present in the answer, the function looking for the key "comment" will return True and try to extract the comment. Solution : Add a check to ensure that we are looking for the key "comment" in dict type. opw-2446194 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66907
- Have a storable product with 3140.0 quantity on hand - Make a sale order for 3106.40, confirm and validate delivery - Reserved quantity will be 3106.40 - Make another sale order for 33.60, confirm and go to delivery - Reserved quantity will be 33.59 because of a rounding issue when calculating the available quantity opw-2449732 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have sign
Original PR description
- Have a storable product with 3140.0 quantity on hand - Make a sale order for 3106.40, confirm and validate delivery - Reserved quantity will be 3106.40 - Make another sale order for 33.60, confirm and go to delivery - Reserved quantity will be 33.59 because of a rounding issue when calculating the available quantity opw-2449732 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65453
Have an empty database Install Recruitment Recruitment>Departments>Administration(3 dots)>Recruitments Missing record message raise This occur because of an access to a record that may not exists opw-2431929 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66650
Original PR description
Have an empty database Install Recruitment Recruitment>Departments>Administration(3 dots)>Recruitments Missing record message raise This occur because of an access to a record that may not exists opw-2431929 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66650
The goal of this PR is to add tips when theme is loaded to encourage users to follow the tour (in Edit mode). task-2440450 Forward-Port-Of: odoo/odoo#65577 Forward-Port-Of: odoo/odoo#65153
Original PR description
The goal of this PR is to add tips when theme is loaded to encourage users to follow the tour (in Edit mode). task-2440450 Forward-Port-Of: odoo/odoo#65577 Forward-Port-Of: odoo/odoo#65153
Description of the issue/feature this PR addresses: - Fix tends to hide done/cancel MOs from mrp.production form - A planned MO is already a confirmed MO Current behavior before PR: - To-do filter displays all MOs Desired behavior after PR is merged: - To-do filter hides MOs with done/cancel state Task ID: 2442058 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66974
Original PR description
Description of the issue/feature this PR addresses: - Fix tends to hide done/cancel MOs from mrp.production form - A planned MO is already a confirmed MO Current behavior before PR: - To-do filter displays all MOs Desired behavior after PR is merged: - To-do filter hides MOs with done/cancel state Task ID: 2442058 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66974
Theorical amount is always 0 when a lot number is scanned This PR introduces the issue: #14451 Forward-Port-Of: odoo/enterprise#16738
Original PR description
Theorical amount is always 0 when a lot number is scanned This PR introduces the issue: #14451 Forward-Port-Of: odoo/enterprise#16738
Setting a product P with recurring_invoice = False must erase the subscription_template_id Otherwise P will still be visible as a product of its previous subscription template. opw:2460980 Forward-Port-Of: odoo/enterprise#16675
Original PR description
Setting a product P with recurring_invoice = False must erase the subscription_template_id Otherwise P will still be visible as a product of its previous subscription template. opw:2460980 Forward-Port-Of: odoo/enterprise#16675
Since commit https://github.com/odoo/odoo/commit/caeb782841fc5a7ad71a196e2c9ee67644ef9074 the foreign currency is set in a new dedicated field foreign_currency_id and the previous currency_id now contains the currency of the journal. We need to adapt the import of CAMT files accordingly to be able to process multi-currencies files without error. opw-2468482 Forward-Port-Of: odoo/enterprise#16735
Original PR description
Since commit https://github.com/odoo/odoo/commit/caeb782841fc5a7ad71a196e2c9ee67644ef9074 the foreign currency is set in a new dedicated field foreign_currency_id and the previous currency_id now contains the currency of the journal. We need to adapt the import of CAMT files accordingly to be able to process multi-currencies files without error. opw-2468482 Forward-Port-Of: odoo/enterprise#16735
Clients sometimes encode the ABN number without the "ABN" prefix. In that case, we need to ignore it to a have a potential match. Forward-Port-Of: odoo/enterprise#16555
Original PR description
Clients sometimes encode the ABN number without the "ABN" prefix. In that case, we need to ignore it to a have a potential match. Forward-Port-Of: odoo/enterprise#16555